Re: system-settings color change vs Qt (non-kde) apps

2011-01-04 Thread Hugo Pereira Da Costa
On Tuesday, January 04, 2011 09:05:13 pm Albert Astals Cid wrote: > A Dimarts, 4 de gener de 2011, Hugo Pereira Da Costa va escriure: > > Hello all, > > > > Here, when I change the color scheme in kde's system-settings, the change > > is propagated properly to KDE apps, but not to Qt (non-kde) app

Re: Review Request: Fix the inability to put an ioslave on hold when using the KIO-QNAM integration class...

2011-01-04 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/6183/ --- (Updated 2011-01-05 06:21:31.733660) Review request for kdelibs and Andrea D

Re: Review Request: [PATCH] Make KIO::Scheduler correctly re-use ioslaves on hold...

2011-01-04 Thread Andreas Hartmetz
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/6271/#review9523 --- Ship it! I didn't test or review anything in depth, but the analy

Re: Review Request: [PATCH] Make KIO::Scheduler correctly re-use ioslaves on hold...

2011-01-04 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/6271/ --- (Updated 2011-01-04 21:47:25.243279) Review request for kdelibs. Summary (

Re: Review Request: [PATCH] Make KIO::Scheduler correctly re-use ioslaves on hold...

2011-01-04 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/6271/ --- (Updated 2011-01-04 21:46:47.110697) Review request for kdelibs. Changes -

Re: Projects in KDE Review longer than 2 weeks

2011-01-04 Thread Christoph Feck
On Tuesday 04 January 2011 21:13:21 Ben Cooksley wrote: > On Wed, Jan 5, 2011 at 12:53 AM, Milian Wolff wrote: > > Oh boy, I totally forgot it. Afaik Massif Visualizer is fine and can be > > moved to extra gear. To my knowledge I fixed all reported issues. > > Ok, which extragear module in partic

Re: Review Request: [PATCH] Make KIO::Scheduler correctly re-use ioslaves that have been put on hold...

2011-01-04 Thread Dawit Alemayehu
> On 2011-01-04 13:44:51, Andreas Hartmetz wrote: > > /trunk/KDE/kdelibs/kio/kio/scheduler.cpp, line 924 > > > > > > Better move everything into a mayReturnContent(KIO::Job *) method and > > avoid the long function n

Re: system-settings color change vs Qt (non-kde) apps

2011-01-04 Thread Albert Astals Cid
A Dimarts, 4 de gener de 2011, Thomas Lübking va escriure: > Am Tuesday 04 January 2011 schrieb Hugo Pereira Da Costa: > > there, then the above gets fixed. I believe however that this is not > > quite acceptable, since obviously reparseConfiguration would be called > > twice for kde apps (correct

Re: Projects in KDE Review longer than 2 weeks

2011-01-04 Thread Ben Cooksley
On Wed, Jan 5, 2011 at 12:53 AM, Milian Wolff wrote: > Ben Cooksley, 04.01.2011: >> Hi all, >> >> The projects "Control Flow Graph" and "Massif Visualizer" have been in >> (git based) KDE Review for more than 2 weeks. Can their decision on >> movement please be reached? >> If they have supposedly

Re: system-settings color change vs Qt (non-kde) apps

2011-01-04 Thread Thomas Lübking
Am Tuesday 04 January 2011 schrieb Hugo Pereira Da Costa: > there, then the above gets fixed. I believe however that this is not quite > acceptable, since obviously reparseConfiguration would be called twice for > kde apps (correct ?). yes -> just don't if qApp inherits KApplication... > So. Does

Re: system-settings color change vs Qt (non-kde) apps

2011-01-04 Thread Albert Astals Cid
A Dimarts, 4 de gener de 2011, Hugo Pereira Da Costa va escriure: > Hello all, > > Here, when I change the color scheme in kde's system-settings, the change > is propagated properly to KDE apps, but not to Qt (non-kde) applications > (like, for instance QGit, and other applications of mine). I bel

Re: Review Request: KFilePlacesView: Allow to add custom actions to the context menu

2011-01-04 Thread Peter Penz
> On 2011-01-04 17:30:53, Kevin Ottens wrote: > > /trunk/KDE/kdelibs/kfile/kfileplacesview.cpp, line 638 > > > > > > Instead of introducing new API what about reusing QWidget::actions() > > here? Then on the dolphin

Re: [Kde-hardware-devel] kdebase-workspace and kdebase-runtime git repos to validate

2011-01-04 Thread Kevin Ottens
On Tuesday 14 December 2010 01:22:38 Ian Monroe wrote: > So kdelibs and kdebase are switching to Git, probably not Dec 20/21 as > was previously thought, but at the release of 4.6.0. > > Whether its next week or next month though, its pretty soon. :) > > I have three work-in-progress repos, the f

Re: Review Request: KFilePlacesView: Allow to add custom actions to the context menu

2011-01-04 Thread Kevin Ottens
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/6267/#review9519 --- Since it's a rather specific feature (I probably see only Dolphin

Re: Adding KFontUtils to kdeui

2011-01-04 Thread Jeremy Whiting
On Mon, Jan 3, 2011 at 1:03 PM, Christoph Feck wrote: > I was asked to restate my position on this thread. > > 1. The namespace should be named KFontUtils as was the original intention. > This is in line with KColorUtils and avoids the confusion with > QFontMetrics. I > suggest to move it to kdeu

Re: Review Request: [PATCH] Make KIO::Scheduler correctly re-use ioslaves that have been put on hold...

2011-01-04 Thread Andreas Hartmetz
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/6271/#review9510 --- /trunk/KDE/kdelibs/kio/kio/scheduler.cpp

Re: Projects in KDE Review longer than 2 weeks

2011-01-04 Thread Milian Wolff
Ben Cooksley, 04.01.2011: > Hi all, > > The projects "Control Flow Graph" and "Massif Visualizer" have been in > (git based) KDE Review for more than 2 weeks. Can their decision on > movement please be reached? > If they have supposedly moved, please indicate where they should be moved > to. Oh b

system-settings color change vs Qt (non-kde) apps

2011-01-04 Thread Hugo Pereira Da Costa
Hello all, Here, when I change the color scheme in kde's system-settings, the change is propagated properly to KDE apps, but not to Qt (non-kde) applications (like, for instance QGit, and other applications of mine). I believe this is due to differences between QApplication and KApplication (co

Re: Review Request: [PATCH] Make KIO::Scheduler correctly re-use ioslaves that have been put on hold...

2011-01-04 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/6271/ --- (Updated 2011-01-04 09:55:29.299913) Review request for kdelibs. Changes -

Re: Review Request: [PATCH] Make KIO::Scheduler correctly re-use ioslaves that have been put on hold...

2011-01-04 Thread Dawit Alemayehu
> On 2011-01-04 09:12:13, Andrea Diamantini wrote: > > /trunk/KDE/kdelibs/kio/kio/scheduler.cpp, line 905 > > > > > > typo? Ahh... yes indeed. Fixed! - Dawit --

Re: Review Request: [PATCH] Make KIO::Scheduler correctly re-use ioslaves that have been put on hold...

2011-01-04 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/6271/ --- (Updated 2011-01-04 09:38:19.430225) Review request for kdelibs. Changes -

Re: Review Request: Fix the inability to put an ioslave on hold when using the KIO-QNAM integration class...

2011-01-04 Thread Andrea Diamantini
> On 2011-01-04 01:28:06, Andrea Diamantini wrote: > > trunk/KDE/kdelibs/kdewebkit/kwebpage.cpp, line 421 > > > > > > I'm studying and testing your patch. I have just a stupid question > > actually: this "remove hol

Re: Review Request: [PATCH] Make KIO::Scheduler correctly re-use ioslaves that have been put on hold...

2011-01-04 Thread Andrea Diamantini
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/6271/#review9505 --- /trunk/KDE/kdelibs/kio/kio/scheduler.cpp