Review Request: [PATCH] Make KIO::Scheduler correctly re-use ioslaves that have been put on hold...

2011-01-03 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/6271/ --- Review request for kdelibs. Summary --- The patch attempts to fix the f

Re: Suspending mailinglists due to lack of moderators.

2011-01-03 Thread Gary Greene
On 1 Jan 2011, at 1:25 PM, Tom Albers wrote: > Hi, > > These are the top mailinglists with the most amount of moderation requests. > For most of them we have tried to contact the current moderators without much > success last year. So now I suggest we get rid of these mailinglists. > > Note

Re: About remove nfs filesharing support

2011-01-03 Thread Gary Greene
On 31 Dec 2010, at 4:26 AM, David Faure wrote: On Tuesday 28 December 2010, Allan Sandfeld Jensen wrote: >> On Tuesday 28 December 2010, Jonathan Riddell wrote: >>> On Tue, Dec 28, 2010 at 01:18:10PM -0200, Raphael Kubo da Costa wrote: Does that mean making KDE completely oblivious to NFS at a

Projects in KDE Review longer than 2 weeks

2011-01-03 Thread Ben Cooksley
Hi all, The projects "Control Flow Graph" and "Massif Visualizer" have been in (git based) KDE Review for more than 2 weeks. Can their decision on movement please be reached? If they have supposedly moved, please indicate where they should be moved to. Regards, Ben [1] https://projects.kde.org/p

Re: Review Request: Fix the inability to put an ioslave on hold when using the KIO-QNAM integration class...

2011-01-03 Thread Dawit Alemayehu
> On 2011-01-04 01:28:06, Andrea Diamantini wrote: > > trunk/KDE/kdelibs/kdewebkit/kwebpage.cpp, line 421 > > > > > > I'm studying and testing your patch. I have just a stupid question > > actually: this "remove hol

Re: Review Request: Fix the inability to put an ioslave on hold when using the KIO-QNAM integration class...

2011-01-03 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/6183/ --- (Updated 2011-01-04 03:26:26.616485) Review request for kdelibs and Andrea D

Re: Review Request: Fix the inability to put an ioslave on hold when using the KIO-QNAM integration class...

2011-01-03 Thread Andrea Diamantini
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/6183/#review9502 --- trunk/KDE/kdelibs/kdewebkit/kwebpage.cpp

[Phonon/4.1] fe3ea00 As discussed on kde-buildsystem rename kde4_add_te

2011-01-03 Thread Andreas Pakulat
commit fe3ea001b2f76e116f2595f064ea12c6f96c3004 branch 4.1 Author: Andreas Pakulat Date: Sun Jun 17 21:13:37 2007 + As discussed on kde-buildsystem rename kde4_add_test to kde4_add_test_executable and introduce kde4_add_unit_test for unittests, which combines kde4_add_test_exec

Re: Review Request: KFilePlacesView: Allow to add custom actions to the context menu

2011-01-03 Thread Peter Penz
> On 2011-01-03 20:03:10, Christoph Feck wrote: > > /trunk/KDE/kdelibs/kfile/kfileplacesview.cpp, line 638 > > > > > > Can you check if just using > > menu.addActions(d->customContextMenuActions) works, too? Ah, I m

Re: Review Request: KFilePlacesView: Allow to add custom actions to the context menu

2011-01-03 Thread Peter Penz
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/6267/ --- (Updated 2011-01-03 20:32:14.648343) Review request for kdelibs and Kevin Ot

Re: Review Request: KFilePlacesView: Allow to add custom actions to the context menu

2011-01-03 Thread Christoph Feck
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/6267/#review9493 --- /trunk/KDE/kdelibs/kfile/kfileplacesview.cpp

Re: Adding KFontUtils to kdeui

2011-01-03 Thread Christoph Feck
I was asked to restate my position on this thread. 1. The namespace should be named KFontUtils as was the original intention. This is in line with KColorUtils and avoids the confusion with QFontMetrics. I suggest to move it to kdeui/fonts/kfontutils.{cpp|h}. 2. I share Parkers concern that pass

Review Request: KFilePlacesView: Allow to add custom actions to the context menu

2011-01-03 Thread Peter Penz
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/6267/ --- Review request for kdelibs and Kevin Ottens. Summary --- For KDE SC 4.7

Re: Suspending mailinglists due to lack of moderators.

2011-01-03 Thread Richard Moore
On Sat, Jan 1, 2011 at 9:25 PM, Tom Albers wrote: >    102 kjsembed This one is already dead, see bug #260331 Cheers Rich.

Re: Suspending mailinglists due to lack of moderators.

2011-01-03 Thread André Wöbbeking
On Saturday 01 January 2011, Tom Albers wrote: > Hi, > > These are the top mailinglists with the most amount of moderation requests. > For most of them we have tried to contact the current moderators without > much success last year. So now I suggest we get rid of these mailinglists. > > Note tha

Re: Git Scratch-Pads for every identity.kde.org account (not only developers)

2011-01-03 Thread Milian Wolff
Andrea Diamantini, 02.01.2011: > On Sunday 02 January 2011 01:25:19 Eike Hein wrote: > > > So this is essentially a "CLOSED/WONTFIX" from your side then - too > > > bad. Any other takers? Esp. considering how others (rekonq) already > > > voiced themself in support of my request. > > > > Assuming

Re: Review Request: Add support for multiple selection in the KEditListBox and KEditListWidget widgets

2011-01-03 Thread David Faure
On Sunday 26 December 2010, Raphael Kubo da Costa wrote: > /trunk/KDE/kdelibs/kdeui/widgets/keditlistbox.cpp > > > According to kdelibs' coding style, you should #include both module and > class name for Qt includes. Only in public headers

Re: konq plugins (Re: KParts::TextExtension)

2011-01-03 Thread David Faure
On Tuesday 28 September 2010, David Faure wrote: > In fact, I don't understand why they are in extragear. I mean, yes, the > initial idea for kdeaddons was "so that they can be optionally installed", > but nowadays it means "and they have a separate release cycle" which > makes no sense whatsoeve