Re: Review Request: Adding "net usershare" suport for KSambaShare

2010-12-27 Thread Alex Fiestas
I just saw the commit, and when trying it the old "Make sure that the Perl script 'fileshareset' is set suid root." appeared. So I performed a grep in kdelibs and fileshareset is at least appearing in: kio/kio/kfileshare.cpp KFileItem::setShared method. Also, the perl scrip is still there in k

Re: Review Request: Fixes for KUrlNavigator on windows

2010-12-27 Thread Peter Penz
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/6206/#review9435 --- Ship it! Thanks, please commit! - Peter On 2010-12-28 00:30:01

Review Request: allow passing arguments to kcmodule from kcmshell command

2010-12-27 Thread arysin
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/6218/ --- Review request for kdelibs. Summary --- usage example: $ kcmshell4 --ar

Re: Need help with "This module still uses K_EXPORT_COMPONENT_FACTORY"

2010-12-27 Thread Raphael Kubo da Costa
On Mon, Dec 27, 2010 at 2:18 PM, Andriy Rysin wrote: > I need some help with KCModuleLoader: when I try to load kcm_keyboard in 4.6 > I get this warning > > $ kcmshell4 kcm_keyboard > kcmshell(946)/kcontrol KCModuleLoader::loadModule: This module still uses > K_EXPORT_COMPONENT_FACTORY. Please por

Re: Review Request: Make kdelibs and kdebase compile without glu library

2010-12-27 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/6213/#review9429 --- Ship it! KWin part is fine, nice catch. - Martin On 2010-12-27

Need help with "This module still uses K_EXPORT_COMPONENT_FACTORY"

2010-12-27 Thread Andriy Rysin
I need some help with KCModuleLoader: when I try to load kcm_keyboard in 4.6 I get this warning $ kcmshell4 kcm_keyboard kcmshell(946)/kcontrol KCModuleLoader::loadModule: This module still uses K_EXPORT_COMPONENT_FACTORY. Please port it to use KPluginFactory and K_EXPORT_PLUGIN. so it fails

Re: Review Request: Fix the inability to put an ioslave on hold when using the KIO-QNAM integration class...

2010-12-27 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/6183/ --- (Updated 2010-12-27 15:24:34.826232) Review request for kdelibs and Andrea D

Re: Review Request: 4.6 Backport: Fetch a person's OCS social network link icons through Attica.

2010-12-27 Thread Teo Mrnjavac
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/6192/ --- (Updated 2010-12-27 14:24:07.688147) Review request for kdelibs. Summary (