Re: Review request

2010-12-16 Thread Raphael Kubo da Costa
At Mon, 6 Dec 2010 14:51:12 +0100, Thomas Baumgart wrote: > Hi folks, > > I have just moved libalkimia as part of Alkimia (see > http://techbase.kde.org/Projects/KdeFinance/Alkimia for details) to > kdereview > for further processing by the community. alkvalue.h == #define ALKIMIA_

Review Request: Make KRecentDirs namespace and export krecentdirs.h

2010-12-16 Thread Jaroslaw Staniek
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/6142/ --- Review request for kdelibs and David Faure. Summary --- Public header k

Re: Review request

2010-12-16 Thread David Faure
On Monday 06 December 2010, Thomas Baumgart wrote: > - a set of unit testcases is provided However you didn't test compilation of the tests, after moving to kdereview, which has stricter compilation flags, notably -DQT_NO_CAST_FROM_ASCII. /d/qt/4/qt-for-trunk/src/corelib/tools/qstring.h: In membe