Re: enable-final and QT_DECLARE_METATYPE

2010-12-07 Thread Eckhart Wörner
Hi Will, On Monday, 06. December 2010 23:00:23 Will Stephenson wrote: > We use it for openSUSE builds. I haven't benchmarked it. A priori it > should save IO time and cache though. and IIRC a lot of disk space when installing debugging symbols - although I never took the time to investigate wh

Re: Review request

2010-12-07 Thread Aaron J. Seigo
On Monday, December 6, 2010, Thomas Baumgart wrote: > The plan is to move libalkimia to extragear/office/alkimia once approved some hopefully useful feedback: binary compat: there is not dptr, making keeping binary compatibility impossible if changes are desired. for shared libraries it is highl

Re: Review request

2010-12-07 Thread Albert Astals Cid
A Dilluns, 6 de desembre de 2010, Thomas Baumgart va escriure: > Hi folks, > > I have just moved libalkimia as part of Alkimia (see > http://techbase.kde.org/Projects/KdeFinance/Alkimia for details) to > kdereview for further processing by the community. > > The plan is to move libalkimia to ext

Re: enable-final and QT_DECLARE_METATYPE

2010-12-07 Thread Pedro Lopez-Cabanillas
On Tuesday 07 December 2010, Alexander Neundorf wrote: > > I'd also be interested to know if KDE4_ENABLE_FINAL is worth it. > > Some benchmarking would be nice :-) I've compared it against PCH some time ago, and in my case it is worth. http://midi-clorianos.blogspot.com/2009/12/precompiled-heade

KUrl::prettyUrl()

2010-12-07 Thread Tony Murray
In the KUrl::prettyUrl() function, QUrl::toPercentEncoding() is used on the username portion of the url. http://api.kde.org/4.5-api/kdelibs-apidocs/kdecore/html/kurl_8cpp_source.html#l01067 This causes usernames like "domain\user" to be sh

Re: enable-final and QT_DECLARE_METATYPE

2010-12-07 Thread Alexander Neundorf
On Tuesday 07 December 2010, Stephen Kelly wrote: > Will Stephenson wrote: > > On Monday 06 December 2010 22:06:05 you wrote: > >> On Monday 06 December 2010, Will Stephenson wrote: > >> > There have been a couple of enable-final breakages while preparing > >> > 4.6beta1 and now beta2 tarballs that

Re: enable-final and QT_DECLARE_METATYPE

2010-12-07 Thread Stephen Kelly
Will Stephenson wrote: > On Monday 06 December 2010 22:06:05 you wrote: >> On Monday 06 December 2010, Will Stephenson wrote: >> > There have been a couple of enable-final breakages while preparing >> > 4.6beta1 and now beta2 tarballs that keep coming up, so I'd like to >> > remind you about enabl

Re: More about kdelibs unittests

2010-12-07 Thread Stephen Kelly
Jaime wrote: > Hi, > > I've run the kdelibs with the environment variable QT_FATAL_WARNINGS=1, > and the number of failed tests has grown in a noticeable way. (also with 2 > crashes). > > I guess that less Qt warnings usually means less unexpected crashes. > Therefore I suggest to add that

More about kdelibs unittests

2010-12-07 Thread Jaime
Hi, I've run the kdelibs with the environment variable QT_FATAL_WARNINGS=1, and the number of failed tests has grown in a noticeable way. (also with 2 crashes). I guess that less Qt warnings usually means less unexpected crashes. Therefore I suggest to add that variable to the test target,