Re: Review Request: bug fix : add DropMimeData in KDescendantsProxyModel

2010-12-05 Thread Stephen Kelly
> On 2010-12-03 18:43:50, Stephen Kelly wrote: > > It wasn't so much forgotten as omitted because of complexity and weird UI. > > > > Drops can be released directly on an item, or between two items. > > > > If a drop on a kdescendantsproxymodel is released on an item it is > > reasonably clear

Re: Review Request: Merge changes from ffmpethumbnail projekt into the kde version

2010-12-05 Thread Andreas Scherf
> On 2010-11-22 21:10:52, Christoph Feck wrote: > > Wouldn't it be much simpler to use a scaled QPainter on the QImage to > > render the filmstrip holes at different sizes? > > Thomas Lübking wrote: > ... besides that the (hard)code(d strips - at least form a glimpse on the > diff) does no

Re: Review Request: bug fix : add DropMimeData in KDescendantsProxyModel

2010-12-05 Thread Ingo Klöcker
> On 2010-12-03 18:43:50, Stephen Kelly wrote: > > It wasn't so much forgotten as omitted because of complexity and weird UI. > > > > Drops can be released directly on an item, or between two items. > > > > If a drop on a kdescendantsproxymodel is released on an item it is > > reasonably clear

Re: ksnapshot assert fail

2010-12-05 Thread David Faure
[ksnapshot was indeed fixed rather long ago for this, but let's discuss the kdialog behavior] On Thursday 02 December 2010, Aaron J. Seigo wrote: > it's KDialog that making the assertion; and the assertion looks bogus since > it's absolutely plausible that the app requests the default to be a but

Re: Extending KPluginFactory to support exporting symbols

2010-12-05 Thread Chris Burel
Hey guys, I'm working on Perl bindings to Plasma.  For this, I've created a subclass of KPluginFactory that links to libperl and loads the Perl KDE bindings.  But I'm running into trouble when the Perl code needs to load in more Perl extensions dynamically (perl modules that are written and compile

Re: Review Request: Adding "net usershare" suport for KSambaShare

2010-12-05 Thread Rodrigo Belem
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/4320/ --- (Updated 2010-12-04 15:28:00.515837) Review request for kdelibs, Raphael Kub

Re: Potential issue in kshareddatacache.cpp checkin revision 1193778

2010-12-05 Thread Thomas Lübking
Am Saturday 04 December 2010 schrieb Thiago Macieira: > 0u is ISO C standard. Thanks, just worried because of the "cumbesome" C cast. > Also, a literal integer is automatically converted to the right type if the > size fits. So 0 is a valid unsigned integer, but 128 isn't a valid uchar. Yes, but n

Re: headers installation and compilation tests

2010-12-05 Thread Alexander Neundorf
On Monday 29 November 2010, David Faure wrote: > On Monday 09 August 2010, Volker Krause wrote: > > On Saturday 07 August 2010 02:24:16 Aaron J. Seigo wrote: > > > On August 6, 2010, Thiago Macieira wrote: > > > > Side comment: shouldn't all of this (the includes and the > > > > installation rules)

Re: kdesdk depends on kdebase

2010-12-05 Thread Alexander Neundorf
On Saturday 04 December 2010, Andras Mantia wrote: > Hi, > > I compiled KDE trunk and installed in a clean install dir. For some > reason kdebase compilation failed and I saw that kdesdk also failed. > Looking at the log it shows that kdesdk depends on kdebase, because > dolphin-plugins/git and sv

Re: Review Request: KLocale: Keep track of original KSharedConfig/KConfig for later use.

2010-12-05 Thread Oswald Buddenhagen
> On 2010-12-05 09:13:59, Oswald Buddenhagen wrote: > > the kconfig magic is a monstrosity, but it seems reasonably safe. > > though i wonder whether it wouldn't be better to get everything you may > > later need from the config and then just throw it away ... > > > > John Layt wrote: > I h

Re: Review Request: KLocale: Keep track of original KSharedConfig/KConfig for later use.

2010-12-05 Thread John Layt
> On 2010-12-05 09:13:59, Oswald Buddenhagen wrote: > > the kconfig magic is a monstrosity, but it seems reasonably safe. > > though i wonder whether it wouldn't be better to get everything you may > > later need from the config and then just throw it away ... > > I had thought of caching the u

Re: Review Request: KLocale: Keep track of original KSharedConfig/KConfig for later use.

2010-12-05 Thread Oswald Buddenhagen
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/6047/#review9131 --- the kconfig magic is a monstrosity, but it seems reasonably safe.