Re: Potential issue in kshareddatacache.cpp checkin revision 1193778

2010-12-03 Thread Michael Pyne
On Friday, December 03, 2010 00:07:06 Vishal Rao wrote: > Hello, > > Sorry if this is spam/silly. > > I happened to notice this while browsing the 4.5.4 release announcement > pages: > > unsigned KSharedDataCache::totalSize() const > > has added: > > if (lock.failed()) { > return false; > }

Re: Review Request: bug fix : add DropMimeData in KDescendantsProxyModel

2010-12-03 Thread Stephen Kelly
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/6035/#review9115 --- It wasn't so much forgotten as omitted because of complexity and w

Review Request: bug fix : add DropMimeData in KDescendantsProxyModel

2010-12-03 Thread Mario Bensi
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/6035/ --- Review request for kdelibs and Stephen Kelly. Summary --- bug fix : add

Potential issue in kshareddatacache.cpp checkin revision 1193778

2010-12-03 Thread Vishal Rao
Hello, Sorry if this is spam/silly. I happened to notice this while browsing the 4.5.4 release announcement pages: unsigned KSharedDataCache::totalSize() const has added: if (lock.failed()) { return false; } Returning bool false for return type unsigned - is this a potential problem or do y