Re: Helping libraries load their own translation catalogs

2010-11-21 Thread Oswald Buddenhagen
On Sun, Nov 21, 2010 at 12:46:53AM +, Albert Astals Cid wrote: > It achieves that by creating a static that instructs KGlobal to load a > given translation catalog on global locale creation. > statics in shared libraries have always been like a red flag for us. i don't know whether the reasons

Re: Helping libraries load their own translation catalogs

2010-11-21 Thread Artur de Souza
Quoting Albert Astals Cid : Here comes a patch that tries to fix that by moving the catalog loading responsability to the library, that is in my opinion where it should live. Great! What do you think about the patch? Is there any way i can convince you it's safe enough for KDE 4.6 inclusion

Re: Helping libraries load their own translation catalogs

2010-11-21 Thread John Layt
On Sunday 21 November 2010 00:46:53 Albert Astals Cid wrote: > Is there any way i can convince you it's safe enough for KDE 4.6 inclusion? > > Albert +1 from me, if the release team are happy I'm happy, but I see it as more a bug fix than a new feature anyway. John.

Re: Helping libraries load their own translation catalogs

2010-11-21 Thread Chusslove Illich
> [: Albert Astals Cid :] > Which this patch, your library would just have somewhere > > K_CATALOG_LOADER(libkdepim); > > and then all the programs linking to your library would automagically get > the libkdepim catalog loaded. I think that it is crazy that the client code has to add library's c

Re: Helping libraries load their own translation catalogs

2010-11-21 Thread Allen Winter
On Saturday 20 November 2010 7:46:53 pm you wrote: > > What do you think about the patch? > > Is there any way i can convince you it's safe enough for KDE 4.6 inclusion? > I'm convinced.

Re: wrong diffs for python on the kde-commits list

2010-11-21 Thread Tom Albers
- Original Message - > but in Python, leading whitespace has a meaning, and > the diff on kde-commits is just wrong. We have chosen that the advantages of -b are more than the disadvantages of it. For more details browse this lists archive. > So - does anybody actually apply those diffs

Re: wrong diffs for python on the kde-commits list

2010-11-21 Thread Andreas Pakulat
On 21.11.10 09:49:32, Wolfgang Rohdewald wrote: > not sure if this is the correct mailing list for > > please look at > > svn diff -r1199190:1199191 kdegames/kajongg/src/board.py > > in trunk. This is rather much output. > > The kde-commits list shows a very short diff > which I can reproduce

wrong diffs for python on the kde-commits list

2010-11-21 Thread Wolfgang Rohdewald
not sure if this is the correct mailing list for please look at svn diff -r1199190:1199191 kdegames/kajongg/src/board.py in trunk. This is rather much output. The kde-commits list shows a very short diff which I can reproduce by svn diff -b but in Python, leading whitespace has a meaning, and