Re: Hiding the statusbar

2010-11-17 Thread Parker Coates
On Wed, Nov 17, 2010 at 20:28, Steven Sroka wrote: > How do you automatically hide or disable the statusbar in KXmlGuiWindow? Don't pass StandardWindowOption::StatusBar to KXmlGuiWindow::setupGUI(). Parker

Hiding the statusbar

2010-11-17 Thread Steven Sroka
How do you automatically hide or disable the statusbar in KXmlGuiWindow?

Re: Review Request: Make sure to remove KXMLGUIClients from factory on destruction

2010-11-17 Thread David Faure
> On 2010-07-03 22:44:14, David Faure wrote: > > I was initially against this kind of thing (too many problems with > > "intelligent" destructors), this is why it hasn't been done before. > > But after long consideration, I think this one is safe and, as you say, > > somewhat expected by users

Re: kdelibs tests (using valgrind)

2010-11-17 Thread Christoph Feck
On Wednesday 17 November 2010 21:29:54 Christoph Feck wrote: > On Wednesday 17 November 2010 20:59:13 Jaime wrote: > > Conditional jump or move depends on uninitialised value(s) > > > > at 0x5362167: KLed::setLook(KLed::Look) (kled.cpp:225) > > by 0x403433: KLedTest::qt_metacall(QMetaObj

Re: kdelibs tests (using valgrind)

2010-11-17 Thread Christoph Feck
On Wednesday 17 November 2010 20:59:13 Jaime wrote: > Conditional jump or move depends on uninitialised value(s) > at 0x5362167: KLed::setLook(KLed::Look) (kled.cpp:225) > by 0x403433: KLedTest::qt_metacall(QMetaObject::Call, int, void**) > (kledtest.moc:77) > > The cause: two constructor

kdelibs tests (using valgrind)

2010-11-17 Thread Jaime
Hi, I've done by hand an experiment: run some kdelibs tests using valgrind --trace-children=yes --leak-check=full --tool=memcheck most of them result in clean valgrind logs, but some of them not. What I do not have time (nor experience) is to modify the CMakeFile files to run all of the

Re: Review Request: Adding "net usershare" suport for KSambaShare

2010-11-17 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/4320/#review8775 --- /trunk/KDE/kdelibs/kio/kio/ksambashare.h

Re: Review Request: Adding "net usershare" suport for KSambaShare

2010-11-17 Thread Rodrigo Belem
> On 2010-11-15 21:49:42, David Faure wrote: > > /trunk/KDE/kdelibs/kio/kio/ksambashare.cpp, line 93 > > > > > > To keep the C++ code maintainable and modular, please declare and use > > variables in the same line, e

Re: Review Request: Adding "net usershare" suport for KSambaShare

2010-11-17 Thread Rodrigo Belem
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/4320/ --- (Updated 2010-11-17 00:46:45.964173) Review request for kdelibs, Raphael Kub

Re: Review Request: Fix for "The name org.kde.kwalletd was not provided by any .service files" errors about kwallet

2010-11-17 Thread Gökcen Eraslan
> On 2010-11-17 11:25:20, David Faure wrote: > > Looks good to me. Nice side effect, the error string as a wallet name :-) Committed to trunk and 4.5 branch, thank you. - Gökcen --- This is an automatically generated e-mail. To reply, v

Re: Review Request: Fix for "The name org.kde.kwalletd was not provided by any .service files" errors about kwallet

2010-11-17 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/5885/#review8779 --- Ship it! Looks good to me. Nice side effect, the error string as

Re: Review Request: Make sure to remove KXMLGUIClients from factory on destruction

2010-11-17 Thread Matthias Fuchs
> On 2010-07-03 22:44:14, David Faure wrote: > > I was initially against this kind of thing (too many problems with > > "intelligent" destructors), this is why it hasn't been done before. > > But after long consideration, I think this one is safe and, as you say, > > somewhat expected by users

Re: Review Request: Fix for "The name org.kde.kwalletd was not provided by any .service files" errors about kwallet

2010-11-17 Thread Gökcen Eraslan
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/5885/ --- (Updated 2010-11-17 11:04:26.001050) Review request for kdelibs and David Fa

Re: Review Request: Fix for "The name org.kde.kwalletd was not provided by any .service files" errors about kwallet

2010-11-17 Thread Gökcen Eraslan
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/5885/ --- (Updated 2010-11-17 10:40:41.618315) Review request for kdelibs. Summary (

Review Request: Fix for "The name org.kde.kwalletd was not provided by any .service files" errors about kwallet

2010-11-17 Thread Gökcen Eraslan
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/5885/ --- Review request for kdelibs. Summary --- In KWallet::Wallet class (of kd

Re: Review Request: Make sure to remove KXMLGUIClients from factory on destruction

2010-11-17 Thread Thomas Friedrichsmeier
> On 2010-07-03 22:44:14, David Faure wrote: > > I was initially against this kind of thing (too many problems with > > "intelligent" destructors), this is why it hasn't been done before. > > But after long consideration, I think this one is safe and, as you say, > > somewhat expected by users