Re: Review Request: kdebase-workspace build failure - missing soprano includes

2010-11-16 Thread Sebastian Trueg
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/5851/#review8767 --- Ship it! looks fine. - Sebastian On 2010-11-15 20:24:22, Pavel

Re: Review Request: Adding "net usershare" suport for KSambaShare

2010-11-16 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/4320/#review8750 --- /trunk/KDE/kdelibs/kio/kio/ksambashare.h

Review Request: kdebase-workspace build failure - missing soprano includes

2010-11-16 Thread Pavel Heimlich
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/5851/ --- Review request for kdelibs and Beat Wolf. Summary --- This is a patch f

Re: Review Request: Using KWallet to store Cookies

2010-11-16 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/4927/#review8357 --- For the record I too share David's concern with nested event loops

Re: Review Request: Using KWallet to store Cookies

2010-11-16 Thread Michael Leupold
> On 2010-11-16 11:21:29, David Faure wrote: > > /trunk/KDE/kdelibs/kioslave/http/kcookiejar/kcookieserver.cpp, line 499 > > > > > > Same here. Why use Asynchronous if you make it sync anyway? > > > > I see y

Re: Review Request: Using KWallet to store Cookies

2010-11-16 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/4927/#review8753 --- /trunk/KDE/kdebase/apps/konqueror/settings/kio/kcookiespolicies.c