Re: Compiling kdebindings

2010-11-08 Thread todd rme
On Mon, Nov 8, 2010 at 10:02 PM, Steven Sroka wrote: > As of yesterday, I've been getting this error when trying to compile > kdebindings: > [ 28%] Building CXX object smoke/qtgui/CMakeFiles/smokeqtgui.dir/x_8.o > /bin/sh: line 1: 19242 Segmentation fault >  /home/steven/kdesvn/build/kdebindings/g

Compiling kdebindings

2010-11-08 Thread Steven Sroka
As of yesterday, I've been getting this error when trying to compile kdebindings: [ 28%] Building CXX object smoke/qtgui/CMakeFiles/smokeqtgui.dir/x_8.o/bin/sh: line 1: 19242 Segmentation fault /home/steven/kdesvn/build/kdebindings/generator/bin/smokegen -config /home/steven/kdesvn/build/

Re: Changing my mind: reverting my menubar, toolbars and statusbar changes

2010-11-08 Thread Aurélien Gâteau
On 06/11/2010 15:31, Aurélien Gâteau wrote: > # The "Fix my mess" plan > > I would like to revert r1186566, r1186567 and r1192393: > > http://websvn.kde.org/?view=revision&revision=1186566 > http://websvn.kde.org/?view=revision&revision=1186567 > http://websvn.kde.org/?view=revision&revision=1192

Re: Review Request: Social About Dialog implementation for KDElibs

2010-11-08 Thread Raphael Kubo da Costa
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/5794/#review8574 --- * It would be nice to have unit tests for the new code. * See the

Re: Fwd: Using multiple klocales uses stale translations

2010-11-08 Thread Stephen Kelly
Chusslove Illich wrote: >> [: Stephen Kelly :] >> Clearly someone decided that should be commented out. Should what I am >> trying work already, or does that need to be uncommented? > > It was I who both added and later commented out that code. As per the > note, I commented it out because I didn

Re: Review Request: Social About Dialog implementation for KDElibs

2010-11-08 Thread Teo Mrnjavac
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/5794/ --- (Updated 2010-11-08 23:09:50.173342) Review request for kdelibs. Changes -

Re: Review Request: Social About Dialog implementation for KDElibs

2010-11-08 Thread Teo Mrnjavac
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/5794/ --- (Updated 2010-11-08 22:36:04.495433) Review request for kdelibs. Changes -

Re: Review Request: Allow kdelibs compilation with QT_USE_FAST_CONCATENATION & QT_USE_FAST_OPERATOR_PLUS flags...

2010-11-08 Thread Olivier Goffart
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/5795/#review8569 --- trunk/KDE/kdelibs/kate/plugins/exporter/htmlexporter.cpp

Re: Review Request: Allow kdelibs compilation with QT_USE_FAST_CONCATENATION & QT_USE_FAST_OPERATOR_PLUS flags...

2010-11-08 Thread Olivier Goffart
> On 2010-11-08 07:55:39, Stephen Kelly wrote: > > trunk/KDE/kdelibs/kate/plugins/exporter/htmlexporter.cpp, line 102 > > > > > > Shouldn't this be something like > > > > ? QLatin1Literal("color:") + attrib-

Re: Review Request: Social About Dialog implementation for KDElibs

2010-11-08 Thread Albert Astals Cid
> On 2010-11-08 19:05:15, Albert Astals Cid wrote: > > trunk/KDE/kdelibs/kdeui/dialogs/kaboutapplicationpersonmodel_p.cpp, line 240 > > > > > > Why two lines here? > > Teo Mrnjavac wrote: > I realize it's against

Re: Review Request: Social About Dialog implementation for KDElibs

2010-11-08 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/5794/#review8563 --- trunk/KDE/kdelibs/kdeui/dialogs/kaboutapplicationpersonmodel_p.h

Re: Changing my mind: reverting my menubar, toolbars and statusbar changes

2010-11-08 Thread Aurélien Gâteau
On 08/11/2010 14:18, Thomas Lübking wrote: > Am Monday 08 November 2010 schrieb Johannes Sixt: >> How is a checkable menu entry that is not checked different from a menu >> entry that is not checkable, hm? There is *no* difference. > Broken UI style? There "*can be*" a difference ;-P > > Unchecked

Re: Review Request: Social About Dialog implementation for KDElibs

2010-11-08 Thread Teo Mrnjavac
> On 2010-11-08 19:05:15, Albert Astals Cid wrote: > > Just a quick review, did not actually look at the code, sorry. Any pair of eyes is greatly appreciated :) > On 2010-11-08 19:05:15, Albert Astals Cid wrote: > > trunk/KDE/kdelibs/kdeui/dialogs/kaboutapplicationdialog.cpp, line 25 > >

Re: Review Request: Social About Dialog implementation for KDElibs

2010-11-08 Thread Teo Mrnjavac
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/5794/ --- (Updated 2010-11-08 20:58:33.918655) Review request for kdelibs. Changes -

Re: Review Request: Social About Dialog implementation for KDElibs

2010-11-08 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/5794/#review8558 --- Just a quick review, did not actually look at the code, sorry. t

Re: Review Request: Allow kdelibs compilation with QT_USE_FAST_CONCATENATION & QT_USE_FAST_OPERATOR_PLUS flags...

2010-11-08 Thread Stephen Kelly
> On 2010-11-08 07:55:39, Stephen Kelly wrote: > > trunk/KDE/kdelibs/kate/plugins/exporter/htmlexporter.cpp, line 102 > > > > > > Shouldn't this be something like > > > > ? QLatin1Literal("color:") + attrib-

Re: Review Request: Allow kdelibs compilation with QT_USE_FAST_CONCATENATION & QT_USE_FAST_OPERATOR_PLUS flags...

2010-11-08 Thread Dawit Alemayehu
> On 2010-11-08 07:55:39, Stephen Kelly wrote: > > trunk/KDE/kdelibs/kate/plugins/exporter/htmlexporter.cpp, line 102 > > > > > > Shouldn't this be something like > > > > ? QLatin1Literal("color:") + attrib-

Re: Review Request: Allow kdelibs compilation with QT_USE_FAST_CONCATENATION & QT_USE_FAST_OPERATOR_PLUS flags...

2010-11-08 Thread Dawit Alemayehu
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/5795/ --- (Updated 2010-11-08 17:12:54.269260) Review request for kdelibs. Changes -

Re: Changing my mind: reverting my menubar, toolbars and statusbar changes

2010-11-08 Thread Thomas Lübking
Am Monday 08 November 2010 schrieb Johannes Sixt: > How is a checkable menu entry that is not checked different from a menu > entry that is not checkable, hm? There is *no* difference. Broken UI style? There "*can be*" a difference ;-P Unchecked Box: Bespin, Skulpture, Oxygen, QtCurve, Motif/CDE,P

Re: Changing my mind: reverting my menubar, toolbars and statusbar changes

2010-11-08 Thread Hugo Pereira Da Costa
On Monday 08 November 2010 14:35:16 Christoph Feck wrote: > On Monday 08 November 2010 08:06:58 Johannes Sixt wrote: > > How is a checkable menu entry that is not checked different from a menu > > entry that is not checkable, hm? There is *no* difference. > > That depends on the used style. With S

Re: Changing my mind: reverting my menubar, toolbars and statusbar changes

2010-11-08 Thread Christoph Feck
On Monday 08 November 2010 08:06:58 Johannes Sixt wrote: > How is a checkable menu entry that is not checked different from a menu > entry that is not checkable, hm? There is *no* difference. That depends on the used style. With Skulpture, for example, any checkable entry shows a check box, eithe

Re: Review Request: Add isReleased() method to StorageDrive interface

2010-11-08 Thread Jacopo De Simoi
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/5770/ --- (Updated 2010-11-08 11:10:44.918200) Review request for kdelibs and Kevin Ot

Review Request: Social About Dialog implementation for KDElibs

2010-11-08 Thread Teo Mrnjavac
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/5794/ --- Review request for kdelibs. Summary --- The present review request cont