subject:"\[valgrind\] \[Bug 388862\] Add replacements for wmemchr and wcsnlen on Linux"

[valgrind] [Bug 388862] Add replacements for wmemchr and wcsnlen on Linux

2018-03-02 Thread Ivo Raisr

https://bugs.kde.org/show_bug.cgi?id=388862 Ivo Raisr changed: What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|---

[valgrind] [Bug 388862] Add replacements for wmemchr and wcsnlen on Linux

2018-03-02 Thread Nix

https://bugs.kde.org/show_bug.cgi?id=388862 --- Comment #11 from Nix --- OK OK I was clearly on some serious drugs that day. God only knows what I actually compiled (though it does seem to work, and is still working). I have now replaced it with your fixed patch, which also works while having the

[valgrind] [Bug 388862] Add replacements for wmemchr and wcsnlen on Linux

2018-03-02 Thread Ivo Raisr

https://bugs.kde.org/show_bug.cgi?id=388862 --- Comment #10 from Ivo Raisr --- :-) There was also a problem with the actual replacement definition. For example wcsnlen had the following: #if defined(VGO_linux) STRNLEN(VG_Z_LIBC_SONAME, wcsnlen) STRNLEN(VG_Z_LIBC_SONAME, __GI_wcsnlen) #endif

[valgrind] [Bug 388862] Add replacements for wmemchr and wcsnlen on Linux

2018-03-02 Thread Nix

https://bugs.kde.org/show_bug.cgi?id=388862 --- Comment #9 from Nix --- OK! I don't understand how my original wcsnlen() is compiling for me at all: I mean it's obvious that I forgot I was writing a while and changed to a for halfway through the statement, leading to something grossly syntactica

[valgrind] [Bug 388862] Add replacements for wmemchr and wcsnlen on Linux

2018-03-02 Thread Ivo Raisr

https://bugs.kde.org/show_bug.cgi?id=388862 Ivo Raisr changed: What|Removed |Added Attachment #42|0 |1 is obsolete||

[valgrind] [Bug 388862] Add replacements for wmemchr and wcsnlen on Linux

2018-03-02 Thread Ivo Raisr

https://bugs.kde.org/show_bug.cgi?id=388862 --- Comment #7 from Ivo Raisr --- Oh, alright, let's make it Int also for wcslen() so the whole file is consistent. -- You are receiving this mail because: You are watching all bug changes.

[valgrind] [Bug 388862] Add replacements for wmemchr and wcsnlen on Linux

2018-03-02 Thread Nix

https://bugs.kde.org/show_bug.cgi?id=388862 --- Comment #6 from Nix --- I'll admit I don't understand why wmemchr() and wcsnlen() need to take UInt *s when the other wide character functions in the same file are quite happy with Ints, but if you prefer it, I don't see any problem doing it that wa

[valgrind] [Bug 388862] Add replacements for wmemchr and wcsnlen on Linux

2018-03-02 Thread Ivo Raisr

https://bugs.kde.org/show_bug.cgi?id=388862 Ivo Raisr changed: What|Removed |Added Attachment #111086|0 |1 is obsolete||

[valgrind] [Bug 388862] Add replacements for wmemchr and wcsnlen on Linux

2018-03-02 Thread Ivo Raisr

https://bugs.kde.org/show_bug.cgi?id=388862 --- Comment #4 from Ivo Raisr --- Thank you for the patch. I had to make some fixes to make it actually work and do not introduce regressions. Please review the attachment. -- You are receiving this mail because: You are watching all bug changes.