[krita] [Bug 394381] Translations are not built when building from git

2018-05-23 Thread Boudewijn Rempt
https://bugs.kde.org/show_bug.cgi?id=394381 Boudewijn Rempt changed: What|Removed |Added Latest Commit|https://commits.kde.org/kri |https://commits.kde.org/kri

[krita] [Bug 394381] Translations are not built when building from git

2018-05-18 Thread Boudewijn Rempt
https://bugs.kde.org/show_bug.cgi?id=394381 Boudewijn Rempt changed: What|Removed |Added Latest Commit||https://commits.kde.org/kri

[krita] [Bug 394381] Translations are not built when building from git

2018-05-17 Thread Boudewijn Rempt
https://bugs.kde.org/show_bug.cgi?id=394381 --- Comment #8 from Boudewijn Rempt --- Well, sure, but the release scripts would still add the two lines to the end, again... -- You are receiving this mail because: You are watching all bug changes.

[krita] [Bug 394381] Translations are not built when building from git

2018-05-17 Thread Peter Eszlari
https://bugs.kde.org/show_bug.cgi?id=394381 --- Comment #7 from Peter Eszlari --- This wouldn't work? if(EXISTS po) find_package(KF5I18n CONFIG REQUIRED) ki18n_install(po) endif -- You are receiving this mail because: You are watching all bug changes.

[krita] [Bug 394381] Translations are not built when building from git

2018-05-17 Thread Boudewijn Rempt
https://bugs.kde.org/show_bug.cgi?id=394381 --- Comment #6 from Boudewijn Rempt --- Sure it could, but the release process doesn't really support that :-( -- You are receiving this mail because: You are watching all bug changes.

[krita] [Bug 394381] Translations are not built when building from git

2018-05-17 Thread Peter Eszlari
https://bugs.kde.org/show_bug.cgi?id=394381 --- Comment #5 from Peter Eszlari --- Couldn't this be made conditional? -- You are receiving this mail because: You are watching all bug changes.

[krita] [Bug 394381] Translations are not built when building from git

2018-05-17 Thread Boudewijn Rempt
https://bugs.kde.org/show_bug.cgi?id=394381 --- Comment #4 from Boudewijn Rempt --- It also adds two lines to the end of the CMakeLists.txt file: find_package(KF5I18n CONFIG REQUIRED) ki18n_install(po) -- You are receiving this mail because: You are watching all bug changes.

[krita] [Bug 394381] Translations are not built when building from git

2018-05-17 Thread Peter Eszlari
https://bugs.kde.org/show_bug.cgi?id=394381 --- Comment #3 from Peter Eszlari --- I extracted the translations from krita-4.0.3.tar.gz to "krita-src/po", but they didn't get picked up by the build system. Is there something else that needs to be modified? -- You are receiving this mail because:

[krita] [Bug 394381] Translations are not built when building from git

2018-05-17 Thread Peter Eszlari
https://bugs.kde.org/show_bug.cgi?id=394381 --- Comment #2 from Peter Eszlari --- (In reply to Boudewijn Rempt from comment #1) > Translations are only copied into the source when we generate the tarballs. >From where (URL)? I could pull them before build automatically. -- You are receiving th

[krita] [Bug 394381] Translations are not built when building from git

2018-05-17 Thread Boudewijn Rempt
https://bugs.kde.org/show_bug.cgi?id=394381 Boudewijn Rempt changed: What|Removed |Added CC||b...@valdyas.org Summary|Translati