Re: [PR] Add an option in the gradle.properties for html junit reports [solr]

2024-10-17 Thread via GitHub
gus-asf commented on PR #2777: URL: https://github.com/apache/solr/pull/2777#issuecomment-2420836433 This is small, and build only, So I intend to merge/port in a day or two unless I get feedback. -- This is an automated message from the Apache Git Service. To respond to the message, plea

[PR] Add an option in the gradle.properties for html junit reports [solr]

2024-10-17 Thread via GitHub
gus-asf opened a new pull request, #2777: URL: https://github.com/apache/solr/pull/2777 This is a simple enhancement that makes it easy to enable the html test report that gradle would normally produce (but we disable to save a few seconds). I frequently have a NO_COMMIT change list contain

Re: [PR] SOLR-17413: ulog replay should copy SolrQueryRequest [solr]

2024-10-17 Thread via GitHub
dsmiley commented on code in PR #2765: URL: https://github.com/apache/solr/pull/2765#discussion_r1805481104 ## solr/core/src/java/org/apache/solr/update/UpdateLog.java: ## @@ -2097,10 +2098,19 @@ public void doReplay(TransactionLog translog) { UpdateRequestProcessorChai

Re: [PR] Update org.apache.hadoop:* to v3.4.0 [solr]

2024-10-17 Thread via GitHub
janhoy merged PR #2380: URL: https://github.com/apache/solr/pull/2380 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

Re: [PR] Update org.apache.hadoop:* to v3.4.0 [solr]

2024-10-17 Thread via GitHub
janhoy commented on PR #2380: URL: https://github.com/apache/solr/pull/2380#issuecomment-2420601869 Thanks @risdenk -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

Re: [PR] Bump up Java version to 21 [solr]

2024-10-17 Thread via GitHub
dsmiley commented on PR #2682: URL: https://github.com/apache/solr/pull/2682#issuecomment-2420572657 No please don't create yet another PR just because the diff isn't looking clear. I've already reviewed everything so I recommend a rebase & force push. You're super close to merging t

[jira] [Updated] (SOLR-17501) CLI: Reduce responsibilities of SolrCLI

2024-10-17 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17501?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated SOLR-17501: -- Labels: cli pull-request-available (was: cli) > CLI: Reduce responsibilities of SolrCLI >

Re: [PR] SOLR-17501: Move out CLI utils from SolrCLI [solr]

2024-10-17 Thread via GitHub
epugh commented on PR #2744: URL: https://github.com/apache/solr/pull/2744#issuecomment-2420464388 Is this able to backwards ported to 9x? Seems good stuff! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

Re: [PR] SOLR-16470: Create V2 equivalent of V1 Replication: Get files/{filePath} [solr]

2024-10-17 Thread via GitHub
gerlowskija commented on code in PR #2734: URL: https://github.com/apache/solr/pull/2734#discussion_r1805218688 ## solr/core/src/java/org/apache/solr/handler/admin/api/CoreReplicationAPI.java: ## @@ -68,6 +71,45 @@ public FileListResponse fetchFileList( return doFetchFileLi

Re: [PR] Bump up Java version to 21 [solr]

2024-10-17 Thread via GitHub
iamsanjay commented on PR #2682: URL: https://github.com/apache/solr/pull/2682#issuecomment-2420152288 > Sadly the PR diff is now confusing; seems to have dependency updates and stuff from main but GitHub isn't detecting/realizing that this PR shouldn't be bringing such changes if merged. O

Re: [PR] SOLR-17450 StatusTool with pure Java code [solr]

2024-10-17 Thread via GitHub
epugh commented on PR #2712: URL: https://github.com/apache/solr/pull/2712#issuecomment-2420106926 I love how instead of making StatusTool help output more complex, you added the "stealth" idea that honestly we may use in other places! -- This is an automated message from the Apache Git S

Re: [PR] SOLR-17450 StatusTool with pure Java code [solr]

2024-10-17 Thread via GitHub
janhoy commented on code in PR #2712: URL: https://github.com/apache/solr/pull/2712#discussion_r1805152713 ## solr/core/src/java/org/apache/solr/cli/StatusTool.java: ## @@ -65,72 +73,224 @@ public String getName() { .desc("Wait up to the specified number of seconds to

[jira] [Updated] (SOLR-16470) Create V2 equivalent of V1 Replication: Get IndexVersion, Get FileStream, Get File List

2024-10-17 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16470?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated SOLR-16470: -- Labels: V2 newdev pull-request-available (was: V2 newdev) > Create V2 equivalent of V1 Replica

Re: [PR] SOLR-16470: Create V2 equivalent of V1 Replication: Get files/{filePath} [solr]

2024-10-17 Thread via GitHub
gerlowskija commented on PR #2734: URL: https://github.com/apache/solr/pull/2734#issuecomment-2420028308 Awesome - thanks @mlbiscoc . Sorry for the delay getting to this - took me awhile to catch back up after the travel last week. Reviewing now... -- This is an automated message from t

Re: [PR] SOLR-17413: ulog replay should copy SolrQueryRequest [solr]

2024-10-17 Thread via GitHub
gerlowskija commented on PR #2765: URL: https://github.com/apache/solr/pull/2765#issuecomment-2420002865 Oops meant to tag you - @dsmiley -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

Re: [PR] SOLR-17413: ulog replay should copy SolrQueryRequest [solr]

2024-10-17 Thread via GitHub
gerlowskija commented on PR #2765: URL: https://github.com/apache/solr/pull/2765#issuecomment-2420002345 Sure - feel free to push to the branch if you've got an idea. Not totally sure what you mean by a "re-using pool", but I'm sure that'll be clearer on seeing the code. (Unless it's

Re: [PR] Bump up Java version to 21 [solr]

2024-10-17 Thread via GitHub
dsmiley commented on PR #2682: URL: https://github.com/apache/solr/pull/2682#issuecomment-2419997783 Sadly the PR diff is now confusing; seems to have dependency updates and stuff from main but GitHub isn't detecting/realizing that this PR shouldn't be bringing such changes if merged. Or y

Re: [PR] Replace CloudLegacySolrClient with CloudHttp2SolrClient in SolrClientCloudManager [solr]

2024-10-17 Thread via GitHub
dsmiley commented on code in PR #2751: URL: https://github.com/apache/solr/pull/2751#discussion_r1805062658 ## solr/solrj-zookeeper/src/test/org/apache/solr/client/solrj/impl/NodeValueFetcherTest.java: ## @@ -62,28 +64,31 @@ public void cleanup() throws Exception { } @Te

Re: [PR] SOLR-17450 StatusTool with pure Java code [solr]

2024-10-17 Thread via GitHub
janhoy commented on code in PR #2712: URL: https://github.com/apache/solr/pull/2712#discussion_r1805048091 ## solr/core/src/java/org/apache/solr/cli/StatusTool.java: ## @@ -65,72 +73,224 @@ public String getName() { .desc("Wait up to the specified number of seconds to

Re: [PR] Update org.apache.hadoop:* to v3.4.0 [solr]

2024-10-17 Thread via GitHub
janhoy commented on PR #2380: URL: https://github.com/apache/solr/pull/2380#issuecomment-2419935006 I got no response on my review request :( Went ahead and brought up to date with main. Will use CTR for this then.. -- This is an automated message from the Apache Git Service. To res

[jira] [Resolved] (SOLR-17472) Upgrade Lucene to 9.12.0

2024-10-17 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-17472?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Høydahl resolved SOLR-17472. Resolution: Duplicate > Upgrade Lucene to 9.12.0 > > > Key

Re: [PR] Bump up Java version to 21 [solr]

2024-10-17 Thread via GitHub
iamsanjay commented on PR #2682: URL: https://github.com/apache/solr/pull/2682#issuecomment-2419885328 Trying to suppress security warnings (excessive logging) but did not work: "-Xlint:removal" ``` WARNING: A command line option has enabled the Security Manager WARNING: T

Re: [PR] Bump up Java version to 21 [solr]

2024-10-17 Thread via GitHub
iamsanjay commented on PR #2682: URL: https://github.com/apache/solr/pull/2682#issuecomment-2419834963 Next: 1. Change the smokeTestRelease. One of the change that I can think of is to test Jar Java version for SolrJ and Solr. 2. Whenever we plan to merge it, we need to make the Java v

[jira] [Created] (SOLR-17502) overlay request forwarding does not work with http/2

2024-10-17 Thread Sebastian Hofmann (Jira)
Sebastian Hofmann created SOLR-17502: Summary: overlay request forwarding does not work with http/2 Key: SOLR-17502 URL: https://issues.apache.org/jira/browse/SOLR-17502 Project: Solr Iss

[jira] [Created] (SOLR-17501) CLI: Reduce responsibilities of SolrCLI

2024-10-17 Thread Christos Malliaridis (Jira)
Christos Malliaridis created SOLR-17501: --- Summary: CLI: Reduce responsibilities of SolrCLI Key: SOLR-17501 URL: https://issues.apache.org/jira/browse/SOLR-17501 Project: Solr Issue Type

Re: [PR] Add link to blog post on C/C NA BOF [solr-site]

2024-10-17 Thread via GitHub
epugh merged PR #129: URL: https://github.com/apache/solr-site/pull/129 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.o

[jira] [Commented] (SOLR-16825) Generate Java bindings from OpenAPI spec

2024-10-17 Thread Jason Gerlowski (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16825?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17890457#comment-17890457 ] Jason Gerlowski commented on SOLR-16825: This ticket added our 'api' gradle modul

[jira] [Commented] (SOLR-15750) Create a v2 equivalent for 'REINDEXCOLLECTION'

2024-10-17 Thread Jason Gerlowski (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17890453#comment-17890453 ] Jason Gerlowski commented on SOLR-15750: Yep, AddReplicaProperty (and the related

[jira] [Commented] (SOLR-6122) API to cancel an already submitted/running Collections API call

2024-10-17 Thread Jason Gerlowski (Jira)
[ https://issues.apache.org/jira/browse/SOLR-6122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17890452#comment-17890452 ] Jason Gerlowski commented on SOLR-6122: --- I agree with David - the thorough discussio

[jira] [Updated] (SOLR-17500) Upgrade Lucene to 10.0.0 (on main)

2024-10-17 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-17500?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Høydahl updated SOLR-17500: --- Fix Version/s: main (10.0) > Upgrade Lucene to 10.0.0 (on main) > --

[jira] [Updated] (SOLR-17500) Upgrade Lucene to 10.0.0 (on main)

2024-10-17 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-17500?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Høydahl updated SOLR-17500: --- Priority: Blocker (was: Major) > Upgrade Lucene to 10.0.0 (on main) > --

[jira] [Created] (SOLR-17500) Upgrade Lucene to 10.0.0 (on main)

2024-10-17 Thread Jira
Jan Høydahl created SOLR-17500: -- Summary: Upgrade Lucene to 10.0.0 (on main) Key: SOLR-17500 URL: https://issues.apache.org/jira/browse/SOLR-17500 Project: Solr Issue Type: Task Security L

Re: [PR] SOLR-16503: Replace default USH apache client with Http2SolrClient [solr]

2024-10-17 Thread via GitHub
dsmiley commented on code in PR #2741: URL: https://github.com/apache/solr/pull/2741#discussion_r1804727277 ## solr/core/src/java/org/apache/solr/filestore/DistribFileStore.java: ## @@ -180,23 +184,35 @@ private boolean fetchFileFromNodeAndPersist(String fromNode) { By

Re: [PR] SOLR-17489: CLI: Deprecate variations on solr urls options [solr]

2024-10-17 Thread via GitHub
epugh commented on PR #2756: URL: https://github.com/apache/solr/pull/2756#issuecomment-2419344613 Will add CHANGES.txt all at once. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

Re: [PR] SOLR-17489: CLI: Deprecate variations on solr urls options [solr]

2024-10-17 Thread via GitHub
epugh merged PR #2756: URL: https://github.com/apache/solr/pull/2756 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

Re: [PR] SOLR-17485 Remove CheckLoggingConfiguration; unnecessary [solr]

2024-10-17 Thread via GitHub
epugh commented on PR #2763: URL: https://github.com/apache/solr/pull/2763#issuecomment-2419342381 Naming looks great, and some simplifications. I tried to understand from javadocs what `excludedPath` was all about and didn't grok it but that isn't important. -- This is an automated

Re: [PR] SOLR-17450 StatusTool with pure Java code [solr]

2024-10-17 Thread via GitHub
epugh commented on code in PR #2712: URL: https://github.com/apache/solr/pull/2712#discussion_r1804628762 ## solr/core/src/java/org/apache/solr/cli/StatusTool.java: ## @@ -65,72 +73,224 @@ public String getName() { .desc("Wait up to the specified number of seconds to

Re: [PR] SOLR-17450 StatusTool with pure Java code [solr]

2024-10-17 Thread via GitHub
janhoy commented on code in PR #2712: URL: https://github.com/apache/solr/pull/2712#discussion_r1804262865 ## solr/core/src/java/org/apache/solr/cli/StatusTool.java: ## @@ -65,72 +73,224 @@ public String getName() { .desc("Wait up to the specified number of seconds to

[PR] feat: Added Elestio as one-click deploy option [solr]

2024-10-17 Thread via GitHub
kaiwalyakoparkar opened a new pull request, #2775: URL: https://github.com/apache/solr/pull/2775 Hey team, I am Kaiwalya, Developer Advocate at Elestio. Elestio has been providing options of fully deploying and managing Solr application as shown [here](https://elest.io/open-source/solr).