Pankraz76 commented on code in PR #2322:
URL: https://github.com/apache/maven/pull/2322#discussion_r2084060246
##
pom.xml:
##
@@ -796,9 +796,60 @@ under the License.
+
+ org.openrewrite.maven
+ rewrite-maven-plugin
+
[
https://issues.apache.org/jira/browse/MNG-8642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17950853#comment-17950853
]
Guillaume Nodet commented on MNG-8642:
--
I think those are new classes for plugins targ
Pankraz76 commented on code in PR #2322:
URL: https://github.com/apache/maven/pull/2322#discussion_r2084070185
##
pom.xml:
##
@@ -796,9 +796,60 @@ under the License.
+
+ org.openrewrite.maven
+ rewrite-maven-plugin
+
Pankraz76 commented on code in PR #2322:
URL: https://github.com/apache/maven/pull/2322#discussion_r2084092664
##
pom.xml:
##
@@ -796,9 +796,60 @@ under the License.
+
+ org.openrewrite.maven
+ rewrite-maven-plugin
+
asf-gitbox-commits closed pull request #237: [SCM-1028] Fix clear password
logging vulnerability
URL: https://github.com/apache/maven-scm/pull/237
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
[
https://issues.apache.org/jira/browse/SCM-1028?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Osipov closed SCM-1028.
---
Resolution: Fixed
Fixed with
[8b44e4f6745e7bd677428be093921267317b8fe8|https://gitbox.apache.org/repos
[
https://issues.apache.org/jira/browse/SCM-1028?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17950856#comment-17950856
]
ASF GitHub Bot commented on SCM-1028:
-
asf-gitbox-commits closed pull request #237: [SC
[
https://issues.apache.org/jira/browse/SCM-1029?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Osipov reassigned SCM-1029:
---
Assignee: Michael Osipov
> JGit performing empty commit on CheckIn command if includes or excl
[
https://issues.apache.org/jira/browse/SCM-1029?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Osipov updated SCM-1029:
Fix Version/s: 2.2.0
> JGit performing empty commit on CheckIn command if includes or excludes
> fil
Pankraz76 commented on PR #2236:
URL: https://github.com/apache/maven/pull/2236#issuecomment-2871372328
this could not compile with help of
https://docs.openrewrite.org/recipes/staticanalysis/finalizemethodarguments
--
This is an automated message from the Apache Git Service.
To respond t
Pankraz76 commented on code in PR #2322:
URL: https://github.com/apache/maven/pull/2322#discussion_r2084077229
##
pom.xml:
##
@@ -796,9 +796,60 @@ under the License.
+
+ org.openrewrite.maven
+ rewrite-maven-plugin
+
Pankraz76 commented on code in PR #2322:
URL: https://github.com/apache/maven/pull/2322#discussion_r2084080484
##
pom.xml:
##
@@ -796,9 +796,60 @@ under the License.
+
+ org.openrewrite.maven
+ rewrite-maven-plugin
+
Pankraz76 commented on code in PR #2322:
URL: https://github.com/apache/maven/pull/2322#discussion_r2084070185
##
pom.xml:
##
@@ -796,9 +796,60 @@ under the License.
+
+ org.openrewrite.maven
+ rewrite-maven-plugin
+
[
https://issues.apache.org/jira/browse/SCM-1028?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Osipov updated SCM-1028:
Labels: vulnerability (was: Vulnerability vulnerabilities vulnerability)
> Vulnerability: Clear text
Pankraz76 commented on PR #2236:
URL: https://github.com/apache/maven/pull/2236#issuecomment-2871407397
rewrite would make the boilerplate way i would prefer silent PMD.
https://adabeat.com/fp/immutability-in-functional-programming/
We make everywhere boilerplate to throw NPE ou
Pankraz76 commented on code in PR #2322:
URL: https://github.com/apache/maven/pull/2322#discussion_r2084111582
##
pom.xml:
##
@@ -796,9 +796,68 @@ under the License.
+
+ org.openrewrite.maven
+ rewrite-maven-plugin
+
Pankraz76 commented on code in PR #2322:
URL: https://github.com/apache/maven/pull/2322#discussion_r2084111582
##
pom.xml:
##
@@ -796,9 +796,68 @@ under the License.
+
+ org.openrewrite.maven
+ rewrite-maven-plugin
+
Pankraz76 commented on code in PR #2322:
URL: https://github.com/apache/maven/pull/2322#discussion_r2084111582
##
pom.xml:
##
@@ -796,9 +796,68 @@ under the License.
+
+ org.openrewrite.maven
+ rewrite-maven-plugin
+
[
https://issues.apache.org/jira/browse/SCM-1029?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Osipov closed SCM-1029.
---
Resolution: Fixed
Fixed with
[c4bbee338746f1979e13c8266c689db2c0ad6bd1|https://gitbox.apache.org/repos
Tamas Cservenak created MNG-8726:
Summary: Bump jlineVersion from 3.29.0 to 3.30.0
Key: MNG-8726
URL: https://issues.apache.org/jira/browse/MNG-8726
Project: Maven
Issue Type: Dependency upgr
cstamas commented on PR #2324:
URL: https://github.com/apache/maven/pull/2324#issuecomment-2871717690
Superseded by https://github.com/apache/maven/pull/2325
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abov
slawekjaranowski commented on PR #237:
URL: https://github.com/apache/maven-scm/pull/237#issuecomment-2871723035
@michael-o - Please take account that PR with status 'closed' will be not
reported by release drafter.
So we will not have it in release notes.
--
This is an automated
Pankraz76 commented on code in PR #2321:
URL: https://github.com/apache/maven/pull/2321#discussion_r2083960846
##
.editorconfig:
##
@@ -0,0 +1,33 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# d
slawekjaranowski commented on code in PR #2321:
URL: https://github.com/apache/maven/pull/2321#discussion_r2083968123
##
.editorconfig:
##
@@ -0,0 +1,33 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE fi
slawekjaranowski merged PR #269:
URL: https://github.com/apache/maven-archetype/pull/269
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr
slawekjaranowski merged PR #129:
URL: https://github.com/apache/maven-changes-plugin/pull/129
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-uns
Pankraz76 commented on code in PR #2321:
URL: https://github.com/apache/maven/pull/2321#discussion_r2083997501
##
.editorconfig:
##
@@ -0,0 +1,33 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# d
Pankraz76 commented on code in PR #2321:
URL: https://github.com/apache/maven/pull/2321#discussion_r2083999197
##
.editorconfig:
##
@@ -0,0 +1,33 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# d
Pankraz76 commented on code in PR #2321:
URL: https://github.com/apache/maven/pull/2321#discussion_r2083999197
##
.editorconfig:
##
@@ -0,0 +1,33 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# d
[
https://issues.apache.org/jira/browse/SCM-1028?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Osipov reassigned SCM-1028:
---
Assignee: Michael Osipov
> Vulnerability: Clear text password is logged by JGit provider and b
[
https://issues.apache.org/jira/browse/SCM-1028?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Osipov updated SCM-1028:
Fix Version/s: 2.2.0
> Vulnerability: Clear text password is logged by JGit provider and by gitexe
>
Pankraz76 commented on code in PR #2322:
URL: https://github.com/apache/maven/pull/2322#discussion_r2084144583
##
src/mdo/java/WrapperList.java:
##
@@ -105,7 +105,7 @@ public T remove(int index) {
}
}
-private Object writeReplace() throws ObjectStreamExceptio
Pankraz76 commented on code in PR #2322:
URL: https://github.com/apache/maven/pull/2322#discussion_r2084111582
##
pom.xml:
##
@@ -796,9 +796,68 @@ under the License.
+
+ org.openrewrite.maven
+ rewrite-maven-plugin
+
[
https://issues.apache.org/jira/browse/MNG-8642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17950849#comment-17950849
]
Slawomir Jaranowski commented on MNG-8642:
--
[~gnodet]
- should we do according c
Pankraz76 commented on code in PR #2322:
URL: https://github.com/apache/maven/pull/2322#discussion_r2084080484
##
pom.xml:
##
@@ -796,9 +796,60 @@ under the License.
+
+ org.openrewrite.maven
+ rewrite-maven-plugin
+
asf-gitbox-commits closed pull request #238: [SCM-1029] Fix empty commits on
JGit checkin
URL: https://github.com/apache/maven-scm/pull/238
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specif
[
https://issues.apache.org/jira/browse/SCM-1029?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17950870#comment-17950870
]
ASF GitHub Bot commented on SCM-1029:
-
asf-gitbox-commits closed pull request #238: [SC
slawekjaranowski commented on PR #238:
URL: https://github.com/apache/maven-scm/pull/238#issuecomment-2871738995
@michael-o
Merged PR should have a label and milestone
By default GitHub action - PR Automation do it but here was not
executed ... probably of merge by commi
[
https://issues.apache.org/jira/browse/SCM-1028?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17950886#comment-17950886
]
ASF GitHub Bot commented on SCM-1028:
-
slawekjaranowski commented on PR #237:
URL: http
slawekjaranowski commented on PR #237:
URL: https://github.com/apache/maven-scm/pull/237#issuecomment-2871728242
please look ar draft release notes -
https://github.com/apache/maven-scm/releases
--
This is an automated message from the Apache Git Service.
To respond to the message, please
[
https://issues.apache.org/jira/browse/SCM-1028?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17950887#comment-17950887
]
ASF GitHub Bot commented on SCM-1028:
-
slawekjaranowski commented on PR #237:
URL: http
[
https://issues.apache.org/jira/browse/SCM-1029?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17950889#comment-17950889
]
ASF GitHub Bot commented on SCM-1029:
-
slawekjaranowski commented on PR #238:
URL: http
michael-o commented on PR #238:
URL: https://github.com/apache/maven-scm/pull/238#issuecomment-2871752383
> @michael-o Merged PR should have a label and milestone
>
> By default GitHub action - PR Automation do it but here was not
executed ... probably of merge by commit no
mhoffrog commented on PR #237:
URL: https://github.com/apache/maven-scm/pull/237#issuecomment-2871752655
@slawekjaranowski @michael-o
- Is there a reason why asf-gitbox-commits is closing without merging the PR
and creating a dedicated commit to master with the changes. Looks pretty
irri
[
https://issues.apache.org/jira/browse/SCM-1029?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17950892#comment-17950892
]
ASF GitHub Bot commented on SCM-1029:
-
michael-o commented on PR #238:
URL: https://git
[
https://issues.apache.org/jira/browse/SCM-1028?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17950893#comment-17950893
]
ASF GitHub Bot commented on SCM-1028:
-
mhoffrog commented on PR #237:
URL: https://gith
[
https://issues.apache.org/jira/browse/SCM-1029?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17950904#comment-17950904
]
ASF GitHub Bot commented on SCM-1029:
-
michael-o commented on PR #238:
URL: https://git
michael-o commented on PR #238:
URL: https://github.com/apache/maven-scm/pull/238#issuecomment-2871923247
> > > @michael-o Merged PR should have a label and milestone
> > > By default GitHub action - PR Automation do it but here was not
executed ... probably of merge by commit n
Bukama commented on issue #364:
URL: https://github.com/apache/maven-enforcer/issues/364#issuecomment-2873499765
On Maven 3.9.8 it's working fine.
[2025-05-12_master_Maven3.9.8.log](https://github.com/user-attachments/files/20170042/2025-05-12_master_Maven3.9.8.log)
--
This is an a
slawekjaranowski merged PR #107:
URL: https://github.com/apache/maven-dist-tool/pull/107
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr
cstamas opened a new pull request, #2328:
URL: https://github.com/apache/maven/pull/2328
Simple changes that makes build/ITs work with Java 24.
PR does not contains:
* action addition of Java 24 to CI
* updated Eclipse Sisu version (needed for that above)
---
https:
[
https://issues.apache.org/jira/browse/MNG-8727?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tamas Cservenak reassigned MNG-8727:
Assignee: Tamas Cservenak
> Prepare for Java 24
> ---
>
> Ke
Bukama opened a new issue, #364:
URL: https://github.com/apache/maven-enforcer/issues/364
### Affected version
3.6.0-SNAPSHOT (master - f6c114b7d7f8035c152af0efe955d71c12870222)
### Bug description
The master branch breaks on Maven 4.0.0-rc3 on Windows (with admin rights)
gnodet commented on PR #2322:
URL: https://github.com/apache/maven/pull/2322#issuecomment-2873545295
As an alternative, could open rewrite be setup to comment on PRs ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use th
gnodet commented on issue #364:
URL: https://github.com/apache/maven-enforcer/issues/364#issuecomment-2873540958
The dependency tree has slightly changed between in Maven 4, so I suspect it
comes from that. If that's the case (you may want to diff the dependency tree),
that's not a bug and
Pankraz76 commented on PR #2236:
URL: https://github.com/apache/maven/pull/2236#issuecomment-2873551134
> useless
disagree, its called best practise for reason.
agree, with help of rewrite, we can get benefits for free. Enforcing really
strong coding guidelines.
--
This is
Pankraz76 commented on PR #2322:
URL: https://github.com/apache/maven/pull/2322#issuecomment-2873791586
> * I don't want to introduce additional plugins into the build.
> *
Format is limited to cosmetics. Check is just file parser too, therefore
very limited.
Ideally, we wou
Tamas Cservenak created MNG-8728:
Summary: Eclipse Sisu upgrade and Java 24
Key: MNG-8728
URL: https://issues.apache.org/jira/browse/MNG-8728
Project: Maven
Issue Type: Task
Repor
[
https://issues.apache.org/jira/browse/MNG-8728?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tamas Cservenak updated MNG-8728:
-
Summary: Bump Eclipse Sisu from 0.9.0.M3 to XXX and use Java 24 on CI
(was: Eclipse Sisu upgrade a
Pankraz76 commented on PR #2326:
URL: https://github.com/apache/maven/pull/2326#issuecomment-2873836165
https://refactoring.guru/design-patterns/factory-method
Considering factory adhering to creational design pattern its supposed to
`create` (what) stuff like shown in pr, not to `do`
Pankraz76 commented on PR #2326:
URL: https://github.com/apache/maven/pull/2326#issuecomment-2873857919
> It really does not make any sense to me to wrap the request (immutable
data object) into another object, just for the sake of having methods
collocated with the data.
we can inli
slawekjaranowski closed pull request #366: GitHub action set fail-fast to false
URL: https://github.com/apache/maven-javadoc-plugin/pull/366
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specif
slawekjaranowski commented on PR #366:
URL:
https://github.com/apache/maven-javadoc-plugin/pull/366#issuecomment-2873596369
looks like all JDKs are ok ... so close it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use th
Bukama commented on issue #364:
URL: https://github.com/apache/maven-enforcer/issues/364#issuecomment-2873609518
> The dependency tree has slightly changed between in Maven 4, so I suspect
it comes from that. If that's the case (you may want to diff the dependency
tree), that's not a bug an
Pankraz76 commented on PR #2322:
URL: https://github.com/apache/maven/pull/2322#issuecomment-2873629051
> As an alternative, could open rewrite be setup to comment on PRs ?
of course, this is aimed happy path for easy integration and wide acceptance.
Its easy to apply then, but
Bukama merged PR #365:
URL: https://github.com/apache/maven-enforcer/pull/365
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.a
dependabot[bot] closed pull request #361: Bump org.apache.maven:maven-parent
from 43 to 44
URL: https://github.com/apache/maven-enforcer/pull/361
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
Bukama commented on PR #361:
URL: https://github.com/apache/maven-enforcer/pull/361#issuecomment-2873639420
@dependabot close
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
gnodet commented on code in PR #2328:
URL: https://github.com/apache/maven/pull/2328#discussion_r2085380486
##
pom.xml:
##
@@ -796,6 +796,17 @@ under the License.
+
+ org.apache.maven.plugins
+ maven-pmd-plugin
Revie
cstamas commented on code in PR #2328:
URL: https://github.com/apache/maven/pull/2328#discussion_r2085383430
##
pom.xml:
##
@@ -796,6 +796,17 @@ under the License.
+
+ org.apache.maven.plugins
+ maven-pmd-plugin
Revi
cstamas commented on code in PR #2328:
URL: https://github.com/apache/maven/pull/2328#discussion_r2085383430
##
pom.xml:
##
@@ -796,6 +796,17 @@ under the License.
+
+ org.apache.maven.plugins
+ maven-pmd-plugin
Revi
cstamas commented on code in PR #2328:
URL: https://github.com/apache/maven/pull/2328#discussion_r2085383430
##
pom.xml:
##
@@ -796,6 +796,17 @@ under the License.
+
+ org.apache.maven.plugins
+ maven-pmd-plugin
Revi
Pankraz76 commented on code in PR #2326:
URL: https://github.com/apache/maven/pull/2326#discussion_r2085375181
##
impl/maven-impl/src/main/java/org/apache/maven/impl/DefaultPluginXmlFactory.java:
##
@@ -35,70 +27,19 @@
import org.apache.maven.api.services.xml.XmlReaderRequest;
Pankraz76 commented on PR #2326:
URL: https://github.com/apache/maven/pull/2326#issuecomment-2873893011
sacrifice/spike architectural design again, in sake to increment code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
cstamas commented on code in PR #2328:
URL: https://github.com/apache/maven/pull/2328#discussion_r2085383430
##
pom.xml:
##
@@ -796,6 +796,17 @@ under the License.
+
+ org.apache.maven.plugins
+ maven-pmd-plugin
Revi
michael-o commented on code in PR #2328:
URL: https://github.com/apache/maven/pull/2328#discussion_r2085415382
##
impl/maven-executor/src/main/java/org/apache/maven/cling/executor/internal/ToolboxTool.java:
##
@@ -142,7 +142,7 @@ private String validateOutput(boolean shave,
Byt
cstamas commented on code in PR #2328:
URL: https://github.com/apache/maven/pull/2328#discussion_r2085418836
##
impl/maven-executor/src/main/java/org/apache/maven/cling/executor/internal/ToolboxTool.java:
##
@@ -142,7 +142,7 @@ private String validateOutput(boolean shave,
ByteA
michael-o commented on code in PR #2328:
URL: https://github.com/apache/maven/pull/2328#discussion_r2085425311
##
impl/maven-executor/src/main/java/org/apache/maven/cling/executor/internal/ToolboxTool.java:
##
@@ -142,7 +142,7 @@ private String validateOutput(boolean shave,
Byt
garydgregory commented on PR #127:
URL:
https://github.com/apache/maven-changes-plugin/pull/127#issuecomment-2872168668
@slawekjaranowski
Thank you for the review and merge.
Would you please set expectations for a release timeframe? This is blocking
Commons Exec unless I use
Pankraz76 commented on code in PR #2312:
URL: https://github.com/apache/maven/pull/2312#discussion_r2084474413
##
impl/maven-impl/src/main/java/org/apache/maven/impl/DefaultPluginXmlFactory.java:
##
@@ -35,93 +27,18 @@
import org.apache.maven.api.services.xml.XmlReaderRequest;
dependabot[bot] opened a new pull request, #1321:
URL: https://github.com/apache/maven-mvnd/pull/1321
Bumps
[org.codehaus.gmavenplus:gmavenplus-plugin](https://github.com/groovy/GMavenPlus)
from 4.1.1 to 4.2.0.
Release notes
Sourced from https://github.com/groovy/GMavenPlus/releas
dependabot[bot] opened a new pull request, #1322:
URL: https://github.com/apache/maven-mvnd/pull/1322
Bumps `testcontainers.version` from 1.20.6 to 1.21.0.
Updates `org.testcontainers:testcontainers` from 1.20.6 to 1.21.0
Release notes
Sourced from https://github.com/testcontaine
Pankraz76 commented on PR #2312:
URL: https://github.com/apache/maven/pull/2312#issuecomment-2872498097
> The point of this PR is to fix the call with the output stream. Please
rename it accordingly.
yes, updated.
--
This is an automated message from the Apache Git Service.
To resp
Pankraz76 commented on PR #2322:
URL: https://github.com/apache/maven/pull/2322#issuecomment-2872525438
> 2\. You're not changing existing public API.
yes,
> * I don't want to introduce additional plugins into the build.
> *
spot is limited to format only, while rewrit
Pankraz76 commented on PR #2322:
URL: https://github.com/apache/maven/pull/2322#issuecomment-2872538698
> * I don't want to introduce additional plugins into the build.
> *
no body want but only computer can fix our code. As we out of nature not
being consistent.
comparing c
Pankraz76 commented on code in PR #2317:
URL: https://github.com/apache/maven/pull/2317#discussion_r2084660845
##
its/core-it-suite/src/test/resources/mng-3694/maven-mng3694-plugin/src/main/java/plugin/MyMojo.java:
##
@@ -47,24 +47,12 @@
*/
public class MyMojo extends Abstrac
Pankraz76 commented on code in PR #2317:
URL: https://github.com/apache/maven/pull/2317#discussion_r2084662901
##
its/core-it-suite/src/test/resources/mng-3694/maven-mng3694-plugin/src/main/java/plugin/MyMojo.java:
##
@@ -47,24 +47,12 @@
*/
public class MyMojo extends Abstrac
Pankraz76 commented on code in PR #2317:
URL: https://github.com/apache/maven/pull/2317#discussion_r2084670550
##
its/core-it-suite/src/test/resources/mng-3694/maven-mng3694-plugin/src/main/java/plugin/MyMojo.java:
##
@@ -47,24 +47,12 @@
*/
public class MyMojo extends Abstrac
Pankraz76 commented on code in PR #2317:
URL: https://github.com/apache/maven/pull/2317#discussion_r2084672990
##
its/core-it-suite/src/test/java/org/apache/maven/it/MavenITmng6401ProxyPortInterpolationTest.java:
##
@@ -28,10 +28,6 @@
class MavenITmng6401ProxyPortInterpolatio
slawekjaranowski commented on PR #2311:
URL: https://github.com/apache/maven/pull/2311#issuecomment-2872681931
maybe it is time for:
- https://github.com/apache/maven-parent/issues/254
or even though
- https://github.com/apache/maven-parent/issues/238
--
This is an automated messa
cstamas commented on code in PR #2311:
URL: https://github.com/apache/maven/pull/2311#discussion_r2084759497
##
impl/maven-executor/src/main/java/org/apache/maven/cling/executor/internal/ToolboxTool.java:
##
@@ -122,27 +122,29 @@ private ExecutorRequest.Builder
mojo(ExecutorReq
cstamas commented on PR #2311:
URL: https://github.com/apache/maven/pull/2311#issuecomment-2872664518
The IT failures:
```
[ERROR] Errors:
[ERROR]
MavenITmng7045DropUselessAndOutdatedCdiApiTest.testShouldNotLeakCdiApi:41 »
Verification Exit code was non-zero: 1; command line and
slawekjaranowski commented on code in PR #2311:
URL: https://github.com/apache/maven/pull/2311#discussion_r2084753265
##
impl/maven-executor/src/main/java/org/apache/maven/cling/executor/internal/ToolboxTool.java:
##
@@ -122,27 +122,29 @@ private ExecutorRequest.Builder
mojo(Ex
cstamas commented on code in PR #2311:
URL: https://github.com/apache/maven/pull/2311#discussion_r2084767433
##
impl/maven-executor/src/main/java/org/apache/maven/cling/executor/internal/ToolboxTool.java:
##
@@ -122,27 +122,29 @@ private ExecutorRequest.Builder
mojo(ExecutorReq
cstamas commented on PR #2311:
URL: https://github.com/apache/maven/pull/2311#issuecomment-2872919108
ITs seems fixed, full-build still plagued by PMD issue
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
Matthias Bünger created MNG-8725:
Summary: Option for "-T" argument: Use max cores minus 1
Key: MNG-8725
URL: https://issues.apache.org/jira/browse/MNG-8725
Project: Maven
Issue Type: Improve
cstamas commented on code in PR #2328:
URL: https://github.com/apache/maven/pull/2328#discussion_r2085481175
##
its/core-it-suite/src/test/resources/mng-7045/pom.xml:
##
@@ -43,13 +43,13 @@
javax.enterprise.inject.Instance.class.getDeclaredMethod("stream")]]>
elharo commented on PR #2307:
URL: https://github.com/apache/maven/pull/2307#issuecomment-2874086355
JUnit has a lot more than assertTrue. There's assertEquals, assertNull,
assertSame, etc. I'm OK with things JUnit doesn't have like assertContains, but
I don't want to replace things JUnit a
michael-o commented on code in PR #2328:
URL: https://github.com/apache/maven/pull/2328#discussion_r2085452335
##
its/core-it-suite/src/test/resources/mng-7045/pom.xml:
##
@@ -43,13 +43,13 @@
javax.enterprise.inject.Instance.class.getDeclaredMethod("stream")]]>
cstamas commented on code in PR #2328:
URL: https://github.com/apache/maven/pull/2328#discussion_r2085492979
##
its/core-it-suite/src/test/resources/mng-7045/pom.xml:
##
@@ -43,13 +43,13 @@
javax.enterprise.inject.Instance.class.getDeclaredMethod("stream")]]>
1 - 100 of 159 matches
Mail list logo