[PR] Bump org.cyclonedx:cyclonedx-maven-plugin from 2.9.0 to 2.9.1 [maven-parent]

2024-11-28 Thread via GitHub
dependabot[bot] opened a new pull request, #214: URL: https://github.com/apache/maven-parent/pull/214 Bumps [org.cyclonedx:cyclonedx-maven-plugin](https://github.com/CycloneDX/cyclonedx-maven-plugin) from 2.9.0 to 2.9.1. Release notes Sourced from https://github.com/CycloneDX/cycl

Re: [PR] Bump org.codehaus.mojo:exec-maven-plugin from 3.4.1 to 3.5.0 [maven-site]

2024-11-28 Thread via GitHub
ditbace commented on PR #568: URL: https://github.com/apache/maven-site/pull/568#issuecomment-2507072659 ok On Thu, Nov 28, 2024 at 3:48 PM Sylwester Lachiewicz < ***@***.***> wrote: > Merged #568 into master. > > — > R

Re: [PR] Fix link to Plugins section [maven-site]

2024-11-28 Thread via GitHub
ditbace commented on PR #581: URL: https://github.com/apache/maven-site/pull/581#issuecomment-2507072798 ok On Thu, Nov 28, 2024 at 3:47 PM Sylwester Lachiewicz < ***@***.***> wrote: > Merged #581 into master. > > — > R

[jira] [Commented] (MANTRUN-231) exportAntProperties ignored when using antfile

2024-11-28 Thread Tres Finocchiaro (Jira)
[ https://issues.apache.org/jira/browse/MANTRUN-231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17901861#comment-17901861 ] Tres Finocchiaro commented on MANTRUN-231: -- Thanks for updating the documentati

[PR] Bump org.slf4j:slf4j-api from 1.7.36 to 2.0.16 [maven-archetype]

2024-11-28 Thread via GitHub
dependabot[bot] opened a new pull request, #247: URL: https://github.com/apache/maven-archetype/pull/247 Bumps org.slf4j:slf4j-api from 1.7.36 to 2.0.16. [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=org.slf4j

[PR] Bump org.apache.felix:maven-bundle-plugin from 5.1.9 to 6.0.0 [maven-indexer]

2024-11-28 Thread via GitHub
dependabot[bot] opened a new pull request, #398: URL: https://github.com/apache/maven-indexer/pull/398 Bumps org.apache.felix:maven-bundle-plugin from 5.1.9 to 6.0.0. [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-n

Re: [PR] Bump org.slf4j:slf4j-api from 1.7.36 to 2.0.16 [maven-archetype]

2024-11-28 Thread via GitHub
slawekjaranowski commented on PR #247: URL: https://github.com/apache/maven-archetype/pull/247#issuecomment-2507149166 @dependabot ignore this major -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

Re: [PR] Bump org.slf4j:slf4j-api from 1.7.36 to 2.0.16 [maven-archetype]

2024-11-28 Thread via GitHub
dependabot[bot] closed pull request #247: Bump org.slf4j:slf4j-api from 1.7.36 to 2.0.16 URL: https://github.com/apache/maven-archetype/pull/247 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

Re: [PR] Bump org.slf4j:slf4j-api from 1.7.36 to 2.0.16 [maven-archetype]

2024-11-28 Thread via GitHub
dependabot[bot] commented on PR #247: URL: https://github.com/apache/maven-archetype/pull/247#issuecomment-2507149236 OK, I won't notify you about org.slf4j:slf4j-api again, unless you re-open this PR. -- This is an automated message from the Apache Git Service. To respond to the message,

Re: [PR] IT: Move ITs off maven-shared-utils [maven]

2024-11-28 Thread via GitHub
cstamas merged PR #1941: URL: https://github.com/apache/maven/pull/1941 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.

Re: [PR] @Component --> @Inject [maven-archetype]

2024-11-28 Thread via GitHub
slawekjaranowski commented on code in PR #243: URL: https://github.com/apache/maven-archetype/pull/243#discussion_r1862079955 ## maven-archetype-plugin/pom.xml: ## @@ -190,6 +210,15 @@ org.eclipse.sisu sisu-maven-plugin + + +

Re: [PR] [MINVOKER-374] Ability to skip project collection [maven-invoker-plugin]

2024-11-28 Thread via GitHub
slawekjaranowski commented on code in PR #265: URL: https://github.com/apache/maven-invoker-plugin/pull/265#discussion_r1861781385 ## src/main/java/org/apache/maven/plugins/invoker/AbstractInvokerMojo.java: ## @@ -217,6 +217,9 @@ public abstract class AbstractInvokerMojo extend

[jira] [Commented] (MINVOKER-374) Ability to skip project collection

2024-11-28 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MINVOKER-374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17901654#comment-17901654 ] ASF GitHub Bot commented on MINVOKER-374: - slawekjaranowski commented on code i

[jira] [Created] (MNG-8391) Wrong effective model when conflicting values come from parents and profiles

2024-11-28 Thread Guillaume Nodet (Jira)
Guillaume Nodet created MNG-8391: Summary: Wrong effective model when conflicting values come from parents and profiles Key: MNG-8391 URL: https://issues.apache.org/jira/browse/MNG-8391 Project: Maven

[PR] Bump com.fasterxml.jackson.core:jackson-core from 2.17.2 to 2.18.2 [maven-dist-tool]

2024-11-28 Thread via GitHub
dependabot[bot] opened a new pull request, #83: URL: https://github.com/apache/maven-dist-tool/pull/83 Bumps [com.fasterxml.jackson.core:jackson-core](https://github.com/FasterXML/jackson-core) from 2.17.2 to 2.18.2. Commits https://github.com/FasterXML/jackson-core/commit/fc1

[PR] Bump com.fasterxml.jackson:jackson-bom from 2.18.1 to 2.18.2 [maven-dist-tool]

2024-11-28 Thread via GitHub
dependabot[bot] opened a new pull request, #84: URL: https://github.com/apache/maven-dist-tool/pull/84 Bumps [com.fasterxml.jackson:jackson-bom](https://github.com/FasterXML/jackson-bom) from 2.18.1 to 2.18.2. Commits https://github.com/FasterXML/jackson-bom/commit/55ff098b613

Re: [PR] Bump com.fasterxml.jackson.core:jackson-core from 2.17.2 to 2.18.1 [maven-dist-tool]

2024-11-28 Thread via GitHub
dependabot[bot] commented on PR #79: URL: https://github.com/apache/maven-dist-tool/pull/79#issuecomment-2506022738 Superseded by #83. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] Bump com.fasterxml.jackson.core:jackson-core from 2.17.2 to 2.18.1 [maven-dist-tool]

2024-11-28 Thread via GitHub
dependabot[bot] closed pull request #79: Bump com.fasterxml.jackson.core:jackson-core from 2.17.2 to 2.18.1 URL: https://github.com/apache/maven-dist-tool/pull/79 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

Re: [PR] Bump org.slf4j:slf4j-simple from 1.7.36 to 2.0.16 [maven-dist-tool]

2024-11-28 Thread via GitHub
slawekjaranowski commented on PR #80: URL: https://github.com/apache/maven-dist-tool/pull/80#issuecomment-2506027251 @dependabot ignore this major -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] Bump org.slf4j:slf4j-simple from 1.7.36 to 2.0.16 [maven-dist-tool]

2024-11-28 Thread via GitHub
dependabot[bot] closed pull request #80: Bump org.slf4j:slf4j-simple from 1.7.36 to 2.0.16 URL: https://github.com/apache/maven-dist-tool/pull/80 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] Bump org.slf4j:slf4j-simple from 1.7.36 to 2.0.16 [maven-dist-tool]

2024-11-28 Thread via GitHub
dependabot[bot] commented on PR #80: URL: https://github.com/apache/maven-dist-tool/pull/80#issuecomment-2506027361 OK, I won't notify you about org.slf4j:slf4j-simple again, unless you re-open this PR. -- This is an automated message from the Apache Git Service. To respond to the message

[jira] [Closed] (ARCHETYPE-562) Error ordering Default Properties

2024-11-28 Thread Elliotte Rusty Harold (Jira)
[ https://issues.apache.org/jira/browse/ARCHETYPE-562?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Elliotte Rusty Harold closed ARCHETYPE-562. --- Please reopen if this is still an issue, but last comment suggests it's fixed

[jira] [Resolved] (ARCHETYPE-562) Error ordering Default Properties

2024-11-28 Thread Elliotte Rusty Harold (Jira)
[ https://issues.apache.org/jira/browse/ARCHETYPE-562?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Elliotte Rusty Harold resolved ARCHETYPE-562. - Resolution: Fixed > Error ordering Default Properties > --

Re: [PR] [ARCHETYPE-562] Collections.sort for ordering assumes transitivity between just ordered items: [maven-archetype]

2024-11-28 Thread via GitHub
elharo closed pull request #26: [ARCHETYPE-562] Collections.sort for ordering assumes transitivity between just ordered items: URL: https://github.com/apache/maven-archetype/pull/26 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

Re: [PR] [ARCHETYPE-584] don't normalize whitespace in tests so we can test for whitespace [maven-archetype]

2024-11-28 Thread via GitHub
elharo closed pull request #65: [ARCHETYPE-584] don't normalize whitespace in tests so we can test for whitespace URL: https://github.com/apache/maven-archetype/pull/65 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

Re: [PR] [ARCHETYPE-584] don't normalize whitespace in tests so we can test for whitespace [maven-archetype]

2024-11-28 Thread via GitHub
elharo commented on PR #65: URL: https://github.com/apache/maven-archetype/pull/65#issuecomment-2506056169 fixed in ARCHETYPE-637 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comm

[jira] [Updated] (ARCHETYPE-691) Refactor FileCharsetDetector

2024-11-28 Thread Elliotte Rusty Harold (Jira)
[ https://issues.apache.org/jira/browse/ARCHETYPE-691?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Elliotte Rusty Harold updated ARCHETYPE-691: Description: This class is weird. It does all the work in the constructo

[jira] [Created] (MNG-8392) Inherited profiles

2024-11-28 Thread Guillaume Nodet (Jira)
Guillaume Nodet created MNG-8392: Summary: Inherited profiles Key: MNG-8392 URL: https://issues.apache.org/jira/browse/MNG-8392 Project: Maven Issue Type: New Feature Components: Pr

[jira] [Created] (ARCHETYPE-691) Refactor FileCharsetDetector

2024-11-28 Thread Elliotte Rusty Harold (Jira)
Elliotte Rusty Harold created ARCHETYPE-691: --- Summary: Refactor FileCharsetDetector Key: ARCHETYPE-691 URL: https://issues.apache.org/jira/browse/ARCHETYPE-691 Project: Maven Archetype

[jira] [Updated] (ARCHETYPE-691) Refactor FileCharsetDetector

2024-11-28 Thread Elliotte Rusty Harold (Jira)
[ https://issues.apache.org/jira/browse/ARCHETYPE-691?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Elliotte Rusty Harold updated ARCHETYPE-691: Description: This class is weird. It does all the work in the constructo

Re: [PR] The end condition of a for loop is precomputed. [maven-archetype]

2024-11-28 Thread via GitHub
elharo closed pull request #245: The end condition of a for loop is precomputed. URL: https://github.com/apache/maven-archetype/pull/245 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

Re: [PR] @Component --> @Inject [maven-archetype]

2024-11-28 Thread via GitHub
elharo merged PR #243: URL: https://github.com/apache/maven-archetype/pull/243 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.

[PR] Remove a lot of old println detritus [maven-archetype]

2024-11-28 Thread via GitHub
elharo opened a new pull request, #246: URL: https://github.com/apache/maven-archetype/pull/246 Debuggers are a thing. This makes builds a little less noisy. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

[jira] [Commented] (MDEP-952) Unpack fails if extension of artifact is used

2024-11-28 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MDEP-952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17901724#comment-17901724 ] ASF GitHub Bot commented on MDEP-952: - elharo merged PR #491: URL: https://github.com/a

Re: [PR] [MDEP-952] Decouple DependencyUtil from StringUtils [maven-dependency-plugin]

2024-11-28 Thread via GitHub
elharo merged PR #491: URL: https://github.com/apache/maven-dependency-plugin/pull/491 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr..

Re: [PR] Remove @Component, rely on constructor injection in subclasses instead [maven-reporting-impl]

2024-11-28 Thread via GitHub
elharo commented on PR #60: URL: https://github.com/apache/maven-reporting-impl/pull/60#issuecomment-2506160174 At some point we do want to get rid of the old plexus injection completely. It's worth thinking about how we're going to finish that job. If only we had a monorepo, and if wishes

Re: [PR] Bump mavenVersion from 4.0.0-beta-3 to 4.0.0-rc-1 [maven-filtering]

2024-11-28 Thread via GitHub
dependabot[bot] commented on PR #134: URL: https://github.com/apache/maven-filtering/pull/134#issuecomment-2506884130 OK, I won't notify you again about this release, but will get in touch when a new version is available. You can also ignore all major, minor, or patch releases for a depende

Re: [PR] Bump mavenVersion from 4.0.0-beta-3 to 4.0.0-rc-1 [maven-filtering]

2024-11-28 Thread via GitHub
slachiewicz closed pull request #134: Bump mavenVersion from 4.0.0-beta-3 to 4.0.0-rc-1 URL: https://github.com/apache/maven-filtering/pull/134 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

[jira] [Commented] (MNG-8284) Re-enable s390x Jenkins CI

2024-11-28 Thread Namrata Bhave (Jira)
[ https://issues.apache.org/jira/browse/MNG-8284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17901730#comment-17901730 ] Namrata Bhave commented on MNG-8284: Thank you [~cstamas] and [~gnodet] for sharing you

Re: [PR] [MDEP-966] Migrate TreeMojo/CopyMojo/AnalyzeExclusionsMojo/UnpackMojo/CopyDependenciesMojo from Plexus to Sisu Guice [maven-dependency-plugin]

2024-11-28 Thread via GitHub
elharo merged PR #483: URL: https://github.com/apache/maven-dependency-plugin/pull/483 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr..

[jira] [Commented] (MDEP-966) Migrate from Plexus annotations to JSR 330 annotations

2024-11-28 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MDEP-966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17901750#comment-17901750 ] ASF GitHub Bot commented on MDEP-966: - elharo merged PR #483: URL: https://github.com/a

[PR] Declare dependencies explicitly [maven-antrun-plugin]

2024-11-28 Thread via GitHub
elharo opened a new pull request, #107: URL: https://github.com/apache/maven-antrun-plugin/pull/107 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscr

Re: [PR] Remove a lot of old println detritus [maven-archetype]

2024-11-28 Thread via GitHub
elharo merged PR #246: URL: https://github.com/apache/maven-archetype/pull/246 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.

Re: [PR] [ARCHETYPE-274] Conditionally include or exclude a file from archetype during generation [maven-archetype]

2024-11-28 Thread via GitHub
elharo commented on code in PR #244: URL: https://github.com/apache/maven-archetype/pull/244#discussion_r1862518129 ## archetype-models/archetype-descriptor/src/main/mdo/archetype-descriptor.mdo: ## @@ -162,6 +162,13 @@ false Encoding to use when filtering

Re: [PR] Update CreateArchetypeFromProjectMojo.java [maven-archetype]

2024-11-28 Thread via GitHub
elharo commented on code in PR #113: URL: https://github.com/apache/maven-archetype/pull/113#discussion_r1862521175 ## maven-archetype-plugin/src/main/java/org/apache/maven/archetype/mojos/CreateArchetypeFromProjectMojo.java: ## @@ -210,7 +210,7 @@ public class CreateArchetypeFr

Re: [PR] Switch from plexus to Guice [maven-antrun-plugin]

2024-11-28 Thread via GitHub
elharo merged PR #106: URL: https://github.com/apache/maven-antrun-plugin/pull/106 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@ma

Re: [PR] Maven 4.0.0-rc-1 Release Notes [maven-site]

2024-11-28 Thread via GitHub
cstamas merged PR #582: URL: https://github.com/apache/maven-site/pull/582 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apac

[jira] [Updated] (MNG-8390) Alternative path for the user settings-security.xml file

2024-11-28 Thread Manuel s (Jira)
[ https://issues.apache.org/jira/browse/MNG-8390?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Manuel s updated MNG-8390: -- Summary: Alternative path for the user settings-security.xml file (was: Alternate path for the user settings-sec

Re: [PR] [MARTIFACT-81] add reproducible-central report [maven-artifact-plugin]

2024-11-28 Thread via GitHub
hboutemy commented on PR #73: URL: https://github.com/apache/maven-artifact-plugin/pull/73#issuecomment-2506457704 badge service PR proposed to img.shields.io https://github.com/badges/shields/pull/10705 this approach brings better results on 404 = when a gav has not been rebuilt, then

[jira] [Commented] (MARTIFACT-81) add "reproducible central" report

2024-11-28 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MARTIFACT-81?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17901758#comment-17901758 ] ASF GitHub Bot commented on MARTIFACT-81: - hboutemy commented on PR #73: URL:

Re: [PR] Declare dependencies explicitly [maven-antrun-plugin]

2024-11-28 Thread via GitHub
elharo merged PR #107: URL: https://github.com/apache/maven-antrun-plugin/pull/107 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@ma

Re: [PR] Correct user visible spelling error [maven-antrun-plugin]

2024-11-28 Thread via GitHub
elharo merged PR #105: URL: https://github.com/apache/maven-antrun-plugin/pull/105 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@ma

Re: [PR] Bump mavenVersion from 4.0.0-beta-3 to 4.0.0-beta-5 [maven-filtering]

2024-11-28 Thread via GitHub
dependabot[bot] commented on PR #131: URL: https://github.com/apache/maven-filtering/pull/131#issuecomment-2506587639 Superseded by #134. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

[PR] Bump mavenVersion from 4.0.0-beta-3 to 4.0.0-rc-1 [maven-filtering]

2024-11-28 Thread via GitHub
dependabot[bot] opened a new pull request, #134: URL: https://github.com/apache/maven-filtering/pull/134 Bumps `mavenVersion` from 4.0.0-beta-3 to 4.0.0-rc-1. Updates `org.apache.maven:maven-api-core` from 4.0.0-beta-3 to 4.0.0-rc-1 Updates `org.apache.maven:maven-api-di` from 4.0.0

Re: [PR] Bump mavenVersion from 4.0.0-beta-3 to 4.0.0-beta-5 [maven-filtering]

2024-11-28 Thread via GitHub
dependabot[bot] closed pull request #131: Bump mavenVersion from 4.0.0-beta-3 to 4.0.0-beta-5 URL: https://github.com/apache/maven-filtering/pull/131 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] Update CreateArchetypeFromProjectMojo.java [maven-archetype]

2024-11-28 Thread via GitHub
slawekjaranowski commented on code in PR #113: URL: https://github.com/apache/maven-archetype/pull/113#discussion_r1862572028 ## maven-archetype-plugin/src/main/java/org/apache/maven/archetype/mojos/CreateArchetypeFromProjectMojo.java: ## @@ -210,7 +210,7 @@ public class CreateA

Re: [PR] [ARCHETYPE-274] Conditionally include or exclude a file from archetype during generation [maven-archetype]

2024-11-28 Thread via GitHub
slawekjaranowski commented on code in PR #244: URL: https://github.com/apache/maven-archetype/pull/244#discussion_r1862573782 ## archetype-models/archetype-descriptor/src/main/mdo/archetype-descriptor.mdo: ## @@ -162,6 +162,13 @@ false Encoding to use when

Re: [PR] [ARCHETYPE-274] Conditionally include or exclude a file from archetype during generation [maven-archetype]

2024-11-28 Thread via GitHub
slawekjaranowski commented on code in PR #244: URL: https://github.com/apache/maven-archetype/pull/244#discussion_r1862578143 ## maven-archetype-plugin/src/it/projects/ARCHETYPE-274_conditional_filesets/project.properties: ## @@ -0,0 +1,28 @@ +# Licensed to the Apache Software F

Re: [PR] [ARCHETYPE-274] Conditionally include or exclude a file from archetype during generation [maven-archetype]

2024-11-28 Thread via GitHub
slawekjaranowski commented on code in PR #244: URL: https://github.com/apache/maven-archetype/pull/244#discussion_r1862585449 ## archetype-models/archetype-descriptor/src/main/mdo/archetype-descriptor.mdo: ## @@ -162,6 +162,13 @@ false Encoding to use when

Re: [PR] Update CreateArchetypeFromProjectMojo.java [maven-archetype]

2024-11-28 Thread via GitHub
slawekjaranowski commented on code in PR #113: URL: https://github.com/apache/maven-archetype/pull/113#discussion_r1862571051 ## maven-archetype-plugin/src/main/java/org/apache/maven/archetype/mojos/CreateArchetypeFromProjectMojo.java: ## @@ -210,7 +210,7 @@ public class CreateA

Re: [PR] [ARCHETYPE-274] Conditionally include or exclude a file from archetype during generation [maven-archetype]

2024-11-28 Thread via GitHub
slawekjaranowski commented on code in PR #244: URL: https://github.com/apache/maven-archetype/pull/244#discussion_r1862578143 ## maven-archetype-plugin/src/it/projects/ARCHETYPE-274_conditional_filesets/project.properties: ## @@ -0,0 +1,28 @@ +# Licensed to the Apache Software F

Re: [PR] [ARCHETYPE-274] Conditionally include or exclude a file from archetype during generation [maven-archetype]

2024-11-28 Thread via GitHub
slawekjaranowski commented on code in PR #244: URL: https://github.com/apache/maven-archetype/pull/244#discussion_r1862582786 ## archetype-models/archetype-descriptor/src/main/mdo/archetype-descriptor.mdo: ## @@ -162,6 +162,13 @@ false Encoding to use when

[jira] [Resolved] (MANTRUN-234) replaceregexp match $ is splitting eol character

2024-11-28 Thread Elliotte Rusty Harold (Jira)
[ https://issues.apache.org/jira/browse/MANTRUN-234?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Elliotte Rusty Harold resolved MANTRUN-234. --- Resolution: Invalid I don't see replaceregexp anywhere in the antrun plugin

[jira] [Closed] (MANTRUN-234) replaceregexp match $ is splitting eol character

2024-11-28 Thread Elliotte Rusty Harold (Jira)
[ https://issues.apache.org/jira/browse/MANTRUN-234?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Elliotte Rusty Harold closed MANTRUN-234. - > replaceregexp match $ is splitting eol character > ---

[jira] [Resolved] (MANTRUN-237) Forwarding dependency classpath to ANT

2024-11-28 Thread Elliotte Rusty Harold (Jira)
[ https://issues.apache.org/jira/browse/MANTRUN-237?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Elliotte Rusty Harold resolved MANTRUN-237. --- Resolution: Won't Do This feels backwards to me. The antrun plugin exists to

[jira] [Closed] (MANTRUN-237) Forwarding dependency classpath to ANT

2024-11-28 Thread Elliotte Rusty Harold (Jira)
[ https://issues.apache.org/jira/browse/MANTRUN-237?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Elliotte Rusty Harold closed MANTRUN-237. - > Forwarding dependency classpath to ANT > -- >

[jira] [Updated] (MANTRUN-234) replaceregexp match $ is splitting eol character

2024-11-28 Thread Elliotte Rusty Harold (Jira)
[ https://issues.apache.org/jira/browse/MANTRUN-234?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Elliotte Rusty Harold updated MANTRUN-234: -- Labels: waiting-for-feedback (was: ) > replaceregexp match $ is splitting eol

[jira] [Commented] (MANTRUN-234) replaceregexp match $ is splitting eol character

2024-11-28 Thread Elliotte Rusty Harold (Jira)
[ https://issues.apache.org/jira/browse/MANTRUN-234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17901781#comment-17901781 ] Elliotte Rusty Harold commented on MANTRUN-234: --- Do you have a reproducibl

[jira] [Commented] (MWRAPPER-148) Allow to use distributionVersion instead of distributionUrl in maven-wrapper.properties

2024-11-28 Thread Stefan Bohn (Jira)
[ https://issues.apache.org/jira/browse/MWRAPPER-148?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17901784#comment-17901784 ] Stefan Bohn commented on MWRAPPER-148: -- That would break the ability to use a repo

[jira] [Assigned] (MANTRUN-231) exportAntProperties ignored when using antfile

2024-11-28 Thread Elliotte Rusty Harold (Jira)
[ https://issues.apache.org/jira/browse/MANTRUN-231?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Elliotte Rusty Harold reassigned MANTRUN-231: - Assignee: Elliotte Rusty Harold > exportAntProperties ignored when usin

[jira] [Commented] (MANTRUN-231) exportAntProperties ignored when using antfile

2024-11-28 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MANTRUN-231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17901785#comment-17901785 ] ASF GitHub Bot commented on MANTRUN-231: elharo opened a new pull request, #108:

Re: [PR] Remove @Component, rely on constructor injection in subclasses instead [maven-reporting-impl]

2024-11-28 Thread via GitHub
michael-o commented on PR #60: URL: https://github.com/apache/maven-reporting-impl/pull/60#issuecomment-2506728400 How does this behave with concrete impls? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

Re: [PR] Remove @Component, rely on constructor injection in subclasses instead [maven-reporting-impl]

2024-11-28 Thread via GitHub
elharo commented on PR #60: URL: https://github.com/apache/maven-reporting-impl/pull/60#issuecomment-2506733129 They're going to need to change so the injection happens in the subclass and the values are passed up the chain in a call to super. I've already done or am in the process of doin

[jira] [Closed] (MANTRUN-231) exportAntProperties ignored when using antfile

2024-11-28 Thread Elliotte Rusty Harold (Jira)
[ https://issues.apache.org/jira/browse/MANTRUN-231?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Elliotte Rusty Harold closed MANTRUN-231. - > exportAntProperties ignored when using antfile > -

Re: [PR] [MANTRUN-231] Document limitations of exportAntProperties [maven-antrun-plugin]

2024-11-28 Thread via GitHub
elharo merged PR #108: URL: https://github.com/apache/maven-antrun-plugin/pull/108 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@ma

Re: [PR] Bump org.codehaus.mojo:exec-maven-plugin from 3.4.1 to 3.5.0 [maven-site]

2024-11-28 Thread via GitHub
slachiewicz merged PR #568: URL: https://github.com/apache/maven-site/pull/568 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.

[jira] [Resolved] (MANTRUN-231) exportAntProperties ignored when using antfile

2024-11-28 Thread Elliotte Rusty Harold (Jira)
[ https://issues.apache.org/jira/browse/MANTRUN-231?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Elliotte Rusty Harold resolved MANTRUN-231. --- Resolution: Fixed Thanks for the detailed description. I've documented this

[jira] [Commented] (MANTRUN-231) exportAntProperties ignored when using antfile

2024-11-28 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MANTRUN-231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17901789#comment-17901789 ] ASF GitHub Bot commented on MANTRUN-231: elharo merged PR #108: URL: https://git

Re: [PR] Fix link to Plugins section [maven-site]

2024-11-28 Thread via GitHub
slachiewicz merged PR #581: URL: https://github.com/apache/maven-site/pull/581 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.

Re: [PR] Update Maven CI to 4.0rc1 [maven-archiver]

2024-11-28 Thread via GitHub
slachiewicz merged PR #80: URL: https://github.com/apache/maven-archiver/pull/80 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@mave

Re: [PR] Bump mavenVersion from 4.0.0-beta-3 to 4.0.0-rc-1 [maven-filtering]

2024-11-28 Thread via GitHub
slachiewicz commented on PR #134: URL: https://github.com/apache/maven-filtering/pull/134#issuecomment-2506763148 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c