Re: [PR] [MNG-7914] Provide a single entry point for configuration [maven]

2024-07-11 Thread via GitHub
michael-o commented on code in PR #1595: URL: https://github.com/apache/maven/pull/1595#discussion_r1674375916 ## maven-api-impl/src/main/java/org/apache/maven/internal/impl/model/MavenBuildTimestamp.java: ## @@ -26,18 +26,18 @@ import java.util.Properties; import java.util.Ti

[jira] [Commented] (MNG-7914) Provide a single entry point for configuration

2024-07-11 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-7914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17865161#comment-17865161 ] ASF GitHub Bot commented on MNG-7914: - michael-o commented on code in PR #1595: URL: ht

[jira] [Commented] (MRELEASE-1151) Maven Release Plugin fails to adjust version (regression in 3.1.0)

2024-07-11 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MRELEASE-1151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17865163#comment-17865163 ] Michael Osipov commented on MRELEASE-1151: -- My bad, thank you. Let's continue

Re: [PR] [MNG-7914] Provide a single entry point for configuration [maven]

2024-07-11 Thread via GitHub
michael-o commented on code in PR #1595: URL: https://github.com/apache/maven/pull/1595#discussion_r1674377952 ## maven-embedder/src/main/java/org/apache/maven/cli/MavenCli.java: ## @@ -510,7 +503,8 @@ void logging(CliRequest cliRequest) { cliRequest.showErrors = cliReq

[jira] [Commented] (MNG-7914) Provide a single entry point for configuration

2024-07-11 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-7914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17865165#comment-17865165 ] ASF GitHub Bot commented on MNG-7914: - michael-o commented on code in PR #1595: URL: ht

Re: [PR] fix: sometimes properties object is not null but it's empty, here only null has been checked that I fixed it. [maven-release]

2024-07-11 Thread via GitHub
michael-o commented on PR #223: URL: https://github.com/apache/maven-release/pull/223#issuecomment-2223503717 What difference does this make. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

[jira] [Updated] (MRELEASE-1153) Revert MRELEASE-1109 due to regression

2024-07-11 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MRELEASE-1153?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov updated MRELEASE-1153: - Summary: Revert MRELEASE-1109 due to regression (was: Revert MRELEASE-1109) > Revert

[jira] [Created] (MRELEASE-1153) Revert MRELEASE-1109

2024-07-11 Thread Michael Osipov (Jira)
Michael Osipov created MRELEASE-1153: Summary: Revert MRELEASE-1109 Key: MRELEASE-1153 URL: https://issues.apache.org/jira/browse/MRELEASE-1153 Project: Maven Release Plugin Issue Type: T

[jira] [Updated] (MRELEASE-1151) [REGRESSION] Maven Release Plugin fails to adjust version

2024-07-11 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MRELEASE-1151?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov updated MRELEASE-1151: - Summary: [REGRESSION] Maven Release Plugin fails to adjust version (was: Maven Releas

[jira] [Updated] (MRELEASE-1151) [REGRESSION] Maven Release Plugin fails to adjust version

2024-07-11 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MRELEASE-1151?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov updated MRELEASE-1151: - Fix Version/s: 3.1.1 > [REGRESSION] Maven Release Plugin fails to adjust version > ---

[jira] [Assigned] (MRELEASE-1151) [REGRESSION] Maven Release Plugin fails to adjust version

2024-07-11 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MRELEASE-1151?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov reassigned MRELEASE-1151: Assignee: Michael Osipov > [REGRESSION] Maven Release Plugin fails to adjust ve

[jira] [Commented] (MRELEASE-1151) [REGRESSION] Maven Release Plugin fails to adjust version

2024-07-11 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MRELEASE-1151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17865169#comment-17865169 ] Michael Osipov commented on MRELEASE-1151: -- I need to admit that my CI-friend

[jira] [Comment Edited] (MRELEASE-1151) [REGRESSION] Maven Release Plugin fails to adjust version

2024-07-11 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MRELEASE-1151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17865169#comment-17865169 ] Michael Osipov edited comment on MRELEASE-1151 at 7/11/24 5:39 PM: -

Re: [PR] [MNG-7914] Provide a single entry point for configuration [maven]

2024-07-11 Thread via GitHub
slawekjaranowski commented on code in PR #1595: URL: https://github.com/apache/maven/pull/1595#discussion_r1674417877 ## maven-embedder/src/main/java/org/apache/maven/cli/props/MavenPropertiesLoader.java: ## @@ -0,0 +1,161 @@ +/* + * Licensed to the Apache Software Foundation (A

[jira] [Updated] (MRELEASE-1153) Revert MRELEASE-1109 (8dfcb47996320af5e6f0b2d50eac209eeb4c29ce) due to a regression

2024-07-11 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MRELEASE-1153?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov updated MRELEASE-1153: - Summary: Revert MRELEASE-1109 (8dfcb47996320af5e6f0b2d50eac209eeb4c29ce) due to a regr

[jira] [Commented] (MNG-7914) Provide a single entry point for configuration

2024-07-11 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-7914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17865171#comment-17865171 ] ASF GitHub Bot commented on MNG-7914: - slawekjaranowski commented on code in PR #1595:

[PR] [MRELEASE-1153] Revert MRELEASE-1109 (8dfcb47996320af5e6f0b2d50eac209… [maven-release]

2024-07-11 Thread via GitHub
michael-o opened a new pull request, #224: URL: https://github.com/apache/maven-release/pull/224 …eeb4c29ce) due to a regression This reverts commit 8dfcb47996320af5e6f0b2d50eac209eeb4c29ce. This closes #224 Following this checklist to help us incorporate your contrib

[jira] [Commented] (MRELEASE-1153) Revert MRELEASE-1109 (8dfcb47996320af5e6f0b2d50eac209eeb4c29ce) due to a regression

2024-07-11 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MRELEASE-1153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17865172#comment-17865172 ] ASF GitHub Bot commented on MRELEASE-1153: -- michael-o opened a new pull reque

[jira] [Updated] (MRELEASE-1153) Revert parts of MRELEASE-1109 (8dfcb47996320af5e6f0b2d50eac209eeb4c29ce) due to a regression

2024-07-11 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MRELEASE-1153?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov updated MRELEASE-1153: - Summary: Revert parts of MRELEASE-1109 (8dfcb47996320af5e6f0b2d50eac209eeb4c29ce) due

Re: [PR] The project builder should be given the correct system properties [maven-project-info-reports-plugin]

2024-07-11 Thread via GitHub
asfgit closed pull request #75: The project builder should be given the correct system properties URL: https://github.com/apache/maven-project-info-reports-plugin/pull/75 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use th

Re: [PR] The project builder should be given the correct system properties [maven-project-info-reports-plugin]

2024-07-11 Thread via GitHub
asfgit merged PR #75: URL: https://github.com/apache/maven-project-info-reports-plugin/pull/75 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-un

[jira] [Closed] (MPIR-466) ModulesReport/IndexReport do not pass a complete building request to renderer

2024-07-11 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MPIR-466?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov closed MPIR-466. --- Resolution: Fixed Fixed with [67ecd332f7bc241ee9a6b59e9f952cb21a19b2ef|https://gitbox.apache.org/repos

Re: [PR] [MRELEASE-1153] Revert parts of MRELEASE-1109 (8dfcb47996320af5e6f0b2d50eac209… [maven-release]

2024-07-11 Thread via GitHub
asfgit closed pull request #224: [MRELEASE-1153] Revert parts of MRELEASE-1109 (8dfcb47996320af5e6f0b2d50eac209… URL: https://github.com/apache/maven-release/pull/224 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

Re: [PR] [MRELEASE-1153] Revert parts of MRELEASE-1109 (8dfcb47996320af5e6f0b2d50eac209… [maven-release]

2024-07-11 Thread via GitHub
asfgit merged PR #224: URL: https://github.com/apache/maven-release/pull/224 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.ap

[jira] [Commented] (MRELEASE-1153) Revert parts of MRELEASE-1109 (8dfcb47996320af5e6f0b2d50eac209eeb4c29ce) due to a regression

2024-07-11 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MRELEASE-1153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17865182#comment-17865182 ] ASF GitHub Bot commented on MRELEASE-1153: -- asfgit merged PR #224: URL: https

[jira] [Commented] (MRELEASE-1153) Revert parts of MRELEASE-1109 (8dfcb47996320af5e6f0b2d50eac209eeb4c29ce) due to a regression

2024-07-11 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MRELEASE-1153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17865181#comment-17865181 ] ASF GitHub Bot commented on MRELEASE-1153: -- asfgit closed pull request #224:

[jira] [Closed] (MRELEASE-1151) [REGRESSION] Maven Release Plugin fails to adjust version

2024-07-11 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MRELEASE-1151?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov closed MRELEASE-1151. Resolution: Fixed Implicitly fixed by MRELEASE-1153. The reverted changset should be app

[jira] [Closed] (MRELEASE-1153) Revert parts of MRELEASE-1109 (8dfcb47996320af5e6f0b2d50eac209eeb4c29ce) due to a regression

2024-07-11 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MRELEASE-1153?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov closed MRELEASE-1153. Resolution: Fixed Fixed with [06f6de43312ee6cab4ec1a194781a61c5db5bdf9|https://gitbox.a

Re: [PR] [MNG-7914] Provide a single entry point for configuration [maven]

2024-07-11 Thread via GitHub
slawekjaranowski commented on code in PR #1595: URL: https://github.com/apache/maven/pull/1595#discussion_r1674500730 ## maven-embedder/src/main/java/org/apache/maven/cli/MavenCli.java: ## @@ -1624,20 +1635,65 @@ static void populateProperties( String mavenBuildVersion

[jira] [Commented] (MNG-7914) Provide a single entry point for configuration

2024-07-11 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-7914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17865187#comment-17865187 ] ASF GitHub Bot commented on MNG-7914: - slawekjaranowski commented on code in PR #1595:

Re: [PR] [MNG-7914] Provide a single entry point for configuration [maven]

2024-07-11 Thread via GitHub
michael-o commented on code in PR #1595: URL: https://github.com/apache/maven/pull/1595#discussion_r1674510073 ## maven-embedder/src/main/java/org/apache/maven/cli/MavenCli.java: ## @@ -1624,20 +1635,65 @@ static void populateProperties( String mavenBuildVersion = CLIR

[jira] [Commented] (MNG-7914) Provide a single entry point for configuration

2024-07-11 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-7914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17865188#comment-17865188 ] ASF GitHub Bot commented on MNG-7914: - michael-o commented on code in PR #1595: URL: ht

[jira] [Commented] (MINVOKER-368) Scope for installing artifacts should be filtered before resolving

2024-07-11 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MINVOKER-368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17865190#comment-17865190 ] ASF GitHub Bot commented on MINVOKER-368: - slawekjaranowski merged PR #249: URL

Re: [PR] [MINVOKER-368] Filter artifacts by scope before resolving in install [maven-invoker-plugin]

2024-07-11 Thread via GitHub
slawekjaranowski merged PR #249: URL: https://github.com/apache/maven-invoker-plugin/pull/249 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-uns

[jira] [Closed] (MINVOKER-368) Scope for installing artifacts should be filtered before resolving

2024-07-11 Thread Slawomir Jaranowski (Jira)
[ https://issues.apache.org/jira/browse/MINVOKER-368?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Slawomir Jaranowski closed MINVOKER-368. Resolution: Fixed > Scope for installing artifacts should be filtered before reso

Re: [PR] [MWAR-470] - Support user property for packagingExcludes [maven-war-plugin]

2024-07-11 Thread via GitHub
slawekjaranowski merged PR #55: URL: https://github.com/apache/maven-war-plugin/pull/55 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr.

[jira] [Commented] (MWAR-470) Support user property for packagingExcludes

2024-07-11 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MWAR-470?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17865201#comment-17865201 ] ASF GitHub Bot commented on MWAR-470: - slawekjaranowski merged PR #55: URL: https://git

[jira] [Closed] (MWAR-470) Support user property for packagingExcludes

2024-07-11 Thread Slawomir Jaranowski (Jira)
[ https://issues.apache.org/jira/browse/MWAR-470?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Slawomir Jaranowski closed MWAR-470. Assignee: Slawomir Jaranowski Resolution: Fixed > Support user property for packagingEx

[jira] [Updated] (MWAR-470) Support user property for packagingExcludes

2024-07-11 Thread Slawomir Jaranowski (Jira)
[ https://issues.apache.org/jira/browse/MWAR-470?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Slawomir Jaranowski updated MWAR-470: - Fix Version/s: next-release > Support user property for packagingExcludes > ---

[jira] [Commented] (MNG-8180) Resolver will blindly assume it is deploying a plugin by presence of META-INF/maven/plugins.xml in JAR

2024-07-11 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/MNG-8180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17865253#comment-17865253 ] Hudson commented on MNG-8180: - SUCCESS: Integrated in Jenkins build Tika » tika-main-jdk11 #167

[jira] [Commented] (MNG-8180) Resolver will blindly assume it is deploying a plugin by presence of META-INF/maven/plugins.xml in JAR

2024-07-11 Thread Tilman Hausherr (Jira)
[ https://issues.apache.org/jira/browse/MNG-8180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17865293#comment-17865293 ] Tilman Hausherr commented on MNG-8180: -- Is this a problem that applies to every projec

[jira] [Commented] (MNG-7914) Provide a single entry point for configuration

2024-07-11 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-7914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17865324#comment-17865324 ] ASF GitHub Bot commented on MNG-7914: - gnodet commented on code in PR #1595: URL: https

Re: [PR] [MNG-7914] Provide a single entry point for configuration [maven]

2024-07-11 Thread via GitHub
gnodet commented on code in PR #1595: URL: https://github.com/apache/maven/pull/1595#discussion_r1675379441 ## maven-embedder/src/main/java/org/apache/maven/cli/MavenCli.java: ## @@ -1204,40 +1203,57 @@ void toolchains(CliRequest cliRequest) throws Exception {

<    1   2