michael-o commented on code in PR #1563:
URL: https://github.com/apache/maven/pull/1563#discussion_r1628924460
##
maven-core/src/main/java/org/apache/maven/project/DefaultProjectDependenciesResolver.java:
##
@@ -160,7 +160,9 @@ public DependencyResolutionResult
resolve(Dependen
[
https://issues.apache.org/jira/browse/MNG-7758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17852664#comment-17852664
]
ASF GitHub Bot commented on MNG-7758:
-
michael-o commented on code in PR #1563:
URL: ht
michael-o commented on code in PR #1563:
URL: https://github.com/apache/maven/pull/1563#discussion_r1628927252
##
maven-core/src/main/java/org/apache/maven/project/DependencyResolutionException.java:
##
@@ -18,18 +18,52 @@
*/
package org.apache.maven.project;
+import java.u
[
https://issues.apache.org/jira/browse/MNG-7758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17852665#comment-17852665
]
ASF GitHub Bot commented on MNG-7758:
-
michael-o commented on code in PR #1563:
URL: ht
[
https://issues.apache.org/jira/browse/MNG-8145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17852666#comment-17852666
]
Michael Osipov commented on MNG-8145:
-
>From my PoV, we are out of control on low level
slawekjaranowski commented on code in PR #1563:
URL: https://github.com/apache/maven/pull/1563#discussion_r1628979345
##
maven-core/src/main/java/org/apache/maven/project/DefaultProjectDependenciesResolver.java:
##
@@ -160,7 +160,9 @@ public DependencyResolutionResult
resolve(D
[
https://issues.apache.org/jira/browse/MNG-7758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17852676#comment-17852676
]
ASF GitHub Bot commented on MNG-7758:
-
slawekjaranowski commented on code in PR #1563:
adangel commented on code in PR #150:
URL: https://github.com/apache/maven-pmd-plugin/pull/150#discussion_r1629003414
##
src/main/java/org/apache/maven/plugins/pmd/exec/PmdErrorMessageReporter.java:
##
@@ -0,0 +1,80 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) und
[
https://issues.apache.org/jira/browse/MPMD-395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17852678#comment-17852678
]
ASF GitHub Bot commented on MPMD-395:
-
adangel commented on code in PR #150:
URL: https
michael-o commented on code in PR #1563:
URL: https://github.com/apache/maven/pull/1563#discussion_r1629016815
##
maven-core/src/main/java/org/apache/maven/project/DefaultProjectDependenciesResolver.java:
##
@@ -160,7 +160,9 @@ public DependencyResolutionResult
resolve(Dependen
[
https://issues.apache.org/jira/browse/MNG-7758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17852681#comment-17852681
]
ASF GitHub Bot commented on MNG-7758:
-
michael-o commented on code in PR #1563:
URL: ht
michael-o commented on PR #150:
URL: https://github.com/apache/maven-pmd-plugin/pull/150#issuecomment-2151711151
@adangel thanks for the rework, will review again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
UR
[
https://issues.apache.org/jira/browse/MNG-7758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17852682#comment-17852682
]
ASF GitHub Bot commented on MNG-7758:
-
gnodet commented on code in PR #1563:
URL: https
[
https://issues.apache.org/jira/browse/MPMD-395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17852683#comment-17852683
]
ASF GitHub Bot commented on MPMD-395:
-
michael-o commented on PR #150:
URL: https://git
gnodet commented on code in PR #1563:
URL: https://github.com/apache/maven/pull/1563#discussion_r1629018214
##
maven-core/src/main/java/org/apache/maven/project/DefaultProjectDependenciesResolver.java:
##
@@ -160,7 +160,9 @@ public DependencyResolutionResult
resolve(DependencyR
slawekjaranowski commented on code in PR #1563:
URL: https://github.com/apache/maven/pull/1563#discussion_r1629134423
##
maven-core/src/main/java/org/apache/maven/project/DefaultProjectDependenciesResolver.java:
##
@@ -160,7 +160,9 @@ public DependencyResolutionResult
resolve(D
[
https://issues.apache.org/jira/browse/MNG-7758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17852702#comment-17852702
]
ASF GitHub Bot commented on MNG-7758:
-
slawekjaranowski commented on code in PR #1563:
[
https://issues.apache.org/jira/browse/MJAVADOC-656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17852704#comment-17852704
]
Robert Važan commented on MJAVADOC-656:
---
[~michael-o]: Not sure I follow with the
michael-o commented on code in PR #1563:
URL: https://github.com/apache/maven/pull/1563#discussion_r1629141312
##
maven-core/src/main/java/org/apache/maven/project/DefaultProjectDependenciesResolver.java:
##
@@ -160,7 +160,9 @@ public DependencyResolutionResult
resolve(Dependen
[
https://issues.apache.org/jira/browse/MNG-7758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17852705#comment-17852705
]
ASF GitHub Bot commented on MNG-7758:
-
michael-o commented on code in PR #1563:
URL: ht
michael-o commented on code in PR #150:
URL: https://github.com/apache/maven-pmd-plugin/pull/150#discussion_r1629157354
##
src/main/java/org/apache/maven/plugins/pmd/exec/PmdErrorMessageReporter.java:
##
@@ -0,0 +1,80 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) u
cstamas commented on PR #1557:
URL: https://github.com/apache/maven/pull/1557#issuecomment-2151862969
Added UT: before this PR, the code in UT would throw `NumberFormatEx`, but
now it cleanly remains inactive and tells the problem.
--
This is an automated message from the Apache Git Servi
[
https://issues.apache.org/jira/browse/MPMD-395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17852706#comment-17852706
]
ASF GitHub Bot commented on MPMD-395:
-
michael-o commented on code in PR #150:
URL: htt
[
https://issues.apache.org/jira/browse/MNG-8142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17852707#comment-17852707
]
ASF GitHub Bot commented on MNG-8142:
-
cstamas commented on PR #1557:
URL: https://gith
michael-o commented on code in PR #150:
URL: https://github.com/apache/maven-pmd-plugin/pull/150#discussion_r1629162067
##
src/test/java/org/apache/maven/plugins/pmd/CpdReportTest.java:
##
@@ -130,7 +130,8 @@ public void testInvalidFormat() throws Exception {
fail
[
https://issues.apache.org/jira/browse/MPMD-395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17852708#comment-17852708
]
ASF GitHub Bot commented on MPMD-395:
-
michael-o commented on code in PR #150:
URL: htt
cstamas merged PR #1558:
URL: https://github.com/apache/maven/pull/1558
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.
[
https://issues.apache.org/jira/browse/MNG-8066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17852714#comment-17852714
]
ASF GitHub Bot commented on MNG-8066:
-
cstamas merged PR #1558:
URL: https://github.com
[
https://issues.apache.org/jira/browse/MNG-8066?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tamas Cservenak closed MNG-8066.
Resolution: Fixed
Fixed with
* 3.9.x
[https://github.com/apache/maven/commit/865072025d98c54e2270d4
[
https://issues.apache.org/jira/browse/MNG-7902?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tamas Cservenak reassigned MNG-7902:
Assignee: Guillaume Nodet
> Sort plugins in validation report
>
michael-o commented on PR #1563:
URL: https://github.com/apache/maven/pull/1563#issuecomment-2152128194
Give me a day or two, I try to try this out in a realworld env.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use th
[
https://issues.apache.org/jira/browse/MNG-7758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17852742#comment-17852742
]
ASF GitHub Bot commented on MNG-7758:
-
michael-o commented on PR #1563:
URL: https://gi
[
https://issues.apache.org/jira/browse/MNG-7868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17852754#comment-17852754
]
Richard Eckart de Castilho commented on MNG-7868:
-
[~cstamas] can you read
cstamas opened a new pull request, #1564:
URL: https://github.com/apache/maven/pull/1564
For start, the distro zip lost almost 1 MB (was 10 MB now is 9MB). Second,
am really unsure why it was introduced in the first place, as it merely caused
confusion, over StringUtils for example.
Tamas Cservenak created MNG-8146:
Summary: Drop use of commons-lang
Key: MNG-8146
URL: https://issues.apache.org/jira/browse/MNG-8146
Project: Maven
Issue Type: Task
Reporter: Tam
[
https://issues.apache.org/jira/browse/MNG-7868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17852771#comment-17852771
]
Tamas Cservenak commented on MNG-7868:
--
sentencepiece: can you tell what was the stack
cstamas commented on PR #1564:
URL: https://github.com/apache/maven/pull/1564#issuecomment-2152375090
> Several changes are _not_ OK. There is clearly a definition that for a
null value an NPE is expected, not IAE for past 10+ years. This violates the
expectations from Effective Java. @elha
[
https://issues.apache.org/jira/browse/MNG-8146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17852775#comment-17852775
]
ASF GitHub Bot commented on MNG-8146:
-
cstamas commented on PR #1564:
URL: https://gith
[
https://issues.apache.org/jira/browse/MNG-7868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17852776#comment-17852776
]
Richard Eckart de Castilho commented on MNG-7868:
-
{noformat}
org.apache.ma
michael-o commented on PR #1564:
URL: https://github.com/apache/maven/pull/1564#issuecomment-2152392587
> > Several changes are _not_ OK. There is clearly a definition that for a
null value an NPE is expected, not IAE for past 10+ years. This violates the
expectations from Effective Java. @
[
https://issues.apache.org/jira/browse/MNG-8146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17852778#comment-17852778
]
ASF GitHub Bot commented on MNG-8146:
-
michael-o commented on PR #1564:
URL: https://gi
[
https://issues.apache.org/jira/browse/MNG-7868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17852779#comment-17852779
]
Tamas Cservenak commented on MNG-7868:
--
Need to take a peek what is happening in
aQut
michael-o commented on code in PR #1564:
URL: https://github.com/apache/maven/pull/1564#discussion_r1629513653
##
pom.xml:
##
@@ -442,16 +441,6 @@ under the License.
commons-cli
commons-cli
${commonsCliVersion}
-
-
-common
[
https://issues.apache.org/jira/browse/MNG-8146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17852782#comment-17852782
]
ASF GitHub Bot commented on MNG-8146:
-
michael-o commented on code in PR #1564:
URL: ht
[
https://issues.apache.org/jira/browse/MNG-7868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17852783#comment-17852783
]
Richard Eckart de Castilho commented on MNG-7868:
-
The bnd plugin version u
[
https://issues.apache.org/jira/browse/MNG-7868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17852786#comment-17852786
]
Tamas Cservenak commented on MNG-7868:
--
Just realized something: Maven 3.9.7 carries f
michael-o commented on PR #1564:
URL: https://github.com/apache/maven/pull/1564#issuecomment-2152503852
I agree that for those few cases Commons Lang is overkill.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
[
https://issues.apache.org/jira/browse/MNG-8146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17852787#comment-17852787
]
ASF GitHub Bot commented on MNG-8146:
-
michael-o commented on PR #1564:
URL: https://gi
motlin commented on PR #136:
URL:
https://github.com/apache/maven-checkstyle-plugin/pull/136#issuecomment-2152517655
I'm trying to use this and running into:
```
Caused by: java.lang.NoSuchMethodError: 'void
com.puppycrawl.tools.checkstyle.SarifLogger.(java.io.OutputStream,
com.p
[
https://issues.apache.org/jira/browse/MCHECKSTYLE-449?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17852788#comment-17852788
]
ASF GitHub Bot commented on MCHECKSTYLE-449:
motlin commented on PR #136
[
https://issues.apache.org/jira/browse/MNG-7868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17852790#comment-17852790
]
Tamas Cservenak commented on MNG-7868:
--
[~rec] can you tell me more about failed build
cstamas commented on code in PR #1564:
URL: https://github.com/apache/maven/pull/1564#discussion_r1629554150
##
pom.xml:
##
@@ -442,16 +441,6 @@ under the License.
commons-cli
commons-cli
${commonsCliVersion}
-
-
-commons-
[
https://issues.apache.org/jira/browse/MNG-8146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17852792#comment-17852792
]
ASF GitHub Bot commented on MNG-8146:
-
cstamas commented on code in PR #1564:
URL: http
[
https://issues.apache.org/jira/browse/MNG-8146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17852794#comment-17852794
]
ASF GitHub Bot commented on MNG-8146:
-
michael-o commented on code in PR #1564:
URL: ht
michael-o commented on code in PR #1564:
URL: https://github.com/apache/maven/pull/1564#discussion_r1629570046
##
pom.xml:
##
@@ -442,16 +441,6 @@ under the License.
commons-cli
commons-cli
${commonsCliVersion}
-
-
-common
michael-o commented on PR #140:
URL:
https://github.com/apache/maven-checkstyle-plugin/pull/140#issuecomment-2152548211
@dependabot ignore this dependency
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
dependabot[bot] closed pull request #140: Bump slf4jVersion from 1.7.36 to
2.0.13
URL: https://github.com/apache/maven-checkstyle-plugin/pull/140
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
dependabot[bot] closed pull request #139: Bump resolverVersion from 1.4.1 to
1.9.20
URL: https://github.com/apache/maven-checkstyle-plugin/pull/139
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to th
dependabot[bot] commented on PR #139:
URL:
https://github.com/apache/maven-checkstyle-plugin/pull/139#issuecomment-2152548571
OK, I won't notify you about any of these dependencies again, unless you
re-open this PR.
--
This is an automated message from the Apache Git Service.
To respond
michael-o commented on PR #139:
URL:
https://github.com/apache/maven-checkstyle-plugin/pull/139#issuecomment-2152548431
@dependabot ignore this dependency
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
dependabot[bot] commented on PR #140:
URL:
https://github.com/apache/maven-checkstyle-plugin/pull/140#issuecomment-2152548434
OK, I won't notify you about any of these dependencies again, unless you
re-open this PR.
--
This is an automated message from the Apache Git Service.
To respond
michael-o commented on PR #136:
URL:
https://github.com/apache/maven-checkstyle-plugin/pull/136#issuecomment-2152552406
@motlin, can you provide `mvn -X` of the plugin execution. I'd like to see
the dep tree. This output confuses me.
--
This is an automated message from the Apache Git Se
michael-o commented on PR #136:
URL:
https://github.com/apache/maven-checkstyle-plugin/pull/136#issuecomment-2152555247
Hold on, 10.17.0 is a major version. Signatures might have changed from 9.
You should check that first. If it runs with the stock one, then the issue is
clear.
--
This
bmarwell closed issue #995: If Maven Daemon executes in 0.2s, the summary
output might be printed too early
URL: https://github.com/apache/maven-mvnd/issues/995
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abov
bmarwell commented on issue #995:
URL: https://github.com/apache/maven-mvnd/issues/995#issuecomment-2152555484
@pedro: I wanted to see first if anyone encountered the same problem.
Since this seems not to be the case, I will close it.
--
This is an automated message from the Apache
[
https://issues.apache.org/jira/browse/MCHECKSTYLE-449?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17852796#comment-17852796
]
ASF GitHub Bot commented on MCHECKSTYLE-449:
michael-o commented on PR #
[
https://issues.apache.org/jira/browse/MCHECKSTYLE-449?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17852797#comment-17852797
]
ASF GitHub Bot commented on MCHECKSTYLE-449:
michael-o commented on PR #
K P created MASSEMBLY-1031:
--
Summary: Regression: assembly plugin 3.7.0 now includes
scope=provided dependencies if they also occur transitively
Key: MASSEMBLY-1031
URL: https://issues.apache.org/jira/browse/MASSEMBLY-10
motlin commented on PR #136:
URL:
https://github.com/apache/maven-checkstyle-plugin/pull/136#issuecomment-2152620974
Downgrading to Checkstyle 9.3 seemed to work. It's not ideal since I use
some newer checks.
--
This is an automated message from the Apache Git Service.
To respond to the
[
https://issues.apache.org/jira/browse/MCHECKSTYLE-449?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17852799#comment-17852799
]
ASF GitHub Bot commented on MCHECKSTYLE-449:
motlin commented on PR #136
cstamas commented on PR #1564:
URL: https://github.com/apache/maven/pull/1564#issuecomment-2152638881
> Yes, through out our entire codebase.
Don't divert: I asked you to show me where _changed_ spots in this PR
benefit anything from NPE (as vs IAEx).
But nevertheless, with co
[
https://issues.apache.org/jira/browse/MNG-8146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17852803#comment-17852803
]
ASF GitHub Bot commented on MNG-8146:
-
cstamas commented on PR #1564:
URL: https://gith
[
https://issues.apache.org/jira/browse/MNG-8146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17852813#comment-17852813
]
ASF GitHub Bot commented on MNG-8146:
-
elharo commented on PR #1564:
URL: https://githu
elharo commented on PR #1564:
URL: https://github.com/apache/maven/pull/1564#issuecomment-2152697789
I'll have to dig into the individual changes. However overall I no longer
trust commons-lang and definitely favor removing our dependence on it if
possible.
--
This is an automated messa
cstamas commented on PR #1564:
URL: https://github.com/apache/maven/pull/1564#issuecomment-2152701271
For ref, the Maven4 PR https://github.com/apache/maven/pull/1080
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
[
https://issues.apache.org/jira/browse/MNG-8146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17852814#comment-17852814
]
ASF GitHub Bot commented on MNG-8146:
-
cstamas commented on PR #1564:
URL: https://gith
elharo commented on code in PR #1564:
URL: https://github.com/apache/maven/pull/1564#discussion_r1629675910
##
maven-artifact/src/main/java/org/apache/maven/artifact/versioning/DefaultArtifactVersion.java:
##
@@ -176,6 +174,18 @@ private static Integer getNextIntegerToken(String
slawekjaranowski commented on PR #1563:
URL: https://github.com/apache/maven/pull/1563#issuecomment-2152711345
> Give me a day or two, I try to try this out in a realworld env.
I would be happy to have it in 3.9.x also
So I fix ITs first 😄
--
This is an automated message fro
[
https://issues.apache.org/jira/browse/MNG-8146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17852816#comment-17852816
]
ASF GitHub Bot commented on MNG-8146:
-
elharo commented on code in PR #1564:
URL: https
[
https://issues.apache.org/jira/browse/MNG-7758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17852817#comment-17852817
]
ASF GitHub Bot commented on MNG-7758:
-
slawekjaranowski commented on PR #1563:
URL: htt
elharo commented on PR #1564:
URL: https://github.com/apache/maven/pull/1564#issuecomment-2152717446
I concur that NPE is strongly preferred over IAE for null values. I didn't
happen to find any places where this was done wrong, but I wasn't reading that
closely.
--
This is an automated
[
https://issues.apache.org/jira/browse/MNG-8146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17852818#comment-17852818
]
ASF GitHub Bot commented on MNG-8146:
-
elharo commented on PR #1564:
URL: https://githu
cstamas commented on code in PR #1564:
URL: https://github.com/apache/maven/pull/1564#discussion_r1629689572
##
maven-artifact/src/main/java/org/apache/maven/artifact/versioning/DefaultArtifactVersion.java:
##
@@ -176,6 +174,18 @@ private static Integer getNextIntegerToken(Strin
[
https://issues.apache.org/jira/browse/MNG-8146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17852819#comment-17852819
]
ASF GitHub Bot commented on MNG-8146:
-
cstamas commented on code in PR #1564:
URL: http
adangel commented on code in PR #150:
URL: https://github.com/apache/maven-pmd-plugin/pull/150#discussion_r1629695838
##
src/main/java/org/apache/maven/plugins/pmd/exec/CpdReportConsumer.java:
##
@@ -0,0 +1,118 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under on
[
https://issues.apache.org/jira/browse/MPMD-395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17852821#comment-17852821
]
ASF GitHub Bot commented on MPMD-395:
-
adangel commented on code in PR #150:
URL: https
adangel commented on code in PR #150:
URL: https://github.com/apache/maven-pmd-plugin/pull/150#discussion_r1629697284
##
src/main/java/org/apache/maven/plugins/pmd/exec/CpdReportConsumer.java:
##
@@ -0,0 +1,118 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under on
[
https://issues.apache.org/jira/browse/MNG-8146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17852823#comment-17852823
]
ASF GitHub Bot commented on MNG-8146:
-
cstamas commented on PR #1564:
URL: https://gith
[
https://issues.apache.org/jira/browse/MPMD-395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17852822#comment-17852822
]
ASF GitHub Bot commented on MPMD-395:
-
adangel commented on code in PR #150:
URL: https
cstamas commented on PR #1564:
URL: https://github.com/apache/maven/pull/1564#issuecomment-2152739532
I agree with this "general" rule to prefer NPE over IAE, but disagree with
unconditional sticking to this rule. One has to be pragmatic a bit, and allow
deviation. My point was, that in thi
[
https://issues.apache.org/jira/browse/MNG-7868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17852829#comment-17852829
]
Richard Eckart de Castilho commented on MNG-7868:
-
It is a {{clean install}
michael-o commented on PR #136:
URL:
https://github.com/apache/maven-checkstyle-plugin/pull/136#issuecomment-2152821352
> Downgrading to Checkstyle 9.3 seemed to work. It's not ideal since I use
some newer checks.
This is something we cannot fix because Checkstyle raised to Java 11 s
[
https://issues.apache.org/jira/browse/MCHECKSTYLE-449?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17852836#comment-17852836
]
ASF GitHub Bot commented on MCHECKSTYLE-449:
michael-o commented on PR #
motlin commented on PR #136:
URL:
https://github.com/apache/maven-checkstyle-plugin/pull/136#issuecomment-2152838061
Would it make sense to release versions of maven-checkstyle-plugin that are
separately compatible with 9.x and 10.x?
--
This is an automated message from the Apache Git Se
[
https://issues.apache.org/jira/browse/MCHECKSTYLE-449?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17852837#comment-17852837
]
ASF GitHub Bot commented on MCHECKSTYLE-449:
motlin commented on PR #136
michael-o commented on PR #136:
URL:
https://github.com/apache/maven-checkstyle-plugin/pull/136#issuecomment-2152889907
> Would it make sense to release versions of maven-checkstyle-plugin that
are separately compatible with 9.x and 10.x?
Technically yes, but not before the Doxia 2.0
[
https://issues.apache.org/jira/browse/MCHECKSTYLE-449?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17852843#comment-17852843
]
ASF GitHub Bot commented on MCHECKSTYLE-449:
michael-o commented on PR #
cstamas merged PR #1557:
URL: https://github.com/apache/maven/pull/1557
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.
[
https://issues.apache.org/jira/browse/MNG-8142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17852858#comment-17852858
]
ASF GitHub Bot commented on MNG-8142:
-
cstamas merged PR #1557:
URL: https://github.com
michael-o commented on PR #1557:
URL: https://github.com/apache/maven/pull/1557#issuecomment-2152956489
All, we should strive to get rid of all `System.setProperty()` calls.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
1 - 100 of 207 matches
Mail list logo
