[jira] [Commented] (SUREFIRE-1939) Build fails if java.home has <=2 path components

2024-06-05 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-1939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17852308#comment-17852308 ] Michael Osipov commented on SUREFIRE-1939: -- I can confirm this issue on Java

Re: [PR] [MRELEASE-1109] Snapshot detection and support for versions like `${revision}${sha1}${changelist}` [maven-release]

2024-06-05 Thread via GitHub
mkolesnikov commented on code in PR #202: URL: https://github.com/apache/maven-release/pull/202#discussion_r1627172157 ## maven-release-manager/src/main/java/org/apache/maven/shared/release/util/CiFriendlyVersion.java: ## @@ -0,0 +1,99 @@ +/* + * Licensed to the Apache Software

[jira] [Commented] (MRELEASE-1109) update-versions removes the CI-friendly ${revisions}

2024-06-05 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MRELEASE-1109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17852316#comment-17852316 ] ASF GitHub Bot commented on MRELEASE-1109: -- mkolesnikov commented on code in

Re: [PR] [MRELEASE-1109] Snapshot detection and support for versions like `${revision}${sha1}${changelist}` [maven-release]

2024-06-05 Thread via GitHub
mkolesnikov commented on code in PR #202: URL: https://github.com/apache/maven-release/pull/202#discussion_r1627174008 ## maven-release-manager/src/main/java/org/apache/maven/shared/release/transform/jdom2/JDomModel.java: ## @@ -192,14 +199,13 @@ public void setVersion(String ve

Re: [PR] [MRELEASE-1109] Snapshot detection and support for versions like `${revision}${sha1}${changelist}` [maven-release]

2024-06-05 Thread via GitHub
mkolesnikov commented on code in PR #202: URL: https://github.com/apache/maven-release/pull/202#discussion_r1627174008 ## maven-release-manager/src/main/java/org/apache/maven/shared/release/transform/jdom2/JDomModel.java: ## @@ -192,14 +199,13 @@ public void setVersion(String ve

[jira] [Commented] (MRELEASE-1109) update-versions removes the CI-friendly ${revisions}

2024-06-05 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MRELEASE-1109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17852317#comment-17852317 ] ASF GitHub Bot commented on MRELEASE-1109: -- mkolesnikov commented on code in

[jira] [Commented] (MRELEASE-1109) update-versions removes the CI-friendly ${revisions}

2024-06-05 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MRELEASE-1109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17852318#comment-17852318 ] ASF GitHub Bot commented on MRELEASE-1109: -- mkolesnikov commented on code in

Re: [PR] [MSHARED-1408] Refresh IntelliJ formater [maven-shared-resources]

2024-06-05 Thread via GitHub
slawekjaranowski commented on code in PR #14: URL: https://github.com/apache/maven-shared-resources/pull/14#discussion_r1627185688 ## src/main/resources/config/maven-idea-codestyle-2022.xml: ## @@ -123,7 +131,7 @@ under the License. - + Review Com

[jira] [Commented] (MSHARED-1408) Refresh IntelliJ formater

2024-06-05 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MSHARED-1408?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17852319#comment-17852319 ] ASF GitHub Bot commented on MSHARED-1408: - slawekjaranowski commented on code i

Re: [PR] Null implementations shall return null [maven-resolver]

2024-06-05 Thread via GitHub
cstamas commented on PR #113: URL: https://github.com/apache/maven-resolver/pull/113#issuecomment-2149139709 I think the classes are named badly. These "default" (and not "null") selectors are meant to not interfere with already equipped repositories. In short, you know that when you

[jira] [Commented] (MNG-8138) Maven internal state should not allow to become "broken"

2024-06-05 Thread Jira
[ https://issues.apache.org/jira/browse/MNG-8138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17852331#comment-17852331 ] Michaël commented on MNG-8138: -- perhaps weird; but the project/submodule is packaging=pom, sho

Re: [PR] [MRELEASE-1109] Snapshot detection and support for versions like `${revision}${sha1}${changelist}` [maven-release]

2024-06-05 Thread via GitHub
michael-o commented on code in PR #202: URL: https://github.com/apache/maven-release/pull/202#discussion_r1627264489 ## maven-release-manager/src/main/java/org/apache/maven/shared/release/util/CiFriendlyVersion.java: ## @@ -0,0 +1,96 @@ +/* + * Licensed to the Apache Software Fo

[jira] [Commented] (MRELEASE-1109) update-versions removes the CI-friendly ${revisions}

2024-06-05 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MRELEASE-1109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17852335#comment-17852335 ] ASF GitHub Bot commented on MRELEASE-1109: -- michael-o commented on code in PR

[jira] [Commented] (MNG-8138) Maven internal state should not allow to become "broken"

2024-06-05 Thread Tamas Cservenak (Jira)
[ https://issues.apache.org/jira/browse/MNG-8138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17852337#comment-17852337 ] Tamas Cservenak commented on MNG-8138: -- Yes, but here is a thing: * we cannot (read:

[jira] [Commented] (MNG-8138) Maven internal state should not allow to become "broken"

2024-06-05 Thread Jira
[ https://issues.apache.org/jira/browse/MNG-8138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17852340#comment-17852340 ] Michaël commented on MNG-8138: -- clear, tnx for explaining, i did expect these limitations as M

[jira] [Commented] (MDEPLOY-318) version 3.1.2 is uploading jar files to wrong endpoints

2024-06-05 Thread Jira
[ https://issues.apache.org/jira/browse/MDEPLOY-318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17852343#comment-17852343 ] Michaël commented on MDEPLOY-318: - i can confirm that deploying that 3.1.2 works with de

[jira] [Commented] (MDEPLOY-318) version 3.1.2 is uploading jar files to wrong endpoints

2024-06-05 Thread Tamas Cservenak (Jira)
[ https://issues.apache.org/jira/browse/MDEPLOY-318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17852346#comment-17852346 ] Tamas Cservenak commented on MDEPLOY-318: - As expected: two CLI invocations mean

[jira] [Commented] (MDEPLOY-318) version 3.1.2 is uploading jar files to wrong endpoints

2024-06-05 Thread Tamas Cservenak (Jira)
[ https://issues.apache.org/jira/browse/MDEPLOY-318?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17852347#comment-17852347 ] Tamas Cservenak commented on MDEPLOY-318: - See [https://maven.apache.org/guides

[jira] [Commented] (MNG-7868) "Could not acquire lock(s)" error in concurrent maven builds

2024-06-05 Thread Richard Eckart de Castilho (Jira)
[ https://issues.apache.org/jira/browse/MNG-7868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17852352#comment-17852352 ] Richard Eckart de Castilho commented on MNG-7868: - I have a dump of the loc

Re: [PR] [MRELEASE-1109] Snapshot detection and support for versions like `${revision}${sha1}${changelist}` [maven-release]

2024-06-05 Thread via GitHub
michael-o commented on code in PR #202: URL: https://github.com/apache/maven-release/pull/202#discussion_r1627389761 ## maven-release-manager/src/main/java/org/apache/maven/shared/release/util/CiFriendlyVersion.java: ## @@ -0,0 +1,99 @@ +/* + * Licensed to the Apache Software Fo

[jira] [Commented] (MRELEASE-1109) update-versions removes the CI-friendly ${revisions}

2024-06-05 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MRELEASE-1109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17852355#comment-17852355 ] ASF GitHub Bot commented on MRELEASE-1109: -- michael-o commented on code in PR

[jira] [Commented] (MJAVADOC-656) Following redirects breaks valid links

2024-06-05 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MJAVADOC-656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17852360#comment-17852360 ] Michael Osipov commented on MJAVADOC-656: - [~robert.vazan], are you interested

[jira] [Created] (MNG-8140) When a model is discarded (by model builder) for whatever reason, show why it happened

2024-06-05 Thread Tamas Cservenak (Jira)
Tamas Cservenak created MNG-8140: Summary: When a model is discarded (by model builder) for whatever reason, show why it happened Key: MNG-8140 URL: https://issues.apache.org/jira/browse/MNG-8140 Proj

[jira] [Assigned] (MNG-8140) When a model is discarded (by model builder) for whatever reason, show why it happened

2024-06-05 Thread Tamas Cservenak (Jira)
[ https://issues.apache.org/jira/browse/MNG-8140?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamas Cservenak reassigned MNG-8140: Assignee: Tamas Cservenak > When a model is discarded (by model builder) for whatever reason

[jira] [Updated] (MNG-8140) When a model is discarded (by model builder) for whatever reason, show why it happened

2024-06-05 Thread Tamas Cservenak (Jira)
[ https://issues.apache.org/jira/browse/MNG-8140?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamas Cservenak updated MNG-8140: - Description: Currently, when a model is discarded as "invalid", Maven 3.x shows this line in conso

[jira] [Updated] (MNG-8140) When a model is discarded (by model builder) for whatever reason, show why it happened

2024-06-05 Thread Tamas Cservenak (Jira)
[ https://issues.apache.org/jira/browse/MNG-8140?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamas Cservenak updated MNG-8140: - Description: Currently, when a model is discarded as "invalid", Maven 3.x shows this line in conso

[jira] [Updated] (MNG-8140) When a model is discarded (by model builder) for whatever reason, show why it happened

2024-06-05 Thread Tamas Cservenak (Jira)
[ https://issues.apache.org/jira/browse/MNG-8140?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamas Cservenak updated MNG-8140: - Description: Currently, when a model is discarded as "invalid", Maven 3.x shows this line in conso

[jira] [Updated] (MNG-8135) Activate profile by capital OS name fail

2024-06-05 Thread Konrad Windszus (Jira)
[ https://issues.apache.org/jira/browse/MNG-8135?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konrad Windszus updated MNG-8135: - Description: This BUG is introduced by MNG-5726. Prior that change the os name, arch and version c

[jira] [Assigned] (MNG-8141) Model Builder should not rely on "validity" of processed model

2024-06-05 Thread Tamas Cservenak (Jira)
[ https://issues.apache.org/jira/browse/MNG-8141?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamas Cservenak reassigned MNG-8141: Assignee: Tamas Cservenak > Model Builder should not rely on "validity" of processed model >

[jira] [Created] (MNG-8141) Model Builder should not rely on "validity" of processed model

2024-06-05 Thread Tamas Cservenak (Jira)
Tamas Cservenak created MNG-8141: Summary: Model Builder should not rely on "validity" of processed model Key: MNG-8141 URL: https://issues.apache.org/jira/browse/MNG-8141 Project: Maven Iss

[jira] [Commented] (MNG-7868) "Could not acquire lock(s)" error in concurrent maven builds

2024-06-05 Thread Tamas Cservenak (Jira)
[ https://issues.apache.org/jira/browse/MNG-7868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17852364#comment-17852364 ] Tamas Cservenak commented on MNG-7868: -- Thanks! Do not share it, but rather with infor

[jira] [Commented] (MNG-7868) "Could not acquire lock(s)" error in concurrent maven builds

2024-06-05 Thread Richard Eckart de Castilho (Jira)
[ https://issues.apache.org/jira/browse/MNG-7868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17852366#comment-17852366 ] Richard Eckart de Castilho commented on MNG-7868: - Well, that's the informa

[jira] [Comment Edited] (MNG-7868) "Could not acquire lock(s)" error in concurrent maven builds

2024-06-05 Thread Richard Eckart de Castilho (Jira)
[ https://issues.apache.org/jira/browse/MNG-7868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17852366#comment-17852366 ] Richard Eckart de Castilho edited comment on MNG-7868 at 6/5/24 10:12 AM: ---

[jira] [Commented] (MNG-8131) Property replacement in dependency pom no longer works

2024-06-05 Thread Tamas Cservenak (Jira)
[ https://issues.apache.org/jira/browse/MNG-8131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17852367#comment-17852367 ] Tamas Cservenak commented on MNG-8131: -- Fixes being prepped and will be released in 3.

[jira] [Comment Edited] (MNG-8131) Property replacement in dependency pom no longer works

2024-06-05 Thread Tamas Cservenak (Jira)
[ https://issues.apache.org/jira/browse/MNG-8131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17852367#comment-17852367 ] Tamas Cservenak edited comment on MNG-8131 at 6/5/24 10:13 AM: --

[jira] [Updated] (MNG-8131) Property replacement in dependency pom no longer works

2024-06-05 Thread Tamas Cservenak (Jira)
[ https://issues.apache.org/jira/browse/MNG-8131?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamas Cservenak updated MNG-8131: - Fix Version/s: 3.9.8 > Property replacement in dependency pom no longer works > ---

[jira] [Comment Edited] (MNG-7868) "Could not acquire lock(s)" error in concurrent maven builds

2024-06-05 Thread Richard Eckart de Castilho (Jira)
[ https://issues.apache.org/jira/browse/MNG-7868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17852366#comment-17852366 ] Richard Eckart de Castilho edited comment on MNG-7868 at 6/5/24 10:14 AM: ---

[jira] [Comment Edited] (MNG-7868) "Could not acquire lock(s)" error in concurrent maven builds

2024-06-05 Thread Richard Eckart de Castilho (Jira)
[ https://issues.apache.org/jira/browse/MNG-7868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17852352#comment-17852352 ] Richard Eckart de Castilho edited comment on MNG-7868 at 6/5/24 10:16 AM: ---

[jira] [Commented] (MNG-8131) Property replacement in dependency pom no longer works

2024-06-05 Thread Tamas Cservenak (Jira)
[ https://issues.apache.org/jira/browse/MNG-8131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17852369#comment-17852369 ] Tamas Cservenak commented on MNG-8131: -- Original issue is "not an issue", but can misl

[jira] [Commented] (MRELEASE-1109) update-versions removes the CI-friendly ${revisions}

2024-06-05 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MRELEASE-1109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17852370#comment-17852370 ] ASF GitHub Bot commented on MRELEASE-1109: -- mkolesnikov commented on code in

Re: [PR] [MRELEASE-1109] Snapshot detection and support for versions like `${revision}${sha1}${changelist}` [maven-release]

2024-06-05 Thread via GitHub
mkolesnikov commented on code in PR #202: URL: https://github.com/apache/maven-release/pull/202#discussion_r1627443336 ## maven-release-manager/src/main/java/org/apache/maven/shared/release/util/CiFriendlyVersion.java: ## @@ -0,0 +1,96 @@ +/* + * Licensed to the Apache Software

Re: [PR] [MRELEASE-1109] Snapshot detection and support for versions like `${revision}${sha1}${changelist}` [maven-release]

2024-06-05 Thread via GitHub
mkolesnikov commented on code in PR #202: URL: https://github.com/apache/maven-release/pull/202#discussion_r1627443336 ## maven-release-manager/src/main/java/org/apache/maven/shared/release/util/CiFriendlyVersion.java: ## @@ -0,0 +1,96 @@ +/* + * Licensed to the Apache Software

[jira] [Commented] (MRELEASE-1109) update-versions removes the CI-friendly ${revisions}

2024-06-05 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MRELEASE-1109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17852372#comment-17852372 ] ASF GitHub Bot commented on MRELEASE-1109: -- mkolesnikov commented on code in

[jira] [Updated] (MNG-8010) Minimize and make generic the README.txt

2024-06-05 Thread Tamas Cservenak (Jira)
[ https://issues.apache.org/jira/browse/MNG-8010?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamas Cservenak updated MNG-8010: - Fix Version/s: 4.0.0-beta-4 (was: 4.0.x-candidate) > Minimize and make gener

[jira] [Comment Edited] (MNG-7868) "Could not acquire lock(s)" error in concurrent maven builds

2024-06-05 Thread Richard Eckart de Castilho (Jira)
[ https://issues.apache.org/jira/browse/MNG-7868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17852366#comment-17852366 ] Richard Eckart de Castilho edited comment on MNG-7868 at 6/5/24 10:23 AM: ---

[jira] [Closed] (MNG-8004) Enhance location tracking

2024-06-05 Thread Tamas Cservenak (Jira)
[ https://issues.apache.org/jira/browse/MNG-8004?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamas Cservenak closed MNG-8004. Resolution: Duplicate > Enhance location tracking > - > > Key

[jira] [Commented] (MNG-8112) extension.xml is ignored when extension is loaded by -Dmaven.ext.class.path

2024-06-05 Thread Tamas Cservenak (Jira)
[ https://issues.apache.org/jira/browse/MNG-8112?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17852373#comment-17852373 ] Tamas Cservenak commented on MNG-8112: -- This is by design: this file resolves and adds

[jira] [Closed] (MNG-8114) install plugin failed with NPE for profiles activated by files existing

2024-06-05 Thread Tamas Cservenak (Jira)
[ https://issues.apache.org/jira/browse/MNG-8114?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamas Cservenak closed MNG-8114. Resolution: Fixed > install plugin failed with NPE for profiles activated by files existing > ---

[jira] [Updated] (MNG-8066) Maven hangs on self-referencing exceptions

2024-06-05 Thread Tamas Cservenak (Jira)
[ https://issues.apache.org/jira/browse/MNG-8066?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamas Cservenak updated MNG-8066: - Fix Version/s: 3.9.8 4.0.0-beta-4 > Maven hangs on self-referencing exceptions >

[jira] [Commented] (MNG-8051) Combine dependency scopes instead of overriding

2024-06-05 Thread Tamas Cservenak (Jira)
[ https://issues.apache.org/jira/browse/MNG-8051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17852375#comment-17852375 ] Tamas Cservenak commented on MNG-8051: -- This sounds wrong: if you need jakarta.inject-

[jira] [Comment Edited] (MNG-8051) Combine dependency scopes instead of overriding

2024-06-05 Thread Tamas Cservenak (Jira)
[ https://issues.apache.org/jira/browse/MNG-8051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17852375#comment-17852375 ] Tamas Cservenak edited comment on MNG-8051 at 6/5/24 10:42 AM: --

[jira] [Comment Edited] (MNG-8051) Combine dependency scopes instead of overriding

2024-06-05 Thread Tamas Cservenak (Jira)
[ https://issues.apache.org/jira/browse/MNG-8051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17852375#comment-17852375 ] Tamas Cservenak edited comment on MNG-8051 at 6/5/24 10:43 AM: --

[jira] [Commented] (MNG-8027) Maven cannot be embedded in applications that have upgraded Guice to 7.0+

2024-06-05 Thread Tamas Cservenak (Jira)
[ https://issues.apache.org/jira/browse/MNG-8027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17852377#comment-17852377 ] Tamas Cservenak commented on MNG-8027: -- Maven relies on Eclipse Sisu that relies on ja

Re: [PR] [MRELEASE-1109] Snapshot detection and support for versions like `${revision}${sha1}${changelist}` [maven-release]

2024-06-05 Thread via GitHub
michael-o commented on code in PR #202: URL: https://github.com/apache/maven-release/pull/202#discussion_r1627504174 ## maven-release-manager/src/main/java/org/apache/maven/shared/release/util/CiFriendlyVersion.java: ## @@ -0,0 +1,96 @@ +/* + * Licensed to the Apache Software Fo

[jira] [Commented] (MRELEASE-1109) update-versions removes the CI-friendly ${revisions}

2024-06-05 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MRELEASE-1109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17852381#comment-17852381 ] ASF GitHub Bot commented on MRELEASE-1109: -- michael-o commented on code in PR

Re: [PR] [MRELEASE-1109] Snapshot detection and support for versions like `${revision}${sha1}${changelist}` [maven-release]

2024-06-05 Thread via GitHub
mkolesnikov commented on code in PR #202: URL: https://github.com/apache/maven-release/pull/202#discussion_r1627512879 ## maven-release-manager/src/main/java/org/apache/maven/shared/release/util/CiFriendlyVersion.java: ## @@ -0,0 +1,99 @@ +/* + * Licensed to the Apache Software

[jira] [Commented] (MRELEASE-1109) update-versions removes the CI-friendly ${revisions}

2024-06-05 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MRELEASE-1109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17852382#comment-17852382 ] ASF GitHub Bot commented on MRELEASE-1109: -- mkolesnikov commented on code in

Re: [PR] [MRELEASE-1109] Snapshot detection and support for versions like `${revision}${sha1}${changelist}` [maven-release]

2024-06-05 Thread via GitHub
mkolesnikov commented on code in PR #202: URL: https://github.com/apache/maven-release/pull/202#discussion_r1627517025 ## maven-release-manager/src/main/java/org/apache/maven/shared/release/util/CiFriendlyVersion.java: ## @@ -0,0 +1,96 @@ +/* + * Licensed to the Apache Software

[jira] [Commented] (MRELEASE-1109) update-versions removes the CI-friendly ${revisions}

2024-06-05 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MRELEASE-1109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17852383#comment-17852383 ] ASF GitHub Bot commented on MRELEASE-1109: -- mkolesnikov commented on code in

[PR] [MNG-8140] Always tell why model was discarded as "invalid" [maven]

2024-06-05 Thread via GitHub
cstamas opened a new pull request, #1555: URL: https://github.com/apache/maven/pull/1555 The info is there, but we redirect user to rinse-repeat in debug mode, that that creates a TON of output. All is there, just tell why. --- https://issues.apache.org/jira/browse/MNG-8

[jira] [Commented] (MNG-8140) When a model is discarded (by model builder) for whatever reason, show why it happened

2024-06-05 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-8140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17852384#comment-17852384 ] ASF GitHub Bot commented on MNG-8140: - cstamas opened a new pull request, #1555: URL: h

Re: [PR] [MNG-8140] Always tell why model was discarded as "invalid" [maven]

2024-06-05 Thread via GitHub
cstamas commented on PR #1555: URL: https://github.com/apache/maven/pull/1555#issuecomment-2149508687 This is how with this the reproducer for JavaFX "broken parent" case looks like: https://gist.github.com/cstamas/288a773459ef026e1500699b7a109451 -- This is an automated message from t

[jira] [Commented] (MNG-8140) When a model is discarded (by model builder) for whatever reason, show why it happened

2024-06-05 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-8140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17852386#comment-17852386 ] ASF GitHub Bot commented on MNG-8140: - cstamas commented on PR #1555: URL: https://gith

[PR] [MNG-8141] Model builder should report problems it finds during build… [maven]

2024-06-05 Thread via GitHub
cstamas opened a new pull request, #1556: URL: https://github.com/apache/maven/pull/1556 …ing the model And not rely that model was validated, which is not true in some cases. Model builder can still easily detect issues with models while building them. --- https://issue

[jira] [Commented] (MNG-8141) Model Builder should not rely on "validity" of processed model

2024-06-05 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-8141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17852390#comment-17852390 ] ASF GitHub Bot commented on MNG-8141: - cstamas opened a new pull request, #1556: URL: h

Re: [PR] [MNG-8141] Model builder should report problems it finds during build [maven]

2024-06-05 Thread via GitHub
cstamas commented on PR #1556: URL: https://github.com/apache/maven/pull/1556#issuecomment-2149520897 This PR results in these FATAL issues being reported in JavaFX issue: https://gist.github.com/cstamas/288a773459ef026e1500699b7a109451 -- This is an automated message from the Apache Gi

[jira] [Comment Edited] (MNG-8051) Combine dependency scopes instead of overriding

2024-06-05 Thread James Howe (Jira)
[ https://issues.apache.org/jira/browse/MNG-8051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17852391#comment-17852391 ] James Howe edited comment on MNG-8051 at 6/5/24 11:03 AM: -- *I* hav

[jira] [Commented] (MNG-8051) Combine dependency scopes instead of overriding

2024-06-05 Thread James Howe (Jira)
[ https://issues.apache.org/jira/browse/MNG-8051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17852391#comment-17852391 ] James Howe commented on MNG-8051: - **I** have no control over how these dependencies requir

[jira] [Commented] (MNG-8141) Model Builder should not rely on "validity" of processed model

2024-06-05 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-8141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17852392#comment-17852392 ] ASF GitHub Bot commented on MNG-8141: - cstamas commented on PR #1556: URL: https://gith

[jira] [Assigned] (MNG-8131) Property replacement in dependency pom no longer works

2024-06-05 Thread Tamas Cservenak (Jira)
[ https://issues.apache.org/jira/browse/MNG-8131?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamas Cservenak reassigned MNG-8131: Assignee: Tamas Cservenak > Property replacement in dependency pom no longer works > ---

[jira] [Commented] (MJAVADOC-656) Following redirects breaks valid links

2024-06-05 Thread Jira
[ https://issues.apache.org/jira/browse/MJAVADOC-656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17852401#comment-17852401 ] Robert Važan commented on MJAVADOC-656: --- [~michael-o]: Is that a per-link paramet

[I] Set `MAVEN_CMD_LINE_ARGS` env [maven-mvnd]

2024-06-05 Thread via GitHub
gsmet opened a new issue, #1008: URL: https://github.com/apache/maven-mvnd/issues/1008 First, thanks for this amazing project, it makes my Quarkus builds a lot faster. When using vanilla Maven, `MAVEN_CMD_LINE_ARGS` is set to whatever the Maven command line is. This allows you

Re: [PR] [MNG-8140] Always tell why model was discarded as "invalid" [maven]

2024-06-05 Thread via GitHub
cstamas commented on PR #1555: URL: https://github.com/apache/maven/pull/1555#issuecomment-2149622982 Lol, 2 ITs failed, one was due this PR that immediately revealed this issue: parent POM has no pom packaging (btw, fixed on master as mvn4 also spotted this): https://github.com/apache/

[jira] [Commented] (MNG-8140) When a model is discarded (by model builder) for whatever reason, show why it happened

2024-06-05 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-8140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17852409#comment-17852409 ] ASF GitHub Bot commented on MNG-8140: - cstamas commented on PR #1555: URL: https://gith

Re: [I] Set `MAVEN_CMD_LINE_ARGS` env [maven-mvnd]

2024-06-05 Thread via GitHub
gnodet commented on issue #1008: URL: https://github.com/apache/maven-mvnd/issues/1008#issuecomment-2149671036 Hey Guillaume, I'm not completely sure about this one. I suppose it could be added back in the mvnd branch supporting Maven 3.x, but that environment variable has been removed in

[jira] [Assigned] (SUREFIRE-1939) Build fails if java.home has <=2 path components

2024-06-05 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-1939?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov reassigned SUREFIRE-1939: Assignee: Michael Osipov (was: Slawomir Jaranowski) > Build fails if java.home

[jira] [Updated] (SUREFIRE-1939) Build fails if java.home has <=2 path components

2024-06-05 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-1939?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov updated SUREFIRE-1939: - Fix Version/s: 3.3.0 > Build fails if java.home has <=2 path components >

[PR] [SUREFIRE-1939] Build fails if java.home has <=2 path components [maven-surefire]

2024-06-05 Thread via GitHub
michael-o opened a new pull request, #743: URL: https://github.com/apache/maven-surefire/pull/743 Removes an invalid test which passes a JDK or JRE home to a method which expects the path to the Java executable. Therefore the invalid input leads to an exception. This closes #743

[jira] [Commented] (SUREFIRE-1939) Build fails if java.home has <=2 path components

2024-06-05 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-1939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17852423#comment-17852423 ] ASF GitHub Bot commented on SUREFIRE-1939: -- michael-o opened a new pull reque

[jira] [Commented] (SUREFIRE-1939) Build fails if java.home has <=2 path components

2024-06-05 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-1939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17852424#comment-17852424 ] ASF GitHub Bot commented on SUREFIRE-1939: -- michael-o commented on PR #387: U

Re: [PR] [SUREFIRE-1939] Fix NPE in SystemUtils.toJdkHomeFromJvmExec if java home has 2 components [maven-surefire]

2024-06-05 Thread via GitHub
michael-o commented on PR #387: URL: https://github.com/apache/maven-surefire/pull/387#issuecomment-2149685198 I have created a new PR addressing this: #743. @CMoH, your approach is appreciated, but it solves only the symptom, not the cause. Look at the signature: https://github.com/apache

Re: [PR] [SUREFIRE-1939] Build fails if java.home has <=2 path components [maven-surefire]

2024-06-05 Thread via GitHub
michael-o commented on PR #743: URL: https://github.com/apache/maven-surefire/pull/743#issuecomment-2149687879 @CMoH @slawekjaranowski -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

[jira] [Commented] (SUREFIRE-1939) Build fails if java.home has <=2 path components

2024-06-05 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-1939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17852425#comment-17852425 ] ASF GitHub Bot commented on SUREFIRE-1939: -- michael-o commented on PR #743: U

[jira] [Created] (MNG-8142) If JDK profile activator gets "invalid" JDK version for whatever reason, it chokes but does not tell why

2024-06-05 Thread Tamas Cservenak (Jira)
Tamas Cservenak created MNG-8142: Summary: If JDK profile activator gets "invalid" JDK version for whatever reason, it chokes but does not tell why Key: MNG-8142 URL: https://issues.apache.org/jira/browse/MNG-8142

[jira] [Assigned] (MNG-8142) If JDK profile activator gets "invalid" JDK version for whatever reason, it chokes but does not tell why

2024-06-05 Thread Tamas Cservenak (Jira)
[ https://issues.apache.org/jira/browse/MNG-8142?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamas Cservenak reassigned MNG-8142: Assignee: Tamas Cservenak > If JDK profile activator gets "invalid" JDK version for whatever

[PR] [MNG-8142] Hidden bug: JDK profile activator throww NumberFormatEx [maven]

2024-06-05 Thread via GitHub
cstamas opened a new pull request, #1557: URL: https://github.com/apache/maven/pull/1557 If property `java.version` is in unexpected format, the activator throws NumberFormatEx, that in turn, is caught and reported by DefaultProfileSelector w/o any cause. These should be cleanly repo

[jira] [Commented] (MNG-8142) If JDK profile activator gets "invalid" JDK version for whatever reason, it chokes but does not tell why

2024-06-05 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-8142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17852428#comment-17852428 ] ASF GitHub Bot commented on MNG-8142: - cstamas opened a new pull request, #1557: URL: h

Re: [PR] [MNG-8142] Hidden bug: JDK profile activator throww NumberFormatEx [maven]

2024-06-05 Thread via GitHub
cstamas commented on PR #1557: URL: https://github.com/apache/maven/pull/1557#issuecomment-2149764735 The IT w/ #1555 failed due this output (in debug, as IT uses Maven with -X): ``` [WARNING] The POM for org.apache.commons:commons-lang3:jar:3.8.1 is invalid, transitive dependencies (i

[jira] [Commented] (MNG-8142) If JDK profile activator gets "invalid" JDK version for whatever reason, it chokes but does not tell why

2024-06-05 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-8142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17852433#comment-17852433 ] ASF GitHub Bot commented on MNG-8142: - cstamas commented on PR #1557: URL: https://gith

Re: [PR] [MNG-8142] Hidden bug: JDK profile activator throww NumberFormatEx [maven]

2024-06-05 Thread via GitHub
michael-o commented on PR #1557: URL: https://github.com/apache/maven/pull/1557#issuecomment-2149767044 > If property `java.version` is in unexpected format, the activator throws NumberFormatEx, that in turn, is caught and reported by DefaultProfileSelector w/o any cause. > > These s

[jira] [Commented] (MNG-8142) If JDK profile activator gets "invalid" JDK version for whatever reason, it chokes but does not tell why

2024-06-05 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-8142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17852435#comment-17852435 ] ASF GitHub Bot commented on MNG-8142: - michael-o commented on PR #1557: URL: https://gi

Re: [PR] [MNG-8142] Hidden bug: JDK profile activator throww NumberFormatEx [maven]

2024-06-05 Thread via GitHub
cstamas commented on PR #1557: URL: https://github.com/apache/maven/pull/1557#issuecomment-2149772564 If this PR gets merged, the #1555 will become fixed as well, as there will be no more ERRORs, as NumberformatEx is reported here as model builder warnings with proper message. The fa

[jira] [Commented] (MNG-8142) If JDK profile activator gets "invalid" JDK version for whatever reason, it chokes but does not tell why

2024-06-05 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-8142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17852436#comment-17852436 ] ASF GitHub Bot commented on MNG-8142: - cstamas commented on PR #1557: URL: https://gith

[jira] [Updated] (MNG-8141) Model Builder should not rely on "validity" of processed model

2024-06-05 Thread Tamas Cservenak (Jira)
[ https://issues.apache.org/jira/browse/MNG-8141?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamas Cservenak updated MNG-8141: - Description: ModelBuilder is component building models (POM + interpolating + parent inheritance a

Re: [PR] Null implementations shall return null [maven-resolver]

2024-06-05 Thread via GitHub
michael-o commented on PR #113: URL: https://github.com/apache/maven-resolver/pull/113#issuecomment-2149841456 Would you rename them for 2.0.0? That feels natural... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[jira] [Updated] (MNG-8066) Maven hangs on self-referencing exceptions

2024-06-05 Thread Tamas Cservenak (Jira)
[ https://issues.apache.org/jira/browse/MNG-8066?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamas Cservenak updated MNG-8066: - Fix Version/s: 4.0.0 > Maven hangs on self-referencing exceptions > ---

[jira] [Updated] (MNG-8116) Plugin configuration can randomly fail in case of method overloading as it doesn't take into account implementation attribute

2024-06-05 Thread Tamas Cservenak (Jira)
[ https://issues.apache.org/jira/browse/MNG-8116?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamas Cservenak updated MNG-8116: - Fix Version/s: 4.0.0 > Plugin configuration can randomly fail in case of method overloading as it

[jira] [Assigned] (MNG-8066) Maven hangs on self-referencing exceptions

2024-06-05 Thread Tamas Cservenak (Jira)
[ https://issues.apache.org/jira/browse/MNG-8066?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamas Cservenak reassigned MNG-8066: Assignee: Tamas Cservenak > Maven hangs on self-referencing exceptions > ---

[jira] [Commented] (MNG-8066) Maven hangs on self-referencing exceptions

2024-06-05 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-8066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17852448#comment-17852448 ] ASF GitHub Bot commented on MNG-8066: - cstamas opened a new pull request, #1558: URL: h

Re: [PR] Null implementations shall return null [maven-resolver]

2024-06-05 Thread via GitHub
cstamas commented on PR #113: URL: https://github.com/apache/maven-resolver/pull/113#issuecomment-2149944881 Created https://issues.apache.org/jira/browse/MRESOLVER-565 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use t

  1   2   3   >