Re: [PR] [MNG-8061] Maven: Require Java 17 [maven-parent]

2024-02-28 Thread via GitHub
olamy commented on PR #165: URL: https://github.com/apache/maven-parent/pull/165#issuecomment-1968578448 > We can not bump JDK in parent ... it will have an impact for all plugins ... but plugins should stay at JDK 8 plugins parent can have ``` 8 ${javaVersion}

Re: [PR] Automatic discovery of JDK toolchains [maven-toolchains-plugin]

2024-02-28 Thread via GitHub
gnodet commented on code in PR #14: URL: https://github.com/apache/maven-toolchains-plugin/pull/14#discussion_r1505684259 ## src/main/java/org/apache/maven/plugins/toolchain/jdk/DisplayDiscoveredJdkToolchainsMojo.java: ## @@ -0,0 +1,51 @@ +/* + * Licensed to the Apache Software

[jira] [Commented] (MGPG-92) `--pinentry-mode error` cannot be used with gpg-agent "standard" socket

2024-02-28 Thread Nick Dimiduk (Jira)
[ https://issues.apache.org/jira/browse/MGPG-92?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17821594#comment-17821594 ] Nick Dimiduk commented on MGPG-92: -- I think that I filed this backwards. The extra socket h

[jira] [Updated] (MGPG-92) `--pinentry-mode error` cannot be used with gpg-agent "extra" socket

2024-02-28 Thread Nick Dimiduk (Jira)
[ https://issues.apache.org/jira/browse/MGPG-92?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nick Dimiduk updated MGPG-92: - Summary: `--pinentry-mode error` cannot be used with gpg-agent "extra" socket (was: `--pinentry-mode error`

Re: [PR] Automatic discovery of JDK toolchains [maven-toolchains-plugin]

2024-02-28 Thread via GitHub
gnodet commented on code in PR #14: URL: https://github.com/apache/maven-toolchains-plugin/pull/14#discussion_r1505687003 ## src/main/java/org/apache/maven/plugins/toolchain/jdk/DisplayDiscoveredJdkToolchainsMojo.java: ## @@ -0,0 +1,51 @@ +/* + * Licensed to the Apache Software

[jira] [Updated] (MGPG-92) `--pinentry-mode error` cannot be used with gpg-agent "extra" socket

2024-02-28 Thread Nick Dimiduk (Jira)
[ https://issues.apache.org/jira/browse/MGPG-92?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nick Dimiduk updated MGPG-92: - Description: Over on HBASE-27312, we found an issue in our release automation, which relies on using this pl

[jira] [Created] (MTOOLCHAINS-49) Automatic discovery of JDK toolchains

2024-02-28 Thread Guillaume Nodet (Jira)
Guillaume Nodet created MTOOLCHAINS-49: -- Summary: Automatic discovery of JDK toolchains Key: MTOOLCHAINS-49 URL: https://issues.apache.org/jira/browse/MTOOLCHAINS-49 Project: Maven Toolchains Plug

Re: [PR] [MNG-5726] Support regular expression matching in profile activation for [maven]

2024-02-28 Thread via GitHub
gnodet commented on PR #1421: URL: https://github.com/apache/maven/pull/1421#issuecomment-1968685875 > @gnodet Is there general support for matching globs built into Java (apart from Files NIO)? I haven't found anything and quick googling revealed https://stackoverflow.com/questions/1247772

[jira] [Commented] (MNG-5726) Update OS Activation To Allow Wildcards In OS Version

2024-02-28 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-5726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17821603#comment-17821603 ] ASF GitHub Bot commented on MNG-5726: - gnodet commented on PR #1421: URL: https://githu

Re: [PR] [MNG-5726] Support regular expression matching in profile activation for [maven]

2024-02-28 Thread via GitHub
kwin commented on PR #1421: URL: https://github.com/apache/maven/pull/1421#issuecomment-1968756016 @gnodet Interesting. We can support `glob:` later once that refactoring is done. For now I would go with just `regex:`. Any concerns with that? -- This is an automated message from the Apach

[jira] [Commented] (MNG-5726) Update OS Activation To Allow Wildcards In OS Version

2024-02-28 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-5726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17821613#comment-17821613 ] ASF GitHub Bot commented on MNG-5726: - kwin commented on PR #1421: URL: https://github.

Re: [PR] [MTOOLCHAINS-49] Automatic discovery of JDK toolchains [maven-toolchains-plugin]

2024-02-28 Thread via GitHub
gnodet commented on PR #14: URL: https://github.com/apache/maven-toolchains-plugin/pull/14#issuecomment-1968843474 > Personally i use JAVA${major}_HOME and wire it in pom in executable or jvm properties today. > > But what I dont like in this pr is that it adds complexity to the com

[jira] [Commented] (MTOOLCHAINS-49) Automatic discovery of JDK toolchains

2024-02-28 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MTOOLCHAINS-49?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17821626#comment-17821626 ] ASF GitHub Bot commented on MTOOLCHAINS-49: --- gnodet commented on PR #14: UR

Re: [PR] [MTOOLCHAINS-49] Automatic discovery of JDK toolchains [maven-toolchains-plugin]

2024-02-28 Thread via GitHub
elharo commented on code in PR #14: URL: https://github.com/apache/maven-toolchains-plugin/pull/14#discussion_r1505841944 ## src/main/java/org/apache/maven/plugins/toolchain/jdk/GenerateJdkToolchainsXmlMojo.java: ## @@ -0,0 +1,75 @@ +/* + * Licensed to the Apache Software Found

[jira] [Commented] (MTOOLCHAINS-49) Automatic discovery of JDK toolchains

2024-02-28 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MTOOLCHAINS-49?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17821630#comment-17821630 ] ASF GitHub Bot commented on MTOOLCHAINS-49: --- elharo commented on code in PR

Re: [PR] [WIP] Add new goal add-toolchain for adding new toolchains dynamically [maven-toolchains-plugin]

2024-02-28 Thread via GitHub
gnodet commented on PR #7: URL: https://github.com/apache/maven-toolchains-plugin/pull/7#issuecomment-1968865439 I think this is superseded by #14 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

Re: [PR] [WIP] Add new goal add-toolchain for adding new toolchains dynamically [maven-toolchains-plugin]

2024-02-28 Thread via GitHub
gnodet closed pull request #7: [WIP] Add new goal add-toolchain for adding new toolchains dynamically URL: https://github.com/apache/maven-toolchains-plugin/pull/7 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

[jira] [Created] (MTOOLCHAINS-50) Upgrade to maven parent 41

2024-02-28 Thread Guillaume Nodet (Jira)
Guillaume Nodet created MTOOLCHAINS-50: -- Summary: Upgrade to maven parent 41 Key: MTOOLCHAINS-50 URL: https://issues.apache.org/jira/browse/MTOOLCHAINS-50 Project: Maven Toolchains Plugin

Re: [PR] [MTOOLCHAINS-50] Update parent pom to 41 [maven-toolchains-plugin]

2024-02-28 Thread via GitHub
gnodet commented on PR #19: URL: https://github.com/apache/maven-toolchains-plugin/pull/19#issuecomment-1968881245 I'm merging this one as it blocks other PRs. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

[jira] [Commented] (MTOOLCHAINS-50) Upgrade to maven parent 41

2024-02-28 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MTOOLCHAINS-50?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17821636#comment-17821636 ] ASF GitHub Bot commented on MTOOLCHAINS-50: --- gnodet commented on PR #19: UR

Re: [PR] [MTOOLCHAINS-50] Update parent pom to 41 [maven-toolchains-plugin]

2024-02-28 Thread via GitHub
gnodet merged PR #19: URL: https://github.com/apache/maven-toolchains-plugin/pull/19 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@

[PR] Bump org.apache.maven:maven-core from 3.2.5 to 3.8.1 [maven-toolchains-plugin]

2024-02-28 Thread via GitHub
dependabot[bot] opened a new pull request, #21: URL: https://github.com/apache/maven-toolchains-plugin/pull/21 Bumps [org.apache.maven:maven-core](https://github.com/apache/maven) from 3.2.5 to 3.8.1. Commits https://github.com/apache/maven/commit/05c21c65bdfed0f71a2f2ada8b84da

[jira] [Assigned] (MTOOLCHAINS-50) Upgrade to maven parent 41

2024-02-28 Thread Guillaume Nodet (Jira)
[ https://issues.apache.org/jira/browse/MTOOLCHAINS-50?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guillaume Nodet reassigned MTOOLCHAINS-50: -- Assignee: Elliotte Rusty Harold > Upgrade to maven parent 41 > ---

[jira] [Commented] (MTOOLCHAINS-50) Upgrade to maven parent 41

2024-02-28 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MTOOLCHAINS-50?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17821637#comment-17821637 ] ASF GitHub Bot commented on MTOOLCHAINS-50: --- gnodet merged PR #19: URL: htt

[jira] [Closed] (MTOOLCHAINS-50) Upgrade to maven parent 41

2024-02-28 Thread Guillaume Nodet (Jira)
[ https://issues.apache.org/jira/browse/MTOOLCHAINS-50?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guillaume Nodet closed MTOOLCHAINS-50. -- Resolution: Fixed > Upgrade to maven parent 41 > -- > >

Re: [PR] Bump org.apache.maven:maven-core from 3.2.5 to 3.8.1 [maven-toolchains-plugin]

2024-02-28 Thread via GitHub
gnodet commented on PR #21: URL: https://github.com/apache/maven-toolchains-plugin/pull/21#issuecomment-1968886933 Superseded by #20 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] Bump org.apache.maven:maven-core from 3.2.5 to 3.8.1 [maven-toolchains-plugin]

2024-02-28 Thread via GitHub
gnodet closed pull request #21: Bump org.apache.maven:maven-core from 3.2.5 to 3.8.1 URL: https://github.com/apache/maven-toolchains-plugin/pull/21 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

Re: [PR] Bump org.apache.maven:maven-core from 3.2.5 to 3.8.1 [maven-toolchains-plugin]

2024-02-28 Thread via GitHub
dependabot[bot] commented on PR #21: URL: https://github.com/apache/maven-toolchains-plugin/pull/21#issuecomment-1968886997 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor

Re: [PR] [MTOOLCHAINS-49] Automatic discovery of JDK toolchains [maven-toolchains-plugin]

2024-02-28 Thread via GitHub
gnodet commented on code in PR #14: URL: https://github.com/apache/maven-toolchains-plugin/pull/14#discussion_r1505884347 ## src/main/java/org/apache/maven/plugins/toolchain/jdk/ToolchainDiscoverer.java: ## @@ -0,0 +1,433 @@ +/* + * Licensed to the Apache Software Foundation (A

[jira] [Commented] (MTOOLCHAINS-49) Automatic discovery of JDK toolchains

2024-02-28 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MTOOLCHAINS-49?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17821642#comment-17821642 ] ASF GitHub Bot commented on MTOOLCHAINS-49: --- gnodet commented on code in PR

Re: [PR] [MTOOLCHAINS-49] Automatic discovery of JDK toolchains [maven-toolchains-plugin]

2024-02-28 Thread via GitHub
gnodet commented on code in PR #14: URL: https://github.com/apache/maven-toolchains-plugin/pull/14#discussion_r1505884688 ## src/main/java/org/apache/maven/plugins/toolchain/jdk/ToolchainDiscoverer.java: ## @@ -0,0 +1,433 @@ +/* + * Licensed to the Apache Software Foundation (A

[jira] [Commented] (MTOOLCHAINS-49) Automatic discovery of JDK toolchains

2024-02-28 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MTOOLCHAINS-49?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17821643#comment-17821643 ] ASF GitHub Bot commented on MTOOLCHAINS-49: --- gnodet commented on code in PR

Re: [PR] [MTOOLCHAINS-49] Automatic discovery of JDK toolchains [maven-toolchains-plugin]

2024-02-28 Thread via GitHub
gnodet commented on code in PR #14: URL: https://github.com/apache/maven-toolchains-plugin/pull/14#discussion_r1505887675 ## src/main/java/org/apache/maven/plugins/toolchain/jdk/GenerateJdkToolchainsXmlMojo.java: ## @@ -0,0 +1,75 @@ +/* + * Licensed to the Apache Software Found

Re: [PR] [MTOOLCHAINS-49] Automatic discovery of JDK toolchains [maven-toolchains-plugin]

2024-02-28 Thread via GitHub
gnodet commented on code in PR #14: URL: https://github.com/apache/maven-toolchains-plugin/pull/14#discussion_r1505887675 ## src/main/java/org/apache/maven/plugins/toolchain/jdk/GenerateJdkToolchainsXmlMojo.java: ## @@ -0,0 +1,75 @@ +/* + * Licensed to the Apache Software Found

[jira] [Commented] (MTOOLCHAINS-49) Automatic discovery of JDK toolchains

2024-02-28 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MTOOLCHAINS-49?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17821644#comment-17821644 ] ASF GitHub Bot commented on MTOOLCHAINS-49: --- gnodet commented on code in PR

[jira] [Commented] (MTOOLCHAINS-49) Automatic discovery of JDK toolchains

2024-02-28 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MTOOLCHAINS-49?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17821645#comment-17821645 ] ASF GitHub Bot commented on MTOOLCHAINS-49: --- gnodet commented on code in PR

Re: [PR] [MTOOLCHAINS-49] Automatic discovery of JDK toolchains [maven-toolchains-plugin]

2024-02-28 Thread via GitHub
gnodet commented on code in PR #14: URL: https://github.com/apache/maven-toolchains-plugin/pull/14#discussion_r1505898831 ## src/main/java/org/apache/maven/plugins/toolchain/jdk/GenerateJdkToolchainsXmlMojo.java: ## @@ -0,0 +1,75 @@ +/* + * Licensed to the Apache Software Found

[jira] [Commented] (MTOOLCHAINS-49) Automatic discovery of JDK toolchains

2024-02-28 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MTOOLCHAINS-49?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17821646#comment-17821646 ] ASF GitHub Bot commented on MTOOLCHAINS-49: --- gnodet commented on code in PR

Re: [PR] [MTOOLCHAINS-49] Automatic discovery of JDK toolchains [maven-toolchains-plugin]

2024-02-28 Thread via GitHub
gnodet commented on code in PR #14: URL: https://github.com/apache/maven-toolchains-plugin/pull/14#discussion_r1505904456 ## src/main/java/org/apache/maven/plugins/toolchain/jdk/ToolchainDiscoverer.java: ## @@ -0,0 +1,433 @@ +/* + * Licensed to the Apache Software Foundation (A

[jira] [Commented] (MTOOLCHAINS-49) Automatic discovery of JDK toolchains

2024-02-28 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MTOOLCHAINS-49?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17821649#comment-17821649 ] ASF GitHub Bot commented on MTOOLCHAINS-49: --- gnodet commented on code in PR

Re: [PR] [MTOOLCHAINS-49] Automatic discovery of JDK toolchains [maven-toolchains-plugin]

2024-02-28 Thread via GitHub
elharo commented on code in PR #14: URL: https://github.com/apache/maven-toolchains-plugin/pull/14#discussion_r1505913934 ## src/main/java/org/apache/maven/plugins/toolchain/jdk/GenerateJdkToolchainsXmlMojo.java: ## @@ -0,0 +1,75 @@ +/* + * Licensed to the Apache Software Found

Re: [PR] [MTOOLCHAINS-49] Automatic discovery of JDK toolchains [maven-toolchains-plugin]

2024-02-28 Thread via GitHub
gnodet commented on code in PR #14: URL: https://github.com/apache/maven-toolchains-plugin/pull/14#discussion_r1505915345 ## src/main/java/org/apache/maven/plugins/toolchain/jdk/ToolchainDiscoverer.java: ## @@ -0,0 +1,433 @@ +/* + * Licensed to the Apache Software Foundation (A

[jira] [Commented] (MTOOLCHAINS-49) Automatic discovery of JDK toolchains

2024-02-28 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MTOOLCHAINS-49?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17821654#comment-17821654 ] ASF GitHub Bot commented on MTOOLCHAINS-49: --- elharo commented on code in PR

[jira] [Commented] (MTOOLCHAINS-49) Automatic discovery of JDK toolchains

2024-02-28 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MTOOLCHAINS-49?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17821655#comment-17821655 ] ASF GitHub Bot commented on MTOOLCHAINS-49: --- gnodet commented on code in PR

Re: [PR] [MTOOLCHAINS-49] Automatic discovery of JDK toolchains [maven-toolchains-plugin]

2024-02-28 Thread via GitHub
elharo commented on code in PR #14: URL: https://github.com/apache/maven-toolchains-plugin/pull/14#discussion_r1505919907 ## src/main/java/org/apache/maven/plugins/toolchain/jdk/ToolchainDiscoverer.java: ## @@ -0,0 +1,433 @@ +/* + * Licensed to the Apache Software Foundation (A

[jira] [Commented] (MTOOLCHAINS-49) Automatic discovery of JDK toolchains

2024-02-28 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MTOOLCHAINS-49?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17821657#comment-17821657 ] ASF GitHub Bot commented on MTOOLCHAINS-49: --- elharo commented on code in PR

Re: [PR] [MTOOLCHAINS-49] Automatic discovery of JDK toolchains [maven-toolchains-plugin]

2024-02-28 Thread via GitHub
gnodet commented on code in PR #14: URL: https://github.com/apache/maven-toolchains-plugin/pull/14#discussion_r1505929533 ## src/main/java/org/apache/maven/plugins/toolchain/jdk/ToolchainDiscoverer.java: ## @@ -0,0 +1,433 @@ +/* + * Licensed to the Apache Software Foundation (A

[jira] [Commented] (MTOOLCHAINS-49) Automatic discovery of JDK toolchains

2024-02-28 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MTOOLCHAINS-49?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17821659#comment-17821659 ] ASF GitHub Bot commented on MTOOLCHAINS-49: --- gnodet commented on code in PR

Re: [PR] [MTOOLCHAINS-49] Automatic discovery of JDK toolchains [maven-toolchains-plugin]

2024-02-28 Thread via GitHub
gnodet commented on code in PR #14: URL: https://github.com/apache/maven-toolchains-plugin/pull/14#discussion_r1505932925 ## src/main/java/org/apache/maven/plugins/toolchain/jdk/ToolchainDiscoverer.java: ## @@ -0,0 +1,433 @@ +/* + * Licensed to the Apache Software Foundation (A

[jira] [Commented] (MTOOLCHAINS-49) Automatic discovery of JDK toolchains

2024-02-28 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MTOOLCHAINS-49?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17821660#comment-17821660 ] ASF GitHub Bot commented on MTOOLCHAINS-49: --- gnodet commented on code in PR

Re: [PR] [MTOOLCHAINS-49] Automatic discovery of JDK toolchains [maven-toolchains-plugin]

2024-02-28 Thread via GitHub
gnodet commented on code in PR #14: URL: https://github.com/apache/maven-toolchains-plugin/pull/14#discussion_r1505950697 ## src/main/java/org/apache/maven/plugins/toolchain/jdk/ToolchainDiscoverer.java: ## @@ -0,0 +1,433 @@ +/* + * Licensed to the Apache Software Foundation (A

[jira] [Commented] (MTOOLCHAINS-49) Automatic discovery of JDK toolchains

2024-02-28 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MTOOLCHAINS-49?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17821666#comment-17821666 ] ASF GitHub Bot commented on MTOOLCHAINS-49: --- gnodet commented on code in PR

Re: [PR] [MTOOLCHAINS-51] Upgrade to maven 3.9.6 at compile time and 3.6.3 at runtime [maven-toolchains-plugin]

2024-02-28 Thread via GitHub
gnodet merged PR #20: URL: https://github.com/apache/maven-toolchains-plugin/pull/20 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@

[jira] [Commented] (MTOOLCHAINS-51) Upgrade to maven 3.9.6 at compile time and 3.6.3 at runtime

2024-02-28 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MTOOLCHAINS-51?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17821667#comment-17821667 ] ASF GitHub Bot commented on MTOOLCHAINS-51: --- gnodet merged PR #20: URL: htt

[jira] [Created] (MTOOLCHAINS-51) Upgrade to maven 3.9.6 at compile time and 3.6.3 at runtime

2024-02-28 Thread Guillaume Nodet (Jira)
Guillaume Nodet created MTOOLCHAINS-51: -- Summary: Upgrade to maven 3.9.6 at compile time and 3.6.3 at runtime Key: MTOOLCHAINS-51 URL: https://issues.apache.org/jira/browse/MTOOLCHAINS-51 Project

[jira] [Closed] (MTOOLCHAINS-51) Upgrade to maven 3.9.6 at compile time and 3.6.3 at runtime

2024-02-28 Thread Guillaume Nodet (Jira)
[ https://issues.apache.org/jira/browse/MTOOLCHAINS-51?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guillaume Nodet closed MTOOLCHAINS-51. -- Resolution: Fixed > Upgrade to maven 3.9.6 at compile time and 3.6.3 at runtime > -

Re: [PR] [MTOOLCHAINS-51] Upgrade to maven 3.9.6 at compile time and 3.6.3 at runtime [maven-toolchains-plugin]

2024-02-28 Thread via GitHub
elharo commented on code in PR #20: URL: https://github.com/apache/maven-toolchains-plugin/pull/20#discussion_r1505967973 ## pom.xml: ## @@ -68,7 +68,7 @@ under the License. 8 -3.2.5 +3.9.6 Review Comment: I don't remember noticing this. If I had I would

[jira] [Commented] (MTOOLCHAINS-51) Upgrade to maven 3.9.6 at compile time and 3.6.3 at runtime

2024-02-28 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MTOOLCHAINS-51?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17821669#comment-17821669 ] ASF GitHub Bot commented on MTOOLCHAINS-51: --- elharo commented on code in PR

Re: [PR] [MNG-5726] Support regular expression matching in profile activation for [maven]

2024-02-28 Thread via GitHub
gnodet commented on PR #1421: URL: https://github.com/apache/maven/pull/1421#issuecomment-1969383944 > @gnodet Interesting. We can support `glob:` later once that refactoring is done. For now I would go with just `regex:`. Any concerns with that? None... -- This is an automated mes

[jira] [Commented] (MNG-5726) Update OS Activation To Allow Wildcards In OS Version

2024-02-28 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-5726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17821755#comment-17821755 ] ASF GitHub Bot commented on MNG-5726: - gnodet commented on PR #1421: URL: https://githu

Re: [PR] [MNG-5726] Support regular expression matching in profile activation for [maven]

2024-02-28 Thread via GitHub
gnodet commented on code in PR #1421: URL: https://github.com/apache/maven/pull/1421#discussion_r1506263168 ## maven-model-builder/src/main/java/org/apache/maven/model/profile/activation/OperatingSystemProfileActivator.java: ## @@ -53,17 +57,21 @@ public boolean isActive(Profile

[jira] [Commented] (MNG-5726) Update OS Activation To Allow Wildcards In OS Version

2024-02-28 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-5726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17821760#comment-17821760 ] ASF GitHub Bot commented on MNG-5726: - gnodet commented on code in PR #1421: URL: https

Re: [PR] [MNG-5726] Support regular expression matching in profile activation for [maven]

2024-02-28 Thread via GitHub
gnodet commented on code in PR #1421: URL: https://github.com/apache/maven/pull/1421#discussion_r1506263168 ## maven-model-builder/src/main/java/org/apache/maven/model/profile/activation/OperatingSystemProfileActivator.java: ## @@ -53,17 +57,21 @@ public boolean isActive(Profile

[jira] [Commented] (MNG-5726) Update OS Activation To Allow Wildcards In OS Version

2024-02-28 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-5726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17821762#comment-17821762 ] ASF GitHub Bot commented on MNG-5726: - gnodet commented on code in PR #1421: URL: https

Re: [PR] [MNG-5726] Support regular expression matching in profile activation for [maven]

2024-02-28 Thread via GitHub
kwin commented on code in PR #1421: URL: https://github.com/apache/maven/pull/1421#discussion_r1506293992 ## maven-model-builder/src/main/java/org/apache/maven/model/profile/activation/OperatingSystemProfileActivator.java: ## @@ -53,17 +57,21 @@ public boolean isActive(Profile p

[jira] [Commented] (MNG-5726) Update OS Activation To Allow Wildcards In OS Version

2024-02-28 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-5726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17821771#comment-17821771 ] ASF GitHub Bot commented on MNG-5726: - kwin commented on code in PR #1421: URL: https:/

Re: [PR] [MNG-5726] Support regular expression matching in profile activation for [maven]

2024-02-28 Thread via GitHub
kwin commented on code in PR #1421: URL: https://github.com/apache/maven/pull/1421#discussion_r1506296544 ## maven-model-builder/src/main/java/org/apache/maven/model/profile/activation/OperatingSystemProfileActivator.java: ## @@ -53,17 +57,21 @@ public boolean isActive(Profile p

[jira] [Commented] (MNG-5726) Update OS Activation To Allow Wildcards In OS Version

2024-02-28 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-5726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17821775#comment-17821775 ] ASF GitHub Bot commented on MNG-5726: - kwin commented on code in PR #1421: URL: https:/

Re: [PR] [MNG-5726] Support regular expression matching in profile activation for [maven]

2024-02-28 Thread via GitHub
kwin merged PR #1421: URL: https://github.com/apache/maven/pull/1421 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

[jira] [Commented] (MNG-5726) Update OS Activation To Allow Wildcards In OS Version

2024-02-28 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-5726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17821800#comment-17821800 ] ASF GitHub Bot commented on MNG-5726: - kwin merged PR #1421: URL: https://github.com/ap

[jira] [Resolved] (MNG-5726) Update OS Activation To Allow Wildcards In OS Version

2024-02-28 Thread Konrad Windszus (Jira)
[ https://issues.apache.org/jira/browse/MNG-5726?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konrad Windszus resolved MNG-5726. -- Resolution: Fixed > Update OS Activation To Allow Wildcards In OS Version > -

[jira] [Updated] (MNG-5726) Update OS Activation To Allow Wildcards In OS Version

2024-02-28 Thread Konrad Windszus (Jira)
[ https://issues.apache.org/jira/browse/MNG-5726?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Konrad Windszus updated MNG-5726: - Fix Version/s: 4.0.0 4.0.0-alpha-13 > Update OS Activation To Allow Wildcards In

[PR] MNG-5762 (backport for Maven 3.9) [maven]

2024-02-28 Thread via GitHub
kwin opened a new pull request, #1431: URL: https://github.com/apache/maven/pull/1431 Following this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MNG) filed for the ch

[jira] [Commented] (MNG-5762) execution request populate ignores plugin repositories

2024-02-28 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-5762?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17821832#comment-17821832 ] ASF GitHub Bot commented on MNG-5762: - kwin opened a new pull request, #1431: URL: http

[PR] [MRESOLVER-301] Addendum [maven-resolver]

2024-02-28 Thread via GitHub
cstamas opened a new pull request, #436: URL: https://github.com/apache/maven-resolver/pull/436 Just simplify, cleanup things, and use fingerprint instead of phased out keyID. --- https://issues.apache.org/jira/browse/MRESOLVER-301 -- This is an automated message from the Ap

[jira] [Commented] (MRESOLVER-301) Artifact Generators

2024-02-28 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MRESOLVER-301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17821870#comment-17821870 ] ASF GitHub Bot commented on MRESOLVER-301: -- cstamas opened a new pull request

Re: [PR] Expand JDK toolchain docs [maven-toolchains-plugin]

2024-02-28 Thread via GitHub
elharo commented on PR #18: URL: https://github.com/apache/maven-toolchains-plugin/pull/18#issuecomment-1970077600 PTAL. parent is updated and all tests pass -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

Re: [PR] Use v4 api to resolve project dependencies [maven]

2024-02-28 Thread via GitHub
gnodet merged PR #1409: URL: https://github.com/apache/maven/pull/1409 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.o

Re: [PR] Use SessionData to store ProjectIndex [maven]

2024-02-28 Thread via GitHub
gnodet merged PR #1423: URL: https://github.com/apache/maven/pull/1423 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.o

Re: [PR] Fix concurrent cache access [maven]

2024-02-28 Thread via GitHub
gnodet merged PR #1425: URL: https://github.com/apache/maven/pull/1425 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.o

Re: [PR] Extract JLine support into its own module [maven]

2024-02-28 Thread via GitHub
gnodet merged PR #1426: URL: https://github.com/apache/maven/pull/1426 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.o

Re: [PR] Add a SpiService marker interface [maven]

2024-02-28 Thread via GitHub
gnodet merged PR #1427: URL: https://github.com/apache/maven/pull/1427 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.o

Re: [PR] Missing annotations on api [maven]

2024-02-28 Thread via GitHub
gnodet merged PR #1428: URL: https://github.com/apache/maven/pull/1428 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.o

Re: [PR] Make LifecycleStarter pluggable [maven]

2024-02-28 Thread via GitHub
gnodet merged PR #1424: URL: https://github.com/apache/maven/pull/1424 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.o

Re: [PR] [MNG-8015] Control the type of path where each dependency can be placed [maven]

2024-02-28 Thread via GitHub
gnodet commented on PR #1401: URL: https://github.com/apache/maven/pull/1401#issuecomment-1970141297 Should we go ahead and merge that one ? It does not really affects the current behaviour, so if we even find something missing, we can still fix it later... -- This is an automated messag

[jira] [Commented] (MNG-8015) Control the type of path where each dependency can be placed

2024-02-28 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-8015?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17821899#comment-17821899 ] ASF GitHub Bot commented on MNG-8015: - gnodet commented on PR #1401: URL: https://githu