[jira] [Assigned] (MRESOLVER-382) Define local outgoing (bind) address

2023-07-05 Thread Benjamin Marwell (Jira)
[ https://issues.apache.org/jira/browse/MRESOLVER-382?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Marwell reassigned MRESOLVER-382: -- Assignee: Benjamin Marwell > Define local outgoing (bind) address > ---

[jira] [Commented] (MRESOLVER-382) Define local outgoing (bind) address

2023-07-05 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MRESOLVER-382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17740040#comment-17740040 ] ASF GitHub Bot commented on MRESOLVER-382: -- bmarwell opened a new pull reques

[GitHub] [maven-resolver] michael-o commented on a diff in pull request #315: [MRESOLVER-382] allow setting outgoing interface

2023-07-05 Thread via GitHub
michael-o commented on code in PR #315: URL: https://github.com/apache/maven-resolver/pull/315#discussion_r1252657965 ## maven-resolver-transport-http/src/main/java/org/eclipse/aether/transport/http/HttpTransporter.java: ## @@ -295,6 +300,20 @@ final class HttpTransporter extend

[jira] [Commented] (MRESOLVER-382) Define local outgoing (bind) address

2023-07-05 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MRESOLVER-382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17740049#comment-17740049 ] ASF GitHub Bot commented on MRESOLVER-382: -- michael-o commented on code in PR

[GitHub] [maven-resolver] bmarwell commented on a diff in pull request #315: [MRESOLVER-382] allow setting outgoing interface

2023-07-05 Thread via GitHub
bmarwell commented on code in PR #315: URL: https://github.com/apache/maven-resolver/pull/315#discussion_r1252667551 ## maven-resolver-transport-http/src/main/java/org/eclipse/aether/transport/http/HttpTransporter.java: ## @@ -295,6 +300,20 @@ final class HttpTransporter extends

[jira] [Commented] (MRESOLVER-382) Define local outgoing (bind) address

2023-07-05 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MRESOLVER-382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17740052#comment-17740052 ] ASF GitHub Bot commented on MRESOLVER-382: -- bmarwell commented on code in PR

[GitHub] [maven-resolver] michael-o commented on a diff in pull request #315: [MRESOLVER-382] allow setting outgoing interface

2023-07-05 Thread via GitHub
michael-o commented on code in PR #315: URL: https://github.com/apache/maven-resolver/pull/315#discussion_r1252670683 ## maven-resolver-transport-http/src/main/java/org/eclipse/aether/transport/http/HttpTransporter.java: ## @@ -295,6 +300,20 @@ final class HttpTransporter extend

[jira] [Commented] (MRESOLVER-382) Define local outgoing (bind) address

2023-07-05 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MRESOLVER-382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17740054#comment-17740054 ] ASF GitHub Bot commented on MRESOLVER-382: -- michael-o commented on code in PR

[GitHub] [maven-resolver] bmarwell commented on a diff in pull request #315: [MRESOLVER-382] allow setting outgoing interface

2023-07-05 Thread via GitHub
bmarwell commented on code in PR #315: URL: https://github.com/apache/maven-resolver/pull/315#discussion_r1252673255 ## maven-resolver-transport-http/src/main/java/org/eclipse/aether/transport/http/HttpTransporter.java: ## @@ -295,6 +300,20 @@ final class HttpTransporter extends

[GitHub] [maven] gnodet commented on a diff in pull request #1193: Improve API doc for ArtifactHandler

2023-07-05 Thread via GitHub
gnodet commented on code in PR #1193: URL: https://github.com/apache/maven/pull/1193#discussion_r1252673778 ## maven-artifact/src/main/java/org/apache/maven/artifact/handler/ArtifactHandler.java: ## @@ -41,7 +42,7 @@ public interface ArtifactHandler { String getDirectory();

[jira] [Commented] (MRESOLVER-382) Define local outgoing (bind) address

2023-07-05 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MRESOLVER-382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17740055#comment-17740055 ] ASF GitHub Bot commented on MRESOLVER-382: -- bmarwell commented on code in PR

[GitHub] [maven-resolver] michael-o commented on a diff in pull request #315: [MRESOLVER-382] allow setting outgoing interface

2023-07-05 Thread via GitHub
michael-o commented on code in PR #315: URL: https://github.com/apache/maven-resolver/pull/315#discussion_r1252684740 ## maven-resolver-transport-http/src/main/java/org/eclipse/aether/transport/http/HttpTransporter.java: ## @@ -295,6 +300,20 @@ final class HttpTransporter extend

[jira] [Commented] (MRESOLVER-382) Define local outgoing (bind) address

2023-07-05 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MRESOLVER-382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17740061#comment-17740061 ] ASF GitHub Bot commented on MRESOLVER-382: -- michael-o commented on code in PR

[GitHub] [maven-resolver] michael-o commented on a diff in pull request #315: [MRESOLVER-382] allow setting outgoing interface

2023-07-05 Thread via GitHub
michael-o commented on code in PR #315: URL: https://github.com/apache/maven-resolver/pull/315#discussion_r1252831609 ## maven-resolver-transport-http/src/main/java/org/eclipse/aether/transport/http/HttpTransporter.java: ## @@ -295,6 +300,20 @@ final class HttpTransporter extend

[jira] [Commented] (MRESOLVER-382) Define local outgoing (bind) address

2023-07-05 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MRESOLVER-382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17740128#comment-17740128 ] ASF GitHub Bot commented on MRESOLVER-382: -- michael-o commented on code in PR

[GitHub] [maven-enforcer] kwin merged pull request #278: Clarify availability of AbstractEnforcerRule

2023-07-05 Thread via GitHub
kwin merged PR #278: URL: https://github.com/apache/maven-enforcer/pull/278 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apa

[jira] [Commented] (MNGSITE-521) Define dependency type

2023-07-05 Thread Elliotte Rusty Harold (Jira)
[ https://issues.apache.org/jira/browse/MNGSITE-521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17740162#comment-17740162 ] Elliotte Rusty Harold commented on MNGSITE-521: --- I'm still not sure myself

[jira] [Updated] (MNGSITE-521) Define dependency type

2023-07-05 Thread Elliotte Rusty Harold (Jira)
[ https://issues.apache.org/jira/browse/MNGSITE-521?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Elliotte Rusty Harold updated MNGSITE-521: -- Description: At no point I can find do we ever explain what a "dependency type

[GitHub] [maven] elharo commented on a diff in pull request #1198: Javadoc fixes

2023-07-05 Thread via GitHub
elharo commented on code in PR #1198: URL: https://github.com/apache/maven/pull/1198#discussion_r1252960901 ## api/maven-api-core/src/main/java/org/apache/maven/api/Type.java: ## @@ -22,7 +22,7 @@ import org.apache.maven.api.annotations.Immutable; /** - * An artifact's{@code

[jira] [Commented] (MNG-7828) Bump guava from 31.1-jre to 32.0.1-jre

2023-07-05 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-7828?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17740166#comment-17740166 ] ASF GitHub Bot commented on MNG-7828: - bvolpato commented on PR #1191: URL: https://git

[GitHub] [maven] elharo commented on a diff in pull request #1197: [MNG 7836] Support alternative syntaxes for POMs

2023-07-05 Thread via GitHub
elharo commented on code in PR #1197: URL: https://github.com/apache/maven/pull/1197#discussion_r1252988776 ## api/maven-api-core/src/main/java/org/apache/maven/api/services/Source.java: ## @@ -20,17 +20,35 @@ import java.io.IOException; import java.io.InputStream; +import j

[jira] [Commented] (MNG-7733) maven4 user settings mirrorOf-external:* does not override global settings external:http:*

2023-07-05 Thread Guillaume Nodet (Jira)
[ https://issues.apache.org/jira/browse/MNG-7733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17740185#comment-17740185 ] Guillaume Nodet commented on MNG-7733: -- [~sellersj] note that 4.0.0-alpha-7 has been r

[jira] [Closed] (MNG-7733) maven4 user settings mirrorOf-external:* does not override global settings external:http:*

2023-07-05 Thread Guillaume Nodet (Jira)
[ https://issues.apache.org/jira/browse/MNG-7733?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guillaume Nodet closed MNG-7733. Resolution: Fixed > maven4 user settings mirrorOf-external:* does not override global settings > ext

[GitHub] [maven-assembly-plugin] mabrarov commented on a diff in pull request #148: [MASSEMBLY-791] overrideUmask option to ensure permissions in packaged archive match …

2023-07-05 Thread via GitHub
mabrarov commented on code in PR #148: URL: https://github.com/apache/maven-assembly-plugin/pull/148#discussion_r1253062676 ## src/main/java/org/apache/maven/plugins/assembly/AssemblerConfigurationSource.java: ## @@ -223,4 +223,9 @@ public interface AssemblerConfigurationSource

[jira] [Commented] (MASSEMBLY-791) fileMode not set in dependencySet creating format tar.gz

2023-07-05 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MASSEMBLY-791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17740188#comment-17740188 ] ASF GitHub Bot commented on MASSEMBLY-791: -- mabrarov commented on code in PR

[GitHub] [maven-assembly-plugin] mabrarov commented on a diff in pull request #148: [MASSEMBLY-791] overrideUmask option to ensure permissions in packaged archive match …

2023-07-05 Thread via GitHub
mabrarov commented on code in PR #148: URL: https://github.com/apache/maven-assembly-plugin/pull/148#discussion_r1253063508 ## src/main/java/org/apache/maven/plugins/assembly/AssemblerConfigurationSource.java: ## @@ -223,4 +223,9 @@ public interface AssemblerConfigurationSource

[jira] [Commented] (MASSEMBLY-791) fileMode not set in dependencySet creating format tar.gz

2023-07-05 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MASSEMBLY-791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17740189#comment-17740189 ] ASF GitHub Bot commented on MASSEMBLY-791: -- mabrarov commented on code in PR

[GitHub] [maven-assembly-plugin] elharo commented on a diff in pull request #148: [MASSEMBLY-791] overrideUmask option to ensure permissions in packaged archive match …

2023-07-05 Thread via GitHub
elharo commented on code in PR #148: URL: https://github.com/apache/maven-assembly-plugin/pull/148#discussion_r1253066482 ## src/main/java/org/apache/maven/plugins/assembly/AssemblerConfigurationSource.java: ## @@ -223,4 +223,12 @@ public interface AssemblerConfigurationSource

[GitHub] [maven-assembly-plugin] mabrarov commented on a diff in pull request #148: [MASSEMBLY-791] overrideUmask option to ensure permissions in packaged archive match …

2023-07-05 Thread via GitHub
mabrarov commented on code in PR #148: URL: https://github.com/apache/maven-assembly-plugin/pull/148#discussion_r1253072332 ## src/main/java/org/apache/maven/plugins/assembly/mojos/AbstractAssemblyMojo.java: ## @@ -430,6 +430,12 @@ public abstract class AbstractAssemblyMojo ext

[jira] [Commented] (MASSEMBLY-791) fileMode not set in dependencySet creating format tar.gz

2023-07-05 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MASSEMBLY-791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17740193#comment-17740193 ] ASF GitHub Bot commented on MASSEMBLY-791: -- elharo commented on code in PR #1

[jira] [Commented] (MASSEMBLY-791) fileMode not set in dependencySet creating format tar.gz

2023-07-05 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MASSEMBLY-791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17740194#comment-17740194 ] ASF GitHub Bot commented on MASSEMBLY-791: -- mabrarov commented on code in PR

[GitHub] [maven-assembly-plugin] mabrarov commented on a diff in pull request #148: [MASSEMBLY-791] overrideUmask option to ensure permissions in packaged archive match …

2023-07-05 Thread via GitHub
mabrarov commented on code in PR #148: URL: https://github.com/apache/maven-assembly-plugin/pull/148#discussion_r1253076754 ## src/main/java/org/apache/maven/plugins/assembly/AssemblerConfigurationSource.java: ## @@ -223,4 +223,12 @@ public interface AssemblerConfigurationSourc

[GitHub] [maven-assembly-plugin] mabrarov commented on a diff in pull request #148: [MASSEMBLY-791] overrideUmask option to ensure permissions in packaged archive match …

2023-07-05 Thread via GitHub
mabrarov commented on code in PR #148: URL: https://github.com/apache/maven-assembly-plugin/pull/148#discussion_r1253076754 ## src/main/java/org/apache/maven/plugins/assembly/AssemblerConfigurationSource.java: ## @@ -223,4 +223,12 @@ public interface AssemblerConfigurationSourc

[jira] [Commented] (MASSEMBLY-791) fileMode not set in dependencySet creating format tar.gz

2023-07-05 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MASSEMBLY-791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17740195#comment-17740195 ] ASF GitHub Bot commented on MASSEMBLY-791: -- mabrarov commented on code in PR

[jira] [Commented] (MASSEMBLY-791) fileMode not set in dependencySet creating format tar.gz

2023-07-05 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MASSEMBLY-791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17740196#comment-17740196 ] ASF GitHub Bot commented on MASSEMBLY-791: -- mabrarov commented on code in PR

[GitHub] [maven-assembly-plugin] mabrarov commented on a diff in pull request #148: [MASSEMBLY-791] overrideUmask option to ensure permissions in packaged archive match …

2023-07-05 Thread via GitHub
mabrarov commented on code in PR #148: URL: https://github.com/apache/maven-assembly-plugin/pull/148#discussion_r1253076754 ## src/main/java/org/apache/maven/plugins/assembly/AssemblerConfigurationSource.java: ## @@ -223,4 +223,12 @@ public interface AssemblerConfigurationSourc

[jira] [Commented] (MASSEMBLY-791) fileMode not set in dependencySet creating format tar.gz

2023-07-05 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MASSEMBLY-791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17740197#comment-17740197 ] ASF GitHub Bot commented on MASSEMBLY-791: -- mabrarov commented on code in PR

[GitHub] [maven-assembly-plugin] elharo commented on a diff in pull request #148: [MASSEMBLY-791] overrideUmask option to ensure permissions in packaged archive match …

2023-07-05 Thread via GitHub
elharo commented on code in PR #148: URL: https://github.com/apache/maven-assembly-plugin/pull/148#discussion_r1253083133 ## src/main/java/org/apache/maven/plugins/assembly/AssemblerConfigurationSource.java: ## @@ -223,4 +223,12 @@ public interface AssemblerConfigurationSource

[jira] [Commented] (MASSEMBLY-791) fileMode not set in dependencySet creating format tar.gz

2023-07-05 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MASSEMBLY-791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17740200#comment-17740200 ] ASF GitHub Bot commented on MASSEMBLY-791: -- elharo commented on code in PR #1

[GitHub] [maven] gnodet commented on a diff in pull request #1198: Javadoc fixes

2023-07-05 Thread via GitHub
gnodet commented on code in PR #1198: URL: https://github.com/apache/maven/pull/1198#discussion_r1253095220 ## api/maven-api-core/src/main/java/org/apache/maven/api/Dependency.java: ## @@ -23,9 +23,9 @@ public interface Dependency extends Artifact { Review Comment: I think

[jira] [Commented] (MASSEMBLY-791) fileMode not set in dependencySet creating format tar.gz

2023-07-05 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MASSEMBLY-791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17740202#comment-17740202 ] ASF GitHub Bot commented on MASSEMBLY-791: -- mabrarov commented on code in PR

[GitHub] [maven-assembly-plugin] mabrarov commented on a diff in pull request #148: [MASSEMBLY-791] overrideUmask option to ensure permissions in packaged archive match …

2023-07-05 Thread via GitHub
mabrarov commented on code in PR #148: URL: https://github.com/apache/maven-assembly-plugin/pull/148#discussion_r1253097140 ## src/main/java/org/apache/maven/plugins/assembly/AssemblerConfigurationSource.java: ## @@ -223,4 +223,12 @@ public interface AssemblerConfigurationSourc

[GitHub] [maven] gnodet commented on a diff in pull request #1197: [MNG 7836] Support alternative syntaxes for POMs

2023-07-05 Thread via GitHub
gnodet commented on code in PR #1197: URL: https://github.com/apache/maven/pull/1197#discussion_r1253112641 ## maven-model-builder/src/main/java/org/apache/maven/model/building/DefaultModelProcessor.java: ## @@ -63,32 +75,110 @@ @Typed(ModelProcessor.class) public class Defaul

[GitHub] [maven] gnodet commented on a diff in pull request #1197: [MNG 7836] Support alternative syntaxes for POMs

2023-07-05 Thread via GitHub
gnodet commented on code in PR #1197: URL: https://github.com/apache/maven/pull/1197#discussion_r1253115756 ## maven-model-builder/src/main/java/org/apache/maven/model/building/FileSource.java: ## @@ -0,0 +1,47 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under on

[GitHub] [maven] gnodet commented on a diff in pull request #1197: [MNG 7836] Support alternative syntaxes for POMs

2023-07-05 Thread via GitHub
gnodet commented on code in PR #1197: URL: https://github.com/apache/maven/pull/1197#discussion_r1253115756 ## maven-model-builder/src/main/java/org/apache/maven/model/building/FileSource.java: ## @@ -0,0 +1,47 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under on

[GitHub] [maven] gnodet commented on a diff in pull request #1197: [MNG 7836] Support alternative syntaxes for POMs

2023-07-05 Thread via GitHub
gnodet commented on code in PR #1197: URL: https://github.com/apache/maven/pull/1197#discussion_r1253118373 ## api/maven-api-core/src/main/java/org/apache/maven/api/services/Source.java: ## @@ -20,17 +20,35 @@ import java.io.IOException; import java.io.InputStream; +import j

[GitHub] [maven] gnodet merged pull request #1196: Use model processor when locating the root pom when using -f/--file

2023-07-05 Thread via GitHub
gnodet merged PR #1196: URL: https://github.com/apache/maven/pull/1196 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.o

[GitHub] [maven] gnodet merged pull request #1195: [MNG-7834] Fix NullPointerException in flatten-maven-plugin

2023-07-05 Thread via GitHub
gnodet merged PR #1195: URL: https://github.com/apache/maven/pull/1195 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.o

[jira] [Commented] (MNG-7834) NPE in flatten-maven-plugin

2023-07-05 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-7834?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17740221#comment-17740221 ] ASF GitHub Bot commented on MNG-7834: - gnodet merged PR #1195: URL: https://github.com/

[jira] [Closed] (MNG-7834) NPE in flatten-maven-plugin

2023-07-05 Thread Guillaume Nodet (Jira)
[ https://issues.apache.org/jira/browse/MNG-7834?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guillaume Nodet closed MNG-7834. Resolution: Fixed > NPE in flatten-maven-plugin > --- > > Key

[jira] [Updated] (MNGSITE-521) Define dependency type

2023-07-05 Thread Elliotte Rusty Harold (Jira)
[ https://issues.apache.org/jira/browse/MNGSITE-521?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Elliotte Rusty Harold updated MNGSITE-521: -- Description: At no point I can find, do we ever explain what a "dependency typ

[jira] [Updated] (MNGSITE-521) Define dependency type

2023-07-05 Thread Elliotte Rusty Harold (Jira)
[ https://issues.apache.org/jira/browse/MNGSITE-521?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Elliotte Rusty Harold updated MNGSITE-521: -- Description: At no point I can find do we ever explain what a "dependency type

[GitHub] [maven] gnodet commented on a diff in pull request #1198: Javadoc fixes

2023-07-05 Thread via GitHub
gnodet commented on code in PR #1198: URL: https://github.com/apache/maven/pull/1198#discussion_r1253249146 ## api/maven-api-core/src/main/java/org/apache/maven/api/Type.java: ## @@ -22,7 +22,7 @@ import org.apache.maven.api.annotations.Immutable; /** - * An artifact's{@code

[GitHub] [maven] gnodet commented on a diff in pull request #1198: Javadoc fixes

2023-07-05 Thread via GitHub
gnodet commented on code in PR #1198: URL: https://github.com/apache/maven/pull/1198#discussion_r1253249489 ## api/maven-api-core/src/main/java/org/apache/maven/api/Type.java: ## @@ -22,7 +22,7 @@ import org.apache.maven.api.annotations.Immutable; /** - * An artifact's{@code

[GitHub] [maven] gnodet commented on a diff in pull request #1194: [MNG-6401] Support interpolation of the proxy port in settings.xml

2023-07-05 Thread via GitHub
gnodet commented on code in PR #1194: URL: https://github.com/apache/maven/pull/1194#discussion_r1253258499 ## api/maven-api-settings/src/main/mdo/settings.mdo: ## @@ -535,6 +539,62 @@ String + + + 1.0.0/1.3.0 + +

[jira] [Commented] (MNG-6401) Support proxy port interpolation in settings.xml

2023-07-05 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-6401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17740254#comment-17740254 ] ASF GitHub Bot commented on MNG-6401: - gnodet commented on code in PR #1194: URL: https

[GitHub] [maven] gnodet commented on a diff in pull request #1194: [MNG-6401] Support interpolation of the proxy port in settings.xml

2023-07-05 Thread via GitHub
gnodet commented on code in PR #1194: URL: https://github.com/apache/maven/pull/1194#discussion_r1253270018 ## api/maven-api-settings/src/main/mdo/settings.mdo: ## @@ -535,6 +539,62 @@ String + + + 1.0.0/1.3.0 + +

[GitHub] [maven] gnodet commented on a diff in pull request #1194: [MNG-6401] Support interpolation of the proxy port in settings.xml

2023-07-05 Thread via GitHub
gnodet commented on code in PR #1194: URL: https://github.com/apache/maven/pull/1194#discussion_r1253270018 ## api/maven-api-settings/src/main/mdo/settings.mdo: ## @@ -535,6 +539,62 @@ String + + + 1.0.0/1.3.0 + +

[jira] [Commented] (MNG-6401) Support proxy port interpolation in settings.xml

2023-07-05 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-6401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17740258#comment-17740258 ] ASF GitHub Bot commented on MNG-6401: - gnodet commented on code in PR #1194: URL: https

[jira] [Commented] (MNG-6401) Support proxy port interpolation in settings.xml

2023-07-05 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-6401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17740260#comment-17740260 ] ASF GitHub Bot commented on MNG-6401: - gnodet commented on code in PR #1194: URL: https

[GitHub] [maven] gnodet commented on a diff in pull request #1194: [MNG-6401] Support interpolation of the proxy port in settings.xml

2023-07-05 Thread via GitHub
gnodet commented on code in PR #1194: URL: https://github.com/apache/maven/pull/1194#discussion_r1253281717 ## api/maven-api-settings/src/main/mdo/settings.mdo: ## @@ -535,6 +539,62 @@ String + + + 1.0.0/1.3.0 + +

[jira] [Commented] (MNG-6401) Support proxy port interpolation in settings.xml

2023-07-05 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-6401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17740263#comment-17740263 ] ASF GitHub Bot commented on MNG-6401: - gnodet commented on code in PR #1194: URL: https

[GitHub] [maven] gnodet commented on a diff in pull request #1194: [MNG-6401] Support interpolation of the proxy port in settings.xml

2023-07-05 Thread via GitHub
gnodet commented on code in PR #1194: URL: https://github.com/apache/maven/pull/1194#discussion_r1253281717 ## api/maven-api-settings/src/main/mdo/settings.mdo: ## @@ -535,6 +539,62 @@ String + + + 1.0.0/1.3.0 + +

[jira] [Commented] (MNG-6401) Support proxy port interpolation in settings.xml

2023-07-05 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-6401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17740264#comment-17740264 ] ASF GitHub Bot commented on MNG-6401: - gnodet commented on code in PR #1194: URL: https

[GitHub] [maven] ywluogg commented on pull request #1191: [MNG-7828] Bump guava from 30.1-jre to 32.0.1-jre

2023-07-05 Thread via GitHub
ywluogg commented on PR #1191: URL: https://github.com/apache/maven/pull/1191#issuecomment-1622074257 > I looked into it, but it's not very straightforward like the bump of `` here. In `3.8.x`, Guava comes transitively from Guice. Thanks for this detail! -- This is an automated mes

[jira] [Commented] (MNG-7828) Bump guava from 31.1-jre to 32.0.1-jre

2023-07-05 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-7828?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17740274#comment-17740274 ] ASF GitHub Bot commented on MNG-7828: - ywluogg commented on PR #1191: URL: https://gith

[GitHub] [maven] gnodet commented on a diff in pull request #1197: [MNG 7836] Support alternative syntaxes for POMs

2023-07-05 Thread via GitHub
gnodet commented on code in PR #1197: URL: https://github.com/apache/maven/pull/1197#discussion_r1253378478 ## api/maven-api-core/src/main/java/org/apache/maven/api/services/Source.java: ## @@ -20,17 +20,35 @@ import java.io.IOException; import java.io.InputStream; +import j

[GitHub] [maven] gnodet commented on a diff in pull request #1197: [MNG 7836] Support alternative syntaxes for POMs

2023-07-05 Thread via GitHub
gnodet commented on code in PR #1197: URL: https://github.com/apache/maven/pull/1197#discussion_r1253409738 ## api/maven-api-spi/src/main/java/org/apache/maven/api/spi/ModelParserException.java: ## @@ -0,0 +1,66 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under o

[GitHub] [maven] gnodet commented on a diff in pull request #1197: [MNG 7836] Support alternative syntaxes for POMs

2023-07-05 Thread via GitHub
gnodet commented on code in PR #1197: URL: https://github.com/apache/maven/pull/1197#discussion_r1253409738 ## api/maven-api-spi/src/main/java/org/apache/maven/api/spi/ModelParserException.java: ## @@ -0,0 +1,66 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under o

[GitHub] [maven] gnodet commented on a diff in pull request #1197: [MNG 7836] Support alternative syntaxes for POMs

2023-07-05 Thread via GitHub
gnodet commented on code in PR #1197: URL: https://github.com/apache/maven/pull/1197#discussion_r1253417277 ## maven-core/src/main/java/org/apache/maven/internal/transformation/ConsumerPomArtifactTransformer.java: ## @@ -165,31 +178,50 @@ private ConsumerPomArtifact(MavenProject

[GitHub] [maven] gnodet commented on a diff in pull request #1197: [MNG 7836] Support alternative syntaxes for POMs

2023-07-05 Thread via GitHub
gnodet commented on code in PR #1197: URL: https://github.com/apache/maven/pull/1197#discussion_r1253418206 ## maven-core/src/main/java/org/apache/maven/internal/transformation/ConsumerPomArtifactTransformer.java: ## @@ -165,31 +178,50 @@ private ConsumerPomArtifact(MavenProject

[GitHub] [maven] gnodet commented on a diff in pull request #1197: [MNG 7836] Support alternative syntaxes for POMs

2023-07-05 Thread via GitHub
gnodet commented on code in PR #1197: URL: https://github.com/apache/maven/pull/1197#discussion_r1253421341 ## maven-core/src/main/java/org/apache/maven/internal/transformation/ConsumerPomArtifactTransformer.java: ## @@ -165,31 +178,50 @@ private ConsumerPomArtifact(MavenProject

[GitHub] [maven] gnodet commented on a diff in pull request #1197: [MNG 7836] Support alternative syntaxes for POMs

2023-07-05 Thread via GitHub
gnodet commented on code in PR #1197: URL: https://github.com/apache/maven/pull/1197#discussion_r1253422326 ## maven-model-builder/src/main/java/org/apache/maven/model/building/DefaultModelProcessor.java: ## @@ -63,32 +75,110 @@ @Typed(ModelProcessor.class) public class Defaul

[GitHub] [maven] gnodet commented on a diff in pull request #1197: [MNG 7836] Support alternative syntaxes for POMs

2023-07-05 Thread via GitHub
gnodet commented on code in PR #1197: URL: https://github.com/apache/maven/pull/1197#discussion_r1253424076 ## maven-model-builder/src/main/java/org/apache/maven/model/building/DefaultModelProcessor.java: ## @@ -63,32 +75,110 @@ @Typed(ModelProcessor.class) public class Defaul

[GitHub] [maven] gnodet commented on a diff in pull request #1197: [MNG 7836] Support alternative syntaxes for POMs

2023-07-05 Thread via GitHub
gnodet commented on code in PR #1197: URL: https://github.com/apache/maven/pull/1197#discussion_r1253450812 ## api/maven-api-core/src/main/java/org/apache/maven/api/services/Source.java: ## @@ -20,17 +20,35 @@ import java.io.IOException; import java.io.InputStream; +import j

[jira] [Commented] (MNG-7733) maven4 user settings mirrorOf-external:* does not override global settings external:http:*

2023-07-05 Thread Jim Sellers (Jira)
[ https://issues.apache.org/jira/browse/MNG-7733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17740286#comment-17740286 ] Jim Sellers commented on MNG-7733: -- Thanks [~gnodet]! Also worked for me with 4.0.0-alpha

[GitHub] [maven] elharo commented on a diff in pull request #1198: Javadoc fixes

2023-07-05 Thread via GitHub
elharo commented on code in PR #1198: URL: https://github.com/apache/maven/pull/1198#discussion_r1253549700 ## api/maven-api-core/src/main/java/org/apache/maven/api/Type.java: ## @@ -43,27 +48,43 @@ public interface Type { String TEST_JAR = "test-jar"; /** - * Re

[jira] [Commented] (MNG-7828) Bump guava from 31.1-jre to 32.0.1-jre

2023-07-05 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-7828?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17740334#comment-17740334 ] ASF GitHub Bot commented on MNG-7828: - ywluogg commented on PR #1191: URL: https://gith

[GitHub] [maven] bvolpato commented on pull request #1189: [MNG-7828] Bump guava from 31.1-jre to 32.0.1-jre

2023-07-05 Thread via GitHub
bvolpato commented on PR #1189: URL: https://github.com/apache/maven/pull/1189#issuecomment-1622980343 Can a committer merge this PR? Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

[GitHub] [maven] bvolpato commented on pull request #1191: [MNG-7828] Bump guava from 30.1-jre to 32.0.1-jre

2023-07-05 Thread via GitHub
bvolpato commented on PR #1191: URL: https://github.com/apache/maven/pull/1191#issuecomment-1622980405 Can a committer merge this PR? Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

[jira] [Commented] (MNG-7828) Bump guava from 31.1-jre to 32.0.1-jre

2023-07-05 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-7828?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17740398#comment-17740398 ] ASF GitHub Bot commented on MNG-7828: - bvolpato commented on PR #1189: URL: https://git

[jira] [Commented] (MNG-7828) Bump guava from 31.1-jre to 32.0.1-jre

2023-07-05 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-7828?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17740399#comment-17740399 ] ASF GitHub Bot commented on MNG-7828: - bvolpato commented on PR #1191: URL: https://git