[GitHub] [maven] slawekjaranowski commented on a diff in pull request #940: [MNG-7648] Fix locationTracking in DefaultModelBuildingRequest copy constructor.

2022-12-29 Thread GitBox
slawekjaranowski commented on code in PR #940: URL: https://github.com/apache/maven/pull/940#discussion_r1058827912 ## maven-core/src/test/java/org/apache/maven/project/ProjectBuilderTest.java: ## @@ -347,4 +349,32 @@ public void testBuildFromModelSourceResolvesBasedir() throws

[jira] [Commented] (MNG-7648) Generated model reader is not setting location information

2022-12-29 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-7648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17652782#comment-17652782 ] ASF GitHub Bot commented on MNG-7648: - slawekjaranowski commented on code in PR #940: U

[jira] [Assigned] (MNG-7648) Generated model reader is not setting location information

2022-12-29 Thread Slawomir Jaranowski (Jira)
[ https://issues.apache.org/jira/browse/MNG-7648?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Slawomir Jaranowski reassigned MNG-7648: Assignee: Slawomir Jaranowski > Generated model reader is not setting location infor

[jira] [Updated] (MNG-7648) Generated model reader is not setting location information

2022-12-29 Thread Slawomir Jaranowski (Jira)
[ https://issues.apache.org/jira/browse/MNG-7648?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Slawomir Jaranowski updated MNG-7648: - Fix Version/s: 4.0.0-alpha-4 4.0.0 > Generated model reader is not setti

[GitHub] [maven] pavelhoral commented on a diff in pull request #940: [MNG-7648] Fix locationTracking in DefaultModelBuildingRequest copy constructor.

2022-12-29 Thread GitBox
pavelhoral commented on code in PR #940: URL: https://github.com/apache/maven/pull/940#discussion_r1058846209 ## maven-core/src/test/java/org/apache/maven/project/ProjectBuilderTest.java: ## @@ -347,4 +349,32 @@ public void testBuildFromModelSourceResolvesBasedir() throws Excep

[jira] [Commented] (MNG-7648) Generated model reader is not setting location information

2022-12-29 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-7648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17652785#comment-17652785 ] ASF GitHub Bot commented on MNG-7648: - pavelhoral commented on code in PR #940: URL: ht

[GitHub] [maven] pavelhoral commented on a diff in pull request #940: [MNG-7648] Fix locationTracking in DefaultModelBuildingRequest copy constructor.

2022-12-29 Thread GitBox
pavelhoral commented on code in PR #940: URL: https://github.com/apache/maven/pull/940#discussion_r1058848533 ## maven-core/src/test/java/org/apache/maven/project/ProjectBuilderTest.java: ## @@ -347,4 +349,32 @@ public void testBuildFromModelSourceResolvesBasedir() throws Excep

[jira] [Commented] (MNG-7648) Generated model reader is not setting location information

2022-12-29 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-7648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17652787#comment-17652787 ] ASF GitHub Bot commented on MNG-7648: - pavelhoral commented on code in PR #940: URL: ht

[GitHub] [maven-dependency-plugin] pzygielo opened a new pull request, #277: Remove unused fields

2022-12-29 Thread GitBox
pzygielo opened a new pull request, #277: URL: https://github.com/apache/maven-dependency-plugin/pull/277 - [X] I hereby declare this contribution to be licensed under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) -- This is an automat

[GitHub] [maven-site] pzygielo closed pull request #358: Fix formatting to have XML rendered correctly

2022-12-29 Thread GitBox
pzygielo closed pull request #358: Fix formatting to have XML rendered correctly URL: https://github.com/apache/maven-site/pull/358 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific commen

[GitHub] [maven-doxia] hboutemy commented on pull request #132: [DOXIA-617] support yaml metadata

2022-12-29 Thread GitBox
hboutemy commented on PR #132: URL: https://github.com/apache/maven-doxia/pull/132#issuecomment-1367246621 because we have our own metadata management code that already tricks Doxia API based on HTML-rendered Markdown: https://github.com/apache/maven-doxia/blob/master/doxia-modules/doxia-mo

[jira] [Updated] (DOXIA-617) doxia-module-markdown: Add support for --- header section marks

2022-12-29 Thread Herve Boutemy (Jira)
[ https://issues.apache.org/jira/browse/DOXIA-617?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Herve Boutemy updated DOXIA-617: Fix Version/s: 1.12.0 2.0.0-M5 > doxia-module-markdown: Add support for --- heade

[jira] [Commented] (DOXIA-617) doxia-module-markdown: Add support for --- header section marks

2022-12-29 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/DOXIA-617?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17652799#comment-17652799 ] ASF GitHub Bot commented on DOXIA-617: -- hboutemy commented on PR #132: URL: https://g

[GitHub] [maven-dependency-plugin] pzygielo commented on pull request #277: Remove unused fields

2022-12-29 Thread GitBox
pzygielo commented on PR #277: URL: https://github.com/apache/maven-dependency-plugin/pull/277#issuecomment-1367250325 May I ask for review, please? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[jira] [Updated] (DOXIA-569) Add Markdown Sink to be able to convert anything to Markdown

2022-12-29 Thread Herve Boutemy (Jira)
[ https://issues.apache.org/jira/browse/DOXIA-569?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Herve Boutemy updated DOXIA-569: Fix Version/s: 1.12.0 > Add Markdown Sink to be able to convert anything to Markdown > -

[GitHub] [maven-enforcer] psiroky commented on a diff in pull request #205: [MENFORCER-431] Introduce option to skip specific rules via custom property

2022-12-29 Thread GitBox
psiroky commented on code in PR #205: URL: https://github.com/apache/maven-enforcer/pull/205#discussion_r1058896974 ## maven-enforcer-plugin/src/main/java/org/apache/maven/plugins/enforcer/EnforceMojo.java: ## @@ -115,6 +120,14 @@ public class EnforceMojo extends AbstractMojo {

[GitHub] [maven-enforcer] psiroky commented on pull request #205: [MENFORCER-431] Introduce option to skip specific rules via custom property

2022-12-29 Thread GitBox
psiroky commented on PR #205: URL: https://github.com/apache/maven-enforcer/pull/205#issuecomment-1367253679 @slawekjaranowski I believe this should be now ready for review. Please take another look when you get a chance. -- This is an automated message from the Apache Git Service. To res

[GitHub] [maven-doxia] michael-o commented on pull request #132: [DOXIA-617] support yaml metadata

2022-12-29 Thread GitBox
michael-o commented on PR #132: URL: https://github.com/apache/maven-doxia/pull/132#issuecomment-1367257971 I think this deserves a comment in the code why we aren't using the extension. -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[jira] [Commented] (DOXIA-617) doxia-module-markdown: Add support for --- header section marks

2022-12-29 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/DOXIA-617?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17652815#comment-17652815 ] ASF GitHub Bot commented on DOXIA-617: -- michael-o commented on PR #132: URL: https://

[jira] [Commented] (SUREFIRE-2121) Failed to parse version of junit:junit: 4.13.2

2022-12-29 Thread Andreas Pabst (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-2121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17652817#comment-17652817 ] Andreas Pabst commented on SUREFIRE-2121: - This is not a bug, it's a configura

[GitHub] [maven-mvnd] marcphilipp commented on issue #759: NullPointerException

2022-12-29 Thread GitBox
marcphilipp commented on issue #759: URL: https://github.com/apache/maven-mvnd/issues/759#issuecomment-1367263736 Yes, the Gradle Enterprise Maven extension is not yet compatible with the Maven Daemon but we're working on it and there should soon be a compatible release. -- This is an au

[GitHub] [maven-surefire] andpab commented on pull request #571: [SUREFIRE-2121] JUnitException: Failed to parse version of junit:junit: 4.13.2

2022-12-29 Thread GitBox
andpab commented on PR #571: URL: https://github.com/apache/maven-surefire/pull/571#issuecomment-1367265046 As described in my comment in SUREFIRE-2121, this pull request does not address the root cause of the issue which is simply a configuration error. There is no need to update the JUnit

[GitHub] [maven-doxia] dependabot[bot] opened a new pull request, #134: Bump flexmarkVersion from 0.62.2 to 0.64.0

2022-12-29 Thread GitBox
dependabot[bot] opened a new pull request, #134: URL: https://github.com/apache/maven-doxia/pull/134 Bumps `flexmarkVersion` from 0.62.2 to 0.64.0. Updates `flexmark` from 0.62.2 to 0.64.0 Commits https://github.com/vsch/flexmark-java/commit/7c187fb2bcf3bbdad4a75226a746aee752

[jira] [Updated] (MRESOLVER-304) DirectoryUtils should consider interpolation

2022-12-29 Thread Tamas Cservenak (Jira)
[ https://issues.apache.org/jira/browse/MRESOLVER-304?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamas Cservenak updated MRESOLVER-304: -- Description: As currently it cannot be interpolated, and it applies this logic: * i

[GitHub] [maven] slawekjaranowski merged pull request #940: [MNG-7648] Fix locationTracking in DefaultModelBuildingRequest copy constructor.

2022-12-29 Thread GitBox
slawekjaranowski merged PR #940: URL: https://github.com/apache/maven/pull/940 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.

[jira] [Commented] (MNG-7648) Generated model reader is not setting location information

2022-12-29 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-7648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17652834#comment-17652834 ] ASF GitHub Bot commented on MNG-7648: - slawekjaranowski merged PR #940: URL: https://gi

[GitHub] [maven] slawekjaranowski commented on pull request #940: [MNG-7648] Fix locationTracking in DefaultModelBuildingRequest copy constructor.

2022-12-29 Thread GitBox
slawekjaranowski commented on PR #940: URL: https://github.com/apache/maven/pull/940#issuecomment-1367306455 @pavelhoral thanks I squashed to one final commit In 3.9.x there is no such issue - looks like `DefaultModelBuildingRequest` constructor is not used but I think that

[jira] [Updated] (MRESOLVER-295) Split FileProcessor into ChecksumProcessor and PathProcessor

2022-12-29 Thread Tamas Cservenak (Jira)
[ https://issues.apache.org/jira/browse/MRESOLVER-295?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamas Cservenak updated MRESOLVER-295: -- Description: The FileProcessor should become obsolete. Instead, split this componen

[jira] [Commented] (MNG-7648) Generated model reader is not setting location information

2022-12-29 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-7648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17652836#comment-17652836 ] ASF GitHub Bot commented on MNG-7648: - slawekjaranowski commented on PR #940: URL: http

[jira] [Updated] (MNG-7648) Generated model reader is not setting location information

2022-12-29 Thread Slawomir Jaranowski (Jira)
[ https://issues.apache.org/jira/browse/MNG-7648?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Slawomir Jaranowski updated MNG-7648: - Fix Version/s: 3.9.0-candidate > Generated model reader is not setting location information

[GitHub] [maven-doxia] bertysentry commented on pull request #132: [DOXIA-617] support yaml metadata

2022-12-29 Thread GitBox
bertysentry commented on PR #132: URL: https://github.com/apache/maven-doxia/pull/132#issuecomment-1367308292 @hboutemy Thank you for taking care of this! While "it works"(tm) as per the tests, the original intent was to remove as much as possible specific code to handle these headers

[jira] [Commented] (DOXIA-617) doxia-module-markdown: Add support for --- header section marks

2022-12-29 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/DOXIA-617?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17652837#comment-17652837 ] ASF GitHub Bot commented on DOXIA-617: -- bertysentry commented on PR #132: URL: https:

[GitHub] [maven-doxia] bertysentry commented on a diff in pull request #132: [DOXIA-617] support yaml metadata

2022-12-29 Thread GitBox
bertysentry commented on code in PR #132: URL: https://github.com/apache/maven-doxia/pull/132#discussion_r1058930626 ## doxia-modules/doxia-module-markdown/src/test/resources/metadata-yaml.md: ## @@ -0,0 +1,14 @@ +--- +title: A Title & a 'Test' +author: Somebody 'Nickname' Great

[jira] [Commented] (DOXIA-617) doxia-module-markdown: Add support for --- header section marks

2022-12-29 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/DOXIA-617?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17652841#comment-17652841 ] ASF GitHub Bot commented on DOXIA-617: -- bertysentry commented on code in PR #132: URL

[jira] [Commented] (MENFORCER-434) Version 3.1.0 is not enforcing bannedDependencies rules

2022-12-29 Thread Jira
[ https://issues.apache.org/jira/browse/MENFORCER-434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17652844#comment-17652844 ] Petr Široký commented on MENFORCER-434: --- Yes, I just tested with latest {{3.2.0-

[GitHub] [maven-enforcer] slawekjaranowski commented on a diff in pull request #205: [MENFORCER-431] Introduce option to skip specific rules via custom property

2022-12-29 Thread GitBox
slawekjaranowski commented on code in PR #205: URL: https://github.com/apache/maven-enforcer/pull/205#discussion_r1058946939 ## maven-enforcer-plugin/src/main/java/org/apache/maven/plugins/enforcer/EnforceMojo.java: ## @@ -282,6 +288,22 @@ private Optional createRulesFromComman

[GitHub] [maven-enforcer] slawekjaranowski merged pull request #205: [MENFORCER-431] Introduce option to skip specific rules via custom property

2022-12-29 Thread GitBox
slawekjaranowski merged PR #205: URL: https://github.com/apache/maven-enforcer/pull/205 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr.

[jira] [Closed] (MENFORCER-431) Skip specific rules

2022-12-29 Thread Slawomir Jaranowski (Jira)
[ https://issues.apache.org/jira/browse/MENFORCER-431?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Slawomir Jaranowski closed MENFORCER-431. - Fix Version/s: 3.2.0 Assignee: Slawomir Jaranowski Resolution:

[GitHub] [maven-enforcer] psiroky commented on a diff in pull request #205: [MENFORCER-431] Introduce option to skip specific rules via custom property

2022-12-29 Thread GitBox
psiroky commented on code in PR #205: URL: https://github.com/apache/maven-enforcer/pull/205#discussion_r1058955173 ## maven-enforcer-plugin/src/main/java/org/apache/maven/plugins/enforcer/EnforceMojo.java: ## @@ -282,6 +288,22 @@ private Optional createRulesFromCommandLineOpti

[GitHub] [maven-surefire] andpab commented on a diff in pull request #554: [SUREFIRE-2109] Add suffix derived from current user to Surefire temp directory name and make directory writable for all

2022-12-29 Thread GitBox
andpab commented on code in PR #554: URL: https://github.com/apache/maven-surefire/pull/554#discussion_r1058956056 ## surefire-api/src/main/java/org/apache/maven/surefire/api/util/TempFileManager.java: ## @@ -180,6 +180,8 @@ public synchronized File createTempFile( String prefix

[GitHub] [maven-enforcer] slawekjaranowski commented on a diff in pull request #205: [MENFORCER-431] Introduce option to skip specific rules via custom property

2022-12-29 Thread GitBox
slawekjaranowski commented on code in PR #205: URL: https://github.com/apache/maven-enforcer/pull/205#discussion_r1058959931 ## maven-enforcer-plugin/src/main/java/org/apache/maven/plugins/enforcer/EnforceMojo.java: ## @@ -282,6 +288,22 @@ private Optional createRulesFromComman

[GitHub] [maven-enforcer] psiroky opened a new pull request, #210: [MENFORCER-431] Clean-up - use List instead of String[]

2022-12-29 Thread GitBox
psiroky opened a new pull request, #210: URL: https://github.com/apache/maven-enforcer/pull/210 Just a small clean-up to avoid dealing with arrays. Following this checklist to help us incorporate your contribution quickly and easily: - [x] Make sure there is a [JIRA issue]

[GitHub] [maven] pavelhoral commented on pull request #940: [MNG-7648] Fix locationTracking in DefaultModelBuildingRequest copy constructor.

2022-12-29 Thread GitBox
pavelhoral commented on PR #940: URL: https://github.com/apache/maven/pull/940#issuecomment-1367330916 > In 3.9.x there is no such issue - looks like `DefaultModelBuildingRequest` constructor is not used but I think that we can cherry pick this commit to be sure that is working as expected

[GitHub] [maven-enforcer] psiroky commented on a diff in pull request #205: [MENFORCER-431] Introduce option to skip specific rules via custom property

2022-12-29 Thread GitBox
psiroky commented on code in PR #205: URL: https://github.com/apache/maven-enforcer/pull/205#discussion_r1058960968 ## maven-enforcer-plugin/src/main/java/org/apache/maven/plugins/enforcer/EnforceMojo.java: ## @@ -282,6 +288,22 @@ private Optional createRulesFromCommandLineOpti

[jira] [Commented] (MNG-7648) Generated model reader is not setting location information

2022-12-29 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-7648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17652851#comment-17652851 ] ASF GitHub Bot commented on MNG-7648: - pavelhoral commented on PR #940: URL: https://gi

[jira] [Commented] (MENFORCER-431) Skip specific rules

2022-12-29 Thread Jira
[ https://issues.apache.org/jira/browse/MENFORCER-431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17652853#comment-17652853 ] Petr Široký commented on MENFORCER-431: --- Just to clarify the naming of the prope

[GitHub] [maven-enforcer] psiroky commented on pull request #210: [MENFORCER-431] Clean-up - use List instead of String[]

2022-12-29 Thread GitBox
psiroky commented on PR #210: URL: https://github.com/apache/maven-enforcer/pull/210#issuecomment-1367342589 The build failed with ``` Error: Failures: Error: TestEvaluateBeanshell.testRuleCanExecuteMultipleThreads:192->assertConcurrent:218 Timeout initializing threads! Perfor

[GitHub] [maven] slawekjaranowski commented on pull request #940: [MNG-7648] Fix locationTracking in DefaultModelBuildingRequest copy constructor.

2022-12-29 Thread GitBox
slawekjaranowski commented on PR #940: URL: https://github.com/apache/maven/pull/940#issuecomment-1367359702 @pavelhoral please create PR for `maven-3.9.x` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[jira] [Commented] (MNG-7648) Generated model reader is not setting location information

2022-12-29 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-7648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17652856#comment-17652856 ] ASF GitHub Bot commented on MNG-7648: - slawekjaranowski commented on PR #940: URL: http

[GitHub] [maven-doxia] hboutemy commented on pull request #132: [DOXIA-617] support yaml metadata

2022-12-29 Thread GitBox
hboutemy commented on PR #132: URL: https://github.com/apache/maven-doxia/pull/132#issuecomment-1367360734 if we use the parsing API for YAML form of metadata, it means we stop supporting metadata without the `---` delimiters is it really what you all want? -- This is an automated

[jira] [Commented] (DOXIA-617) doxia-module-markdown: Add support for --- header section marks

2022-12-29 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/DOXIA-617?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17652857#comment-17652857 ] ASF GitHub Bot commented on DOXIA-617: -- hboutemy commented on PR #132: URL: https://g

[GitHub] [maven-doxia] hboutemy commented on a diff in pull request #128: DOXIA-569 add Markdown output (sink)

2022-12-29 Thread GitBox
hboutemy commented on code in PR #128: URL: https://github.com/apache/maven-doxia/pull/128#discussion_r1058979160 ## doxia-modules/doxia-module-markdown/src/main/java/org/apache/maven/doxia/module/markdown/MarkdownMarkup.java: ## @@ -0,0 +1,147 @@ +package org.apache.maven.doxia

[jira] [Commented] (DOXIA-569) Add Markdown Sink to be able to convert anything to Markdown

2022-12-29 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/DOXIA-569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17652858#comment-17652858 ] ASF GitHub Bot commented on DOXIA-569: -- hboutemy commented on code in PR #128: URL: h

[GitHub] [maven-doxia] hboutemy commented on a diff in pull request #128: DOXIA-569 add Markdown output (sink)

2022-12-29 Thread GitBox
hboutemy commented on code in PR #128: URL: https://github.com/apache/maven-doxia/pull/128#discussion_r1058979799 ## doxia-core/src/test/java/org/apache/maven/doxia/sink/impl/AbstractSinkTest.java: ## @@ -492,7 +492,7 @@ public void testFooter() * the same result as {@link

[jira] [Commented] (DOXIA-569) Add Markdown Sink to be able to convert anything to Markdown

2022-12-29 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/DOXIA-569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17652859#comment-17652859 ] ASF GitHub Bot commented on DOXIA-569: -- hboutemy commented on code in PR #128: URL: h

[GitHub] [maven-doxia] hboutemy commented on a diff in pull request #128: DOXIA-569 add Markdown output (sink)

2022-12-29 Thread GitBox
hboutemy commented on code in PR #128: URL: https://github.com/apache/maven-doxia/pull/128#discussion_r1058980228 ## doxia-modules/doxia-module-markdown/src/main/java/org/apache/maven/doxia/module/markdown/MarkdownMarkup.java: ## @@ -0,0 +1,144 @@ +package org.apache.maven.doxia

[jira] [Commented] (DOXIA-569) Add Markdown Sink to be able to convert anything to Markdown

2022-12-29 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/DOXIA-569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17652860#comment-17652860 ] ASF GitHub Bot commented on DOXIA-569: -- hboutemy commented on code in PR #128: URL: h

[GitHub] [maven-doxia] michael-o commented on a diff in pull request #128: DOXIA-569 add Markdown output (sink)

2022-12-29 Thread GitBox
michael-o commented on code in PR #128: URL: https://github.com/apache/maven-doxia/pull/128#discussion_r1058981264 ## doxia-modules/doxia-module-markdown/src/main/java/org/apache/maven/doxia/module/markdown/MarkdownMarkup.java: ## @@ -0,0 +1,144 @@ +package org.apache.maven.doxi

[jira] [Commented] (DOXIA-569) Add Markdown Sink to be able to convert anything to Markdown

2022-12-29 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/DOXIA-569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17652861#comment-17652861 ] ASF GitHub Bot commented on DOXIA-569: -- michael-o commented on code in PR #128: URL:

[GitHub] [maven] hboutemy commented on a diff in pull request #830: [MNG-7571] add Maven API javadoc

2022-12-29 Thread GitBox
hboutemy commented on code in PR #830: URL: https://github.com/apache/maven/pull/830#discussion_r1058983423 ## plexus-utils/pom.xml: ## @@ -28,6 +28,8 @@ under the License. org.apache.maven plexus-utils 4.0.0-alpha-4-SNAPSHOT + Apache Maven Plexus-Utils + Apache Maven

[jira] [Commented] (MNG-7571) add new Maven immutable API to reference documentation

2022-12-29 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-7571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17652862#comment-17652862 ] ASF GitHub Bot commented on MNG-7571: - hboutemy commented on code in PR #830: URL: http

[GitHub] [maven] hboutemy commented on a diff in pull request #830: [MNG-7571] add Maven API javadoc

2022-12-29 Thread GitBox
hboutemy commented on code in PR #830: URL: https://github.com/apache/maven/pull/830#discussion_r1058984209 ## api/maven-api-core/src/site/site.xml: ## @@ -0,0 +1,38 @@ + + + + +http://maven.apache.org/DECORATION/1.8.0"; xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; +

[jira] [Commented] (MNG-7571) add new Maven immutable API to reference documentation

2022-12-29 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-7571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17652863#comment-17652863 ] ASF GitHub Bot commented on MNG-7571: - hboutemy commented on code in PR #830: URL: http

[GitHub] [maven] michael-o commented on a diff in pull request #830: [MNG-7571] add Maven API javadoc

2022-12-29 Thread GitBox
michael-o commented on code in PR #830: URL: https://github.com/apache/maven/pull/830#discussion_r1058986630 ## plexus-utils/pom.xml: ## @@ -28,6 +28,8 @@ under the License. org.apache.maven plexus-utils 4.0.0-alpha-4-SNAPSHOT + Apache Maven Plexus-Utils + Apache Mave

[GitHub] [maven] hboutemy commented on a diff in pull request #830: [MNG-7571] add Maven API javadoc

2022-12-29 Thread GitBox
hboutemy commented on code in PR #830: URL: https://github.com/apache/maven/pull/830#discussion_r1058986535 ## api/maven-api-meta/pom.xml: ## @@ -27,6 +27,7 @@ maven-api-meta - Maven API Meta annotations + Maven 4 API Meta annotations Review Comment: should we ren

[jira] [Commented] (MNG-7571) add new Maven immutable API to reference documentation

2022-12-29 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-7571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17652864#comment-17652864 ] ASF GitHub Bot commented on MNG-7571: - hboutemy commented on code in PR #830: URL: http

[jira] [Commented] (MNG-7571) add new Maven immutable API to reference documentation

2022-12-29 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-7571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17652865#comment-17652865 ] ASF GitHub Bot commented on MNG-7571: - michael-o commented on code in PR #830: URL: htt

[GitHub] [maven] michael-o commented on a diff in pull request #830: [MNG-7571] add Maven API javadoc

2022-12-29 Thread GitBox
michael-o commented on code in PR #830: URL: https://github.com/apache/maven/pull/830#discussion_r1058986775 ## api/maven-api-core/src/site/site.xml: ## @@ -0,0 +1,38 @@ + + + + +http://maven.apache.org/DECORATION/1.8.0"; xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; +

[GitHub] [maven] hboutemy commented on a diff in pull request #830: [MNG-7571] add Maven API javadoc

2022-12-29 Thread GitBox
hboutemy commented on code in PR #830: URL: https://github.com/apache/maven/pull/830#discussion_r1058987151 ## api/maven-api-settings/pom.xml: ## @@ -28,8 +28,8 @@ under the License. maven-api-settings - Maven API Settings - Maven API Settings model. + Maven 4 API - Se

[jira] [Commented] (MNG-7571) add new Maven immutable API to reference documentation

2022-12-29 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-7571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17652866#comment-17652866 ] ASF GitHub Bot commented on MNG-7571: - michael-o commented on code in PR #830: URL: htt

[GitHub] [maven] michael-o commented on a diff in pull request #830: [MNG-7571] add Maven API javadoc

2022-12-29 Thread GitBox
michael-o commented on code in PR #830: URL: https://github.com/apache/maven/pull/830#discussion_r1058987275 ## api/maven-api-meta/pom.xml: ## @@ -27,6 +27,7 @@ maven-api-meta - Maven API Meta annotations + Maven 4 API Meta annotations Review Comment: Yes, good id

[jira] [Commented] (MNG-7571) add new Maven immutable API to reference documentation

2022-12-29 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-7571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17652867#comment-17652867 ] ASF GitHub Bot commented on MNG-7571: - hboutemy commented on code in PR #830: URL: http

[jira] [Commented] (MNG-7571) add new Maven immutable API to reference documentation

2022-12-29 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-7571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17652868#comment-17652868 ] ASF GitHub Bot commented on MNG-7571: - michael-o commented on code in PR #830: URL: htt

[GitHub] [maven] michael-o commented on a diff in pull request #830: [MNG-7571] add Maven API javadoc

2022-12-29 Thread GitBox
michael-o commented on code in PR #830: URL: https://github.com/apache/maven/pull/830#discussion_r1058988520 ## api/maven-api-settings/pom.xml: ## @@ -28,8 +28,8 @@ under the License. maven-api-settings - Maven API Settings - Maven API Settings model. + Maven 4 API - S

[jira] [Commented] (MNG-7571) add new Maven immutable API to reference documentation

2022-12-29 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-7571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17652869#comment-17652869 ] ASF GitHub Bot commented on MNG-7571: - michael-o commented on code in PR #830: URL: htt

[GitHub] [maven] michael-o commented on a diff in pull request #830: [MNG-7571] add Maven API javadoc

2022-12-29 Thread GitBox
michael-o commented on code in PR #830: URL: https://github.com/apache/maven/pull/830#discussion_r1058988520 ## api/maven-api-settings/pom.xml: ## @@ -28,8 +28,8 @@ under the License. maven-api-settings - Maven API Settings - Maven API Settings model. + Maven 4 API - S

[GitHub] [maven] michael-o commented on a diff in pull request #830: [MNG-7571] add Maven API javadoc

2022-12-29 Thread GitBox
michael-o commented on code in PR #830: URL: https://github.com/apache/maven/pull/830#discussion_r1058988520 ## api/maven-api-settings/pom.xml: ## @@ -28,8 +28,8 @@ under the License. maven-api-settings - Maven API Settings - Maven API Settings model. + Maven 4 API - S

[jira] [Commented] (MNG-7571) add new Maven immutable API to reference documentation

2022-12-29 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-7571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17652870#comment-17652870 ] ASF GitHub Bot commented on MNG-7571: - michael-o commented on code in PR #830: URL: htt

[jira] [Commented] (MNG-7571) add new Maven immutable API to reference documentation

2022-12-29 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-7571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17652871#comment-17652871 ] ASF GitHub Bot commented on MNG-7571: - michael-o commented on code in PR #830: URL: htt

[GitHub] [maven-enforcer] slawekjaranowski merged pull request #210: [MENFORCER-431] Clean-up - use List instead of String[]

2022-12-29 Thread GitBox
slawekjaranowski merged PR #210: URL: https://github.com/apache/maven-enforcer/pull/210 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr.

[GitHub] [maven-doxia] michael-o commented on pull request #134: Bump flexmarkVersion from 0.62.2 to 0.64.0

2022-12-29 Thread GitBox
michael-o commented on PR #134: URL: https://github.com/apache/maven-doxia/pull/134#issuecomment-1367389436 Can't be done. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. T

[GitHub] [maven-doxia] michael-o closed pull request #134: Bump flexmarkVersion from 0.62.2 to 0.64.0

2022-12-29 Thread GitBox
michael-o closed pull request #134: Bump flexmarkVersion from 0.62.2 to 0.64.0 URL: https://github.com/apache/maven-doxia/pull/134 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

[GitHub] [maven-doxia] dependabot[bot] commented on pull request #134: Bump flexmarkVersion from 0.62.2 to 0.64.0

2022-12-29 Thread GitBox
dependabot[bot] commented on PR #134: URL: https://github.com/apache/maven-doxia/pull/134#issuecomment-1367389466 OK, I won't notify you again about this release, but will get in touch when a new version is available. You can also ignore all major, minor, or patch releases for a dependency

[GitHub] [maven-doxia] michael-o commented on pull request #132: [DOXIA-617] support yaml metadata

2022-12-29 Thread GitBox
michael-o commented on PR #132: URL: https://github.com/apache/maven-doxia/pull/132#issuecomment-1367391412 > if we use the parsing API for YAML form of metadata, it means we stop supporting metadata without the `---` delimiters > > is it really what you all want? This would be

[jira] [Commented] (DOXIA-617) doxia-module-markdown: Add support for --- header section marks

2022-12-29 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/DOXIA-617?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17652876#comment-17652876 ] ASF GitHub Bot commented on DOXIA-617: -- michael-o commented on PR #132: URL: https://

[GitHub] [maven-doxia] cstamas commented on pull request #134: Bump flexmarkVersion from 0.62.2 to 0.64.0

2022-12-29 Thread GitBox
cstamas commented on PR #134: URL: https://github.com/apache/maven-doxia/pull/134#issuecomment-1367393699 > Can't be done. Just out of curiosity, why? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

[jira] [Comment Edited] (MENFORCER-431) Skip specific rules

2022-12-29 Thread Jira
[ https://issues.apache.org/jira/browse/MENFORCER-431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17652853#comment-17652853 ] Petr Široký edited comment on MENFORCER-431 at 12/29/22 3:05 PM: ---

[GitHub] [maven-doxia] michael-o commented on pull request #134: Bump flexmarkVersion from 0.62.2 to 0.64.0

2022-12-29 Thread GitBox
michael-o commented on PR #134: URL: https://github.com/apache/maven-doxia/pull/134#issuecomment-1367396206 > > Can't be done. > > Just out of curiosity, why? One of the reasons I consider these bots totally useless: https://github.com/apache/maven-doxia/blob/master/doxia-modul

[GitHub] [maven-doxia] cstamas commented on pull request #134: Bump flexmarkVersion from 0.62.2 to 0.64.0

2022-12-29 Thread GitBox
cstamas commented on PR #134: URL: https://github.com/apache/maven-doxia/pull/134#issuecomment-1367399384 wow, so it went Java 11 between 0.62 and 0.64? wow -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [maven-doxia] michael-o commented on pull request #134: Bump flexmarkVersion from 0.62.2 to 0.64.0

2022-12-29 Thread GitBox
michael-o commented on PR #134: URL: https://github.com/apache/maven-doxia/pull/134#issuecomment-1367400991 > wow, so it went Java 11 between 0.62 and 0.64? wow Yes, that is total bullshit development. -- This is an automated message from the Apache Git Service. To respond to the m

[jira] [Updated] (MENFORCER-454) Deprecate 'rules' property and introduce 'enforcer.rules' as a replacement

2022-12-29 Thread Jira
[ https://issues.apache.org/jira/browse/MENFORCER-454?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Petr Široký updated MENFORCER-454: -- Description: The current property {{rules}} is the only one that does not use the {{{}enfor

[jira] [Created] (MENFORCER-454) Deprecate 'rules' property and introduce 'enforcer.rules' as a replacement

2022-12-29 Thread Jira
Petr Široký created MENFORCER-454: - Summary: Deprecate 'rules' property and introduce 'enforcer.rules' as a replacement Key: MENFORCER-454 URL: https://issues.apache.org/jira/browse/MENFORCER-454 Proj

[GitHub] [maven] hboutemy opened a new pull request, #942: [MNG-7655] maven-plexus-utils and maven-plexus-utils-xml (xml-impl)

2022-12-29 Thread GitBox
hboutemy opened a new pull request, #942: URL: https://github.com/apache/maven/pull/942 https://issues.apache.org/jira/browse/MNG-7655 keeping `plexus-utils` artifactId with `org.apache.maven` vs `org.codehaus.plexus` groupId is confusing: let's name it `maven-plexus-utils` and

[jira] [Commented] (MNG-7655) rename Maven core's plexus-utils to more explicit artifactId

2022-12-29 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-7655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17652888#comment-17652888 ] ASF GitHub Bot commented on MNG-7655: - hboutemy opened a new pull request, #942: URL: h

[GitHub] [maven-doxia] hboutemy commented on a diff in pull request #128: DOXIA-569 add Markdown output (sink)

2022-12-29 Thread GitBox
hboutemy commented on code in PR #128: URL: https://github.com/apache/maven-doxia/pull/128#discussion_r1059032524 ## doxia-modules/doxia-module-markdown/src/main/java/org/apache/maven/doxia/module/markdown/MarkdownMarkup.java: ## @@ -0,0 +1,144 @@ +package org.apache.maven.doxia

[jira] [Commented] (DOXIA-569) Add Markdown Sink to be able to convert anything to Markdown

2022-12-29 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/DOXIA-569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17652889#comment-17652889 ] ASF GitHub Bot commented on DOXIA-569: -- hboutemy commented on code in PR #128: URL: h

[GitHub] [maven-enforcer] psiroky opened a new pull request, #211: [MENFORCER-454] Deprecate 'rules' property and introduce 'enforcer.rules' as a replacement

2022-12-29 Thread GitBox
psiroky opened a new pull request, #211: URL: https://github.com/apache/maven-enforcer/pull/211 This aligns the property names to us the `enforcer.` prefix. Also updated the ITs to verify the rules are indeed getting fully replaced with the list from the property Following

[GitHub] [maven-doxia] michael-o commented on a diff in pull request #128: DOXIA-569 add Markdown output (sink)

2022-12-29 Thread GitBox
michael-o commented on code in PR #128: URL: https://github.com/apache/maven-doxia/pull/128#discussion_r1059036758 ## doxia-modules/doxia-module-markdown/src/main/java/org/apache/maven/doxia/module/markdown/MarkdownMarkup.java: ## @@ -0,0 +1,144 @@ +package org.apache.maven.doxi

[jira] [Commented] (DOXIA-569) Add Markdown Sink to be able to convert anything to Markdown

2022-12-29 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/DOXIA-569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17652893#comment-17652893 ] ASF GitHub Bot commented on DOXIA-569: -- michael-o commented on code in PR #128: URL:

[GitHub] [maven-enforcer] slawekjaranowski commented on a diff in pull request #211: [MENFORCER-454] Deprecate 'rules' property and introduce 'enforcer.rules' as a replacement

2022-12-29 Thread GitBox
slawekjaranowski commented on code in PR #211: URL: https://github.com/apache/maven-enforcer/pull/211#discussion_r1059047291 ## maven-enforcer-plugin/src/main/java/org/apache/maven/plugins/enforcer/EnforceMojo.java: ## @@ -127,11 +127,22 @@ public class EnforceMojo extends Abstr

  1   2   3   >