[GitHub] [maven-resolver] caiwei-ebay opened a new pull request, #217: fix param does not match with doc

caiwei-ebay opened a new pull request, #217: URL: https://github.com/apache/maven-resolver/pull/217 As discussed in https://issues.apache.org/jira/browse/MNG-5896, the param in code does not match with the one in doc: https://maven.apache.org/resolver/configuration.html DOC: aether

[GitHub] [maven-resolver] caiwei-ebay commented on pull request #217: fix param does not match with doc

caiwei-ebay commented on PR #217: URL: https://github.com/apache/maven-resolver/pull/217#issuecomment-1309996966 @michael-o @cstamas Please help cheeck. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

[jira] [Commented] (MNG-5896) Download dependency POMs in parallel

[ https://issues.apache.org/jira/browse/MNG-5896?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17631551#comment-17631551 ] wei cai commented on MNG-5896: -- [~jhaber] [~michael-o] [~cstamas]  Thanks for feedback. Hope

[GitHub] [maven] michael-o commented on pull request #863: [MNG-7590] Allow to configure resolver by properties in settings.xml

michael-o commented on PR #863: URL: https://github.com/apache/maven/pull/863#issuecomment-1310138531 > Well, sorry for late as I missed: due https://issues.apache.org/jira/browse/MRESOLVER-284 this is not true for ANY settings as we talk here only about session config properties, but i

[jira] [Commented] (MNG-7590) Allow configure resolver by properties in settings.xml

[ https://issues.apache.org/jira/browse/MNG-7590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17631598#comment-17631598 ] ASF GitHub Bot commented on MNG-7590: - michael-o commented on PR #863: URL: https://git

[GitHub] [maven] AzezSalami opened a new pull request, #868: Move the misleading logger from multiModuleProjectPom to collectProjects

AzezSalami opened a new pull request, #868: URL: https://github.com/apache/maven/pull/868 JIRA issue: https://issues.apache.org/jira/browse/MNG-7542 To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/

[GitHub] [maven] slawekjaranowski commented on pull request #863: [MNG-7590] Allow to configure resolver by properties in settings.xml

slawekjaranowski commented on PR #863: URL: https://github.com/apache/maven/pull/863#issuecomment-1310349244 I also think that the most configuration will be worked. I see that only `aether.syncContext.named.factory` and `aether.syncContext.named.nameMapper` was moved from session scop

[jira] [Commented] (MNG-7590) Allow configure resolver by properties in settings.xml

[ https://issues.apache.org/jira/browse/MNG-7590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17631672#comment-17631672 ] ASF GitHub Bot commented on MNG-7590: - slawekjaranowski commented on PR #863: URL: http

[GitHub] [maven-parent] kwin opened a new pull request, #90: [MPOM-354] leverage new report plugin

kwin opened a new pull request, #90: URL: https://github.com/apache/maven-parent/pull/90 use javadoc from plugin documentation -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

[jira] [Commented] (MJAVADOC-692) Error generating maven-javadoc-plugin:3.3.1:test-aggregate-no-fork report

[ https://issues.apache.org/jira/browse/MJAVADOC-692?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17631687#comment-17631687 ] Anthony Vanelverdinghe commented on MJAVADOC-692: - This can be closed s

[GitHub] [maven-plugin-tools] gnodet commented on pull request #117: [MPLUGIN-441] Support for the new maven4 api

gnodet commented on PR #117: URL: https://github.com/apache/maven-plugin-tools/pull/117#issuecomment-1310466640 @kwin @slawekjaranowski I've rebased, cleaned up and added an IT. The base maven version has been reverted to 3.2.5 so that the plugin remains fully compatible with 3.x. -- T

[jira] [Commented] (MPLUGIN-441) Support mojos using the new maven v4 api

[ https://issues.apache.org/jira/browse/MPLUGIN-441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17631712#comment-17631712 ] ASF GitHub Bot commented on MPLUGIN-441: gnodet commented on PR #117: URL: http

[GitHub] [maven-parent] slawekjaranowski commented on a diff in pull request #90: [MPOM-354] leverage new report plugin

slawekjaranowski commented on code in PR #90: URL: https://github.com/apache/maven-parent/pull/90#discussion_r1019286693 ## maven-plugins/pom.xml: ## @@ -145,9 +148,21 @@ under the License. + +org.apache.maven.plugins +maven-javadoc-plugin +

[GitHub] [maven-parent] kwin commented on a diff in pull request #90: [MPOM-354] leverage new report plugin

kwin commented on code in PR #90: URL: https://github.com/apache/maven-parent/pull/90#discussion_r1019300267 ## maven-plugins/pom.xml: ## @@ -145,9 +148,21 @@ under the License. + +org.apache.maven.plugins +maven-javadoc-plugin + +

[jira] [Commented] (MDEPLOY-201) deployAtEnd issue for multi-module projects

[ https://issues.apache.org/jira/browse/MDEPLOY-201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17631720#comment-17631720 ] jycr commented on MDEPLOY-201: -- This issue is reproducible with version 3.0.0. [~sjaranows

[GitHub] [maven] MartinKanters opened a new pull request, #869: [MNG-7338] Automatically activate batch-mode and make output quiet when running in CI.

MartinKanters opened a new pull request, #869: URL: https://github.com/apache/maven/pull/869 After a discussion with @rmannibucau, @slawekjaranowski and @michael-o, I think this is the best solution. The env CI check is done in Java code, making it easy to unit test. Also, a new flag had

[jira] [Commented] (MNG-7338) Reduce carbon footprint in CI

[ https://issues.apache.org/jira/browse/MNG-7338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17631729#comment-17631729 ] ASF GitHub Bot commented on MNG-7338: - MartinKanters opened a new pull request, #869: U

[GitHub] [maven-dependency-plugin] antoniolucasnobar opened a new pull request, #260: Mdep 568 go offline filter

antoniolucasnobar opened a new pull request, #260: URL: https://github.com/apache/maven-dependency-plugin/pull/260 Following this checklist to help us incorporate your contribution quickly and easily: - [x] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/M

[GitHub] [maven-dependency-plugin] antoniolucasnobar closed pull request #260: Mdep 568 go offline filter

antoniolucasnobar closed pull request #260: Mdep 568 go offline filter URL: https://github.com/apache/maven-dependency-plugin/pull/260 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific com

[GitHub] [maven-plugin-tools] slawekjaranowski commented on a diff in pull request #117: [MPLUGIN-441] Support for the new maven4 api

slawekjaranowski commented on code in PR #117: URL: https://github.com/apache/maven-plugin-tools/pull/117#discussion_r1019317435 ## pom.xml: ## @@ -29,7 +29,7 @@ org.apache.maven.plugin-tools maven-plugin-tools - 3.7.1-SNAPSHOT + 4.0.0-SNAPSHOT Review Comment: Do

[jira] [Commented] (MPLUGIN-441) Support mojos using the new maven v4 api

[ https://issues.apache.org/jira/browse/MPLUGIN-441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17631752#comment-17631752 ] ASF GitHub Bot commented on MPLUGIN-441: slawekjaranowski commented on code in P

[GitHub] [maven-plugin-tools] gnodet commented on a diff in pull request #117: [MPLUGIN-441] Support for the new maven4 api

gnodet commented on code in PR #117: URL: https://github.com/apache/maven-plugin-tools/pull/117#discussion_r1019359399 ## maven-plugin-tools-api/src/main/java/org/apache/maven/tools/plugin/util/PluginUtils.java: ## @@ -63,7 +63,14 @@ private PluginUtils() mavenComponen

[jira] [Commented] (MPLUGIN-441) Support mojos using the new maven v4 api

[ https://issues.apache.org/jira/browse/MPLUGIN-441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17631755#comment-17631755 ] ASF GitHub Bot commented on MPLUGIN-441: gnodet commented on code in PR #117: UR

[GitHub] [maven-plugin-tools] gnodet commented on a diff in pull request #117: [MPLUGIN-441] Support for the new maven4 api

gnodet commented on code in PR #117: URL: https://github.com/apache/maven-plugin-tools/pull/117#discussion_r1019361346 ## pom.xml: ## @@ -29,7 +29,7 @@ org.apache.maven.plugin-tools maven-plugin-tools - 3.7.1-SNAPSHOT + 4.0.0-SNAPSHOT Review Comment: Not really.

[jira] [Commented] (MPLUGIN-441) Support mojos using the new maven v4 api

[ https://issues.apache.org/jira/browse/MPLUGIN-441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17631758#comment-17631758 ] ASF GitHub Bot commented on MPLUGIN-441: gnodet commented on code in PR #117: UR

[GitHub] [maven-plugin-tools] gnodet commented on a diff in pull request #117: [MPLUGIN-441] Support for the new maven4 api

gnodet commented on code in PR #117: URL: https://github.com/apache/maven-plugin-tools/pull/117#discussion_r1019369103 ## pom.xml: ## @@ -29,7 +29,7 @@ org.apache.maven.plugin-tools maven-plugin-tools - 3.7.1-SNAPSHOT + 4.0.0-SNAPSHOT Review Comment: The downside

[jira] [Commented] (MPLUGIN-441) Support mojos using the new maven v4 api

[ https://issues.apache.org/jira/browse/MPLUGIN-441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17631766#comment-17631766 ] ASF GitHub Bot commented on MPLUGIN-441: gnodet commented on code in PR #117: UR

[GitHub] [maven-plugin-tools] gnodet commented on a diff in pull request #117: [MPLUGIN-441] Support for the new maven4 api

gnodet commented on code in PR #117: URL: https://github.com/apache/maven-plugin-tools/pull/117#discussion_r1019371002 ## maven-plugin-plugin/pom.xml: ## @@ -38,11 +38,12 @@ -${mavenVersion} +3.2.5 Review Comment: Yes, that comes from when the PR had switc

[jira] [Commented] (MPLUGIN-441) Support mojos using the new maven v4 api

[ https://issues.apache.org/jira/browse/MPLUGIN-441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17631767#comment-17631767 ] ASF GitHub Bot commented on MPLUGIN-441: gnodet commented on code in PR #117: UR

[GitHub] [maven-parent] slawekjaranowski commented on a diff in pull request #90: [MPOM-354] leverage new report plugin

slawekjaranowski commented on code in PR #90: URL: https://github.com/apache/maven-parent/pull/90#discussion_r1019378271 ## maven-plugins/pom.xml: ## @@ -145,9 +148,21 @@ under the License. + +org.apache.maven.plugins +maven-javadoc-plugin +

[GitHub] [maven-plugin-tools] slawekjaranowski commented on a diff in pull request #117: [MPLUGIN-441] Support for the new maven4 api

slawekjaranowski commented on code in PR #117: URL: https://github.com/apache/maven-plugin-tools/pull/117#discussion_r1019383208 ## maven-plugin-tools-api/src/main/java/org/apache/maven/tools/plugin/util/PluginUtils.java: ## @@ -63,7 +63,14 @@ private PluginUtils() mav

[jira] [Commented] (MPLUGIN-441) Support mojos using the new maven v4 api

[ https://issues.apache.org/jira/browse/MPLUGIN-441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17631776#comment-17631776 ] ASF GitHub Bot commented on MPLUGIN-441: slawekjaranowski commented on code in P

[GitHub] [maven-plugin-tools] slawekjaranowski commented on a diff in pull request #117: [MPLUGIN-441] Support for the new maven4 api

slawekjaranowski commented on code in PR #117: URL: https://github.com/apache/maven-plugin-tools/pull/117#discussion_r1019383208 ## maven-plugin-tools-api/src/main/java/org/apache/maven/tools/plugin/util/PluginUtils.java: ## @@ -63,7 +63,14 @@ private PluginUtils() mav

[jira] [Commented] (MPLUGIN-441) Support mojos using the new maven v4 api

[ https://issues.apache.org/jira/browse/MPLUGIN-441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17631778#comment-17631778 ] ASF GitHub Bot commented on MPLUGIN-441: slawekjaranowski commented on code in P

[GitHub] [maven-plugin-tools] gnodet commented on a diff in pull request #117: [MPLUGIN-441] Support for the new maven4 api

gnodet commented on code in PR #117: URL: https://github.com/apache/maven-plugin-tools/pull/117#discussion_r1019385027 ## maven-plugin-tools-api/src/main/java/org/apache/maven/tools/plugin/util/PluginUtils.java: ## @@ -63,7 +63,14 @@ private PluginUtils() mavenComponen

[jira] [Commented] (MPLUGIN-441) Support mojos using the new maven v4 api

[ https://issues.apache.org/jira/browse/MPLUGIN-441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17631781#comment-17631781 ] ASF GitHub Bot commented on MPLUGIN-441: gnodet commented on code in PR #117: UR

[GitHub] [maven-plugin-tools] gnodet commented on a diff in pull request #117: [MPLUGIN-441] Support for the new maven4 api

gnodet commented on code in PR #117: URL: https://github.com/apache/maven-plugin-tools/pull/117#discussion_r1019394322 ## maven-plugin-tools-api/src/main/java/org/apache/maven/tools/plugin/util/PluginUtils.java: ## @@ -63,7 +63,14 @@ private PluginUtils() mavenComponen

[jira] [Commented] (MPLUGIN-441) Support mojos using the new maven v4 api

[ https://issues.apache.org/jira/browse/MPLUGIN-441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17631791#comment-17631791 ] ASF GitHub Bot commented on MPLUGIN-441: gnodet commented on code in PR #117: UR

[GitHub] [maven] rmannibucau commented on a diff in pull request #869: [MNG-7338] Automatically activate batch-mode and make output quiet when running in CI.

rmannibucau commented on code in PR #869: URL: https://github.com/apache/maven/pull/869#discussion_r1019401966 ## maven-embedder/src/main/java/org/apache/maven/cli/MavenCli.java: ## @@ -1593,7 +1622,10 @@ private TransferListener determineTransferListener( final boolean quiet,

[jira] [Commented] (MNG-7338) Reduce carbon footprint in CI

[ https://issues.apache.org/jira/browse/MNG-7338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17631794#comment-17631794 ] ASF GitHub Bot commented on MNG-7338: - rmannibucau commented on code in PR #869: URL: h

[GitHub] [maven] michael-o commented on a diff in pull request #869: [MNG-7338] Automatically activate batch-mode and make output quiet when running in CI.

michael-o commented on code in PR #869: URL: https://github.com/apache/maven/pull/869#discussion_r1019414975 ## maven-embedder/src/main/java/org/apache/maven/cli/MavenCli.java: ## @@ -1593,7 +1622,10 @@ private TransferListener determineTransferListener( final boolean quiet,

[jira] [Commented] (MNG-7338) Reduce carbon footprint in CI

[ https://issues.apache.org/jira/browse/MNG-7338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17631802#comment-17631802 ] ASF GitHub Bot commented on MNG-7338: - michael-o commented on code in PR #869: URL: htt

[GitHub] [maven] rmannibucau commented on a diff in pull request #869: [MNG-7338] Automatically activate batch-mode and make output quiet when running in CI.

rmannibucau commented on code in PR #869: URL: https://github.com/apache/maven/pull/869#discussion_r1019424733 ## maven-embedder/src/main/java/org/apache/maven/cli/MavenCli.java: ## @@ -1593,7 +1622,10 @@ private TransferListener determineTransferListener( final boolean quiet,

[jira] [Commented] (MNG-7338) Reduce carbon footprint in CI

[ https://issues.apache.org/jira/browse/MNG-7338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17631806#comment-17631806 ] ASF GitHub Bot commented on MNG-7338: - rmannibucau commented on code in PR #869: URL: h

[GitHub] [maven-parent] kwin commented on a diff in pull request #90: [MPOM-354] leverage new report plugin

kwin commented on code in PR #90: URL: https://github.com/apache/maven-parent/pull/90#discussion_r1019431694 ## maven-plugins/pom.xml: ## @@ -145,9 +148,21 @@ under the License. + +org.apache.maven.plugins +maven-javadoc-plugin + +

[GitHub] [maven-parent] kwin commented on a diff in pull request #90: [MPOM-354] leverage new report plugin

kwin commented on code in PR #90: URL: https://github.com/apache/maven-parent/pull/90#discussion_r1019431694 ## maven-plugins/pom.xml: ## @@ -145,9 +148,21 @@ under the License. + +org.apache.maven.plugins +maven-javadoc-plugin + +

[GitHub] [maven] michael-o commented on a diff in pull request #869: [MNG-7338] Automatically activate batch-mode and make output quiet when running in CI.

michael-o commented on code in PR #869: URL: https://github.com/apache/maven/pull/869#discussion_r1019443790 ## maven-embedder/src/main/java/org/apache/maven/cli/MavenCli.java: ## @@ -1593,7 +1622,10 @@ private TransferListener determineTransferListener( final boolean quiet,

[jira] [Commented] (MNG-7338) Reduce carbon footprint in CI

[ https://issues.apache.org/jira/browse/MNG-7338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17631814#comment-17631814 ] ASF GitHub Bot commented on MNG-7338: - michael-o commented on code in PR #869: URL: htt

[GitHub] [maven] rmannibucau commented on a diff in pull request #869: [MNG-7338] Automatically activate batch-mode and make output quiet when running in CI.

rmannibucau commented on code in PR #869: URL: https://github.com/apache/maven/pull/869#discussion_r1019463457 ## maven-embedder/src/main/java/org/apache/maven/cli/MavenCli.java: ## @@ -1593,7 +1622,10 @@ private TransferListener determineTransferListener( final boolean quiet,

[jira] [Commented] (MNG-7338) Reduce carbon footprint in CI

[ https://issues.apache.org/jira/browse/MNG-7338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17631832#comment-17631832 ] ASF GitHub Bot commented on MNG-7338: - rmannibucau commented on code in PR #869: URL: h

[GitHub] [maven-parent] kwin commented on a diff in pull request #90: [MPOM-354] leverage new report plugin

kwin commented on code in PR #90: URL: https://github.com/apache/maven-parent/pull/90#discussion_r1019470524 ## maven-plugins/pom.xml: ## @@ -145,9 +148,21 @@ under the License. + +org.apache.maven.plugins +maven-javadoc-plugin + +

[GitHub] [maven] michael-o commented on a diff in pull request #869: [MNG-7338] Automatically activate batch-mode and make output quiet when running in CI.

michael-o commented on code in PR #869: URL: https://github.com/apache/maven/pull/869#discussion_r1019482470 ## maven-embedder/src/main/java/org/apache/maven/cli/MavenCli.java: ## @@ -1593,7 +1622,10 @@ private TransferListener determineTransferListener( final boolean quiet,

[jira] [Commented] (MNG-7338) Reduce carbon footprint in CI

[ https://issues.apache.org/jira/browse/MNG-7338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17631852#comment-17631852 ] ASF GitHub Bot commented on MNG-7338: - michael-o commented on code in PR #869: URL: htt

[GitHub] [maven] rmannibucau commented on a diff in pull request #869: [MNG-7338] Automatically activate batch-mode and make output quiet when running in CI.

rmannibucau commented on code in PR #869: URL: https://github.com/apache/maven/pull/869#discussion_r1019516366 ## maven-embedder/src/main/java/org/apache/maven/cli/MavenCli.java: ## @@ -1593,7 +1622,10 @@ private TransferListener determineTransferListener( final boolean quiet,

[jira] [Commented] (MNG-7338) Reduce carbon footprint in CI

[ https://issues.apache.org/jira/browse/MNG-7338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17631870#comment-17631870 ] ASF GitHub Bot commented on MNG-7338: - rmannibucau commented on code in PR #869: URL: h

[GitHub] [maven] mthmulders commented on pull request #868: Move the misleading logger from multiModuleProjectPom to collectProjects

mthmulders commented on PR #868: URL: https://github.com/apache/maven/pull/868#issuecomment-1311334950 Note to self: commit message could include > Move the misleading logger from determining the multi-module project root POM to collecting the projects inside that directory. -- Thi

[GitHub] [maven] mthmulders commented on a diff in pull request #868: [MNG-7542] Remove misleading warning about multi-module root directory

mthmulders commented on code in PR #868: URL: https://github.com/apache/maven/pull/868#discussion_r1019955847 ## maven-core/src/main/java/org/apache/maven/project/collector/MultiModuleCollectionStrategy.java: ## @@ -64,23 +65,36 @@ public MultiModuleCollectionStrategy( ModelLoca

[jira] [Commented] (MNG-7542) Wrong Information - multi-module project

[ https://issues.apache.org/jira/browse/MNG-7542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17632140#comment-17632140 ] ASF GitHub Bot commented on MNG-7542: - mthmulders commented on code in PR #868: URL: ht