[jira] [Commented] (MNG-7455) IllegalStateException in SessionScope during guice injection in multithreaded build

2022-04-12 Thread Jira
[ https://issues.apache.org/jira/browse/MNG-7455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17520951#comment-17520951 ] Tamás Cservenák commented on MNG-7455: -- [~Abel S.Romero] provider would be needed if y

[jira] [Commented] (MNG-7433) [REGRESSION] Multiple maven instances working on same source tree can lock each other

2022-04-12 Thread Jira
[ https://issues.apache.org/jira/browse/MNG-7433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17520956#comment-17520956 ] Tamás Cservenák commented on MNG-7433: -- Aggregator mojos has access to full reactor, a

[jira] [Commented] (SUREFIRE-2063) Adding configuration using with --add-opens or --add-exports fails

2022-04-12 Thread Maarten Mulders (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-2063?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17520957#comment-17520957 ] Maarten Mulders commented on SUREFIRE-2063: --- Thank you, [~dsubel]! If I did

[jira] [Closed] (MNG-7458) Maven 3.8.4 binary is missing

2022-04-12 Thread Slawomir Jaranowski (Jira)
[ https://issues.apache.org/jira/browse/MNG-7458?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Slawomir Jaranowski closed MNG-7458. Resolution: Invalid Please follow official Maven download page [https://maven.apache.org/down

[jira] [Commented] (MNG-7458) Maven 3.8.4 binary is missing

2022-04-12 Thread Noorul Islam K M (Jira)
[ https://issues.apache.org/jira/browse/MNG-7458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17520964#comment-17520964 ] Noorul Islam K M commented on MNG-7458: --- [~sjaranowski]  ok, Thank you. I see them at

[jira] [Comment Edited] (SUREFIRE-2063) Adding configuration using with --add-opens or --add-exports fails

2022-04-12 Thread Maarten Mulders (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-2063?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17520957#comment-17520957 ] Maarten Mulders edited comment on SUREFIRE-2063 at 4/12/22 7:44 AM:

[jira] [Commented] (MPLUGIN-396) Allow only @Deprecated annotation without @deprecated javadoc tag

2022-04-12 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MPLUGIN-396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17521004#comment-17521004 ] Michael Osipov commented on MPLUGIN-396: [~sjaranowski], thanks for creating thi

[GitHub] [maven-mvnd] gnodet closed pull request #577: Set default max heap size to null

2022-04-12 Thread GitBox
gnodet closed pull request #577: Set default max heap size to null URL: https://github.com/apache/maven-mvnd/pull/577 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubsc

[GitHub] [maven-mvnd] gnodet commented on pull request #577: Set default max heap size to null

2022-04-12 Thread GitBox
gnodet commented on PR #577: URL: https://github.com/apache/maven-mvnd/pull/577#issuecomment-1096340241 Superseded by #610 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [maven-mvnd] gnodet commented on issue #601: java.nio.BufferUnderflowException occurs when I run any mvnd command

2022-04-12 Thread GitBox
gnodet commented on issue #601: URL: https://github.com/apache/maven-mvnd/issues/601#issuecomment-1096355085 Fixed with #614 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [maven-mvnd] gnodet closed issue #601: java.nio.BufferUnderflowException occurs when I run any mvnd command

2022-04-12 Thread GitBox
gnodet closed issue #601: java.nio.BufferUnderflowException occurs when I run any mvnd command URL: https://github.com/apache/maven-mvnd/issues/601 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[GitHub] [maven-mvnd] gnodet closed issue #516: [discuss]`maven.version` conflict in pom.xml & system property

2022-04-12 Thread GitBox
gnodet closed issue #516: [discuss]`maven.version` conflict in pom.xml & system property URL: https://github.com/apache/maven-mvnd/issues/516 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

[GitHub] [maven-mvnd] gnodet commented on issue #516: [discuss]`maven.version` conflict in pom.xml & system property

2022-04-12 Thread GitBox
gnodet commented on issue #516: URL: https://github.com/apache/maven-mvnd/issues/516#issuecomment-1096362497 I don't think this is a `mvn` issue as maven defines those system properties explicitely: https://github.com/apache/maven/blob/8456294977b40660ce37db853de344f0d26ee46d/maven-embed

[jira] [Commented] (MNG-7455) IllegalStateException in SessionScope during guice injection in multithreaded build

2022-04-12 Thread Guillaume Nodet (Jira)
[ https://issues.apache.org/jira/browse/MNG-7455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17521036#comment-17521036 ] Guillaume Nodet commented on MNG-7455: -- Yes, this clearly looks like a regression caus

[jira] [Updated] (MPMD-334) Source Encoding parameter is ignored

2022-04-12 Thread Andreas Dangel (Jira)
[ https://issues.apache.org/jira/browse/MPMD-334?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andreas Dangel updated MPMD-334: Fix Version/s: 3.17.0 > Source Encoding parameter is ignored > >

[jira] [Updated] (MPMD-334) Source Encoding parameter is ignored

2022-04-12 Thread Andreas Dangel (Jira)
[ https://issues.apache.org/jira/browse/MPMD-334?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andreas Dangel updated MPMD-334: Component/s: PMD > Source Encoding parameter is ignored > > >

[jira] [Commented] (MSHADE-375) Source Repo Page cannot be Found

2022-04-12 Thread Slawomir Jaranowski (Jira)
[ https://issues.apache.org/jira/browse/MSHADE-375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17521051#comment-17521051 ] Slawomir Jaranowski commented on MSHADE-375: There is https://maven.apache.or

[jira] [Updated] (MSHADE-375) Source Repo Page cannot be Found

2022-04-12 Thread Slawomir Jaranowski (Jira)
[ https://issues.apache.org/jira/browse/MSHADE-375?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Slawomir Jaranowski updated MSHADE-375: --- Fix Version/s: waiting-for-feedback > Source Repo Page cannot be Found > ---

[jira] [Commented] (MSHADE-262) Add jpms goal

2022-04-12 Thread Slawomir Jaranowski (Jira)
[ https://issues.apache.org/jira/browse/MSHADE-262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17521056#comment-17521056 ] Slawomir Jaranowski commented on MSHADE-262: There is also appear idea for cr

[jira] [Commented] (MNG-7455) IllegalStateException in SessionScope during guice injection in multithreaded build

2022-04-12 Thread Guillaume Nodet (Jira)
[ https://issues.apache.org/jira/browse/MNG-7455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17521058#comment-17521058 ] Guillaume Nodet commented on MNG-7455: -- [~papegaaij]do you use a maven plugin that is

[GitHub] [maven] michael-o commented on a diff in pull request #705: [MNG-5222] Maven 3 no longer logs warnings about deprecated plugin parameters

2022-04-12 Thread GitBox
michael-o commented on code in PR #705: URL: https://github.com/apache/maven/pull/705#discussion_r848261045 ## maven-core/src/main/java/org/apache/maven/plugin/internal/ValidatingConfigurationListener.java: ## @@ -92,6 +109,102 @@ private void notify( String fieldName, Object va

[GitHub] [maven] slawekjaranowski commented on a diff in pull request #705: [MNG-5222] Maven 3 no longer logs warnings about deprecated plugin parameters

2022-04-12 Thread GitBox
slawekjaranowski commented on code in PR #705: URL: https://github.com/apache/maven/pull/705#discussion_r848269483 ## maven-core/src/main/java/org/apache/maven/plugin/internal/ValidatingConfigurationListener.java: ## @@ -92,6 +109,102 @@ private void notify( String fieldName, Ob

[GitHub] [maven] michael-o commented on a diff in pull request #705: [MNG-5222] Maven 3 no longer logs warnings about deprecated plugin parameters

2022-04-12 Thread GitBox
michael-o commented on code in PR #705: URL: https://github.com/apache/maven/pull/705#discussion_r848272147 ## maven-core/src/main/java/org/apache/maven/plugin/internal/ValidatingConfigurationListener.java: ## @@ -92,6 +109,102 @@ private void notify( String fieldName, Object va

[GitHub] [maven-pmd-plugin] adangel merged pull request #64: [MPMD-334] - Source Encoding parameter is ignored

2022-04-12 Thread GitBox
adangel merged PR #64: URL: https://github.com/apache/maven-pmd-plugin/pull/64 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.

[jira] [Closed] (MPMD-334) Source Encoding parameter is ignored

2022-04-12 Thread Andreas Dangel (Jira)
[ https://issues.apache.org/jira/browse/MPMD-334?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andreas Dangel closed MPMD-334. --- Resolution: Fixed > Source Encoding parameter is ignored > > >

[jira] [Commented] (MNG-7455) IllegalStateException in SessionScope during guice injection in multithreaded build

2022-04-12 Thread Guillaume Nodet (Jira)
[ https://issues.apache.org/jira/browse/MNG-7455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17521068#comment-17521068 ] Guillaume Nodet commented on MNG-7455: -- So the problem certainly happens if a thread i

[GitHub] [maven-integration-testing] michael-o commented on pull request #143: [MNG-5222] IT test - warn about deprecated plugin params

2022-04-12 Thread GitBox
michael-o commented on PR #143: URL: https://github.com/apache/maven-integration-testing/pull/143#issuecomment-1096550730 Call me stupid, but I ran the IT, but cannot see any warnings on the `log.txt`. I guess they aren't retained for further anlysis? This makes it hard to manually review

[jira] [Commented] (MPMD-334) Source Encoding parameter is ignored

2022-04-12 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/MPMD-334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17521071#comment-17521071 ] Hudson commented on MPMD-334: - Build succeeded in Jenkins: Maven » Maven TLP » maven-pmd-plugin

[GitHub] [maven-integration-testing] slawekjaranowski commented on pull request #143: [MNG-5222] IT test - warn about deprecated plugin params

2022-04-12 Thread GitBox
slawekjaranowski commented on PR #143: URL: https://github.com/apache/maven-integration-testing/pull/143#issuecomment-1096560485 There are three test - one test `testEmptyConfiguration` confirm that no warning is generated when no configuration is used. All test use the same test pro

[jira] [Commented] (MNG-7455) IllegalStateException in SessionScope during guice injection in multithreaded build

2022-04-12 Thread Emond Papegaaij (Jira)
[ https://issues.apache.org/jira/browse/MNG-7455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17521077#comment-17521077 ] Emond Papegaaij commented on MNG-7455: -- [~gnodet] what plugins do you mean with an agg

[jira] [Commented] (MRESOLVER-62) Resolver can skip cyclic dependencies underneath removed nodes

2022-04-12 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MRESOLVER-62?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17521079#comment-17521079 ] Michael Osipov commented on MRESOLVER-62: - I will leave this open until [~thamm

[GitHub] [maven-integration-testing] slawekjaranowski commented on pull request #143: [MNG-5222] IT test - warn about deprecated plugin params

2022-04-12 Thread GitBox
slawekjaranowski commented on PR #143: URL: https://github.com/apache/maven-integration-testing/pull/143#issuecomment-1096588646 I've set separate logs for each tests. ``` core-it-suite/target/test-classes/mng-5222-mojo-deprecated-params/log-deprecated-config.txt core-it-suit

[GitHub] [maven-integration-testing] michael-o commented on pull request #143: [MNG-5222] IT test - warn about deprecated plugin params

2022-04-12 Thread GitBox
michael-o commented on PR #143: URL: https://github.com/apache/maven-integration-testing/pull/143#issuecomment-1096606175 Checking... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [maven-indexer] michael-o commented on a diff in pull request #185: [MINDEXER-145] Update parent and dependencies

2022-04-12 Thread GitBox
michael-o commented on code in PR #185: URL: https://github.com/apache/maven-indexer/pull/185#discussion_r848338339 ## indexer-examples/indexer-examples-spring/pom.xml: ## @@ -35,7 +35,7 @@ under the License. -5.3.15 +5.3.16 Review Comment: This needs alrea

[jira] [Updated] (MRESOLVER-249) Update Hazelcast to 5.1.1 in named-locks-hazelcast module

2022-04-12 Thread Jira
[ https://issues.apache.org/jira/browse/MRESOLVER-249?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamás Cservenák updated MRESOLVER-249: -- Summary: Update Hazelcast to 5.1.1 in named-locks-hazelcast module (was: Update Haz

[GitHub] [maven-resolver] cstamas merged pull request #164: [MRESOLVER-249] Update Hazelcast to 5.1.1

2022-04-12 Thread GitBox
cstamas merged PR #164: URL: https://github.com/apache/maven-resolver/pull/164 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.

[jira] [Closed] (MRESOLVER-249) Update Hazelcast to 5.1.1 in named-locks-hazelcast module

2022-04-12 Thread Jira
[ https://issues.apache.org/jira/browse/MRESOLVER-249?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamás Cservenák closed MRESOLVER-249. - > Update Hazelcast to 5.1.1 in named-locks-hazelcast module >

[jira] [Resolved] (MRESOLVER-249) Update Hazelcast to 5.1.1 in named-locks-hazelcast module

2022-04-12 Thread Jira
[ https://issues.apache.org/jira/browse/MRESOLVER-249?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamás Cservenák resolved MRESOLVER-249. --- Resolution: Fixed > Update Hazelcast to 5.1.1 in named-locks-hazelcast module > --

[jira] [Commented] (MRESOLVER-249) Update Hazelcast to 5.1.1 in named-locks-hazelcast module

2022-04-12 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/MRESOLVER-249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17521100#comment-17521100 ] Hudson commented on MRESOLVER-249: -- Build succeeded in Jenkins: Maven » Maven TLP » m

[GitHub] [maven-resolver] dependabot[bot] opened a new pull request, #165: Bump jetty-server from 9.4.36.v20210114 to 9.4.41.v20210516 in /maven-resolver-transport-http

2022-04-12 Thread GitBox
dependabot[bot] opened a new pull request, #165: URL: https://github.com/apache/maven-resolver/pull/165 Bumps [jetty-server](https://github.com/eclipse/jetty.project) from 9.4.36.v20210114 to 9.4.41.v20210516. Release notes Sourced from https://github.com/eclipse/jetty.project/rele

[GitHub] [maven] michael-o commented on pull request #713: [MNG-7455] Use a single session object during the whole build

2022-04-12 Thread GitBox
michael-o commented on PR #713: URL: https://github.com/apache/maven/pull/713#issuecomment-1096645369 Uuuh, we have already burned ourselves with TLS. Is this really necessary? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[jira] [Commented] (MNG-7455) IllegalStateException in SessionScope during guice injection in multithreaded build

2022-04-12 Thread Abel Salgado Romero (Jira)
[ https://issues.apache.org/jira/browse/MNG-7455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17521109#comment-17521109 ] Abel Salgado Romero commented on MNG-7455: -- Thank you all for the support. As I un

[GitHub] [maven] gnodet opened a new pull request, #714: Attempt to use a single session

2022-04-12 Thread GitBox
gnodet opened a new pull request, #714: URL: https://github.com/apache/maven/pull/714 # Conflicts: #maven-core/src/main/java/org/apache/maven/execution/MavenSession.java Following this checklist to help us incorporate your contribution quickly and easily: - [ ] Make s

[jira] [Commented] (MNG-7419) Add overiding dependencies from a BOM dependencyManagement

2022-04-12 Thread zosrothko (Jira)
[ https://issues.apache.org/jira/browse/MNG-7419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17521117#comment-17521117 ] zosrothko commented on MNG-7419: Could this request extension be implemented and delivered?

[GitHub] [maven] gnodet commented on pull request #713: [MNG-7455] Use a single session object during the whole build

2022-04-12 Thread GitBox
gnodet commented on PR #713: URL: https://github.com/apache/maven/pull/713#issuecomment-1096670268 > Uuuh, we have already burned ourselves with TLS. Is this really necessary? I'd be happy to find another solution, but the revert would introduce back a TLS anyway, without actually fix

[GitHub] [maven] gnodet commented on pull request #714: [MNG-7455] Use a single session object during the whole build

2022-04-12 Thread GitBox
gnodet commented on PR #714: URL: https://github.com/apache/maven/pull/714#issuecomment-1096708307 This is similar to https://github.com/apache/maven/pull/666 which attempts to fix http://issues.apache.org/jira/browse/MNG-7401 -- This is an automated message from the Apache Git Service.

[GitHub] [maven-mvnd] gnodet commented on issue #604: Log purging goes to stdout breaking scripts

2022-04-12 Thread GitBox
gnodet commented on issue #604: URL: https://github.com/apache/maven-mvnd/issues/604#issuecomment-1096723746 @findepi #617 prints the message to the error stream so that you could redirect it to `/dev/null` without having to disable purge. Would that work for you ? -- This is an automate

[jira] [Commented] (MSHADE-323) Flatten Maven Plugin conflicts with Maven Shade Plugin

2022-04-12 Thread Ilya Kasnacheev (Jira)
[ https://issues.apache.org/jira/browse/MSHADE-323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17521142#comment-17521142 ] Ilya Kasnacheev commented on MSHADE-323: Unfortunately I'm not a committer to Mav

[GitHub] [maven-surefire] Tibor17 commented on pull request #518: [SUREFIRE-2058] - Corrupted STDOUT by directly writing to native stream in forked JVM 1 with UTF-8 console logging

2022-04-12 Thread GitBox
Tibor17 commented on PR #518: URL: https://github.com/apache/maven-surefire/pull/518#issuecomment-1096733212 @zoltanmeze I have used only your two unit tests on master without the fix. I could reproduce the issue. Thx for the fix. -- This is an automated message from the Apache Git Se

[GitHub] [maven-surefire] Tibor17 commented on pull request #518: [SUREFIRE-2058] - Corrupted STDOUT by directly writing to native stream in forked JVM 1 with UTF-8 console logging

2022-04-12 Thread GitBox
Tibor17 commented on PR #518: URL: https://github.com/apache/maven-surefire/pull/518#issuecomment-1096740032 @zoltanmeze I wrote this code but I would like to remove the [loop](https://github.com/apache/maven-surefire/pull/518/commits/8615d16ea12f472b7ed1b1f0857bfd8c961066e0#diff-3d0df21

[GitHub] [maven-war-plugin] dennisl opened a new pull request, #22: [MWAR-450] ISO-8859-1 properties files get changed into UTF-8 when fi…

2022-04-12 Thread GitBox
dennisl opened a new pull request, #22: URL: https://github.com/apache/maven-war-plugin/pull/22 …ltered. https://issues.apache.org/jira/browse/MWAR-450 The fix for this issue is similar to MRESOURCES-171. We have added a configuration parameter called propertiesEncoding to the

[GitHub] [maven-surefire] zoltanmeze commented on pull request #518: [SUREFIRE-2058] - Corrupted STDOUT by directly writing to native stream in forked JVM 1 with UTF-8 console logging

2022-04-12 Thread GitBox
zoltanmeze commented on PR #518: URL: https://github.com/apache/maven-surefire/pull/518#issuecomment-1096752891 > @zoltanmeze I wrote this code but I would like to remove the [loop](https://github.com/apache/maven-surefire/pull/518/commits/8615d16ea12f472b7ed1b1f0857bfd8c961066e0#diff-3d0df2

[GitHub] [maven] gnodet commented on pull request #713: [MNG-7455] Use a single session object during the whole build

2022-04-12 Thread GitBox
gnodet commented on PR #713: URL: https://github.com/apache/maven/pull/713#issuecomment-1096753451 > > Uuuh, we have already burned ourselves with TLS. Is this really necessary? > > I'd be happy to find another solution, but the revert would introduce back a TLS anyway, without actua

[GitHub] [maven] rmannibucau commented on pull request #713: [MNG-7455] Use a single session object during the whole build

2022-04-12 Thread GitBox
rmannibucau commented on PR #713: URL: https://github.com/apache/maven/pull/713#issuecomment-1096760181 Not a big fan if this `InheritableThreadLocal` we know doesn't work. Cant we already create a new API and keep the session instances? Maybe a bit like in your immutable PR but without a

[GitHub] [maven-surefire] Tibor17 commented on a diff in pull request #518: [SUREFIRE-2058] - Corrupted STDOUT by directly writing to native stream in forked JVM 1 with UTF-8 console logging

2022-04-12 Thread GitBox
Tibor17 commented on code in PR #518: URL: https://github.com/apache/maven-surefire/pull/518#discussion_r848466591 ## surefire-api/src/test/java/org/apache/maven/surefire/api/stream/AbstractStreamDecoderTest.java: ## @@ -258,6 +258,56 @@ public void shouldReadString() throws Exc

[GitHub] [maven-surefire] Tibor17 commented on a diff in pull request #518: [SUREFIRE-2058] - Corrupted STDOUT by directly writing to native stream in forked JVM 1 with UTF-8 console logging

2022-04-12 Thread GitBox
Tibor17 commented on code in PR #518: URL: https://github.com/apache/maven-surefire/pull/518#discussion_r848466591 ## surefire-api/src/test/java/org/apache/maven/surefire/api/stream/AbstractStreamDecoderTest.java: ## @@ -258,6 +258,56 @@ public void shouldReadString() throws Exc

[GitHub] [maven-surefire] Tibor17 commented on a diff in pull request #518: [SUREFIRE-2058] - Corrupted STDOUT by directly writing to native stream in forked JVM 1 with UTF-8 console logging

2022-04-12 Thread GitBox
Tibor17 commented on code in PR #518: URL: https://github.com/apache/maven-surefire/pull/518#discussion_r848466591 ## surefire-api/src/test/java/org/apache/maven/surefire/api/stream/AbstractStreamDecoderTest.java: ## @@ -258,6 +258,56 @@ public void shouldReadString() throws Exc

[GitHub] [maven-mvnd] findepi commented on issue #604: Log purging goes to stdout breaking scripts

2022-04-12 Thread GitBox
findepi commented on issue #604: URL: https://github.com/apache/maven-mvnd/issues/604#issuecomment-1096782301 @gnodet the stderr would do, thanks! (in my case, i don't even need to redirect it to /dev/null, it simply won't become of shell's variable value) -- This is an automated mess

[GitHub] [maven] gnodet commented on pull request #713: [MNG-7455] Use a single session object during the whole build

2022-04-12 Thread GitBox
gnodet commented on PR #713: URL: https://github.com/apache/maven/pull/713#issuecomment-109673 > Not a big fan if this `InheritableThreadLocal` we know doesn't work. > Cant we already create a new API and keep the session instances? Maybe a bit like in your immutable PR but without an

[GitHub] [maven-surefire] zoltanmeze commented on a diff in pull request #518: [SUREFIRE-2058] - Corrupted STDOUT by directly writing to native stream in forked JVM 1 with UTF-8 console logging

2022-04-12 Thread GitBox
zoltanmeze commented on code in PR #518: URL: https://github.com/apache/maven-surefire/pull/518#discussion_r848495107 ## surefire-api/src/test/java/org/apache/maven/surefire/api/stream/AbstractStreamDecoderTest.java: ## @@ -258,6 +258,56 @@ public void shouldReadString() throws

[GitHub] [maven-surefire] Tibor17 commented on a diff in pull request #518: [SUREFIRE-2058] - Corrupted STDOUT by directly writing to native stream in forked JVM 1 with UTF-8 console logging

2022-04-12 Thread GitBox
Tibor17 commented on code in PR #518: URL: https://github.com/apache/maven-surefire/pull/518#discussion_r848513301 ## surefire-api/src/test/java/org/apache/maven/surefire/api/stream/AbstractStreamDecoderTest.java: ## @@ -258,6 +258,56 @@ public void shouldReadString() throws Exc

[jira] [Created] (MRESOLVER-250) Usage of descriptors map in DataPool prevents gargabe collection

2022-04-12 Thread Frank Upgang (Jira)
Frank Upgang created MRESOLVER-250: -- Summary: Usage of descriptors map in DataPool prevents gargabe collection Key: MRESOLVER-250 URL: https://issues.apache.org/jira/browse/MRESOLVER-250 Project: Mav

[GitHub] [maven] gnodet opened a new pull request, #715: Revert "[3.8.x][MNG-7347] SessionScoped beans should be singletons for a given session"

2022-04-12 Thread GitBox
gnodet opened a new pull request, #715: URL: https://github.com/apache/maven/pull/715 Reverts apache/maven#653 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscrib

[jira] [Commented] (MNG-5222) Maven 3 no longer logs warnings about deprecated plugin parameters.

2022-04-12 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/MNG-5222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17521204#comment-17521204 ] Hudson commented on MNG-5222: - Build succeeded in Jenkins: Maven » Maven TLP » maven » PR-705 #

[jira] [Commented] (MRESOLVER-250) Usage of descriptors map in DataPool prevents gargabe collection

2022-04-12 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MRESOLVER-250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17521214#comment-17521214 ] Michael Osipov commented on MRESOLVER-250: -- Do have a fix proposal which we c

[jira] [Commented] (MRESOLVER-250) Usage of descriptors map in DataPool prevents gargabe collection

2022-04-12 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MRESOLVER-250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17521215#comment-17521215 ] Michael Osipov commented on MRESOLVER-250: -- [~cstamas] > Usage of descriptor

[GitHub] [maven] michael-o commented on pull request #715: [MNG-7455] Revert "[3.8.x][MNG-7347] SessionScoped beans should be singletons for a given session"

2022-04-12 Thread GitBox
michael-o commented on PR #715: URL: https://github.com/apache/maven/pull/715#issuecomment-1096902202 This should be a separate ticket, not hijacking MNG-7455. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

[jira] [Commented] (MNG-5222) Maven 3 no longer logs warnings about deprecated plugin parameters.

2022-04-12 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/MNG-5222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17521224#comment-17521224 ] Hudson commented on MNG-5222: - Build unstable in Jenkins: Maven » Maven TLP » maven » PR-705 #8

[GitHub] [maven] rmannibucau commented on pull request #713: [MNG-7455] Use a single session object during the whole build

2022-04-12 Thread GitBox
rmannibucau commented on PR #713: URL: https://github.com/apache/maven/pull/713#issuecomment-1096933304 @gnodet do I get it right the revert would be a revert of the revert so get us back to the state which was not working? Think we'll need to use a ClassFileTransformer in ClassRealm to be

[jira] [Updated] (MNG-5222) Maven 3 no longer logs warnings about deprecated plugin parameters.

2022-04-12 Thread Slawomir Jaranowski (Jira)
[ https://issues.apache.org/jira/browse/MNG-5222?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Slawomir Jaranowski updated MNG-5222: - Fix Version/s: 3.9.0 4.0.0-alpha-1 (was: 4.0.x-can

[jira] [Commented] (SUREFIRE-2063) Adding configuration using with --add-opens or --add-exports fails

2022-04-12 Thread Daniel Subelman (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-2063?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17521238#comment-17521238 ] Daniel Subelman commented on SUREFIRE-2063: --- [~mthmulders], thanks for revie

[GitHub] [maven-surefire] Tibor17 commented on pull request #518: [SUREFIRE-2058] - Corrupted STDOUT by directly writing to native stream in forked JVM 1 with UTF-8 console logging

2022-04-12 Thread GitBox
Tibor17 commented on PR #518: URL: https://github.com/apache/maven-surefire/pull/518#issuecomment-1096956544 `StringBuilder s = new StringBuilder( 1025 )` extra 1000 nano seconds are not visible by humans. `StringBuilder` reallocates the internal array. The other users may think that `1025`

[jira] [Comment Edited] (SUREFIRE-2063) Adding configuration using with --add-opens or --add-exports fails

2022-04-12 Thread Daniel Subelman (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-2063?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17521238#comment-17521238 ] Daniel Subelman edited comment on SUREFIRE-2063 at 4/12/22 4:42 PM:

[jira] [Comment Edited] (SUREFIRE-2063) Adding configuration using with --add-opens or --add-exports fails

2022-04-12 Thread Daniel Subelman (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-2063?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17521238#comment-17521238 ] Daniel Subelman edited comment on SUREFIRE-2063 at 4/12/22 4:43 PM:

[jira] [Comment Edited] (SUREFIRE-2063) Adding configuration using with --add-opens or --add-exports fails

2022-04-12 Thread Daniel Subelman (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-2063?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17521238#comment-17521238 ] Daniel Subelman edited comment on SUREFIRE-2063 at 4/12/22 4:44 PM:

[GitHub] [maven-resolver] cstamas opened a new pull request, #166: [MRESOLVER-250] Wrap descriptors into weak refs

2022-04-12 Thread GitBox
cstamas opened a new pull request, #166: URL: https://github.com/apache/maven-resolver/pull/166 As proposed by user, yet to be tested and proven the memory effect (but looks correct thing to do). --- https://issues.apache.org/jira/browse/MRESOLVER-250 -- This is an automated

[jira] [Updated] (SUREFIRE-2063) Adding configuration using with --add-opens or --add-exports fails

2022-04-12 Thread Daniel Subelman (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-2063?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Subelman updated SUREFIRE-2063: -- Description: Since v3.3.0-M6 fails when using to export or open a package. The fai

[jira] [Created] (MNG-7459) Revert MNG-7347 (SessionScoped beans should be singletons for a given session)

2022-04-12 Thread Guillaume Nodet (Jira)
Guillaume Nodet created MNG-7459: Summary: Revert MNG-7347 (SessionScoped beans should be singletons for a given session) Key: MNG-7459 URL: https://issues.apache.org/jira/browse/MNG-7459 Project: Mav

[GitHub] [maven] gnodet commented on pull request #713: [MNG-7455] Use a single session object during the whole build

2022-04-12 Thread GitBox
gnodet commented on PR #713: URL: https://github.com/apache/maven/pull/713#issuecomment-1097010448 Closing this PR in favour of #715 on 3.8.x branch and keep #714 for 3.9.x branch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

[GitHub] [maven] gnodet opened a new pull request, #716: [MNG-7455] Another attempt to fix the concurrency issue

2022-04-12 Thread GitBox
gnodet opened a new pull request, #716: URL: https://github.com/apache/maven/pull/716 This is another attempt to fix the concurrency issue with minimal changes and without introducing back a thread local storage. The downside of this proposal is that components annotated with `@SessionSc

[jira] [Created] (MNG-7460) Make MavenSession fields final

2022-04-12 Thread Guillaume Nodet (Jira)
Guillaume Nodet created MNG-7460: Summary: Make MavenSession fields final Key: MNG-7460 URL: https://issues.apache.org/jira/browse/MNG-7460 Project: Maven Issue Type: Improvement

[GitHub] [maven-surefire] Tibor17 commented on a diff in pull request #518: [SUREFIRE-2058] - Corrupted STDOUT by directly writing to native stream in forked JVM 1 with UTF-8 console logging

2022-04-12 Thread GitBox
Tibor17 commented on code in PR #518: URL: https://github.com/apache/maven-surefire/pull/518#discussion_r848757753 ## surefire-api/src/test/java/org/apache/maven/surefire/api/stream/AbstractStreamDecoderTest.java: ## @@ -258,6 +258,56 @@ public void shouldReadString() throws Exc

[jira] [Commented] (MRESOLVER-250) Usage of descriptors map in DataPool prevents gargabe collection

2022-04-12 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MRESOLVER-250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17521290#comment-17521290 ] Michael Osipov commented on MRESOLVER-250: -- [~fupgang], a PR is available. Pl

[GitHub] [maven] gnodet closed pull request #713: [MNG-7455] Use a single session object during the whole build

2022-04-12 Thread GitBox
gnodet closed pull request #713: [MNG-7455] Use a single session object during the whole build URL: https://github.com/apache/maven/pull/713 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

[GitHub] [maven-integration-testing] slawekjaranowski merged pull request #143: [MNG-5222] IT test - warn about deprecated plugin params

2022-04-12 Thread GitBox
slawekjaranowski merged PR #143: URL: https://github.com/apache/maven-integration-testing/pull/143 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issue

[GitHub] [maven] slawekjaranowski merged pull request #705: [MNG-5222] Maven 3 no longer logs warnings about deprecated plugin parameters

2022-04-12 Thread GitBox
slawekjaranowski merged PR #705: URL: https://github.com/apache/maven/pull/705 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.

[GitHub] [maven-deploy-plugin] plotters commented on a diff in pull request #21: [doc] improve site documentation deploy-ssh-external example

2022-04-12 Thread GitBox
plotters commented on code in PR #21: URL: https://github.com/apache/maven-deploy-plugin/pull/21#discussion_r848786754 ## src/site/apt/examples/deploy-ssh-external.apt: ## @@ -58,9 +58,26 @@ Deployment of artifacts in an external SSH command ++ - If you are deploying fr

[jira] [Commented] (MNG-5222) Maven 3 no longer logs warnings about deprecated plugin parameters.

2022-04-12 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/MNG-5222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17521303#comment-17521303 ] Hudson commented on MNG-5222: - Build failed in Jenkins: Maven » Maven TLP » maven » master #28

[GitHub] [maven-deploy-plugin] slawekjaranowski commented on pull request #21: [doc] improve site documentation deploy-ssh-external example

2022-04-12 Thread GitBox
slawekjaranowski commented on PR #21: URL: https://github.com/apache/maven-deploy-plugin/pull/21#issuecomment-1097168006 @plotters I hope you have environment to test it ... I don't have such 😄 -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [maven-deploy-plugin] slawekjaranowski commented on pull request #21: [doc] improve site documentation deploy-ssh-external example

2022-04-12 Thread GitBox
slawekjaranowski commented on PR #21: URL: https://github.com/apache/maven-deploy-plugin/pull/21#issuecomment-1097168005 @plotters I hope you have environment to test it ... I don't have such 😄 -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [maven-deploy-plugin] michael-o commented on pull request #21: [doc] improve site documentation deploy-ssh-external example

2022-04-12 Thread GitBox
michael-o commented on PR #21: URL: https://github.com/apache/maven-deploy-plugin/pull/21#issuecomment-1097175393 I'd say that this I'd partially wrong because `scp(1)` will find the private key automatically if there is one. -- This is an automated message from the Apache Git Service.

[GitHub] [maven-surefire] Tibor17 commented on pull request #517: [SUREFIRE-2064] Allow all supported values of [parallel] option

2022-04-12 Thread GitBox
Tibor17 commented on PR #517: URL: https://github.com/apache/maven-surefire/pull/517#issuecomment-1097198159 @sbabcoc We are not doing the refactoring due to reflection. Reflection is a minimum problem for the developer. The main problem in this Configuration is the fact that we relied

[GitHub] [maven-deploy-plugin] plotters closed pull request #21: [doc] improve site documentation deploy-ssh-external example

2022-04-12 Thread GitBox
plotters closed pull request #21: [doc] improve site documentation deploy-ssh-external example URL: https://github.com/apache/maven-deploy-plugin/pull/21 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[jira] [Created] (SUREFIRE-2071) failIfNoTests config option to fail when no tests are found (in a given module)

2022-04-12 Thread Marcin Zajaczkowski (Jira)
Marcin Zajaczkowski created SUREFIRE-2071: - Summary: failIfNoTests config option to fail when no tests are found (in a given module) Key: SUREFIRE-2071 URL: https://issues.apache.org/jira/browse/SUREFIRE-2

[GitHub] [maven-surefire] chalmagr commented on pull request #516: [SUREFIRE-2065] Test Reports Inconsistencies with Parameterized and junit4

2022-04-12 Thread GitBox
chalmagr commented on PR #516: URL: https://github.com/apache/maven-surefire/pull/516#issuecomment-1097224464 Pulled the changes from master and now clean install seems to run fine - looking into some test failures and will attempt to run with the integration test profiles as well and post

[jira] [Commented] (MNG-7433) [REGRESSION] Multiple maven instances working on same source tree can lock each other

2022-04-12 Thread Dan Tran (Jira)
[ https://issues.apache.org/jira/browse/MNG-7433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17521340#comment-17521340 ] Dan Tran commented on MNG-7433: --- buildnumber:create-metadate is used since it has a feature w

[jira] [Commented] (MNG-5222) Maven 3 no longer logs warnings about deprecated plugin parameters.

2022-04-12 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/MNG-5222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17521343#comment-17521343 ] Hudson commented on MNG-5222: - Build succeeded in Jenkins: Maven » Maven TLP » maven » maven-3.

[GitHub] [maven] gnodet commented on pull request #713: [MNG-7455] Use a single session object during the whole build

2022-04-12 Thread GitBox
gnodet commented on PR #713: URL: https://github.com/apache/maven/pull/713#issuecomment-1097242031 > @gnodet do I get it right the revert would be a revert of the revert so get us back to the state which was not working? Think we'll need to use a ClassFileTransformer in ClassRealm to be abl

[jira] [Commented] (MCOMPILER-434) Annotation processor exceptions in forked Javac are ignored

2022-04-12 Thread Delany (Jira)
[ https://issues.apache.org/jira/browse/MCOMPILER-434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17521344#comment-17521344 ] Delany commented on MCOMPILER-434: -- This is resolved with maven-compiler-plugin:3.10.

[jira] [Closed] (MNG-5222) Maven 3 no longer logs warnings about deprecated plugin parameters.

2022-04-12 Thread Slawomir Jaranowski (Jira)
[ https://issues.apache.org/jira/browse/MNG-5222?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Slawomir Jaranowski closed MNG-5222. Fix Version/s: 4.0.0 Resolution: Fixed > Maven 3 no longer logs warnings about depreca

  1   2   >