[jira] [Commented] (MSHADE-156) shade plugin is transforming also strings that are not supposed to be transformed

2022-01-12 Thread Shengnan YU (Jira)
[ https://issues.apache.org/jira/browse/MSHADE-156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17474344#comment-17474344 ] Shengnan YU commented on MSHADE-156: Any solution on this issue? It is annoying. > s

[jira] [Updated] (MEAR-307) skinny modules war libs are not put into shared lib directory

2022-01-12 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MEAR-307?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov updated MEAR-307: Description: {code:xml} maven-ear-plugin 3.2.0 8

[jira] [Updated] (MEAR-307) skinny modules war libs are not put into shared lib directory

2022-01-12 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MEAR-307?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov updated MEAR-307: Summary: skinny modules war libs are not put into shared lib directory (was: skinny modules war libs

[GitHub] [maven-surefire] slawekjaranowski opened a new pull request #439: Use the latest release version of failsafe in ITs

2022-01-12 Thread GitBox
slawekjaranowski opened a new pull request #439: URL: https://github.com/apache/maven-surefire/pull/439 Following this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/SUREFIRE) f

[GitHub] [maven] michael-o commented on a change in pull request #616: [MNG-7160] Ability to customize core extensions classloaders

2022-01-12 Thread GitBox
michael-o commented on a change in pull request #616: URL: https://github.com/apache/maven/pull/616#discussion_r782922523 ## File path: maven-embedder/src/main/java/org/apache/maven/cli/internal/BootstrapCoreExtensionManager.java ## @@ -114,14 +123,42 @@ private CoreExtensionE

[GitHub] [maven] gnodet closed pull request #552: [MNG-7260] [MNG-7266] Remove maven-compat module

2022-01-12 Thread GitBox
gnodet closed pull request #552: URL: https://github.com/apache/maven/pull/552 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@

[GitHub] [maven] gnodet commented on a change in pull request #616: [MNG-7160] Ability to customize core extensions classloaders

2022-01-12 Thread GitBox
gnodet commented on a change in pull request #616: URL: https://github.com/apache/maven/pull/616#discussion_r782930812 ## File path: maven-embedder/src/main/java/org/apache/maven/cli/internal/BootstrapCoreExtensionManager.java ## @@ -114,14 +123,42 @@ private CoreExtensionEntr

[GitHub] [maven] michael-o commented on pull request #552: [MNG-7260] [MNG-7266] Remove maven-compat module

2022-01-12 Thread GitBox
michael-o commented on pull request #552: URL: https://github.com/apache/maven/pull/552#issuecomment-1010895881 > The `ArtifactDeployer` and `ArtifactInstaller`, `ArtifactCollector`, `ArtifactResolver` interfaces contains various methods used in https://github.com/apache/maven-integration-

[jira] [Comment Edited] (MNG-7345) Missing exported packages

2022-01-12 Thread Guillaume Nodet (Jira)
[ https://issues.apache.org/jira/browse/MNG-7345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17448456#comment-17448456 ] Guillaume Nodet edited comment on MNG-7345 at 1/12/22, 10:33 AM:

[GitHub] [maven] michael-o commented on a change in pull request #616: [MNG-7160] Ability to customize core extensions classloaders

2022-01-12 Thread GitBox
michael-o commented on a change in pull request #616: URL: https://github.com/apache/maven/pull/616#discussion_r782934356 ## File path: maven-embedder/src/main/java/org/apache/maven/cli/internal/BootstrapCoreExtensionManager.java ## @@ -114,14 +123,42 @@ private CoreExtensionE

[GitHub] [maven] michael-o commented on a change in pull request #616: [MNG-7160] Ability to customize core extensions classloaders

2022-01-12 Thread GitBox
michael-o commented on a change in pull request #616: URL: https://github.com/apache/maven/pull/616#discussion_r782934356 ## File path: maven-embedder/src/main/java/org/apache/maven/cli/internal/BootstrapCoreExtensionManager.java ## @@ -114,14 +123,42 @@ private CoreExtensionE

[GitHub] [maven] gnodet commented on a change in pull request #616: [MNG-7160] Ability to customize core extensions classloaders

2022-01-12 Thread GitBox
gnodet commented on a change in pull request #616: URL: https://github.com/apache/maven/pull/616#discussion_r782944181 ## File path: maven-embedder/src/main/java/org/apache/maven/cli/internal/BootstrapCoreExtensionManager.java ## @@ -114,14 +123,42 @@ private CoreExtensionEntr

[jira] [Commented] (MEAR-307) skinny modules war libs are not put into shared lib directory

2022-01-12 Thread Benjamin Asbach (Jira)
[ https://issues.apache.org/jira/browse/MEAR-307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17474463#comment-17474463 ] Benjamin Asbach commented on MEAR-307: -- [~abrarovm], thansk for your fast response. I

[GitHub] [maven] michael-o commented on a change in pull request #616: [MNG-7160] Ability to customize core extensions classloaders

2022-01-12 Thread GitBox
michael-o commented on a change in pull request #616: URL: https://github.com/apache/maven/pull/616#discussion_r782979548 ## File path: maven-embedder/src/main/java/org/apache/maven/cli/internal/BootstrapCoreExtensionManager.java ## @@ -114,14 +123,42 @@ private CoreExtensionE

[GitHub] [maven] michael-o commented on a change in pull request #616: [MNG-7160] Ability to customize core extensions classloaders

2022-01-12 Thread GitBox
michael-o commented on a change in pull request #616: URL: https://github.com/apache/maven/pull/616#discussion_r782980780 ## File path: maven-embedder/src/main/java/org/apache/maven/cli/internal/BootstrapCoreExtensionManager.java ## @@ -114,14 +123,42 @@ private CoreExtensionE

[jira] [Comment Edited] (MEAR-307) skinny modules war libs are not put into shared lib directory

2022-01-12 Thread Marat Abrarov (Jira)
[ https://issues.apache.org/jira/browse/MEAR-307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17474469#comment-17474469 ] Marat Abrarov edited comment on MEAR-307 at 1/12/22, 11:48 AM: --

[jira] [Commented] (MEAR-307) skinny modules war libs are not put into shared lib directory

2022-01-12 Thread Marat Abrarov (Jira)
[ https://issues.apache.org/jira/browse/MEAR-307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17474469#comment-17474469 ] Marat Abrarov commented on MEAR-307: [~asbachb], I'm not the author of this approach,

[jira] [Comment Edited] (MEAR-307) skinny modules war libs are not put into shared lib directory

2022-01-12 Thread Marat Abrarov (Jira)
[ https://issues.apache.org/jira/browse/MEAR-307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17474469#comment-17474469 ] Marat Abrarov edited comment on MEAR-307 at 1/12/22, 11:49 AM: --

[jira] [Comment Edited] (MEAR-307) skinny modules war libs are not put into shared lib directory

2022-01-12 Thread Marat Abrarov (Jira)
[ https://issues.apache.org/jira/browse/MEAR-307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17474469#comment-17474469 ] Marat Abrarov edited comment on MEAR-307 at 1/12/22, 11:50 AM: --

[jira] [Comment Edited] (MEAR-307) skinny modules war libs are not put into shared lib directory

2022-01-12 Thread Marat Abrarov (Jira)
[ https://issues.apache.org/jira/browse/MEAR-307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17474469#comment-17474469 ] Marat Abrarov edited comment on MEAR-307 at 1/12/22, 11:50 AM: --

[GitHub] [maven] gnodet commented on a change in pull request #616: [MNG-7160] Ability to customize core extensions classloaders

2022-01-12 Thread GitBox
gnodet commented on a change in pull request #616: URL: https://github.com/apache/maven/pull/616#discussion_r783019478 ## File path: maven-embedder/src/main/java/org/apache/maven/cli/internal/BootstrapCoreExtensionManager.java ## @@ -114,14 +123,42 @@ private CoreExtensionEntr

[GitHub] [maven] gnodet commented on a change in pull request #616: [MNG-7160] Ability to customize core extensions classloaders

2022-01-12 Thread GitBox
gnodet commented on a change in pull request #616: URL: https://github.com/apache/maven/pull/616#discussion_r783019478 ## File path: maven-embedder/src/main/java/org/apache/maven/cli/internal/BootstrapCoreExtensionManager.java ## @@ -114,14 +123,42 @@ private CoreExtensionEntr

[GitHub] [maven] gnodet commented on a change in pull request #616: [MNG-7160] Ability to customize core extensions classloaders

2022-01-12 Thread GitBox
gnodet commented on a change in pull request #616: URL: https://github.com/apache/maven/pull/616#discussion_r783019478 ## File path: maven-embedder/src/main/java/org/apache/maven/cli/internal/BootstrapCoreExtensionManager.java ## @@ -114,14 +123,42 @@ private CoreExtensionEntr

[GitHub] [maven] gnodet commented on a change in pull request #616: [MNG-7160] Ability to customize core extensions classloaders

2022-01-12 Thread GitBox
gnodet commented on a change in pull request #616: URL: https://github.com/apache/maven/pull/616#discussion_r783019478 ## File path: maven-embedder/src/main/java/org/apache/maven/cli/internal/BootstrapCoreExtensionManager.java ## @@ -114,14 +123,42 @@ private CoreExtensionEntr

[GitHub] [maven] gnodet commented on a change in pull request #616: [MNG-7160] Ability to customize core extensions classloaders

2022-01-12 Thread GitBox
gnodet commented on a change in pull request #616: URL: https://github.com/apache/maven/pull/616#discussion_r783019478 ## File path: maven-embedder/src/main/java/org/apache/maven/cli/internal/BootstrapCoreExtensionManager.java ## @@ -114,14 +123,42 @@ private CoreExtensionEntr

[GitHub] [maven-mvnd] gnodet merged pull request #582: Remove unused subclass

2022-01-12 Thread GitBox
gnodet merged pull request #582: URL: https://github.com/apache/maven-mvnd/pull/582 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubsc

[GitHub] [maven] gnodet commented on a change in pull request #616: [MNG-7160] Ability to customize core extensions classloaders

2022-01-12 Thread GitBox
gnodet commented on a change in pull request #616: URL: https://github.com/apache/maven/pull/616#discussion_r783019478 ## File path: maven-embedder/src/main/java/org/apache/maven/cli/internal/BootstrapCoreExtensionManager.java ## @@ -114,14 +123,42 @@ private CoreExtensionEntr

[GitHub] [maven] michael-o commented on a change in pull request #616: [MNG-7160] Ability to customize core extensions classloaders

2022-01-12 Thread GitBox
michael-o commented on a change in pull request #616: URL: https://github.com/apache/maven/pull/616#discussion_r783026282 ## File path: maven-embedder/src/main/java/org/apache/maven/cli/internal/BootstrapCoreExtensionManager.java ## @@ -114,14 +123,42 @@ private CoreExtensionE

[GitHub] [maven-resolver] cstamas commented on pull request #139: [MRESOLVER-230] Make supported checksum algorithms extensible

2022-01-12 Thread GitBox
cstamas commented on pull request #139: URL: https://github.com/apache/maven-resolver/pull/139#issuecomment-1011013483 > > Can you adjust https://github.com/apache/maven-resolver/blob/master/src/site/markdown/configuration.md on how to configure this (probably requires adjustment of descri

[jira] [Comment Edited] (MEAR-307) skinny modules war libs are not put into shared lib directory

2022-01-12 Thread Benjamin Asbach (Jira)
[ https://issues.apache.org/jira/browse/MEAR-307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17474463#comment-17474463 ] Benjamin Asbach edited comment on MEAR-307 at 1/12/22, 1:16 PM: -

[jira] [Commented] (MEAR-307) skinny modules war libs are not put into shared lib directory

2022-01-12 Thread Benjamin Asbach (Jira)
[ https://issues.apache.org/jira/browse/MEAR-307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17474515#comment-17474515 ] Benjamin Asbach commented on MEAR-307: -- [~abrarovm] thanks for your support. The solut

[jira] [Commented] (MEAR-307) skinny modules war libs are not put into shared lib directory

2022-01-12 Thread Benjamin Asbach (Jira)
[ https://issues.apache.org/jira/browse/MEAR-307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17474516#comment-17474516 ] Benjamin Asbach commented on MEAR-307: -- Actually I'm unable to close the issue. Feel f

[jira] [Commented] (MEAR-307) skinny modules war libs are not put into shared lib directory

2022-01-12 Thread Marat Abrarov (Jira)
[ https://issues.apache.org/jira/browse/MEAR-307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17474525#comment-17474525 ] Marat Abrarov commented on MEAR-307: Hi [~asbachb], Regarding [your note|https://issu

[GitHub] [maven] cstamas commented on a change in pull request #616: [MNG-7160] Ability to customize core extensions classloaders

2022-01-12 Thread GitBox
cstamas commented on a change in pull request #616: URL: https://github.com/apache/maven/pull/616#discussion_r783084437 ## File path: maven-embedder/src/main/java/org/apache/maven/cli/internal/BootstrapCoreExtensionManager.java ## @@ -114,14 +123,42 @@ private CoreExtensionEnt

[jira] [Commented] (MASSEMBLY-874) maven-assembly plugin always downloads dependencies from net

2022-01-12 Thread Arkadiusz Biczewski (Jira)
[ https://issues.apache.org/jira/browse/MASSEMBLY-874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17474532#comment-17474532 ] Arkadiusz Biczewski commented on MASSEMBLY-874: --- Hello, As not only depe

[jira] [Comment Edited] (MASSEMBLY-874) maven-assembly plugin always downloads dependencies from net

2022-01-12 Thread Arkadiusz Biczewski (Jira)
[ https://issues.apache.org/jira/browse/MASSEMBLY-874?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17474532#comment-17474532 ] Arkadiusz Biczewski edited comment on MASSEMBLY-874 at 1/12/22, 1:42 PM: ---

[GitHub] [maven-plugin-tools] dependabot[bot] opened a new pull request #63: Bump plexus-utils from 3.3.0 to 3.4.1

2022-01-12 Thread GitBox
dependabot[bot] opened a new pull request #63: URL: https://github.com/apache/maven-plugin-tools/pull/63 Bumps [plexus-utils](https://github.com/codehaus-plexus/plexus-utils) from 3.3.0 to 3.4.1. Release notes Sourced from https://github.com/codehaus-plexus/plexus-utils/releases";

[GitHub] [maven-plugin-tools] dependabot[bot] opened a new pull request #64: Bump mockito-core from 2.28.2 to 4.2.0

2022-01-12 Thread GitBox
dependabot[bot] opened a new pull request #64: URL: https://github.com/apache/maven-plugin-tools/pull/64 Bumps [mockito-core](https://github.com/mockito/mockito) from 2.28.2 to 4.2.0. Release notes Sourced from https://github.com/mockito/mockito/releases";>mockito-core's releases

[GitHub] [maven] michael-o commented on a change in pull request #616: [MNG-7160] Ability to customize core extensions classloaders

2022-01-12 Thread GitBox
michael-o commented on a change in pull request #616: URL: https://github.com/apache/maven/pull/616#discussion_r783106746 ## File path: maven-embedder/src/main/java/org/apache/maven/cli/internal/BootstrapCoreExtensionManager.java ## @@ -114,14 +123,42 @@ private CoreExtensionE

[GitHub] [maven] cstamas commented on a change in pull request #616: [MNG-7160] Ability to customize core extensions classloaders

2022-01-12 Thread GitBox
cstamas commented on a change in pull request #616: URL: https://github.com/apache/maven/pull/616#discussion_r783124929 ## File path: maven-embedder/src/main/java/org/apache/maven/cli/internal/BootstrapCoreExtensionManager.java ## @@ -114,14 +123,42 @@ private CoreExtensionEnt

[GitHub] [maven] cstamas commented on a change in pull request #616: [MNG-7160] Ability to customize core extensions classloaders

2022-01-12 Thread GitBox
cstamas commented on a change in pull request #616: URL: https://github.com/apache/maven/pull/616#discussion_r783124929 ## File path: maven-embedder/src/main/java/org/apache/maven/cli/internal/BootstrapCoreExtensionManager.java ## @@ -114,14 +123,42 @@ private CoreExtensionEnt

[GitHub] [maven-surefire] Tibor17 commented on pull request #407: [SUREFIRE-1967] Fix parallel test ordering to prevent high resource consumption

2022-01-12 Thread GitBox
Tibor17 commented on pull request #407: URL: https://github.com/apache/maven-surefire/pull/407#issuecomment-1011149404 `JUnit47ParallelIT.forcedShutdownVerifyingLogs` is not related to this issue since the IT is not related to TestNG. -- This is an automated message from the Apache Git S

[GitHub] [maven-surefire] slawekjaranowski merged pull request #439: Use the latest release version of failsafe in ITs

2022-01-12 Thread GitBox
slawekjaranowski merged pull request #439: URL: https://github.com/apache/maven-surefire/pull/439 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [maven-assembly-plugin] slachiewicz closed pull request #46: Bump maven-aether-provider from 3.0 to 3.3.9

2022-01-12 Thread GitBox
slachiewicz closed pull request #46: URL: https://github.com/apache/maven-assembly-plugin/pull/46 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [maven-assembly-plugin] dependabot[bot] commented on pull request #46: Bump maven-aether-provider from 3.0 to 3.3.9

2022-01-12 Thread GitBox
dependabot[bot] commented on pull request #46: URL: https://github.com/apache/maven-assembly-plugin/pull/46#issuecomment-1011172227 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major

[GitHub] [maven-assembly-plugin] slachiewicz closed pull request #42: Bump sisu-inject-plexus from 1.4.2 to 2.6.0

2022-01-12 Thread GitBox
slachiewicz closed pull request #42: URL: https://github.com/apache/maven-assembly-plugin/pull/42 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [maven-assembly-plugin] dependabot[bot] commented on pull request #42: Bump sisu-inject-plexus from 1.4.2 to 2.6.0

2022-01-12 Thread GitBox
dependabot[bot] commented on pull request #42: URL: https://github.com/apache/maven-assembly-plugin/pull/42#issuecomment-1011172576 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major

[GitHub] [maven-surefire] Tibor17 commented on pull request #407: [SUREFIRE-1967] Fix parallel test ordering to prevent high resource consumption

2022-01-12 Thread GitBox
Tibor17 commented on pull request #407: URL: https://github.com/apache/maven-surefire/pull/407#issuecomment-1011178942 ``` Matcher matcher = Pattern.compile( "^(\\d+)\\..*$" ).matcher( System.getProperty( "java.version" ) ); assertTrue( matcher.matches() ); int javaVersion

[GitHub] [maven-build-cache-extension] maximilian-novikov-db opened a new pull request #1: MNG-7129 fix for cleanup of partial state

2022-01-12 Thread GitBox
maximilian-novikov-db opened a new pull request #1: URL: https://github.com/apache/maven-build-cache-extension/pull/1 Following this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/brow

[jira] [Assigned] (MNG-7386) ModelMerger$MergingList is not serializable

2022-01-12 Thread Guillaume Nodet (Jira)
[ https://issues.apache.org/jira/browse/MNG-7386?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guillaume Nodet reassigned MNG-7386: Assignee: Guillaume Nodet > ModelMerger$MergingList is not serializable > --

[jira] [Commented] (MNG-7386) ModelMerger$MergingList is not serializable

2022-01-12 Thread Guillaume Nodet (Jira)
[ https://issues.apache.org/jira/browse/MNG-7386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17474645#comment-17474645 ] Guillaume Nodet commented on MNG-7386: -- This is a regression caused by MNG-6695. > Mo

[GitHub] [maven-surefire] findepi commented on pull request #407: [SUREFIRE-1967] Fix parallel test ordering to prevent high resource consumption

2022-01-12 Thread GitBox
findepi commented on pull request #407: URL: https://github.com/apache/maven-surefire/pull/407#issuecomment-1011201165 > can be replaced with > > ``` > import static org.apache.maven.surefire.its.fixture.HelperAssertions.assumeJavaMaxVersion; > ``` nice, thanks @Tibor17,

[jira] [Commented] (MNG-7386) ModelMerger$MergingList is not serializable

2022-01-12 Thread Guillaume Nodet (Jira)
[ https://issues.apache.org/jira/browse/MNG-7386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17474655#comment-17474655 ] Guillaume Nodet commented on MNG-7386: -- The {{MergingList}} has been introduced to pro

[GitHub] [maven] gnodet opened a new pull request #656: [MNG-7386] Make sure the ModelMerger$MergingList can be serialized

2022-01-12 Thread GitBox
gnodet opened a new pull request #656: URL: https://github.com/apache/maven/pull/656 Following this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MNG) filed for the ch

[jira] [Commented] (MNG-7386) ModelMerger$MergingList is not serializable

2022-01-12 Thread Guillaume Nodet (Jira)
[ https://issues.apache.org/jira/browse/MNG-7386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17474656#comment-17474656 ] Guillaume Nodet commented on MNG-7386: -- Untested PR available at https://github.com/ap

[GitHub] [maven] gnodet commented on pull request #656: [MNG-7386] Make sure the ModelMerger$MergingList can be serialized

2022-01-12 Thread GitBox
gnodet commented on pull request #656: URL: https://github.com/apache/maven/pull/656#issuecomment-1011213043 I'll try to backport the test from https://github.com/diffplug/spotless/pull/1074 -- This is an automated message from the Apache Git Service. To respond to the message, please lo

[GitHub] [maven-surefire] Tibor17 commented on pull request #407: [SUREFIRE-1967] Fix parallel test ordering to prevent high resource consumption

2022-01-12 Thread GitBox
Tibor17 commented on pull request #407: URL: https://github.com/apache/maven-surefire/pull/407#issuecomment-1011214473 One more thing. The `Base` class has try-catch. Please use throws Exception , it is typical for tests to process the exception by itself in the report, not necessary to re

[GitHub] [maven-surefire] Tibor17 commented on a change in pull request #407: [SUREFIRE-1967] Fix parallel test ordering to prevent high resource consumption

2022-01-12 Thread GitBox
Tibor17 commented on a change in pull request #407: URL: https://github.com/apache/maven-surefire/pull/407#discussion_r774992573 ## File path: surefire-its/src/test/resources/surefire-1967-testng-method-parallel-ordering/src/test/java/testng/parallelOrdering/Base.java ## @@ -0

[GitHub] [maven-surefire] Tibor17 commented on pull request #407: [SUREFIRE-1967] Fix parallel test ordering to prevent high resource consumption

2022-01-12 Thread GitBox
Tibor17 commented on pull request #407: URL: https://github.com/apache/maven-surefire/pull/407#issuecomment-1011289025 One more thing. Is this new method `tryGetConstructor` called in some unit test? It would be great to have a coverage. I know your implementation is okay but it is usef

[GitHub] [maven-surefire] Tibor17 edited a comment on pull request #407: [SUREFIRE-1967] Fix parallel test ordering to prevent high resource consumption

2022-01-12 Thread GitBox
Tibor17 edited a comment on pull request #407: URL: https://github.com/apache/maven-surefire/pull/407#issuecomment-1011289025 @findepi One more thing. Is this new method `tryGetConstructor` called in some unit test? It would be great to have a coverage. I know your implementation is o

[GitHub] [maven-build-cache-extension] hboutemy merged pull request #1: MNG-7129 fix for cleanup of partial state

2022-01-12 Thread GitBox
hboutemy merged pull request #1: URL: https://github.com/apache/maven-build-cache-extension/pull/1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [maven-mvnd] aalmiray commented on pull request #539: Do not cut sha256 in release workflow

2022-01-12 Thread GitBox
aalmiray commented on pull request #539: URL: https://github.com/apache/maven-mvnd/pull/539#issuecomment-1011345697 FWIW #574 addresses this with JReleaser -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[jira] [Updated] (MNG-7386) ModelMerger$MergingList is not serializable

2022-01-12 Thread Guillaume Nodet (Jira)
[ https://issues.apache.org/jira/browse/MNG-7386?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guillaume Nodet updated MNG-7386: - Fix Version/s: 4.0.0-alpha-1 3.8.5 > ModelMerger$MergingList is not serializable

[GitHub] [maven-surefire] findepi commented on a change in pull request #407: [SUREFIRE-1967] Fix parallel test ordering to prevent high resource consumption

2022-01-12 Thread GitBox
findepi commented on a change in pull request #407: URL: https://github.com/apache/maven-surefire/pull/407#discussion_r783424283 ## File path: surefire-providers/surefire-testng/src/main/java/org/apache/maven/surefire/testng/TestNGExecutor.java ## @@ -137,6 +152,31 @@ static v

[GitHub] [maven-surefire] findepi commented on a change in pull request #407: [SUREFIRE-1967] Fix parallel test ordering to prevent high resource consumption

2022-01-12 Thread GitBox
findepi commented on a change in pull request #407: URL: https://github.com/apache/maven-surefire/pull/407#discussion_r783434179 ## File path: surefire-providers/surefire-testng/src/main/java/org/apache/maven/surefire/testng/TestNGExecutor.java ## @@ -137,6 +152,31 @@ static v

[jira] [Updated] (MNG-7386) ModelMerger$MergingList is not serializable

2022-01-12 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MNG-7386?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov updated MNG-7386: Fix Version/s: 4.0.0 > ModelMerger$MergingList is not serializable >

[GitHub] [maven-surefire] slawekjaranowski commented on pull request #407: [SUREFIRE-1967] Fix parallel test ordering to prevent high resource consumption

2022-01-12 Thread GitBox
slawekjaranowski commented on pull request #407: URL: https://github.com/apache/maven-surefire/pull/407#issuecomment-1011476860 OK, local branch for jenkins created https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven-surefire/job/SUREFIRE-1967/ -- This is an automated me

[jira] [Updated] (MSHARED-879) make build Reproducible

2022-01-12 Thread Slawomir Jaranowski (Jira)
[ https://issues.apache.org/jira/browse/MSHARED-879?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Slawomir Jaranowski updated MSHARED-879: Fix Version/s: (was: maven-dependency-analyzer-1.11.3) > make build Reproducib

[jira] [Commented] (MSHARED-632) Expose which dependency classes are used and where

2022-01-12 Thread Slawomir Jaranowski (Jira)
[ https://issues.apache.org/jira/browse/MSHARED-632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17474986#comment-17474986 ] Slawomir Jaranowski commented on MSHARED-632: - [~slachiewicz]  I can't find

[jira] [Created] (MSHARED-1020) Include class names in used undeclared dependencies

2022-01-12 Thread Slawomir Jaranowski (Jira)
Slawomir Jaranowski created MSHARED-1020: Summary: Include class names in used undeclared dependencies Key: MSHARED-1020 URL: https://issues.apache.org/jira/browse/MSHARED-1020 Project: Maven S

[jira] [Closed] (MSHARED-1020) Include class names in used undeclared dependencies

2022-01-12 Thread Slawomir Jaranowski (Jira)
[ https://issues.apache.org/jira/browse/MSHARED-1020?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Slawomir Jaranowski closed MSHARED-1020. Assignee: Sylwester Lachiewicz Resolution: Fixed > Include class names in u

[jira] [Reopened] (MDEP-779) dependency:analyze should list the classes that cause a used undeclared dependency

2022-01-12 Thread Slawomir Jaranowski (Jira)
[ https://issues.apache.org/jira/browse/MDEP-779?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Slawomir Jaranowski reopened MDEP-779: -- PR 178 is not merged > dependency:analyze should list the classes that cause a used undeclar

[jira] [Created] (MSHARED-1021) Handle different classes from same artifact used by model and test code

2022-01-12 Thread Slawomir Jaranowski (Jira)
Slawomir Jaranowski created MSHARED-1021: Summary: Handle different classes from same artifact used by model and test code Key: MSHARED-1021 URL: https://issues.apache.org/jira/browse/MSHARED-1021

[jira] [Closed] (MSHARED-1021) Handle different classes from same artifact used by model and test code

2022-01-12 Thread Slawomir Jaranowski (Jira)
[ https://issues.apache.org/jira/browse/MSHARED-1021?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Slawomir Jaranowski closed MSHARED-1021. Resolution: Fixed > Handle different classes from same artifact used by model and

[jira] [Closed] (MSHARED-997) Failed / error test DefaultProjectDependencyAnalyzerTest in maven-dependency-analyzer

2022-01-12 Thread Slawomir Jaranowski (Jira)
[ https://issues.apache.org/jira/browse/MSHARED-997?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Slawomir Jaranowski closed MSHARED-997. --- > Failed / error test DefaultProjectDependencyAnalyzerTest in > maven-dependency-analyz

[GitHub] [maven-mvnd] ppalaga commented on pull request #574: Refactor build and release workflows

2022-01-12 Thread GitBox
ppalaga commented on pull request #574: URL: https://github.com/apache/maven-mvnd/pull/574#issuecomment-1011520767 Looks good, thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

[GitHub] [maven-surefire] Tibor17 opened a new pull request #440: Included Excluded Files as patterns

2022-01-12 Thread GitBox
Tibor17 opened a new pull request #440: URL: https://github.com/apache/maven-surefire/pull/440 Following this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/SUREFIRE) filed

[GitHub] [maven-surefire] Tibor17 commented on pull request #437: Bump junit-jupiter-params from 5.3.2 to 5.8.2

2022-01-12 Thread GitBox
Tibor17 commented on pull request #437: URL: https://github.com/apache/maven-surefire/pull/437#issuecomment-1011537317 This upgrade may lead to another upgrade of `junit-jupiter-engine` and we won't break the old users of JUnit5 surefire provider. -- This is an automated message from the

[GitHub] [maven-surefire] Tibor17 commented on pull request #437: Bump junit-jupiter-params from 5.3.2 to 5.8.2

2022-01-12 Thread GitBox
Tibor17 commented on pull request #437: URL: https://github.com/apache/maven-surefire/pull/437#issuecomment-1011537758 . -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[GitHub] [maven-surefire] Tibor17 removed a comment on pull request #437: Bump junit-jupiter-params from 5.3.2 to 5.8.2

2022-01-12 Thread GitBox
Tibor17 removed a comment on pull request #437: URL: https://github.com/apache/maven-surefire/pull/437#issuecomment-1011537758 . -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comm

[GitHub] [maven-surefire] Tibor17 closed pull request #437: Bump junit-jupiter-params from 5.3.2 to 5.8.2

2022-01-12 Thread GitBox
Tibor17 closed pull request #437: URL: https://github.com/apache/maven-surefire/pull/437 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-un

[GitHub] [maven-surefire] dependabot[bot] commented on pull request #437: Bump junit-jupiter-params from 5.3.2 to 5.8.2

2022-01-12 Thread GitBox
dependabot[bot] commented on pull request #437: URL: https://github.com/apache/maven-surefire/pull/437#issuecomment-1011540680 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or mi

[GitHub] [maven-surefire] Tibor17 commented on pull request #431: Bump maven-common-artifact-filters from 3.1.0 to 3.2.0

2022-01-12 Thread GitBox
Tibor17 commented on pull request #431: URL: https://github.com/apache/maven-surefire/pull/431#issuecomment-1011546595 @slawekjaranowski This artifact is not part of Maven Core, so it is not too dangerous to skip this, but still we may suffer from ignoring this dependency upgrade. The lo

[GitHub] [maven-surefire] Tibor17 commented on pull request #431: Bump maven-common-artifact-filters from 3.1.0 to 3.2.0

2022-01-12 Thread GitBox
Tibor17 commented on pull request #431: URL: https://github.com/apache/maven-surefire/pull/431#issuecomment-1011549888 We should rename the name of PR and commit to a typical Jira issue. This is part of usual non-test dependency. -- This is an automated message from the Apache Git Servic

[GitHub] [maven-surefire] Tibor17 commented on pull request #440: [SUREFIRE-1964] Support for method filtering on excludesFile and includesFile

2022-01-12 Thread GitBox
Tibor17 commented on pull request #440: URL: https://github.com/apache/maven-surefire/pull/440#issuecomment-1011650210 @imonteroperez @slawekjaranowski Let's see this as well. The ASM class used `getTest()` for the tests filter. We want to extend it with inc/excludedFiles param but

[GitHub] [maven-surefire] Tibor17 commented on pull request #400: [SUREFIRE-1964] Support for method filtering on excludesFile and includesFile

2022-01-12 Thread GitBox
Tibor17 commented on pull request #400: URL: https://github.com/apache/maven-surefire/pull/400#issuecomment-1011657874 @imonteroperez @slawekjaranowski Pls let a have a look into #440 as well. -- This is an automated message from the Apache Git Service. To respond to the message, pl

[GitHub] [maven-surefire] Tibor17 commented on pull request #440: [SUREFIRE-1964] Support for method filtering on excludesFile and includesFile

2022-01-12 Thread GitBox
Tibor17 commented on pull request #440: URL: https://github.com/apache/maven-surefire/pull/440#issuecomment-1011669630 The docs and IT does not exist in here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

[GitHub] [maven-surefire] mattsheppard commented on pull request #339: [SUREFIRE-1890] Support TestNG 7.4.0

2022-01-12 Thread GitBox
mattsheppard commented on pull request #339: URL: https://github.com/apache/maven-surefire/pull/339#issuecomment-1011711965 I'd also like to see a release with this fix. Unfortunately all versions of testng prior to 7.5.0 are subject to a number of CVEs in their dependencies which are hard

[jira] [Commented] (MRESOLVER-133) Improve resolver performance by using breadth-first search

2022-01-12 Thread wei cai (Jira)
[ https://issues.apache.org/jira/browse/MRESOLVER-133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17475069#comment-17475069 ] wei cai commented on MRESOLVER-133: --- [~ibabiankou] [~michael-o]  Here maven is using

[GitHub] [maven-surefire] dependabot[bot] opened a new pull request #441: Bump maven-enforcer-plugin from 3.0.0-M3 to 3.0.0

2022-01-12 Thread GitBox
dependabot[bot] opened a new pull request #441: URL: https://github.com/apache/maven-surefire/pull/441 Bumps [maven-enforcer-plugin](https://github.com/apache/maven-enforcer) from 3.0.0-M3 to 3.0.0. Commits https://github.com/apache/maven-enforcer/commit/b1b22822174bc92857a2e6

[GitHub] [maven-surefire] dependabot[bot] opened a new pull request #442: Bump maven-invoker-plugin from 3.2.0 to 3.2.2

2022-01-12 Thread GitBox
dependabot[bot] opened a new pull request #442: URL: https://github.com/apache/maven-surefire/pull/442 Bumps [maven-invoker-plugin](https://github.com/apache/maven-invoker-plugin) from 3.2.0 to 3.2.2. Commits https://github.com/apache/maven-invoker-plugin/commit/efe8ee0bc66068

[GitHub] [maven-mvnd] 710850609 commented on issue #571: windows11 and mvnd-0.7.1 and JDK 11.0.2

2022-01-12 Thread GitBox
710850609 commented on issue #571: URL: https://github.com/apache/maven-mvnd/issues/571#issuecomment-1011816925 > This is very weird as your first report indicates the jansi library cannot be loaded or does not find the `isatty` function, but the second indicates that it works. The `mvnd`

[GitHub] [maven-mvnd] 710850609 edited a comment on issue #571: windows11 and mvnd-0.7.1 and JDK 11.0.2

2022-01-12 Thread GitBox
710850609 edited a comment on issue #571: URL: https://github.com/apache/maven-mvnd/issues/571#issuecomment-1011816925 > This is very weird as your first report indicates the jansi library cannot be loaded or does not find the `isatty` function, but the second indicates that it works. The

[GitHub] [maven-mvnd] 710850609 edited a comment on issue #571: windows11 and mvnd-0.7.1 and JDK 11.0.2

2022-01-12 Thread GitBox
710850609 edited a comment on issue #571: URL: https://github.com/apache/maven-mvnd/issues/571#issuecomment-1011816925 > This is very weird as your first report indicates the jansi library cannot be loaded or does not find the `isatty` function, but the second indicates that it works. The

[GitHub] [maven-mvnd] 710850609 edited a comment on issue #571: windows11 and mvnd-0.7.1 and JDK 11.0.2

2022-01-12 Thread GitBox
710850609 edited a comment on issue #571: URL: https://github.com/apache/maven-mvnd/issues/571#issuecomment-1011816925 > This is very weird as your first report indicates the jansi library cannot be loaded or does not find the `isatty` function, but the second indicates that it works. The

[GitHub] [maven-surefire] slawekjaranowski commented on a change in pull request #440: [SUREFIRE-1964] Support for method filtering on excludesFile and includesFile

2022-01-12 Thread GitBox
slawekjaranowski commented on a change in pull request #440: URL: https://github.com/apache/maven-surefire/pull/440#discussion_r783682775 ## File path: maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/AbstractSurefireMojo.java ## @@ -2289,16 +2321,13 @@ pri

[GitHub] [maven-mvnd] gnodet commented on issue #571: windows11 and mvnd-0.7.1 and JDK 11.0.2

2022-01-12 Thread GitBox
gnodet commented on issue #571: URL: https://github.com/apache/maven-mvnd/issues/571#issuecomment-1011862265 > > This is very weird as your first report indicates the jansi library cannot be loaded or does not find the `isatty` function, but the second indicates that it works. The `mvnd` i

[GitHub] [maven-mvnd] gnodet edited a comment on issue #571: windows11 and mvnd-0.7.1 and JDK 11.0.2

2022-01-12 Thread GitBox
gnodet edited a comment on issue #571: URL: https://github.com/apache/maven-mvnd/issues/571#issuecomment-1011862265 > > This is very weird as your first report indicates the jansi library cannot be loaded or does not find the `isatty` function, but the second indicates that it works. The `

[GitHub] [maven-mvnd] gnodet edited a comment on issue #571: windows11 and mvnd-0.7.1 and JDK 11.0.2

2022-01-12 Thread GitBox
gnodet edited a comment on issue #571: URL: https://github.com/apache/maven-mvnd/issues/571#issuecomment-1011862265 > > This is very weird as your first report indicates the jansi library cannot be loaded or does not find the `isatty` function, but the second indicates that it works. The `

[jira] [Assigned] (MNG-7345) Missing exported packages

2022-01-12 Thread Guillaume Nodet (Jira)
[ https://issues.apache.org/jira/browse/MNG-7345?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guillaume Nodet reassigned MNG-7345: Assignee: Guillaume Nodet > Missing exported packages > - > >

  1   2   >