[jira] [Commented] (MNG-6806) Provide Maven BOM

2020-12-28 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MNG-6806?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17255501#comment-17255501 ] Michael Osipov commented on MNG-6806: - No, Maven Core only. > Provide Maven BOM >

[jira] [Closed] (MJLINK-61) Provide .editorconfig based on checkstyle configuration

2020-12-28 Thread Benjamin Marwell (Jira)
[ https://issues.apache.org/jira/browse/MJLINK-61?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Marwell closed MJLINK-61. -- Resolution: Won't Fix No {{.editorconfig}} will be maintained for now as stated on the mailing l

[jira] [Updated] (MRESOLVER-153) resolver-status.properties file is corrupted due to concurrent writes

2020-12-28 Thread Jira
[ https://issues.apache.org/jira/browse/MRESOLVER-153?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamás Cservenák updated MRESOLVER-153: -- Fix Version/s: (was: 1.7.0) > resolver-status.properties file is corrupted due t

[jira] [Updated] (MRESOLVER-153) resolver-status.properties file is corrupted due to concurrent writes

2020-12-28 Thread Jira
[ https://issues.apache.org/jira/browse/MRESOLVER-153?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamás Cservenák updated MRESOLVER-153: -- Fix Version/s: 1.7.0 > resolver-status.properties file is corrupted due to concurren

[jira] [Created] (MRESOLVER-155) Make TrackingFileManager member of DefaultUpdateCheckManager

2020-12-28 Thread Jira
Tamás Cservenák created MRESOLVER-155: - Summary: Make TrackingFileManager member of DefaultUpdateCheckManager Key: MRESOLVER-155 URL: https://issues.apache.org/jira/browse/MRESOLVER-155 Project:

[GitHub] [maven-resolver] cstamas closed pull request #85: [MRESOLVER-155] Make TrackingFileManager member of DefUpdateCheckManager

2020-12-28 Thread GitBox
cstamas closed pull request #85: URL: https://github.com/apache/maven-resolver/pull/85 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [maven-resolver] cstamas commented on pull request #85: [MRESOLVER-155] Make TrackingFileManager member of DefUpdateCheckManager

2020-12-28 Thread GitBox
cstamas commented on pull request #85: URL: https://github.com/apache/maven-resolver/pull/85#issuecomment-751666748 merged as c0b42df326b1ba9b45fe6aadca8aa90e51702577 This is an automated message from the Apache Git Service.

[jira] [Updated] (MRESOLVER-155) Make TrackingFileManager member of DefaultUpdateCheckManager

2020-12-28 Thread Jira
[ https://issues.apache.org/jira/browse/MRESOLVER-155?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamás Cservenák updated MRESOLVER-155: -- Fix Version/s: 1.7.0 > Make TrackingFileManager member of DefaultUpdateCheckManager

[jira] [Assigned] (MRESOLVER-155) Make TrackingFileManager member of DefaultUpdateCheckManager

2020-12-28 Thread Jira
[ https://issues.apache.org/jira/browse/MRESOLVER-155?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamás Cservenák reassigned MRESOLVER-155: - Assignee: Tamás Cservenák > Make TrackingFileManager member of DefaultUpdateC

[jira] [Closed] (MRESOLVER-155) Make TrackingFileManager member of DefaultUpdateCheckManager

2020-12-28 Thread Jira
[ https://issues.apache.org/jira/browse/MRESOLVER-155?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamás Cservenák closed MRESOLVER-155. - > Make TrackingFileManager member of DefaultUpdateCheckManager >

[jira] [Resolved] (MRESOLVER-155) Make TrackingFileManager member of DefaultUpdateCheckManager

2020-12-28 Thread Jira
[ https://issues.apache.org/jira/browse/MRESOLVER-155?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamás Cservenák resolved MRESOLVER-155. --- Resolution: Fixed > Make TrackingFileManager member of DefaultUpdateCheckManager

[jira] [Updated] (MJLINK-39) Add support for choosing vm

2020-12-28 Thread Benjamin Marwell (Jira)
[ https://issues.apache.org/jira/browse/MJLINK-39?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Marwell updated MJLINK-39: --- Affects Version/s: 3.0.0 3.1.0 > Add support for choosing vm >

[jira] [Commented] (MRESOLVER-155) Make TrackingFileManager member of DefaultUpdateCheckManager

2020-12-28 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/MRESOLVER-155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17255518#comment-17255518 ] Hudson commented on MRESOLVER-155: -- Build failed in Jenkins: Maven » Maven TLP » mave

[GitHub] [maven] asfgit closed pull request #416: [MNG-4660] Increase usefulness of logging (2)

2020-12-28 Thread GitBox
asfgit closed pull request #416: URL: https://github.com/apache/maven/pull/416 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

[GitHub] [maven-integration-testing] asfgit closed pull request #91: [MNG-4660] Increase usefulness of logging (2)

2020-12-28 Thread GitBox
asfgit closed pull request #91: URL: https://github.com/apache/maven-integration-testing/pull/91 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

[jira] [Updated] (MJLINK-59) Replace Printwriter, eats IOExceptions

2020-12-28 Thread Benjamin Marwell (Jira)
[ https://issues.apache.org/jira/browse/MJLINK-59?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Marwell updated MJLINK-59: --- Description: … as suggested by [~elharo]:  https://github.com/apache/maven-jlink-plugin/pull/1

[jira] [Commented] (MRESOLVER-153) resolver-status.properties file is corrupted due to concurrent writes

2020-12-28 Thread Guy Brand (Jira)
[ https://issues.apache.org/jira/browse/MRESOLVER-153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17255522#comment-17255522 ] Guy Brand commented on MRESOLVER-153: - [~michael-o] Regarding > Why do you pass {

[jira] [Created] (MJLINK-62) Replace ByteArrayOutputStream with StringWriter

2020-12-28 Thread Benjamin Marwell (Jira)
Benjamin Marwell created MJLINK-62: -- Summary: Replace ByteArrayOutputStream with StringWriter Key: MJLINK-62 URL: https://issues.apache.org/jira/browse/MJLINK-62 Project: Maven JLink Plugin

[GitHub] [maven-jlink-plugin] bmarwell opened a new pull request #28: [MJLINK-62] Use StringWriter for BAOS.

2020-12-28 Thread GitBox
bmarwell opened a new pull request #28: URL: https://github.com/apache/maven-jlink-plugin/pull/28 Following this checklist to help us incorporate your contribution quickly and easily: - [X] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MJLINK) filed

[GitHub] [maven-resolver] rmannibucau commented on pull request #77: [MRESOLVER-145] SyncContext implementations

2020-12-28 Thread GitBox
rmannibucau commented on pull request #77: URL: https://github.com/apache/maven-resolver/pull/77#issuecomment-751680455 Hi, I have 2 questions on the PR: 1. I think hazelcast should handle a property to find the client configuration file as redisson does (will avoid to play with clas

[jira] [Commented] (MNG-4660) Use of --resume-from in multi-module project fails with missing inter-module dependencies

2020-12-28 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/MNG-4660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17255530#comment-17255530 ] Hudson commented on MNG-4660: - Build succeeded in Jenkins: Maven » Maven TLP » maven » master #

[jira] [Commented] (MRESOLVER-153) resolver-status.properties file is corrupted due to concurrent writes

2020-12-28 Thread Jira
[ https://issues.apache.org/jira/browse/MRESOLVER-153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17255533#comment-17255533 ] Tamás Cservenák commented on MRESOLVER-153: --- [~Brand] work of providing func

[GitHub] [maven-resolver] michael-o commented on pull request #77: [MRESOLVER-145] SyncContext implementations

2020-12-28 Thread GitBox
michael-o commented on pull request #77: URL: https://github.com/apache/maven-resolver/pull/77#issuecomment-751682400 @rmannibucau 1) This makes sense, but I don't want to create a mapping from properties to the object ob Redisson. The YAML configuration is so vast that I want to leave

[jira] [Comment Edited] (MRESOLVER-153) resolver-status.properties file is corrupted due to concurrent writes

2020-12-28 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MRESOLVER-153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17255522#comment-17255522 ] Michael Osipov edited comment on MRESOLVER-153 at 12/28/20, 11:34 AM: --

[jira] [Comment Edited] (MRESOLVER-153) resolver-status.properties file is corrupted due to concurrent writes

2020-12-28 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MRESOLVER-153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17255522#comment-17255522 ] Michael Osipov edited comment on MRESOLVER-153 at 12/28/20, 11:34 AM: --

[GitHub] [maven-resolver] cstamas commented on pull request #77: [MRESOLVER-145] SyncContext implementations

2020-12-28 Thread GitBox
cstamas commented on pull request #77: URL: https://github.com/apache/maven-resolver/pull/77#issuecomment-751683148 Howdy @rmannibucau For now I consider both HZ and Redisson as "lab" implementation still, due these: * for HZ to work we either must use deprecated HZ 3.x call (Hazelc

[GitHub] [maven] bmarwell commented on a change in pull request #415: [MNG-7032] do not print colours for --version when in batch mode.

2020-12-28 Thread GitBox
bmarwell commented on a change in pull request #415: URL: https://github.com/apache/maven/pull/415#discussion_r549316323 ## File path: maven-embedder/src/main/java/org/apache/maven/cli/MavenCli.java ## @@ -433,6 +433,8 @@ void cli( CliRequest cliRequest ) if ( cliReq

[jira] [Comment Edited] (MRESOLVER-153) resolver-status.properties file is corrupted due to concurrent writes

2020-12-28 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MRESOLVER-153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17255537#comment-17255537 ] Michael Osipov edited comment on MRESOLVER-153 at 12/28/20, 11:36 AM: --

[jira] [Commented] (MRESOLVER-153) resolver-status.properties file is corrupted due to concurrent writes

2020-12-28 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MRESOLVER-153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17255537#comment-17255537 ] Michael Osipov commented on MRESOLVER-153: -- [~Brand], thanks for the update.

[jira] [Comment Edited] (MRESOLVER-153) resolver-status.properties file is corrupted due to concurrent writes

2020-12-28 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MRESOLVER-153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17255537#comment-17255537 ] Michael Osipov edited comment on MRESOLVER-153 at 12/28/20, 11:39 AM: --

[jira] [Comment Edited] (MRESOLVER-153) resolver-status.properties file is corrupted due to concurrent writes

2020-12-28 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MRESOLVER-153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17255537#comment-17255537 ] Michael Osipov edited comment on MRESOLVER-153 at 12/28/20, 11:40 AM: --

[GitHub] [maven-resolver] cstamas edited a comment on pull request #77: [MRESOLVER-145] SyncContext implementations

2020-12-28 Thread GitBox
cstamas edited a comment on pull request #77: URL: https://github.com/apache/maven-resolver/pull/77#issuecomment-751683148 Howdy @rmannibucau For now I consider both HZ and Redisson as "lab" implementation still, due these: * for HZ to work we either must use deprecated HZ 3.x call

[GitHub] [maven-resolver] cstamas edited a comment on pull request #77: [MRESOLVER-145] SyncContext implementations

2020-12-28 Thread GitBox
cstamas edited a comment on pull request #77: URL: https://github.com/apache/maven-resolver/pull/77#issuecomment-751683148 Howdy @rmannibucau For now I consider both HZ and Redisson as "lab" implementation still, due these: * for HZ to work we either must use deprecated HZ 3.x call

[GitHub] [maven] michael-o commented on pull request #415: [MNG-7032] do not print colours for --version when in batch mode.

2020-12-28 Thread GitBox
michael-o commented on pull request #415: URL: https://github.com/apache/maven/pull/415#issuecomment-751684726 I will happily go through. I was never really happy that Jansi is installed by default even if batch or file mode were activated.

[GitHub] [maven-resolver] michael-o commented on pull request #77: [MRESOLVER-145] SyncContext implementations

2020-12-28 Thread GitBox
michael-o commented on pull request #77: URL: https://github.com/apache/maven-resolver/pull/77#issuecomment-751685099 As for testing Redis, I would not rely on tools like Docker because it is too OS specific. One could probe whether the redis daemon is in `PATH`. If yes, start it. Run test

[GitHub] [maven-resolver] rmannibucau commented on pull request #77: [MRESOLVER-145] SyncContext implementations

2020-12-28 Thread GitBox
rmannibucau commented on pull request #77: URL: https://github.com/apache/maven-resolver/pull/77#issuecomment-751685353 @michael-o everything can be shaded but a few can be "hard". For properties what about supporting in the resolver.properties something like "configuration.external=path-t

[GitHub] [maven] rfscholte commented on a change in pull request #415: [MNG-7032] do not print colours for --version when in batch mode.

2020-12-28 Thread GitBox
rfscholte commented on a change in pull request #415: URL: https://github.com/apache/maven/pull/415#discussion_r549321675 ## File path: maven-embedder/src/main/java/org/apache/maven/cli/MavenCli.java ## @@ -518,10 +520,9 @@ else if ( !"auto".equals( styleColor ) )

[GitHub] [maven-resolver] michael-o commented on pull request #77: [MRESOLVER-145] SyncContext implementations

2020-12-28 Thread GitBox
michael-o commented on pull request #77: URL: https://github.com/apache/maven-resolver/pull/77#issuecomment-751690622 @rmannibucau I would not exclude them from the delivery, but mark as experimental. I want people to test them. If we don't make it publically available it won't be usable f

[jira] [Commented] (MJLINK-39) Add support for choosing vm

2020-12-28 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MJLINK-39?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17255547#comment-17255547 ] Michael Osipov commented on MJLINK-39: -- As long as jlink does the right thing when in

[jira] [Commented] (MNG-7022) Remove o.a.m.lifecycle.mapping.Lifecycle optional mojos backward compat code

2020-12-28 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/MNG-7022?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=1721#comment-1721 ] Hudson commented on MNG-7022: - Build unstable in Jenkins: Maven » Maven TLP » maven » MNG-7032_

[jira] [Commented] (MNG-5639) Support resolution of Import Scope POMs from Repo that contains a ${parameter}

2020-12-28 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/MNG-5639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=1723#comment-1723 ] Hudson commented on MNG-5639: - Build unstable in Jenkins: Maven » Maven TLP » maven » MNG-7032_

[jira] [Commented] (MNG-7046) Revert MNG-5639 and make repo config static only

2020-12-28 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/MNG-7046?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=1722#comment-1722 ] Hudson commented on MNG-7046: - Build unstable in Jenkins: Maven » Maven TLP » maven » MNG-7032_

[jira] [Commented] (MNG-4660) Use of --resume-from in multi-module project fails with missing inter-module dependencies

2020-12-28 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/MNG-4660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=1724#comment-1724 ] Hudson commented on MNG-4660: - Build unstable in Jenkins: Maven » Maven TLP » maven » MNG-7032_

[jira] [Commented] (MNG-7032) Option -B still showing formatting when used with --version

2020-12-28 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/MNG-7032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=1720#comment-1720 ] Hudson commented on MNG-7032: - Build unstable in Jenkins: Maven » Maven TLP » maven » MNG-7032_

[jira] [Commented] (DOXIA-616) Markdown: Properly expose the language specified in fenced code blocks

2020-12-28 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/DOXIA-616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17255560#comment-17255560 ] Michael Osipov commented on DOXIA-616: -- Drop clirr, on hc.apache.org we have decided

[jira] [Commented] (DOXIA-616) Markdown: Properly expose the language specified in fenced code blocks

2020-12-28 Thread Bertrand Martin (Jira)
[ https://issues.apache.org/jira/browse/DOXIA-616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17255563#comment-17255563 ] Bertrand Martin commented on DOXIA-616: --- I found my way with clirr. I guess we'll re

[jira] [Issue Comment Deleted] (MNG-7032) Option -B still showing formatting when used with --version

2020-12-28 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MNG-7032?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov updated MNG-7032: Comment: was deleted (was: Build unstable in Jenkins: Maven » Maven TLP » maven » MNG-7032_versionco

[jira] [Commented] (DOXIA-616) Markdown: Properly expose the language specified in fenced code blocks

2020-12-28 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/DOXIA-616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17255565#comment-17255565 ] Michael Osipov commented on DOXIA-616: -- Agreed. > Markdown: Properly expose the lang

[GitHub] [maven] rfscholte commented on a change in pull request #419: [MNG-4645] Move Central repo definition out of Maven's core so it can…

2020-12-28 Thread GitBox
rfscholte commented on a change in pull request #419: URL: https://github.com/apache/maven/pull/419#discussion_r549349372 ## File path: apache-maven/src/assembly/maven/conf/settings.xml ## @@ -244,14 +244,43 @@ under the License. --> + + maven:core:c

[GitHub] [maven-resolver] michael-o commented on a change in pull request #77: [MRESOLVER-145] SyncContext implementations

2020-12-28 Thread GitBox
michael-o commented on a change in pull request #77: URL: https://github.com/apache/maven-resolver/pull/77#discussion_r549341209 ## File path: maven-resolver-impl/pom.xml ## @@ -49,6 +49,10 @@ org.apache.maven.resolver maven-resolver-spi + + org.apa

[GitHub] [maven] michael-o commented on a change in pull request #419: [MNG-4645] Move Central repo definition out of Maven's core so it can…

2020-12-28 Thread GitBox
michael-o commented on a change in pull request #419: URL: https://github.com/apache/maven/pull/419#discussion_r549356949 ## File path: apache-maven/src/assembly/maven/conf/settings.xml ## @@ -244,14 +244,43 @@ under the License. --> + + maven:core:c

[GitHub] [maven-ear-plugin] elharo commented on a change in pull request #34: update ejb plugin

2020-12-28 Thread GitBox
elharo commented on a change in pull request #34: URL: https://github.com/apache/maven-ear-plugin/pull/34#discussion_r549357981 ## File path: pom.xml ## @@ -88,7 +88,7 @@ 2020-09-26T20:10:30Z 3.3.1 2.5.1 -2.3 +3.1.0 Review comment: I prefer to le

[GitHub] [maven-ear-plugin] elharo merged pull request #35: compareTo should throw NullPointerException per spec

2020-12-28 Thread GitBox
elharo merged pull request #35: URL: https://github.com/apache/maven-ear-plugin/pull/35 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [maven-ear-plugin] elharo merged pull request #34: update ejb plugin

2020-12-28 Thread GitBox
elharo merged pull request #34: URL: https://github.com/apache/maven-ear-plugin/pull/34 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [maven] mkarg opened a new pull request #421: Artifact.getPath() and .setPath()

2020-12-28 Thread GitBox
mkarg opened a new pull request #421: URL: https://github.com/apache/maven/pull/421 Simplifying usage of Java NIO API (since Java 7), so the *calling* code does not need to convert to / from Path ON ITS OWN again and again. By using `default` interface methods, this should not imply

[GitHub] [maven] rfscholte commented on a change in pull request #421: Artifact.getPath() and .setPath()

2020-12-28 Thread GitBox
rfscholte commented on a change in pull request #421: URL: https://github.com/apache/maven/pull/421#discussion_r549377500 ## File path: maven-artifact/src/main/java/org/apache/maven/artifact/Artifact.java ## @@ -86,6 +87,16 @@ void setFile( File destination ); +def

[GitHub] [maven-ejb-plugin] elharo opened a new pull request #12: ignore versions backup files

2020-12-28 Thread GitBox
elharo opened a new pull request #12: URL: https://github.com/apache/maven-ejb-plugin/pull/12 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [maven-ejb-plugin] elharo closed pull request #9: add travic-ci; add travis badge to README.md

2020-12-28 Thread GitBox
elharo closed pull request #9: URL: https://github.com/apache/maven-ejb-plugin/pull/9 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[GitHub] [maven-ejb-plugin] elharo commented on pull request #9: add travic-ci; add travis badge to README.md

2020-12-28 Thread GitBox
elharo commented on pull request #9: URL: https://github.com/apache/maven-ejb-plugin/pull/9#issuecomment-751749847 https://www.r-bloggers.com/2020/11/moving-away-from-travis-ci/ This is an automated message from the Apache Gi

[GitHub] [maven-ejb-plugin] elharo commented on a change in pull request #11: [MEJB-130] Accept ejbVersion 4.x

2020-12-28 Thread GitBox
elharo commented on a change in pull request #11: URL: https://github.com/apache/maven-ejb-plugin/pull/11#discussion_r549387107 ## File path: src/main/java/org/apache/maven/plugins/ejb/EjbMojo.java ## @@ -465,10 +465,10 @@ private File generateEjbClient() private void chec

[jira] [Commented] (MNG-6830) Warn on missing namespace

2020-12-28 Thread Brian E Fox (Jira)
[ https://issues.apache.org/jira/browse/MNG-6830?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17255622#comment-17255622 ] Brian E Fox commented on MNG-6830: -- After chatting in slack to find some good examples:  

[jira] [Commented] (MNG-6830) Warn on missing namespace

2020-12-28 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MNG-6830?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17255625#comment-17255625 ] Michael Osipov commented on MNG-6830: - Correct, so we should say we do not care about n

[GitHub] [maven] bmarwell commented on pull request #415: [MNG-7032] do not print colours for --version when in batch mode.

2020-12-28 Thread GitBox
bmarwell commented on pull request #415: URL: https://github.com/apache/maven/pull/415#issuecomment-751754398 > This looks OK, but incomplete. When if you at `org.apache.maven.cli.MavenCli.logging(CliRequest)` in the block marked with `// LOG COLOR` you see duplicate code now. It is probab

[GitHub] [maven] bmarwell edited a comment on pull request #415: [MNG-7032] do not print colours for --version when in batch mode.

2020-12-28 Thread GitBox
bmarwell edited a comment on pull request #415: URL: https://github.com/apache/maven/pull/415#issuecomment-751754398 > This looks OK, but incomplete. When if you at `org.apache.maven.cli.MavenCli.logging(CliRequest)` in the block marked with `// LOG COLOR` you see duplicate code now. It is

[GitHub] [maven-ejb-plugin] elharo opened a new pull request #13: remove dependency on AssertJ

2020-12-28 Thread GitBox
elharo opened a new pull request #13: URL: https://github.com/apache/maven-ejb-plugin/pull/13 @michael-o also update JUnit This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [maven] mkarg commented on a change in pull request #421: Artifact.getPath() and .setPath()

2020-12-28 Thread GitBox
mkarg commented on a change in pull request #421: URL: https://github.com/apache/maven/pull/421#discussion_r549391327 ## File path: maven-artifact/src/main/java/org/apache/maven/artifact/Artifact.java ## @@ -86,6 +87,16 @@ void setFile( File destination ); +default

[GitHub] [maven] rmannibucau commented on pull request #421: Artifact.getPath() and .setPath()

2020-12-28 Thread GitBox
rmannibucau commented on pull request #421: URL: https://github.com/apache/maven/pull/421#issuecomment-751756543 Quick side note: using a default method is a breaking change so should likely happen only in maven >= 4 (it breaks java lang proxies). -

[jira] [Commented] (MNG-6830) Warn on missing namespace

2020-12-28 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MNG-6830?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17255628#comment-17255628 ] Michael Osipov commented on MNG-6830: - The Modello model allows to define versions on e

[GitHub] [maven-ejb-plugin] elharo opened a new pull request #14: remove deprecation warnings by not stubbing value class

2020-12-28 Thread GitBox
elharo opened a new pull request #14: URL: https://github.com/apache/maven-ejb-plugin/pull/14 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [maven] michael-o commented on pull request #415: [MNG-7032] do not print colours for --version when in batch mode.

2020-12-28 Thread GitBox
michael-o commented on pull request #415: URL: https://github.com/apache/maven/pull/415#issuecomment-751758529 My bad, I did not notice that you have moved the code. But still, The property needs to be in the new method now for consistency reasons.

[GitHub] [maven] mkarg commented on pull request #421: Artifact.getPath() and .setPath()

2020-12-28 Thread GitBox
mkarg commented on pull request #421: URL: https://github.com/apache/maven/pull/421#issuecomment-751758976 > Quick side note: using a default method is a breaking change so should likely happen only in maven >= 4 (it breaks java lang proxies). What can break here? -

[GitHub] [maven] mkarg edited a comment on pull request #421: Artifact.getPath() and .setPath()

2020-12-28 Thread GitBox
mkarg edited a comment on pull request #421: URL: https://github.com/apache/maven/pull/421#issuecomment-751758976 > Quick side note: using a default method is a breaking change so should likely happen only in maven >= 4 (it breaks java lang proxies). What can break here? Isn't

[jira] [Created] (MNGSITE-437) Intellij IDEA code style setting file is outdated

2020-12-28 Thread Sandra Parsick (Jira)
Sandra Parsick created MNGSITE-437: -- Summary: Intellij IDEA code style setting file is outdated Key: MNGSITE-437 URL: https://issues.apache.org/jira/browse/MNGSITE-437 Project: Maven Project Web Site

[jira] [Commented] (MNG-7032) Option -B still showing formatting when used with --version

2020-12-28 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/MNG-7032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17255633#comment-17255633 ] Hudson commented on MNG-7032: - Build unstable in Jenkins: Maven » Maven TLP » maven » MNG-7032_

[GitHub] [maven] rmannibucau commented on pull request #421: Artifact.getPath() and .setPath()

2020-12-28 Thread GitBox
rmannibucau commented on pull request #421: URL: https://github.com/apache/maven/pull/421#issuecomment-751766701 @mkarg java lang proxies don't know how to invoke the default method so you will not get the expected behavior. This is a common breaking change since default methods were intro

[GitHub] [maven] mkarg commented on pull request #421: Artifact.getPath() and .setPath()

2020-12-28 Thread GitBox
mkarg commented on pull request #421: URL: https://github.com/apache/maven/pull/421#issuecomment-751779644 I have no strong feelings whether we should keep it as `default` methods or whether to force all implementations to adopt it on their own. Somebody has to decide. --

[GitHub] [maven-apache-parent] dependabot[bot] commented on pull request #28: Bump maven-scm-publish-plugin from 3.0.0 to 3.1.0

2020-12-28 Thread GitBox
dependabot[bot] commented on pull request #28: URL: https://github.com/apache/maven-apache-parent/pull/28#issuecomment-751796780 Looks like org.apache.maven.plugins:maven-scm-publish-plugin is up-to-date now, so this is no longer needed. --

[GitHub] [maven-apache-parent] dependabot[bot] closed pull request #28: Bump maven-scm-publish-plugin from 3.0.0 to 3.1.0

2020-12-28 Thread GitBox
dependabot[bot] closed pull request #28: URL: https://github.com/apache/maven-apache-parent/pull/28 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[jira] [Commented] (MPOM-259) Upgrade maven-scm-plugin from 3.0.0 to 3.1.0

2020-12-28 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/MPOM-259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17255665#comment-17255665 ] Hudson commented on MPOM-259: - Build succeeded in Jenkins: Maven » Maven TLP » maven-apache-par

[jira] [Updated] (MPOM-259) Upgrade maven-scm-plugin from 3.0.0 to 3.1.0

2020-12-28 Thread Sylwester Lachiewicz (Jira)
[ https://issues.apache.org/jira/browse/MPOM-259?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sylwester Lachiewicz updated MPOM-259: -- Fix Version/s: ASF-24 > Upgrade maven-scm-plugin from 3.0.0 to 3.1.0 > --

[jira] [Assigned] (MPOM-259) Upgrade maven-scm-plugin from 3.0.0 to 3.1.0

2020-12-28 Thread Sylwester Lachiewicz (Jira)
[ https://issues.apache.org/jira/browse/MPOM-259?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sylwester Lachiewicz reassigned MPOM-259: - Assignee: Sylwester Lachiewicz > Upgrade maven-scm-plugin from 3.0.0 to 3.1.0 > --

[jira] [Closed] (MPOM-259) Upgrade maven-scm-plugin from 3.0.0 to 3.1.0

2020-12-28 Thread Sylwester Lachiewicz (Jira)
[ https://issues.apache.org/jira/browse/MPOM-259?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sylwester Lachiewicz closed MPOM-259. - Resolution: Fixed > Upgrade maven-scm-plugin from 3.0.0 to 3.1.0 >

[jira] [Commented] (MPOM-259) Upgrade maven-scm-plugin from 3.0.0 to 3.1.0

2020-12-28 Thread Sylwester Lachiewicz (Jira)
[ https://issues.apache.org/jira/browse/MPOM-259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17255666#comment-17255666 ] Sylwester Lachiewicz commented on MPOM-259: --- Done in [01d812b4e78c1661ad61b1d1be

[GitHub] [maven-ejb-plugin] pzygielo commented on a change in pull request #11: [MEJB-130] Accept ejbVersion 4.x

2020-12-28 Thread GitBox
pzygielo commented on a change in pull request #11: URL: https://github.com/apache/maven-ejb-plugin/pull/11#discussion_r549431440 ## File path: src/main/java/org/apache/maven/plugins/ejb/EjbMojo.java ## @@ -465,10 +465,10 @@ private File generateEjbClient() private void ch

[GitHub] [maven] bmarwell commented on pull request #415: [MNG-7032] do not print colours for --version when in batch mode.

2020-12-28 Thread GitBox
bmarwell commented on pull request #415: URL: https://github.com/apache/maven/pull/415#issuecomment-751812135 > My bad, I did not notice that you have moved the code. But still, The property needs to be in the new method now for consistency reasons. I see. I could just move that bloc

[GitHub] [maven] rmannibucau commented on pull request #421: Artifact.getPath() and .setPath()

2020-12-28 Thread GitBox
rmannibucau commented on pull request #421: URL: https://github.com/apache/maven/pull/421#issuecomment-751817795 From a quick review it sounds hurting less to add it and enforce impl to have it (for impl using proxies it will be hurtless) and others likely use our artifact impl so sounds a

[GitHub] [maven] mkarg commented on pull request #421: Artifact.getPath() and .setPath()

2020-12-28 Thread GitBox
mkarg commented on pull request #421: URL: https://github.com/apache/maven/pull/421#issuecomment-751821795 Well, in the first place it means more work for me while it is unclear how many proxies exist for `Artifact`. ;-) But if the majority wants me to change my solution to that more compl

[GitHub] [maven-resolver] cstamas commented on a change in pull request #77: [MRESOLVER-145] SyncContext implementations

2020-12-28 Thread GitBox
cstamas commented on a change in pull request #77: URL: https://github.com/apache/maven-resolver/pull/77#discussion_r549457200 ## File path: maven-resolver-impl/pom.xml ## @@ -49,6 +49,10 @@ org.apache.maven.resolver maven-resolver-spi + + org.apach

[GitHub] [maven] rmannibucau commented on pull request #421: Artifact.getPath() and .setPath()

2020-12-28 Thread GitBox
rmannibucau commented on pull request #421: URL: https://github.com/apache/maven/pull/421#issuecomment-751833740 Path is slower than File, it is only interesting when the filesystem can be abstracted IIRC. Also changing the internal will not help much in regards of what is done or we need

[GitHub] [maven-resolver] cstamas commented on a change in pull request #77: [MRESOLVER-145] SyncContext implementations

2020-12-28 Thread GitBox
cstamas commented on a change in pull request #77: URL: https://github.com/apache/maven-resolver/pull/77#discussion_r549460660 ## File path: maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/synccontext/NamedSyncContextFactory.java ## @@ -0,0 +1,91 @@ +package

[GitHub] [maven-resolver] cstamas commented on a change in pull request #77: [MRESOLVER-145] SyncContext implementations

2020-12-28 Thread GitBox
cstamas commented on a change in pull request #77: URL: https://github.com/apache/maven-resolver/pull/77#discussion_r549460708 ## File path: maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/synccontext/SyncContextFactoryAdapter.java ## @@ -0,0 +1,272 @@ +pack

[GitHub] [maven-resolver] cstamas commented on a change in pull request #77: [MRESOLVER-145] SyncContext implementations

2020-12-28 Thread GitBox
cstamas commented on a change in pull request #77: URL: https://github.com/apache/maven-resolver/pull/77#discussion_r549460800 ## File path: maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/synccontext/SyncContextFactoryAdapter.java ## @@ -0,0 +1,272 @@ +pack

[GitHub] [maven-resolver] cstamas commented on a change in pull request #77: [MRESOLVER-145] SyncContext implementations

2020-12-28 Thread GitBox
cstamas commented on a change in pull request #77: URL: https://github.com/apache/maven-resolver/pull/77#discussion_r549461252 ## File path: maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/synccontext/SyncContextFactoryAdapter.java ## @@ -0,0 +1,272 @@ +pack

[GitHub] [maven-resolver] cstamas commented on a change in pull request #77: [MRESOLVER-145] SyncContext implementations

2020-12-28 Thread GitBox
cstamas commented on a change in pull request #77: URL: https://github.com/apache/maven-resolver/pull/77#discussion_r549461325 ## File path: maven-resolver-named-hazelcast/src/test/resources/hazelcast-client.xml ## @@ -0,0 +1,39 @@ + + + + +http://www.hazelcast.com/schema/clie

[GitHub] [maven-resolver] cstamas commented on a change in pull request #77: [MRESOLVER-145] SyncContext implementations

2020-12-28 Thread GitBox
cstamas commented on a change in pull request #77: URL: https://github.com/apache/maven-resolver/pull/77#discussion_r549461341 ## File path: maven-resolver-named-hazelcast/src/test/resources/hazelcast.xml ## @@ -0,0 +1,42 @@ + + + + +http://www.hazelcast.com/schema/config"; +

[GitHub] [maven-resolver] cstamas commented on a change in pull request #77: [MRESOLVER-145] SyncContext implementations

2020-12-28 Thread GitBox
cstamas commented on a change in pull request #77: URL: https://github.com/apache/maven-resolver/pull/77#discussion_r549461637 ## File path: maven-resolver-named/src/main/java/org/eclipse/aether/named/NamedLock.java ## @@ -0,0 +1,71 @@ +package org.eclipse.aether.named; + +/*

[jira] [Commented] (MEAR-269) Generate Websphere Deployment Descriptors

2020-12-28 Thread Benjamin Marwell (Jira)
[ https://issues.apache.org/jira/browse/MEAR-269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17255704#comment-17255704 ] Benjamin Marwell commented on MEAR-269: --- [~dgautier] are you referring to the files {

[jira] [Created] (MEAR-295) Require Maven 3.1.1

2020-12-28 Thread Sylwester Lachiewicz (Jira)
Sylwester Lachiewicz created MEAR-295: - Summary: Require Maven 3.1.1 Key: MEAR-295 URL: https://issues.apache.org/jira/browse/MEAR-295 Project: Maven EAR Plugin Issue Type: Dependency upg

[GitHub] [maven-resolver] cstamas commented on a change in pull request #77: [MRESOLVER-145] SyncContext implementations

2020-12-28 Thread GitBox
cstamas commented on a change in pull request #77: URL: https://github.com/apache/maven-resolver/pull/77#discussion_r549467158 ## File path: maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/synccontext/SyncContextFactoryAdapter.java ## @@ -0,0 +1,272 @@ +pack

[GitHub] [maven-resolver] cstamas commented on a change in pull request #77: [MRESOLVER-145] SyncContext implementations

2020-12-28 Thread GitBox
cstamas commented on a change in pull request #77: URL: https://github.com/apache/maven-resolver/pull/77#discussion_r549475294 ## File path: maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/synccontext/SyncContextFactoryAdapter.java ## @@ -0,0 +1,272 @@ +pack

  1   2   >