rfscholte commented on pull request #16:
URL:
https://github.com/apache/maven-deploy-plugin/pull/16#issuecomment-751231372
I think the description is wrong, because MDEPLOY-231 is still valid to me.
It looks like you're only restoring an IT, which is not the same.
---
mabrarov commented on a change in pull request #32:
URL: https://github.com/apache/maven-ear-plugin/pull/32#discussion_r548865908
##
File path:
src/test/java/org/apache/maven/plugins/ear/util/ArtifactRepositoryTest.java
##
@@ -34,14 +36,15 @@
extends AbstractEarTestBase
mabrarov commented on a change in pull request #32:
URL: https://github.com/apache/maven-ear-plugin/pull/32#discussion_r548865908
##
File path:
src/test/java/org/apache/maven/plugins/ear/util/ArtifactRepositoryTest.java
##
@@ -34,14 +36,15 @@
extends AbstractEarTestBase
mabrarov commented on a change in pull request #32:
URL: https://github.com/apache/maven-ear-plugin/pull/32#discussion_r548865908
##
File path:
src/test/java/org/apache/maven/plugins/ear/util/ArtifactRepositoryTest.java
##
@@ -34,14 +36,15 @@
extends AbstractEarTestBase
michael-o commented on pull request #16:
URL:
https://github.com/apache/maven-deploy-plugin/pull/16#issuecomment-751247730
I am confused by your statement. I do not restore the IT, I am removing it.
Please explain how you understand the issue is still valid.
-
[
https://issues.apache.org/jira/browse/MNG-7052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17254842#comment-17254842
]
Michael Osipov commented on MNG-7052:
-
I would also add colon (\{{:}}) to the list for
[
https://issues.apache.org/jira/browse/MNG-7052?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Osipov updated MNG-7052:
Comment: was deleted
(was: I think this should also apply to elements in the settings, but should
re
michael-o commented on pull request #16:
URL:
https://github.com/apache/maven-deploy-plugin/pull/16#issuecomment-751253385
Your understanding is that the commit title should read: "Revert IT of
MDEPLOY-231"?
This is an auto
[
https://issues.apache.org/jira/browse/MNG-7052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17254844#comment-17254844
]
Michael Osipov commented on MNG-7052:
-
I consider that understscore (\{{_}}) should als
[
https://issues.apache.org/jira/browse/MNG-6757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17254863#comment-17254863
]
Kalle Widell commented on MNG-6757:
---
[~michael-o] Im on vacation until jan 4:th. Would it
[
https://issues.apache.org/jira/browse/MNG-6757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17254864#comment-17254864
]
Michael Osipov commented on MNG-6757:
-
No issue, take your time. Providing a sample pro
[
https://issues.apache.org/jira/browse/MNG-6757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17254872#comment-17254872
]
Kalle Widell commented on MNG-6757:
---
[~michael-o] Ok. ill see to that such is provided.
[
https://issues.apache.org/jira/browse/MNG-6757?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17254872#comment-17254872
]
Michael Osipov edited comment on MNG-6757 at 12/25/20, 4:31 PM:
-
[
https://issues.apache.org/jira/browse/MRESOLVER-153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17254912#comment-17254912
]
Tamás Cservenák commented on MRESOLVER-153:
---
[~michael-o]I agree, synchroniz
[
https://issues.apache.org/jira/browse/MRESOLVER-153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17254913#comment-17254913
]
Michael Osipov commented on MRESOLVER-153:
--
I do not fully agree that the tra
rfscholte commented on pull request #16:
URL:
https://github.com/apache/maven-deploy-plugin/pull/16#issuecomment-751288561
I was a bit confused, but it is not a complete revert, just partial.
However, I think it is valid to keep this IT. It in an _integration test_
that ensures the chec
michael-o commented on pull request #16:
URL:
https://github.com/apache/maven-deploy-plugin/pull/16#issuecomment-751288717
The problem with this is that it is not portable. It does not know which
checksums are generated. It is assumed, but nothing else.
--
michael-o edited a comment on pull request #16:
URL:
https://github.com/apache/maven-deploy-plugin/pull/16#issuecomment-751288717
The problem with this is that it is not portable. It does not know which
checksums are generated. It is assumed, but nothing else. This especially
depends on t
michael-o commented on pull request #16:
URL:
https://github.com/apache/maven-deploy-plugin/pull/16#issuecomment-751289154
See my comment:
https://issues.apache.org/jira/browse/MDEPLOY-231?focusedCommentId=17253097&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#com
rfscholte commented on pull request #16:
URL:
https://github.com/apache/maven-deploy-plugin/pull/16#issuecomment-751289327
But based on the Maven version we know the default generated checksum right?
This is an automated mes
michael-o commented on pull request #16:
URL:
https://github.com/apache/maven-deploy-plugin/pull/16#issuecomment-751289417
>
>
> But based on the Maven version we know the default generated checksum
right?
Theoretically, yes. You could add this to the configuration somehow.
[
https://issues.apache.org/jira/browse/MRESOLVER-153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17254916#comment-17254916
]
Tamás Cservenák commented on MRESOLVER-153:
---
Yup, did not meant to return (r
[
https://issues.apache.org/jira/browse/MRESOLVER-153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17254917#comment-17254917
]
Michael Osipov commented on MRESOLVER-153:
--
{quote}Yup, did not meant to retu
[
https://issues.apache.org/jira/browse/MRESOLVER-153?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Osipov updated MRESOLVER-153:
-
Comment: was deleted
(was: {quote}Yup, did not meant to return (removed) FS locking or
[
https://issues.apache.org/jira/browse/MRESOLVER-153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17254918#comment-17254918
]
Michael Osipov commented on MRESOLVER-153:
--
bq. Yup, did not meant to return
[
https://issues.apache.org/jira/browse/MNG-6979?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Falko Modler updated MNG-6979:
--
Attachment: MNG-6979.zip
> MavenSession.getCurrentProject may return an incorrect project in a
> multimo
[
https://issues.apache.org/jira/browse/MNG-6979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17254924#comment-17254924
]
Falko Modler commented on MNG-6979:
---
[~michael-o] see [^MNG-6979.zip].
- {{mvn clean inst
[
https://issues.apache.org/jira/browse/MNG-6979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17254925#comment-17254925
]
George Gastaldi commented on MNG-6979:
--
Thank you so much [~famod]!
> MavenSession.ge
[
https://issues.apache.org/jira/browse/MNG-6979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17254926#comment-17254926
]
Michael Osipov commented on MNG-6979:
-
Thanks, I will try to reproduce and let you know
[
https://issues.apache.org/jira/browse/MASSEMBLY-947?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17254927#comment-17254927
]
Peter lynch commented on MASSEMBLY-947:
---
The issue was noticed when stray cr lin
[
https://issues.apache.org/jira/browse/MASSEMBLY-947?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17254928#comment-17254928
]
Michael Osipov commented on MASSEMBLY-947:
--
Agreed.
> fileSet lineEnding crl
[
https://issues.apache.org/jira/browse/MNG-6979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17254924#comment-17254924
]
Falko Modler edited comment on MNG-6979 at 12/26/20, 12:11 AM:
--
[
https://issues.apache.org/jira/browse/DOXIA-542?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Osipov updated DOXIA-542:
-
Labels: (was: close-pending)
> Markdown module converts all apostrophes to quotation marks
> ---
33 matches
Mail list logo
