[
https://issues.apache.org/jira/browse/MPOM-244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17245755#comment-17245755
]
Konrad Windszus commented on MPOM-244:
--
Manual steps fiddling with your Maven installa
bmarwell commented on pull request #17:
URL:
https://github.com/apache/maven-checkstyle-plugin/pull/17#issuecomment-740494240
Rebased, CI running again
https://ci-builds.apache.org/blue/organizations/jenkins/Maven%2Fmaven-box%2Fmaven-checkstyle-plugin/detail/MCHECKSTYLE-385/15/pipel
bmarwell commented on pull request #17:
URL:
https://github.com/apache/maven-checkstyle-plugin/pull/17#issuecomment-740508298
Fixed in
https://github.com/apache/maven-checkstyle-plugin/commit/b259e84bdd0ed798ec52d1500d8323c18f0790ea.
--
bmarwell closed pull request #17:
URL: https://github.com/apache/maven-checkstyle-plugin/pull/17
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL ab
rmannibucau commented on pull request #21:
URL: https://github.com/apache/maven-jlink-plugin/pull/21#issuecomment-740512358
Looks better than it was so +1.
Can need some more tests like with a null module artifact or switched one
but can come later imho.
---
rmannibucau commented on pull request #23:
URL: https://github.com/apache/maven-jlink-plugin/pull/23#issuecomment-740513922
Isnt it better to use the class logger like before rather than a static one
which looses the context when logging the class name for these cases?
Also not sure it i
[
https://issues.apache.org/jira/browse/MCHECKSTYLE-385?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17245783#comment-17245783
]
Hudson commented on MCHECKSTYLE-385:
Build succeeded in Jenkins: Maven » Maven T
[
https://issues.apache.org/jira/browse/MCHECKSTYLE-385?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Benjamin Marwell resolved MCHECKSTYLE-385.
--
Fix Version/s: 3.1.2
Assignee: Benjamin Marwell
Resolution:
[
https://issues.apache.org/jira/browse/MPOM-244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17245814#comment-17245814
]
Michael Osipov commented on MPOM-244:
-
If you really need it, you will do it.
> Upload
bmarwell commented on pull request #20:
URL: https://github.com/apache/maven-jlink-plugin/pull/20#issuecomment-740547709
> The "jabba + openj9@11" could be replaced with a usage of setup-java
action. Not?
I would not know how. The Jabba plugin puts the installation path into an
env
bmarwell commented on pull request #14:
URL: https://github.com/apache/maven-jlink-plugin/pull/14#issuecomment-740548516
> Small point: should jvm version be checked to fail if it is not supported?
Thanks, I will add a nice error message if neither the toolchain (if
present) nor the
bmarwell commented on pull request #23:
URL: https://github.com/apache/maven-jlink-plugin/pull/23#issuecomment-740549053
> Isnt it better to use the class logger like before rather than a static
one which looses the context when logging the class name for these cases?
> Also not sure it
elharo commented on pull request #23:
URL: https://github.com/apache/maven-jlink-plugin/pull/23#issuecomment-740551021
Yes, we'd like to get rid of the maven logging and just use SLF4J everywhere
This is an automated message
rmannibucau commented on pull request #23:
URL: https://github.com/apache/maven-jlink-plugin/pull/23#issuecomment-740553825
My point was not about slf4j, the slf4j part was just "no need to move mojo
to another logger since correct logger setup is already wired", the point is
that the logg
bmarwell commented on pull request #21:
URL: https://github.com/apache/maven-jlink-plugin/pull/21#issuecomment-740554700
Hey, I will not merge it right now because I just saw the the plugin will
always write to `target/maven-jlink`. If multiple artifacts would be generated,
they would over
[
https://issues.apache.org/jira/browse/DOXIA-616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17245837#comment-17245837
]
Bertrand Martin commented on DOXIA-616:
---
[~hboutemy][~michael-o][~michaelo] Guys, do
elharo commented on pull request #23:
URL: https://github.com/apache/maven-jlink-plugin/pull/23#issuecomment-740578992
This plugin has only been released in alpha so far. Thus no need to worry
about API compatibility.
This
rmannibucau commented on pull request #23:
URL: https://github.com/apache/maven-jlink-plugin/pull/23#issuecomment-740598352
@elharo it is not about the plugin compat but the feature it provides. A
logger per mojo is a key feature for logs (in particular on CI), moving to a
static instance
bmarwell commented on pull request #23:
URL: https://github.com/apache/maven-jlink-plugin/pull/23#issuecomment-740619544
> This plugin has only been released in alpha so far. Thus no need to worry
about API compatibility.
Sorry, you might have missed that, but there is a 3.0.0 releas
elharo commented on pull request #23:
URL: https://github.com/apache/maven-jlink-plugin/pull/23#issuecomment-740621788
The [website](https://maven.apache.org/plugins/maven-jlink-plugin/)
prominently states, "NOTE: This is an alpha release which means everything can
change until we reach th
Moti Nisenson-Ken created MNG-7049:
--
Summary: Version range resolution downloads all poms, not just the
highest version
Key: MNG-7049
URL: https://issues.apache.org/jira/browse/MNG-7049
Project: Mave
bmarwell commented on pull request #23:
URL: https://github.com/apache/maven-jlink-plugin/pull/23#issuecomment-740622513
> The [website](https://maven.apache.org/plugins/maven-jlink-plugin/)
prominently states, "NOTE: This is an alpha release which means everything can
change until we reac
rmannibucau commented on pull request #23:
URL: https://github.com/apache/maven-jlink-plugin/pull/23#issuecomment-740628359
Hey guys, lt's keep the site update discussion for another thread, think we
have enough with make the logger setup right.
So we have 2 options I think:
1. do
rmannibucau edited a comment on pull request #23:
URL: https://github.com/apache/maven-jlink-plugin/pull/23#issuecomment-740628359
Hey guys, let's keep the site update discussion for another thread, think we
have enough with make the logger setup right.
So we have 2 options I think:
bmarwell commented on pull request #23:
URL: https://github.com/apache/maven-jlink-plugin/pull/23#issuecomment-740629505
This must be discussed on the mailing list. @elharo can you do that please?
This is an automated message
struberg commented on pull request #23:
URL: https://github.com/apache/maven-jlink-plugin/pull/23#issuecomment-740632700
Hmm, to be honest - I still see no reason to use slf4j over our very own
logging API.
The discussion is very old actually, and I never was a fan of dropping our
own c
rmannibucau commented on pull request #23:
URL: https://github.com/apache/maven-jlink-plugin/pull/23#issuecomment-740635441
Strictly speaking slf4j is NOT stable (only 1.7 is stable and not last one
sadly so it will break soon too). Other issue is that maven leaks slf4j without
hanling slf
[
https://issues.apache.org/jira/browse/DOXIA-616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17245923#comment-17245923
]
Michael Osipov commented on DOXIA-616:
--
It does. The first question, does the code hi
[
https://issues.apache.org/jira/browse/DOXIA-616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17245923#comment-17245923
]
Michael Osipov edited comment on DOXIA-616 at 12/8/20, 2:39 PM:
[
https://issues.apache.org/jira/browse/DOXIA-616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17245923#comment-17245923
]
Michael Osipov edited comment on DOXIA-616 at 12/8/20, 2:39 PM:
elharo commented on pull request #23:
URL: https://github.com/apache/maven-jlink-plugin/pull/23#issuecomment-740673182
The current Maven project-wide decision is to use SLF4J. That's not what I
would have chosen, but we shouldn't be deciding this on a plugin-by-plugin
basis. Any changes to
rmannibucau commented on pull request #23:
URL: https://github.com/apache/maven-jlink-plugin/pull/23#issuecomment-740676395
@elharo think there is a misconception there, maven != plugins. Plugins must
use plugin API, nothing complicated. For maven-core there is this partial -
since it was
elharo commented on pull request #23:
URL: https://github.com/apache/maven-jlink-plugin/pull/23#issuecomment-740709447
I don't agree. This is a project wide decision. There's a lot of shared
infrastructure and code between the plugins and the core. They should follow
the same standards.
rmannibucau commented on pull request #23:
URL: https://github.com/apache/maven-jlink-plugin/pull/23#issuecomment-740739995
@elharo we can agree to disagree but this thread tend to proove this is not
right and we don't have any slf4j mojo alternative to getLog() to ensure logger
is correct
[
https://issues.apache.org/jira/browse/DOXIA-616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17246033#comment-17246033
]
Bertrand Martin commented on DOXIA-616:
---
That's how one of the [most utilized
highl
[
https://issues.apache.org/jira/browse/MNG-7049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17246073#comment-17246073
]
Michael Osipov commented on MNG-7049:
-
I am so certain that I have seen a similiar requ
[
https://issues.apache.org/jira/browse/MRESOLVER-144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17246072#comment-17246072
]
Michael Osipov commented on MRESOLVER-144:
--
[~cstamas], did you get a chance
[
https://issues.apache.org/jira/browse/SCM-947?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17246075#comment-17246075
]
Michael Osipov commented on SCM-947:
Will pick up the PR as soon as I can.
> Improve Ch
[
https://issues.apache.org/jira/browse/MRESOLVER-145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17246079#comment-17246079
]
Michael Osipov commented on MRESOLVER-145:
--
This is not forgotten, but schedu
michael-o commented on pull request #399:
URL: https://github.com/apache/maven/pull/399#issuecomment-740864726
@gnodet I would like to review. Can you ping me on Friday by noon?
This is an automated message from the Apache G
michael-o edited a comment on pull request #399:
URL: https://github.com/apache/maven/pull/399#issuecomment-740864726
@gnodet I would like to review too. Can you ping me on Friday by noon?
This is an automated message from t
[
https://issues.apache.org/jira/browse/MWAR-439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17225587#comment-17225587
]
Michael Osipov edited comment on MWAR-439 at 12/8/20, 7:05 PM:
--
[
https://issues.apache.org/jira/browse/MWAR-439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17246082#comment-17246082
]
Michael Osipov commented on MWAR-439:
-
Can you bisect between these two versions?
> WA
[
https://issues.apache.org/jira/browse/MRESOLVER-90?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16867292#comment-16867292
]
Michael Osipov edited comment on MRESOLVER-90 at 12/8/20, 7:15 PM:
--
[
https://issues.apache.org/jira/browse/MNG-6979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17246098#comment-17246098
]
Michael Osipov commented on MNG-6979:
-
I wll have a look at this again...this year.
>
[
https://issues.apache.org/jira/browse/MNG-6979?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Osipov reassigned MNG-6979:
---
Assignee: Michael Osipov
> MavenSession.getCurrentProject may return an incorrect project in a
[
https://issues.apache.org/jira/browse/MRESOLVER-90?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17246097#comment-17246097
]
Michael Osipov commented on MRESOLVER-90:
-
[~hohwille], Maven 4.0.0-alpha-1 wil
Michael Osipov created MRESOLVER-151:
Summary: Switch the default checksum policy from "warn" to "fail"
Key: MRESOLVER-151
URL: https://issues.apache.org/jira/browse/MRESOLVER-151
Project: Maven Re
[
https://issues.apache.org/jira/browse/MRESOLVER-151?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Osipov updated MRESOLVER-151:
-
Description: This mirrors MNG-5728. The change has to happen in
{{DefaultChecksumPolic
[
https://issues.apache.org/jira/browse/MRESOLVER-151?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Osipov updated MRESOLVER-151:
-
Description: This mirrors MNG-5728. The change has to happen in
{{DefaultChecksumPolic
[
https://issues.apache.org/jira/browse/MRESOLVER-90?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Osipov updated MRESOLVER-90:
Fix Version/s: version-next
waiting-for-feedback
> HTML content in POM
[
https://issues.apache.org/jira/browse/MDEPLOY-260?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Osipov updated MDEPLOY-260:
---
Fix Version/s: wontfix-candidate
> Create correct SHA File content
> ---
[
https://issues.apache.org/jira/browse/MDEPLOY-260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17246110#comment-17246110
]
Michael Osipov commented on MDEPLOY-260:
Two reasons why this should be closed:
[
https://issues.apache.org/jira/browse/MNG-6870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17246119#comment-17246119
]
Michael Osipov commented on MNG-6870:
-
[~rfscholte], here is your dup: MNG-6457.
> A m
[
https://issues.apache.org/jira/browse/MNG-6457?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Osipov updated MNG-6457:
Fix Version/s: wontfix-candidate
> Resolving repository with an environment variable substitution fai
[
https://issues.apache.org/jira/browse/MNG-7046?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17246120#comment-17246120
]
Michael Osipov commented on MNG-7046:
-
[~rfscholte], MNG-6457 is the exact reason why t
[
https://issues.apache.org/jira/browse/MNG-6457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17246121#comment-17246121
]
Michael Osipov commented on MNG-6457:
-
Please see MNG-7046.
> Resolving repository wit
[
https://issues.apache.org/jira/browse/MNG-7044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17246131#comment-17246131
]
Will Iverson commented on MNG-7044:
---
Looks like the change would be to this file:
https:/
Matt Voboril created MPMD-311:
-
Summary: Improve excludesFile docs
Key: MPMD-311
URL: https://issues.apache.org/jira/browse/MPMD-311
Project: Maven PMD Plugin
Issue Type: Improvement
Co
TobiTenno opened a new pull request #39:
URL: https://github.com/apache/maven-pmd-plugin/pull/39
Improve the documentation around `exclude-cpd.properties` file formatting
This is an automated message from the Apache Git Servi
[
https://issues.apache.org/jira/browse/MPMD-311?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matt Voboril updated MPMD-311:
--
Description:
There is a bit of ambiguity when dealing with the {{exclude-cpd.properties}}
file format.
Manuel Jordan created MNG-7050:
--
Summary: Create M2_REPOSITORY env variable for Local Repository
and Wrapper locations
Key: MNG-7050
URL: https://issues.apache.org/jira/browse/MNG-7050
Project: Maven
struberg commented on pull request #23:
URL: https://github.com/apache/maven-jlink-plugin/pull/23#issuecomment-741587582
> The current Maven project-wide decision is to use SLF4J.
It historically was actually more a one person decision which went out of
control. Happened in around 2
struberg edited a comment on pull request #23:
URL: https://github.com/apache/maven-jlink-plugin/pull/23#issuecomment-741587582
> The current Maven project-wide decision is to use SLF4J.
It historically was actually more a one person decision which went out of
control. Happened in a
[
https://issues.apache.org/jira/browse/SUREFIRE-1862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17246336#comment-17246336
]
Marc Philipp commented on SUREFIRE-1862:
You're right, I missed that. Feel fre
65 matches
Mail list logo
