MartinKanters opened a new pull request #328:
URL: https://github.com/apache/maven-surefire/pull/328
Continuing https://github.com/apache/maven-surefire/pull/326/...
This is an automated message from the Apache Git Service.
T
bmarwell commented on pull request #19:
URL: https://github.com/apache/maven-jlink-plugin/pull/19#issuecomment-739480883
Fixed in #24f2bf8d10df37696f5901f4353e2ef1bd3fdd0b
This is an automated message from the Apache Git Serv
bmarwell closed pull request #19:
URL: https://github.com/apache/maven-jlink-plugin/pull/19
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above t
bmarwell edited a comment on pull request #19:
URL: https://github.com/apache/maven-jlink-plugin/pull/19#issuecomment-739480883
Fixed in
https://github.com/apache/maven-jlink-plugin/commit/24f2bf8d10df37696f5901f4353e2ef1bd3fdd0b
---
[
https://issues.apache.org/jira/browse/MJLINK-58?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Benjamin Marwell resolved MJLINK-58.
Assignee: Benjamin Marwell
Resolution: Fixed
> Remove usage of plexus utils, use commo
[
https://issues.apache.org/jira/browse/MJLINK-58?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17244699#comment-17244699
]
Hudson commented on MJLINK-58:
--
Build failed in Jenkins: Maven » Maven TLP » maven-jlink-plug
[
https://issues.apache.org/jira/browse/MNG-6268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17244703#comment-17244703
]
Michael Osipov commented on MNG-6268:
-
I will leave this ticket open for at least anoth
MartinKanters merged pull request #328:
URL: https://github.com/apache/maven-surefire/pull/328
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abov
Tibor17 commented on pull request #327:
URL: https://github.com/apache/maven-surefire/pull/327#issuecomment-739488042
@gianm
Pls check the logs from the
[build](https://github.com/apache/maven-surefire/pull/327/checks?check_run_id=1505231524).
There are 5 checkstyle violations. Pls f
[
https://issues.apache.org/jira/browse/MJLINK-53?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Benjamin Marwell updated MJLINK-53:
---
Fix Version/s: 3.0.1
> ITs should fail if no jlink binary is available
> -
[
https://issues.apache.org/jira/browse/MJLINK-53?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Benjamin Marwell reassigned MJLINK-53:
--
Assignee: Benjamin Marwell
> ITs should fail if no jlink binary is available
>
[
https://issues.apache.org/jira/browse/MJLINK-41?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Benjamin Marwell updated MJLINK-41:
---
Fix Version/s: 3.0.1
> Add support for launcher script
> ---
>
>
[
https://issues.apache.org/jira/browse/MJLINK-41?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Benjamin Marwell reassigned MJLINK-41:
--
Assignee: Benjamin Marwell
> Add support for launcher script
>
[
https://issues.apache.org/jira/browse/SUREFIRE-1584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17244728#comment-17244728
]
Tibor Digana commented on SUREFIRE-1584:
[~ctubbsii] I ahve to talkout it with
[
https://issues.apache.org/jira/browse/SUREFIRE-1584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17244728#comment-17244728
]
Tibor Digana edited comment on SUREFIRE-1584 at 12/6/20, 12:13 PM:
-
[
https://issues.apache.org/jira/browse/MNG-7038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17244729#comment-17244729
]
Konrad Windszus commented on MNG-7038:
--
Just FTR: There is a plugin which is able to s
mabrarov commented on pull request #24:
URL: https://github.com/apache/maven-ear-plugin/pull/24#issuecomment-739500692
It looks like this pull request was partially merged, because the diff has
reduced but is still not empty:
https://github.com/apache/maven-ear-plugin/compare/master.
[
https://issues.apache.org/jira/browse/MNG-7038?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Osipov updated MNG-7038:
Fix Version/s: Issues to be reviewed for 4.x
> Introduce public property to point to a root directory
mabrarov commented on pull request #22:
URL: https://github.com/apache/maven-ear-plugin/pull/22#issuecomment-739505049
Merged conflicts were resolved. Please trigger a new Jenkins build.
This is an automated message from the
Maxim Solodovnik created MRESOURCES-272:
---
Summary: Error message is not clear
Key: MRESOURCES-272
URL: https://issues.apache.org/jira/browse/MRESOURCES-272
Project: Maven Resources Plugin
[
https://issues.apache.org/jira/browse/MEAR-289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17244742#comment-17244742
]
Marat Abrarov commented on MEAR-289:
There is a chance that this issue is fixed within
[
https://issues.apache.org/jira/browse/MEAR-289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17244742#comment-17244742
]
Marat Abrarov edited comment on MEAR-289 at 12/6/20, 2:12 PM:
--
[
https://issues.apache.org/jira/browse/MEAR-289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17244742#comment-17244742
]
Marat Abrarov edited comment on MEAR-289 at 12/6/20, 2:18 PM:
--
[
https://issues.apache.org/jira/browse/MEAR-289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17244742#comment-17244742
]
Marat Abrarov edited comment on MEAR-289 at 12/6/20, 2:19 PM:
--
elharo commented on a change in pull request #21:
URL: https://github.com/apache/maven-jlink-plugin/pull/21#discussion_r537048702
##
File path: src/it/projects/MJLINK-52_classifiers/invoker.properties
##
@@ -0,0 +1,18 @@
+# Licensed to the Apache Software Foundation (ASF) under
elharo commented on a change in pull request #19:
URL: https://github.com/apache/maven-jlink-plugin/pull/19#discussion_r537049767
##
File path: pom.xml
##
@@ -109,6 +109,11 @@
commons-lang3
3.6
+
Review comment:
Even if this plugin requires Java
[
https://issues.apache.org/jira/browse/MEAR-216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17244747#comment-17244747
]
Hudson commented on MEAR-216:
-
Build succeeded in Jenkins: Maven » Maven TLP » maven-ear-plugin
[
https://issues.apache.org/jira/browse/MEAR-288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17244746#comment-17244746
]
Hudson commented on MEAR-288:
-
Build succeeded in Jenkins: Maven » Maven TLP » maven-ear-plugin
elharo opened a new pull request #22:
URL: https://github.com/apache/maven-jlink-plugin/pull/22
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abo
sparsick opened a new pull request #23:
URL: https://github.com/apache/maven-jlink-plugin/pull/23
- add slf4j dependencies
Following this checklist to help us incorporate your
contribution quickly and easily:
- [x] Make sure there is a [JIRA
issue](https://issues.apache.o
[
https://issues.apache.org/jira/browse/MPOM-244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17244751#comment-17244751
]
Michael Osipov commented on MPOM-244:
-
This has to be configured in the release plugin
Sandra Parsick created MJLINK-61:
Summary: Provide .editorconfig based on checkstyle configuration
Key: MJLINK-61
URL: https://issues.apache.org/jira/browse/MJLINK-61
Project: Maven JLink Plugin
[
https://issues.apache.org/jira/browse/MNG-6268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17244754#comment-17244754
]
Andreas Sewe commented on MNG-6268:
---
Closing as Won't Fix is fair enough.
That being sai
mabrarov opened a new pull request #28:
URL: https://github.com/apache/maven-ear-plugin/pull/28
[MEAR-182] - Don't add MANFIEST.mf Class-Path entry for EAR modules if
skipClassPathModification is configured, generated Class-Path is empty and
original MANFIEST.mf doesn't contain Class-Path
[
https://issues.apache.org/jira/browse/MEAR-182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17244796#comment-17244796
]
Marat Abrarov commented on MEAR-182:
It looks like there is a bug in implementation of
[
https://issues.apache.org/jira/browse/MEAR-289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17244742#comment-17244742
]
Marat Abrarov edited comment on MEAR-289 at 12/6/20, 5:28 PM:
--
mabrarov commented on pull request #24:
URL: https://github.com/apache/maven-ear-plugin/pull/24#issuecomment-739535717
I fixed [that
issue](https://github.com/apache/maven-ear-plugin/pull/24#issuecomment-739500692)
with not empty diff by merge master branch into the source branch of this p
michael-o commented on a change in pull request #412:
URL: https://github.com/apache/maven/pull/412#discussion_r537086472
##
File path: .github/workflows/maven.yml
##
@@ -137,4 +137,4 @@ jobs:
- name: Running integration tests
shell: bash
-run: mvn ins
mabrarov edited a comment on pull request #24:
URL: https://github.com/apache/maven-ear-plugin/pull/24#issuecomment-739535717
I fixed [that
issue](https://github.com/apache/maven-ear-plugin/pull/24#issuecomment-739500692)
with not empty diff by merging the master branch into the source bra
mabrarov edited a comment on pull request #24:
URL: https://github.com/apache/maven-ear-plugin/pull/24#issuecomment-739535717
I fixed [that
issue](https://github.com/apache/maven-ear-plugin/pull/24#issuecomment-739500692)
with not empty diff by merging the master branch into the source bra
mabrarov commented on pull request #22:
URL: https://github.com/apache/maven-ear-plugin/pull/22#issuecomment-739536070
This PR was successfully built by Jenkins. Is it possible to get this PR
merged?
This is an automated mes
hboutemy commented on pull request #24:
URL: https://github.com/apache/maven-ear-plugin/pull/24#issuecomment-739538449
Hi Marat,
yes, I merged this PR but amended the last commit message because it was
written against MEAR-216 instead of MEAR-153: I was waiting for Apache Jenkins
job to
hboutemy edited a comment on pull request #24:
URL: https://github.com/apache/maven-ear-plugin/pull/24#issuecomment-739538449
Hi Marat,
yes, I merged this PR but amended the last commit message in
30395beebffb0232d8ad7ffb03af57d919c1e89e because it was written against
MEAR-216 instead o
mabrarov commented on pull request #24:
URL: https://github.com/apache/maven-ear-plugin/pull/24#issuecomment-739538879
Hi @hboutemy,
> Did I miss something?
No you didn't. It looks like you merged all changed I proposed in this PR.
I'm just confused what to do with this PR.
hboutemy closed pull request #24:
URL: https://github.com/apache/maven-ear-plugin/pull/24
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
hboutemy commented on pull request #24:
URL: https://github.com/apache/maven-ear-plugin/pull/24#issuecomment-739540158
It has been merged, even if GitHub can't really get it because of the last
commit I amended...
let's close
and more importantly enjoy and say a big thank you for this
mabrarov commented on pull request #28:
URL: https://github.com/apache/maven-ear-plugin/pull/28#issuecomment-739541265
@hboutemy, it would be nice to include this PR and PR #22 into 3.2.0 release
of Maven EAR Plugin.
This is
mabrarov edited a comment on pull request #28:
URL: https://github.com/apache/maven-ear-plugin/pull/28#issuecomment-739541265
@hboutemy, it would be nice to include this PR and PR #22 into 3.2.0 release
of Maven EAR Plugin. My Skype account is marat.abrarov, feel free to IM if
immediate ac
sparsick commented on pull request #22:
URL: https://github.com/apache/maven-jlink-plugin/pull/22#issuecomment-739563155
Maybe we should upgrade the other dependencies to require Java 8
This is an automated message from the A
sparsick edited a comment on pull request #22:
URL: https://github.com/apache/maven-jlink-plugin/pull/22#issuecomment-739563155
Maybe we should upgrade the other dependencies that requires Java 8
This is an automated message
bmarwell commented on a change in pull request #22:
URL: https://github.com/apache/maven-jlink-plugin/pull/22#discussion_r537134930
##
File path: pom.xml
##
@@ -112,7 +112,7 @@
commons-io
commons-io
- 2.8.0
Review comment:
Please give a short re
bmarwell commented on a change in pull request #21:
URL: https://github.com/apache/maven-jlink-plugin/pull/21#discussion_r537135356
##
File path: src/it/projects/MJLINK-52_classifiers/invoker.properties
##
@@ -0,0 +1,18 @@
+# Licensed to the Apache Software Foundation (ASF) und
bmarwell commented on pull request #14:
URL: https://github.com/apache/maven-jlink-plugin/pull/14#issuecomment-739574405
> What happens if someone builds the project with JDK 8 or 11? We can't
require JDK 14+ for building.
Then the integration test is not being executed. You need at
bmarwell edited a comment on pull request #14:
URL: https://github.com/apache/maven-jlink-plugin/pull/14#issuecomment-739574405
> What happens if someone builds the project with JDK 8 or 11? We can't
require JDK 14+ for building.
Then the integration test is not being executed. You n
bmarwell commented on a change in pull request #21:
URL: https://github.com/apache/maven-jlink-plugin/pull/21#discussion_r537139144
##
File path: src/main/java/org/apache/maven/plugins/jlink/JLinkMojo.java
##
@@ -428,11 +437,13 @@ private JLinkExecutor getExecutor()
re
elharo commented on a change in pull request #23:
URL: https://github.com/apache/maven-jlink-plugin/pull/23#discussion_r537147596
##
File path:
src/main/java/org/apache/maven/plugins/jlink/AbstractJLinkToolchainExecutor.java
##
@@ -35,11 +36,11 @@
abstract class AbstractJLi
elharo commented on a change in pull request #22:
URL: https://github.com/apache/maven-jlink-plugin/pull/22#discussion_r537147922
##
File path: pom.xml
##
@@ -112,7 +112,7 @@
commons-io
commons-io
- 2.8.0
Review comment:
check the dependency con
elharo commented on pull request #22:
URL: https://github.com/apache/maven-jlink-plugin/pull/22#issuecomment-739583228
Upgrading other dependencies would be a major breaking change that shoould
be discussed on the mailing list and follow some analysis of how many projects
and people we'd b
bmarwell commented on a change in pull request #23:
URL: https://github.com/apache/maven-jlink-plugin/pull/23#discussion_r537148500
##
File path:
src/main/java/org/apache/maven/plugins/jlink/AbstractJLinkToolchainExecutor.java
##
@@ -35,11 +36,11 @@
abstract class AbstractJ
bmarwell commented on pull request #22:
URL: https://github.com/apache/maven-jlink-plugin/pull/22#issuecomment-739583748
Assuming this plugin needs at least java 9 to work (either by toolchain or
by the executing Java), I do not see the purpose of this change. No one would
be affected.
-
elharo commented on a change in pull request #23:
URL: https://github.com/apache/maven-jlink-plugin/pull/23#discussion_r537148975
##
File path:
src/main/java/org/apache/maven/plugins/jlink/AbstractJLinkToolchainExecutor.java
##
@@ -35,11 +36,11 @@
abstract class AbstractJLi
elharo commented on pull request #22:
URL: https://github.com/apache/maven-jlink-plugin/pull/22#issuecomment-739584400
It's not just about this plugin. It's about its own dependencies like
maven-archiver that are expecting an older version of commons-io. They'll
probably work with the new
[
https://issues.apache.org/jira/browse/SUREFIRE-1863?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tibor Digana closed SUREFIRE-1863.
--
Fix Version/s: SUREFIRE-1815
Resolution: Duplicate
> Tests run in surefire can clear
[
https://issues.apache.org/jira/browse/SUREFIRE-1862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17244874#comment-17244874
]
Tibor Digana commented on SUREFIRE-1862:
This method parameter _firstForkExcep
medb opened a new pull request #75:
URL: https://github.com/apache/maven-wagon/pull/75
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
[
https://issues.apache.org/jira/browse/WAGON-575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17244923#comment-17244923
]
Igor Dvorzhak commented on WAGON-575:
-
I have sent a [PR|https://github.com/apache/mav
[
https://issues.apache.org/jira/browse/WAGON-575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17244923#comment-17244923
]
Igor Dvorzhak edited comment on WAGON-575 at 12/7/20, 3:21 AM:
-
[
https://issues.apache.org/jira/browse/WAGON-575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17244923#comment-17244923
]
Igor Dvorzhak edited comment on WAGON-575 at 12/7/20, 3:22 AM:
-
gianm commented on pull request #327:
URL: https://github.com/apache/maven-surefire/pull/327#issuecomment-739639633
@Tibor17 OK, I've made those changes.
This is an automated message from the Apache Git Service.
To respond to
gianm closed pull request #327:
URL: https://github.com/apache/maven-surefire/pull/327
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
gianm commented on pull request #327:
URL: https://github.com/apache/maven-surefire/pull/327#issuecomment-739715279
The "GitHub CI for *Nix / build (macOS-latest)" check is still failing, but
I'm not sure why.
This is an aut
mabrarov edited a comment on pull request #28:
URL: https://github.com/apache/maven-ear-plugin/pull/28#issuecomment-739541265
@hboutemy, it would be nice to include this PR and PR #22 into 3.2.0 release
of Maven EAR Plugin.
sparsick commented on a change in pull request #23:
URL: https://github.com/apache/maven-jlink-plugin/pull/23#discussion_r537283535
##
File path:
src/main/java/org/apache/maven/plugins/jlink/AbstractJLinkToolchainExecutor.java
##
@@ -35,11 +36,11 @@
abstract class AbstractJ
bmarwell commented on a change in pull request #19:
URL: https://github.com/apache/maven-jlink-plugin/pull/19#discussion_r537287176
##
File path: pom.xml
##
@@ -109,6 +109,11 @@
commons-lang3
3.6
+
Review comment:
Plugins are isolated. Dependency
74 matches
Mail list logo
