pzygielo commented on a change in pull request #399:
URL: https://github.com/apache/maven/pull/399#discussion_r530837309
##
File path:
maven-model-builder/src/test/java/org/apache/maven/model/building/DefaultModelBuilderTest.java
##
@@ -0,0 +1,151 @@
+package org.apache.maven.
sparsick opened a new pull request #19:
URL: https://github.com/apache/maven-jlink-plugin/pull/19
…java instead.
- replace org.codehaus.plexus.util.StringUtils by
org.apache.commons.lang3.StringUtils
- replace org.codehaus.plexus.util.FileUtils by
org.apache.commons.io.FileUtils
sparsick commented on pull request #19:
URL: https://github.com/apache/maven-jlink-plugin/pull/19#issuecomment-734204263
One question: Is there a possibility to prevent import package like
`org.codehaus.plexus.util.*` via a maven plugin?
---
sparsick commented on pull request #19:
URL: https://github.com/apache/maven-jlink-plugin/pull/19#issuecomment-734206534
I found this
[project](https://github.com/skuzzle/restrict-imports-enforcer-rule) that
create enforce rule for this use case. Would be it OK, when I would introduce
it
bmarwell opened a new pull request #20:
URL: https://github.com/apache/maven-jlink-plugin/pull/20
### DO NOT MERGE YET
The `toolchain.xml` file is not being used:
https://github.com/bmarwell/maven-jlink-plugin/runs/1458231353?check_suite_focus=true
Open up the "Build with Mave
bmarwell commented on pull request #19:
URL: https://github.com/apache/maven-jlink-plugin/pull/19#issuecomment-734213882
There’s also https://github.com/policeman-tools/forbidden-apis.
I am not a committer, but I would like to see import restrictions as well.
Maybe @elharo has an opinio
scela closed pull request #19:
URL: https://github.com/apache/maven-indexer/pull/19
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
Guillaume Nodet created MNG-7035:
Summary: Migrate unit tests to Unit 4
Key: MNG-7035
URL: https://issues.apache.org/jira/browse/MNG-7035
Project: Maven
Issue Type: Task
Reporter:
gnodet opened a new pull request #400:
URL: https://github.com/apache/maven/pull/400
Migration of all tests to Unit 4 without any refactoring beyond the bare
minimum (i.e. add @Test, @Before and @After) methods.
For plexus powered tests, I had to copy the migrated `PlexusTestCase` as
th
Volkan Yazici created MNG-7036:
--
Summary: Avoid non-compile goals (e.g., test) for --also-make
introduced modules
Key: MNG-7036
URL: https://issues.apache.org/jira/browse/MNG-7036
Project: Maven
[
https://issues.apache.org/jira/browse/MNG-7036?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Volkan Yazici updated MNG-7036:
---
Description:
It is a common practice to execute goals for a single module, e.g., {{mvn \-pl
son verify
[
https://issues.apache.org/jira/browse/MNG-7036?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17239194#comment-17239194
]
Volkan Yazici commented on MNG-7036:
See [the related StackOverflow
post|https://stack
slachiewicz commented on pull request #400:
URL: https://github.com/apache/maven/pull/400#issuecomment-734248903
please also look into #346 where I made a related changes
This is an automated message from the Apache Git Servi
michael-o commented on pull request #346:
URL: https://github.com/apache/maven/pull/346#issuecomment-734249917
Why wasn't this merged yet?
This is an automated message from the Apache Git Service.
To respond to the message, p
slachiewicz commented on a change in pull request #400:
URL: https://github.com/apache/maven/pull/400#discussion_r530970798
##
File path: maven-compat/src/test/java/org/apache/maven/PlexusTestCase.java
##
@@ -0,0 +1,294 @@
+package org.apache.maven;
+
+/*
+ * Licensed to the Ap
Sylwester Lachiewicz created MSHARED-963:
Summary: Require Maven 3.1.1 (drop dependency to Mave 3.0 Sonatype
Aether)
Key: MSHARED-963
URL: https://issues.apache.org/jira/browse/MSHARED-963
Pro
[
https://issues.apache.org/jira/browse/MSHARED-848?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sylwester Lachiewicz updated MSHARED-848:
-
Fix Version/s: (was: maven-shared-utils-3.3.3)
> Code Improvement in ReaderF
[
https://issues.apache.org/jira/browse/MSHARED-860?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sylwester Lachiewicz updated MSHARED-860:
-
Fix Version/s: maven-shared-utils-3.3.3
> Deprecate obsolete functionality
> ---
[
https://issues.apache.org/jira/browse/MSHARED-860?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sylwester Lachiewicz reassigned MSHARED-860:
Assignee: Elliotte Rusty Harold
> Deprecate obsolete functionality
>
[
https://issues.apache.org/jira/browse/MSHARED-860?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sylwester Lachiewicz closed MSHARED-860.
Resolution: Fixed
> Deprecate obsolete functionality
> ---
[
https://issues.apache.org/jira/browse/MNG-7028?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17239279#comment-17239279
]
Guillaume Nodet commented on MNG-7028:
--
If there's any problem with the jansi, let me
bmarwell opened a new pull request #21:
URL: https://github.com/apache/maven-jlink-plugin/pull/21
Following this checklist to help us incorporate your
contribution quickly and easily:
- [X] Make sure there is a [JIRA
issue](https://issues.apache.org/jira/browse/MJLINK) filed
bmarwell commented on a change in pull request #21:
URL: https://github.com/apache/maven-jlink-plugin/pull/21#discussion_r531052492
##
File path: src/main/java/org/apache/maven/plugins/jlink/JLinkMojo.java
##
@@ -428,11 +437,13 @@ private JLinkExecutor getExecutor()
re
gnodet commented on a change in pull request #399:
URL: https://github.com/apache/maven/pull/399#discussion_r531053387
##
File path:
maven-model-builder/src/test/java/org/apache/maven/model/building/DefaultModelBuilderTest.java
##
@@ -0,0 +1,151 @@
+package org.apache.maven.mo
gnodet commented on a change in pull request #399:
URL: https://github.com/apache/maven/pull/399#discussion_r531053718
##
File path:
maven-model-builder/src/test/java/org/apache/maven/model/building/CyclicParentTest.java
##
@@ -0,0 +1,143 @@
+package org.apache.maven.model.bui
rvesse commented on pull request #3:
URL: https://github.com/apache/maven-deploy-plugin/pull/3#issuecomment-734331457
Another practical use case, due to the constraints of our CI/CD system some
of our projects use Apache Maven as the overarching build tool but use plugins
to invoke other t
gnodet commented on a change in pull request #400:
URL: https://github.com/apache/maven/pull/400#discussion_r531099832
##
File path: maven-compat/src/test/java/org/apache/maven/PlexusTestCase.java
##
@@ -0,0 +1,294 @@
+package org.apache.maven;
+
+/*
+ * Licensed to the Apache
gnodet commented on pull request #400:
URL: https://github.com/apache/maven/pull/400#issuecomment-734361374
> please also look into #346 where I made a related changes
This is mostly related to JSR330 afaik.
I think the blocking issue for migrating to JSR330 is
[MNG-6898](https://
elharo commented on pull request #19:
URL: https://github.com/apache/maven-jlink-plugin/pull/19#issuecomment-734364680
In general import restrictions sound good. Probably bring it up on the dev
mailing list to see if we want a policy for all of maven.
Bertrand Martin created DOXIA-616:
-
Summary: Markdown: Properly expose the language specified in
fenced code blocks
Key: DOXIA-616
URL: https://issues.apache.org/jira/browse/DOXIA-616
Project: Maven D
[
https://issues.apache.org/jira/browse/DOXIA-616?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bertrand Martin updated DOXIA-616:
--
Description:
h1. Use Case
Writers can specify the language used in a fenced code block (typicall
[
https://issues.apache.org/jira/browse/MNG-7024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17239387#comment-17239387
]
Martin Kanters commented on MNG-7024:
-
I think I agree with that. If someone wants to t
[
https://issues.apache.org/jira/browse/MNG-6268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17239394#comment-17239394
]
Martin Kanters commented on MNG-6268:
-
[~michael-o] I agree with all or nothing, but it
[
https://issues.apache.org/jira/browse/MNG-6268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17239394#comment-17239394
]
Martin Kanters edited comment on MNG-6268 at 11/26/20, 7:09 PM:
-
[
https://issues.apache.org/jira/browse/MNG-6268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17239397#comment-17239397
]
Piotr Zygielo commented on MNG-6268:
[~martinkanters] - MNG-4660 - most probably! Thank
[
https://issues.apache.org/jira/browse/DOXIA-542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17239398#comment-17239398
]
Bertrand Martin commented on DOXIA-542:
---
This is still true with the new FlexMark ma
[
https://issues.apache.org/jira/browse/MNG-7033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17239400#comment-17239400
]
Martin Kanters commented on MNG-7033:
-
Hi [~agentgt], thanks for your thorough explanat
[
https://issues.apache.org/jira/browse/MNG-6268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17239402#comment-17239402
]
Martin Kanters commented on MNG-6268:
-
[~pzygielo] no problem! I'm glad that we cleared
[
https://issues.apache.org/jira/browse/MPLUGIN-340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17239436#comment-17239436
]
Sylwester Lachiewicz commented on MPLUGIN-340:
--
With the upgrade to Ant 1.8
slachiewicz opened a new pull request #401:
URL: https://github.com/apache/maven/pull/401
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
[
https://issues.apache.org/jira/browse/MNG-3485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17239447#comment-17239447
]
Hudson commented on MNG-3485:
-
Build succeeded in Jenkins: Maven » Maven TLP » maven » MNG-7028
[
https://issues.apache.org/jira/browse/MNG-7028?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17239446#comment-17239446
]
Hudson commented on MNG-7028:
-
Build succeeded in Jenkins: Maven » Maven TLP » maven » MNG-7028
[
https://issues.apache.org/jira/browse/MNG-7019?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17239445#comment-17239445
]
Hudson commented on MNG-7019:
-
Build succeeded in Jenkins: Maven » Maven TLP » maven » MNG-7028
sparsick commented on pull request #20:
URL: https://github.com/apache/maven-jlink-plugin/pull/20#issuecomment-734679429
@bmarwell I had a look on the output of the Github Action. I think the
toolchain is used because of this debug line:
```shell
DEBUG] Reading user toolchains fro
[
https://issues.apache.org/jira/browse/SUREFIRE-1840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17239558#comment-17239558
]
Matthew Wang commented on SUREFIRE-1840:
I would expect that this is because t
[
https://issues.apache.org/jira/browse/SUREFIRE-1840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17239558#comment-17239558
]
Matthew Wang edited comment on SUREFIRE-1840 at 11/27/20, 7:51 AM:
-
[
https://issues.apache.org/jira/browse/SUREFIRE-1840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17239558#comment-17239558
]
Matthew Wang edited comment on SUREFIRE-1840 at 11/27/20, 7:52 AM:
-
47 matches
Mail list logo
