[GitHub] [maven] mthmulders commented on a change in pull request #386: [MNG-6999] Chained (consumer) XMLFilters can result in "floating" comments

2020-10-22 Thread GitBox
mthmulders commented on a change in pull request #386: URL: https://github.com/apache/maven/pull/386#discussion_r509948995 ## File path: maven-core/src/test/java/org/apache/maven/internal/aether/ConsumerModelSourceTransformerTest.java ## @@ -0,0 +1,69 @@ +package org.apache.ma

[GitHub] [maven] eolivelli commented on a change in pull request #386: [MNG-6999] Chained (consumer) XMLFilters can result in "floating" comments

2020-10-22 Thread GitBox
eolivelli commented on a change in pull request #386: URL: https://github.com/apache/maven/pull/386#discussion_r509952862 ## File path: maven-core/src/test/java/org/apache/maven/internal/aether/ConsumerModelSourceTransformerTest.java ## @@ -0,0 +1,69 @@ +package org.apache.mav

[GitHub] [maven] mthmulders commented on a change in pull request #386: [MNG-6999] Chained (consumer) XMLFilters can result in "floating" comments

2020-10-22 Thread GitBox
mthmulders commented on a change in pull request #386: URL: https://github.com/apache/maven/pull/386#discussion_r509957484 ## File path: maven-xml/src/test/java/org/apache/maven/xml/sax/filter/ConsumerPomXMLFilterTest.java ## @@ -231,5 +234,22 @@ public void licenseHeader() th

[GitHub] [maven] mthmulders commented on a change in pull request #386: [MNG-6999] Chained (consumer) XMLFilters can result in "floating" comments

2020-10-22 Thread GitBox
mthmulders commented on a change in pull request #386: URL: https://github.com/apache/maven/pull/386#discussion_r509958205 ## File path: maven-xml/src/test/java/org/apache/maven/xml/sax/filter/ConsumerPomXMLFilterTest.java ## @@ -231,5 +234,22 @@ public void licenseHeader() th

[jira] [Created] (MNG-7003) Inconsistent dependency tree

2020-10-22 Thread Arkadiusz Firus (Jira)
Arkadiusz Firus created MNG-7003: Summary: Inconsistent dependency tree Key: MNG-7003 URL: https://issues.apache.org/jira/browse/MNG-7003 Project: Maven Issue Type: Bug Components:

[jira] [Updated] (MPMD-307) NPE when using custom rule

2020-10-22 Thread Andreas Dangel (Jira)
[ https://issues.apache.org/jira/browse/MPMD-307?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andreas Dangel updated MPMD-307: Issue Type: Bug (was: Task) > NPE when using custom rule > -- > >

[jira] [Created] (MPMD-307) NPE when using custom rule

2020-10-22 Thread Andreas Dangel (Jira)
Andreas Dangel created MPMD-307: --- Summary: NPE when using custom rule Key: MPMD-307 URL: https://issues.apache.org/jira/browse/MPMD-307 Project: Maven PMD Plugin Issue Type: Task Comp

[jira] [Updated] (MPMD-307) NPE when using custom rule

2020-10-22 Thread Andreas Dangel (Jira)
[ https://issues.apache.org/jira/browse/MPMD-307?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andreas Dangel updated MPMD-307: Description: While testing the latest m-pmd-p 3.14.0-SNAPSHOT, the following NPE can appear, if a cu

[jira] [Commented] (MPMD-307) NPE when using custom rule

2020-10-22 Thread Andreas Dangel (Jira)
[ https://issues.apache.org/jira/browse/MPMD-307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17218884#comment-17218884 ] Andreas Dangel commented on MPMD-307: - That's probably a regression due to the restruct

[jira] [Resolved] (MPMD-307) NPE when using custom rule

2020-10-22 Thread Andreas Dangel (Jira)
[ https://issues.apache.org/jira/browse/MPMD-307?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andreas Dangel resolved MPMD-307. - Resolution: Fixed > NPE when using custom rule > -- > > Key

[jira] [Commented] (MPMD-307) NPE when using custom rule

2020-10-22 Thread Andreas Dangel (Jira)
[ https://issues.apache.org/jira/browse/MPMD-307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17218899#comment-17218899 ] Andreas Dangel commented on MPMD-307: - Fixed with https://gitbox.apache.org/repos/asf?

[jira] [Commented] (MPMD-307) NPE when using custom rule

2020-10-22 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/MPMD-307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17218905#comment-17218905 ] Hudson commented on MPMD-307: - Build succeeded in Jenkins: Maven » Maven TLP » maven-pmd-plugin

[jira] [Commented] (MNG-6727) Using version range in parent and CI Friendly Version fails

2020-10-22 Thread Ralf (Jira)
[ https://issues.apache.org/jira/browse/MNG-6727?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17218911#comment-17218911 ] Ralf commented on MNG-6727: --- Yes. "Unfortunately I have to confirm that as well." Too much time s

[jira] [Comment Edited] (MNG-6727) Using version range in parent and CI Friendly Version fails

2020-10-22 Thread Ralf (Jira)
[ https://issues.apache.org/jira/browse/MNG-6727?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17218911#comment-17218911 ] Ralf edited comment on MNG-6727 at 10/22/20, 10:14 AM: --- Yes. "Unfortu

[jira] [Closed] (MPMD-307) NPE when using custom rule

2020-10-22 Thread Andreas Dangel (Jira)
[ https://issues.apache.org/jira/browse/MPMD-307?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andreas Dangel closed MPMD-307. --- > NPE when using custom rule > -- > > Key: MPMD-307 >

[jira] [Commented] (SUREFIRE-1837) NullPointerException at AbstractSurefireMojo$ClasspathCache.setCachedClasspath

2020-10-22 Thread Falko Modler (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-1837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17218972#comment-17218972 ] Falko Modler commented on SUREFIRE-1837: +1 https://github.com/mvndaemon/mvnd/

[GitHub] [maven-ear-plugin] mabrarov commented on pull request #22: [MEAR-216] Handling test JARs as regular JARs

2020-10-22 Thread GitBox
mabrarov commented on pull request #22: URL: https://github.com/apache/maven-ear-plugin/pull/22#issuecomment-714485368 Need to check one more case I found recently. The case (I'll add a test for it) may demonstrate that this pull request is wrong and needs further work. Please, don't merge

[jira] [Commented] (SUREFIRE-1837) NullPointerException at AbstractSurefireMojo$ClasspathCache.setCachedClasspath

2020-10-22 Thread Tibor Digana (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-1837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17219056#comment-17219056 ] Tibor Digana commented on SUREFIRE-1837: [~Enigo] [~famod] Pls follow my comme

[GitHub] [maven-ear-plugin] mabrarov commented on a change in pull request #24: [MEAR-153] skinnyModules option

2020-10-22 Thread GitBox
mabrarov commented on a change in pull request #24: URL: https://github.com/apache/maven-ear-plugin/pull/24#discussion_r510208486 ## File path: src/test/resources/projects/project-094/ear/pom.xml ## @@ -0,0 +1,100 @@ + + + +http://maven.apache.org/POM/4.0.0"; xmlns:xsi="http:/

[GitHub] [maven] rfscholte commented on a change in pull request #386: [MNG-6999] Chained (consumer) XMLFilters can result in "floating" comments

2020-10-22 Thread GitBox
rfscholte commented on a change in pull request #386: URL: https://github.com/apache/maven/pull/386#discussion_r510301491 ## File path: maven-xml/src/test/java/org/apache/maven/xml/sax/filter/ConsumerPomXMLFilterTest.java ## @@ -231,5 +234,22 @@ public void licenseHeader() thr

[GitHub] [maven] rfscholte commented on a change in pull request #386: [MNG-6999] Chained (consumer) XMLFilters can result in "floating" comments

2020-10-22 Thread GitBox
rfscholte commented on a change in pull request #386: URL: https://github.com/apache/maven/pull/386#discussion_r510301491 ## File path: maven-xml/src/test/java/org/apache/maven/xml/sax/filter/ConsumerPomXMLFilterTest.java ## @@ -231,5 +234,22 @@ public void licenseHeader() thr

[GitHub] [maven] rfscholte commented on a change in pull request #386: [MNG-6999] Chained (consumer) XMLFilters can result in "floating" comments

2020-10-22 Thread GitBox
rfscholte commented on a change in pull request #386: URL: https://github.com/apache/maven/pull/386#discussion_r510306319 ## File path: maven-core/src/test/java/org/apache/maven/internal/aether/ConsumerModelSourceTransformerTest.java ## @@ -0,0 +1,69 @@ +package org.apache.mav

[GitHub] [maven] rfscholte commented on a change in pull request #386: [MNG-6999] Chained (consumer) XMLFilters can result in "floating" comments

2020-10-22 Thread GitBox
rfscholte commented on a change in pull request #386: URL: https://github.com/apache/maven/pull/386#discussion_r510306596 ## File path: maven-core/src/test/java/org/apache/maven/internal/aether/ConsumerModelSourceTransformerTest.java ## @@ -0,0 +1,69 @@ +package org.apache.mav

[jira] [Commented] (MNGSITE-388) Need to change "property" to "system property" in POM Reference

2020-10-22 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/MNGSITE-388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17219271#comment-17219271 ] Hudson commented on MNGSITE-388: Build succeeded in Jenkins: Maven » Maven TLP » maven-s

[jira] [Commented] (MNGSITE-393) Remove references to Maven 2.x

2020-10-22 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/MNGSITE-393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17219272#comment-17219272 ] Hudson commented on MNGSITE-393: Build succeeded in Jenkins: Maven » Maven TLP » maven-s

[jira] [Commented] (MNGSITE-419) The instructions for releasing a Maven project need to be updated for JDK 7 because of TLS1.2 for central

2020-10-22 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/MNGSITE-419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17219270#comment-17219270 ] Hudson commented on MNGSITE-419: Build succeeded in Jenkins: Maven » Maven TLP » maven-s

[jira] [Commented] (MNGSITE-430) Clarify remote repository resolution order

2020-10-22 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/MNGSITE-430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17219269#comment-17219269 ] Hudson commented on MNGSITE-430: Build succeeded in Jenkins: Maven » Maven TLP » maven-s

[jira] [Created] (MANTRUN-229) exec target output has newlines converted corrupting binary information

2020-10-22 Thread Gray (Jira)
Gray created MANTRUN-229: Summary: exec target output has newlines converted corrupting binary information Key: MANTRUN-229 URL: https://issues.apache.org/jira/browse/MANTRUN-229 Project: Maven Antrun Plugin

[jira] [Updated] (MANTRUN-229) exec target output has newlines converted corrupting binary information

2020-10-22 Thread Gray (Jira)
[ https://issues.apache.org/jira/browse/MANTRUN-229?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gray updated MANTRUN-229: - Description: I was trying to use the gzip task but it doesn't support level so I switched to using the exec tas

[jira] [Commented] (MNG-6976) --no-transfer-progress variant to diagnose download issue

2020-10-22 Thread Jesse Glick (Jira)
[ https://issues.apache.org/jira/browse/MNG-6976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17219317#comment-17219317 ] Jesse Glick commented on MNG-6976: -- A custom Logback configuration does not seem like a re

[jira] [Commented] (MNG-7001) Reconsider seemingly useless check of artifacts' source repository introduced in Maven 3.0

2020-10-22 Thread Petr Bodnar (Jira)
[ https://issues.apache.org/jira/browse/MNG-7001?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17219322#comment-17219322 ] Petr Bodnar commented on MNG-7001: -- {quote}What about mirrors? Do you want to treat them a

[GitHub] [maven-indexer] pzygielo commented on pull request #72: (doc) Use exception message in printed message

2020-10-22 Thread GitBox
pzygielo commented on pull request #72: URL: https://github.com/apache/maven-indexer/pull/72#issuecomment-714744842 May I ask for review, please? This is an automated message from the Apache Git Service. To respond to the mes

[GitHub] [maven-indexer] pzygielo commented on pull request #73: (doc) Fix spurious javadoc @param tags

2020-10-22 Thread GitBox
pzygielo commented on pull request #73: URL: https://github.com/apache/maven-indexer/pull/73#issuecomment-714744981 May I ask for review, please? This is an automated message from the Apache Git Service. To respond to the mes

[GitHub] [maven-indexer] michael-o merged pull request #73: (doc) Fix spurious javadoc @param tags

2020-10-22 Thread GitBox
michael-o merged pull request #73: URL: https://github.com/apache/maven-indexer/pull/73 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [maven-indexer] michael-o merged pull request #72: (doc) Use exception message in printed message

2020-10-22 Thread GitBox
michael-o merged pull request #72: URL: https://github.com/apache/maven-indexer/pull/72 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [maven-indexer] pzygielo commented on pull request #72: (doc) Use exception message in printed message

2020-10-22 Thread GitBox
pzygielo commented on pull request #72: URL: https://github.com/apache/maven-indexer/pull/72#issuecomment-714754366 @michael-o - thanks for checking. This is an automated message from the Apache Git Service. To respond to the

[GitHub] [maven-indexer] pzygielo commented on pull request #73: (doc) Fix spurious javadoc @param tags

2020-10-22 Thread GitBox
pzygielo commented on pull request #73: URL: https://github.com/apache/maven-indexer/pull/73#issuecomment-714754159 @michael-o - thanks for checking. This is an automated message from the Apache Git Service. To respond to the

[jira] [Commented] (MNG-7001) Reconsider seemingly useless check of artifacts' source repository introduced in Maven 3.0

2020-10-22 Thread Petr Bodnar (Jira)
[ https://issues.apache.org/jira/browse/MNG-7001?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17219344#comment-17219344 ] Petr Bodnar commented on MNG-7001: -- {quote}We must also bear in mind that we have very lit

[GitHub] [maven-ear-plugin] mabrarov commented on pull request #22: [MEAR-216] Handling test JARs as regular JARs

2020-10-22 Thread GitBox
mabrarov commented on pull request #22: URL: https://github.com/apache/maven-ear-plugin/pull/22#issuecomment-714766910 I fixed [that issue](https://github.com/apache/maven-ear-plugin/pull/22#issuecomment-714485368) and this pull request is ready for review now. @elharo and @hboutemy

[jira] [Comment Edited] (MNG-7001) Reconsider seemingly useless check of artifacts' source repository introduced in Maven 3.0

2020-10-22 Thread Petr Bodnar (Jira)
[ https://issues.apache.org/jira/browse/MNG-7001?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17219344#comment-17219344 ] Petr Bodnar edited comment on MNG-7001 at 10/22/20, 9:34 PM: - {

[jira] [Comment Edited] (MEAR-216) Unable to include dependencies of type test-jar

2020-10-22 Thread Marat Abrarov (Jira)
[ https://issues.apache.org/jira/browse/MEAR-216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17213237#comment-17213237 ] Marat Abrarov edited comment on MEAR-216 at 10/22/20, 9:56 PM: --

[jira] [Comment Edited] (MEAR-216) Unable to include dependencies of type test-jar

2020-10-22 Thread Marat Abrarov (Jira)
[ https://issues.apache.org/jira/browse/MEAR-216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17213237#comment-17213237 ] Marat Abrarov edited comment on MEAR-216 at 10/22/20, 9:56 PM: --