eolivelli commented on a change in pull request #16: Remove window line endings
from files
URL:
https://github.com/apache/maven-checkstyle-plugin/pull/16#discussion_r287584619
##
File path: src/it/MCHECKSTYLE-54/checkstyle.xml
##
@@ -0,0 +1,25 @@
+
+
+https://checkstyle.o
pzygielo commented on issue #234: (doc) add static modifier to signatures
URL: https://github.com/apache/maven-surefire/pull/234#issuecomment-495981187
> I am not sure if we should keep this docs at all.
As long as there is that feature (POJO Tests), I think it should be
documented.
sormuras commented on issue #234: (doc) add static modifier to signatures
URL: https://github.com/apache/maven-surefire/pull/234#issuecomment-495981445
> Why a developer should choose not to use junit or any other framework?
Zero (external) dependency is a valid (design) goal. Similar
Tibor17 commented on issue #234: (doc) add static modifier to signatures
URL: https://github.com/apache/maven-surefire/pull/234#issuecomment-495982561
@eolivelli
Back to your original question if this change is okay.
The change looks reasonable but we cannot prove it by any integratio
Karl Heinz Marbaise created MASSEMBLY-910:
-
Summary: Upgrade plexus-utils 3.2.0
Key: MASSEMBLY-910
URL: https://issues.apache.org/jira/browse/MASSEMBLY-910
Project: Maven Assembly Plugin
[
https://issues.apache.org/jira/browse/MASSEMBLY-910?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Karl Heinz Marbaise reassigned MASSEMBLY-910:
-
Assignee: Karl Heinz Marbaise
> Upgrade plexus-utils 3.2.0
>
pzygielo commented on issue #234: (doc) add static modifier to signatures
URL: https://github.com/apache/maven-surefire/pull/234#issuecomment-495985222
Answering to self
> shall be (surprisingly)
_Unsurprised_ here:
https://github.com/apache/maven-surefire/blob/33360045e005b38
Karl Heinz Marbaise created MASSEMBLY-911:
-
Summary: Upgrade maven-artifact-transfer 0.11.0
Key: MASSEMBLY-911
URL: https://issues.apache.org/jira/browse/MASSEMBLY-911
Project: Maven Assembly P
[
https://issues.apache.org/jira/browse/MNG-5001?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16848386#comment-16848386
]
Hervé Boutemy commented on MNG-5001:
+1 to move fail to 3.7.0
perhaps warn in 3.6.2, no
[
https://issues.apache.org/jira/browse/MASSEMBLY-911?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Karl Heinz Marbaise reassigned MASSEMBLY-911:
-
Assignee: Karl Heinz Marbaise
> Upgrade maven-artifact-transfer 0.11.
pzygielo commented on issue #234: (doc) add static modifier to signatures
URL: https://github.com/apache/maven-surefire/pull/234#issuecomment-495986043
*Me thinks* it was overlooked with implementation of
[SUREFIRE-498](https://issues.apache.org/jira/browse) in
a2f5a8e92cad041a83ed624d042a
Karl Heinz Marbaise created MASSEMBLY-912:
-
Summary: Upgrade maven-common-artifact-filters 3.1.0
Key: MASSEMBLY-912
URL: https://issues.apache.org/jira/browse/MASSEMBLY-912
Project: Maven Assem
[
https://issues.apache.org/jira/browse/MASSEMBLY-912?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Karl Heinz Marbaise reassigned MASSEMBLY-912:
-
Assignee: Karl Heinz Marbaise
> Upgrade maven-common-artifact-filters
[
https://issues.apache.org/jira/browse/MJAR-183?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16848389#comment-16848389
]
Michael Osipov commented on MJAR-183:
-
[~khmarbaise], I believe this change either caus
[
https://issues.apache.org/jira/browse/MNG-6556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16848390#comment-16848390
]
Michael Osipov commented on MNG-6556:
-
MPLUGIN issues have been indentified and fixed i
[
https://issues.apache.org/jira/browse/MJAR-183?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16848389#comment-16848389
]
Michael Osipov edited comment on MJAR-183 at 5/26/19 10:20 AM:
--
[
https://issues.apache.org/jira/browse/MJAR-183?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16848389#comment-16848389
]
Michael Osipov edited comment on MJAR-183 at 5/26/19 10:23 AM:
--
[
https://issues.apache.org/jira/browse/MASSEMBLY-910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16848391#comment-16848391
]
Karl Heinz Marbaise commented on MASSEMBLY-910:
---
Done in
[f0fa09a0e7609
[
https://issues.apache.org/jira/browse/MASSEMBLY-910?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Karl Heinz Marbaise closed MASSEMBLY-910.
-
Resolution: Done
> Upgrade plexus-utils 3.2.0
> --
>
>
[
https://issues.apache.org/jira/browse/MNG-6556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16848400#comment-16848400
]
Hudson commented on MNG-6556:
-
Build unstable in Jenkins: Maven TLP » maven » MNG-6169/MNG-6556
[
https://issues.apache.org/jira/browse/MASSEMBLY-910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16848407#comment-16848407
]
Hudson commented on MASSEMBLY-910:
--
Build succeeded in Jenkins: Maven TLP » maven-ass
[
https://issues.apache.org/jira/browse/MASSEMBLY-913?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Karl Heinz Marbaise reassigned MASSEMBLY-913:
-
Assignee: Karl Heinz Marbaise
> Upgrade commons-compress/commons-io f
Karl Heinz Marbaise created MASSEMBLY-913:
-
Summary: Upgrade commons-compress/commons-io for Maven Invoker
Plugin
Key: MASSEMBLY-913
URL: https://issues.apache.org/jira/browse/MASSEMBLY-913
Pr
Karl Heinz Marbaise created MASSEMBLY-914:
-
Summary: Add GitHub Informations
Key: MASSEMBLY-914
URL: https://issues.apache.org/jira/browse/MASSEMBLY-914
Project: Maven Assembly Plugin
[
https://issues.apache.org/jira/browse/MASSEMBLY-914?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Karl Heinz Marbaise reassigned MASSEMBLY-914:
-
Assignee: Karl Heinz Marbaise
> Add GitHub Informations
> ---
[
https://issues.apache.org/jira/browse/MASSEMBLY-914?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Karl Heinz Marbaise updated MASSEMBLY-914:
--
Description:
Adding:
* CONTRIBUTING.md
* README.md
* Issue Template for Git
[
https://issues.apache.org/jira/browse/MASSEMBLY-911?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Karl Heinz Marbaise updated MASSEMBLY-911:
--
Description:
[Release
0.11.0|https://issues.apache.org/jira/secure/ReleaseN
[
https://issues.apache.org/jira/browse/MASSEMBLY-911?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Karl Heinz Marbaise updated MASSEMBLY-911:
--
Description:
[Release
0.11.0|https://issues.apache.org/jira/secure/ReleaseN
[
https://issues.apache.org/jira/browse/MASSEMBLY-911?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Karl Heinz Marbaise updated MASSEMBLY-911:
--
Description:
[Release
0.11.0|[https://issues.apache.org/jira/secure/Release
[
https://issues.apache.org/jira/browse/MASSEMBLY-911?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Karl Heinz Marbaise updated MASSEMBLY-911:
--
Description:
[Release
0.11.0|https://issues.apache.org/jira/secure/ReleaseN
[
https://issues.apache.org/jira/browse/MASSEMBLY-913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16848412#comment-16848412
]
Karl Heinz Marbaise commented on MASSEMBLY-913:
---
Done in
[088dff66dff1e
[
https://issues.apache.org/jira/browse/MASSEMBLY-913?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Karl Heinz Marbaise updated MASSEMBLY-913:
--
Description: This causes a [security issue
hint|https://nvd.nist.gov/vuln/de
[
https://issues.apache.org/jira/browse/MASSEMBLY-913?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Karl Heinz Marbaise closed MASSEMBLY-913.
-
Resolution: Done
> Upgrade commons-compress/commons-io for Maven Invoker Plugi
[
https://issues.apache.org/jira/browse/MASSEMBLY-911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16848416#comment-16848416
]
Karl Heinz Marbaise commented on MASSEMBLY-911:
---
Done in
[943f668d4326a
[
https://issues.apache.org/jira/browse/MASSEMBLY-911?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Karl Heinz Marbaise closed MASSEMBLY-911.
-
Resolution: Done
> Upgrade maven-artifact-transfer 0.11.0
> --
[
https://issues.apache.org/jira/browse/MASSEMBLY-912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16848425#comment-16848425
]
Karl Heinz Marbaise commented on MASSEMBLY-912:
---
Done in
[35f5a000e9232
[
https://issues.apache.org/jira/browse/MASSEMBLY-912?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Karl Heinz Marbaise closed MASSEMBLY-912.
-
Resolution: Done
> Upgrade maven-common-artifact-filters 3.1.0
> -
[
https://issues.apache.org/jira/browse/MCHECKSTYLE-376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16848429#comment-16848429
]
Roman Ivanov commented on MCHECKSTYLE-376:
--
release 8.21 is ready - https:/
[
https://issues.apache.org/jira/browse/MASSEMBLY-913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16848431#comment-16848431
]
Hudson commented on MASSEMBLY-913:
--
Build succeeded in Jenkins: Maven TLP » maven-ass
pzygielo commented on issue #234: (doc) add static modifier to signatures
URL: https://github.com/apache/maven-surefire/pull/234#issuecomment-495999773
> Why this files was modified?
More commits waiting for push. No worries, it will be restored.
-
pzygielo commented on issue #234: (doc) add static modifier to signatures
URL: https://github.com/apache/maven-surefire/pull/234#issuecomment-495999840
> The tearDown method can be called the way that you print some message via
System.out.println and IT is able to check appearence of the me
[
https://issues.apache.org/jira/browse/MASSEMBLY-911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16848435#comment-16848435
]
Hudson commented on MASSEMBLY-911:
--
Build succeeded in Jenkins: Maven TLP » maven-ass
[
https://issues.apache.org/jira/browse/MASSEMBLY-912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16848437#comment-16848437
]
Hudson commented on MASSEMBLY-912:
--
Build succeeded in Jenkins: Maven TLP » maven-ass
[
https://issues.apache.org/jira/browse/MASSEMBLY-914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16848441#comment-16848441
]
Karl Heinz Marbaise commented on MASSEMBLY-914:
---
Done in
[1a36f70abb6e9
[
https://issues.apache.org/jira/browse/MASSEMBLY-914?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Karl Heinz Marbaise closed MASSEMBLY-914.
-
Resolution: Done
> Add GitHub Informations
> ---
>
>
pzygielo commented on issue #234: (doc) add static modifier to signatures
URL: https://github.com/apache/maven-surefire/pull/234#issuecomment-496006328
@Tibor17
> Extending PojoTest with these two methods setUp/tearDown would be great in
this PR too.
PojoTest updated. Please revi
Tibor17 commented on a change in pull request #234: (doc) add static modifier
to signatures
URL: https://github.com/apache/maven-surefire/pull/234#discussion_r287601477
##
File path:
surefire-its/src/test/resources/pojo-simple/src/test/java/PojoTest.java
##
@@ -21,6 +21,1
[
https://issues.apache.org/jira/browse/MASSEMBLY-914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16848455#comment-16848455
]
Hudson commented on MASSEMBLY-914:
--
Build succeeded in Jenkins: Maven TLP » maven-ass
pzygielo commented on a change in pull request #234: (doc) add static modifier
to signatures
URL: https://github.com/apache/maven-surefire/pull/234#discussion_r287601797
##
File path:
surefire-its/src/test/resources/pojo-simple/src/test/java/PojoTest.java
##
@@ -21,6 +21,
Tibor17 commented on issue #234: (doc) add static modifier to signatures
URL: https://github.com/apache/maven-surefire/pull/234#issuecomment-496008435
We have to drop this requirement because the documentation is right.
The implementation is right as well.
Here we do not talk about sem
pzygielo commented on issue #234: (doc) add static modifier to signatures
URL: https://github.com/apache/maven-surefire/pull/234#issuecomment-496008928
> The implementation is right as well.
Then isn't as proved by 355ed4cb63de46fe98aa749ab69832df5586137b and code
linked in
https://
pzygielo edited a comment on issue #234: (doc) add static modifier to signatures
URL: https://github.com/apache/maven-surefire/pull/234#issuecomment-496008928
> The implementation is right as well.
Then it isn't as proved by 355ed4cb63de46fe98aa749ab69832df5586137b and code
linked in
pzygielo edited a comment on issue #234: (doc) add static modifier to signatures
URL: https://github.com/apache/maven-surefire/pull/234#issuecomment-496008928
> The implementation is right as well.
Then it isn't as proved by 355ed4cb63de46fe98aa749ab69832df5586137b and code
linked in
pzygielo commented on issue #234: (doc) add static modifier to signatures
URL: https://github.com/apache/maven-surefire/pull/234#issuecomment-496009327
> Here we do not talk about semantics of `@BeforeClass` what you know in
JUnit4 but the documentaion and implementation talks anout semanti
pzygielo edited a comment on issue #234: (doc) add static modifier to signatures
URL: https://github.com/apache/maven-surefire/pull/234#issuecomment-496009327
> Here we do not talk about semantics of `@BeforeClass` what you know in
JUnit4 but the documentaion and implementation talks anout
[
https://issues.apache.org/jira/browse/MCHECKSTYLE-376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16848500#comment-16848500
]
Enrico Olivelli commented on MCHECKSTYLE-376:
-
Great! Can you create a J
Tibor17 edited a comment on issue #234: (doc) add static modifier to signatures
URL: https://github.com/apache/maven-surefire/pull/234#issuecomment-496024381
@pzygielo
You are wrong. The `@Before` must not be static. Every test method must be
isolated due to a new object of the test is
Tibor17 commented on issue #234: (doc) add static modifier to signatures
URL: https://github.com/apache/maven-surefire/pull/234#issuecomment-496024381
@pzygielo
You are wrong. The `@Before` must not be static. Every test method must be
isolated due to a new object of the test is created
Tibor17 edited a comment on issue #234: (doc) add static modifier to signatures
URL: https://github.com/apache/maven-surefire/pull/234#issuecomment-496024381
@pzygielo
You are wrong. The `@Before` must not be static. Every test method must be
isolated due to a new object of the test is
Tibor17 edited a comment on issue #234: (doc) add static modifier to signatures
URL: https://github.com/apache/maven-surefire/pull/234#issuecomment-496024381
@pzygielo
You are wrong. The `@Before` must not be static. Every test method must be
isolated due to a new object of the test is
Tibor17 edited a comment on issue #234: (doc) add static modifier to signatures
URL: https://github.com/apache/maven-surefire/pull/234#issuecomment-496024381
@pzygielo
You are wrong. The `@Before` must not be static. Every test method must be
isolated due to a new object creation every
pzygielo commented on issue #234: (doc) add static modifier to signatures
URL: https://github.com/apache/maven-surefire/pull/234#issuecomment-496027203
> @pzygielo
> You are wrong. The `@Before` must not be static.
We are discussing POJO tests here, and this
> Because it works
Tibor17 commented on issue #234: (doc) add static modifier to signatures
URL: https://github.com/apache/maven-surefire/pull/234#issuecomment-496028544
@pzygielo
I think I have explained everyting and properly and completely.
I have completed a fix and now multiple instances are create
rhowe opened a new pull request #21: Cleanup debug log handling
URL: https://github.com/apache/maven-compiler-plugin/pull/21
Make better use of `isDebugEnabled()`. See individual commits for details.
The diff looks better if you ignore whitespace changes.
- [x] I hereby declar
pzygielo commented on issue #234: (doc) add static modifier to signatures
URL: https://github.com/apache/maven-surefire/pull/234#issuecomment-496029126
> I have completed a fix and now multiple instances are created as it should
be.
I didn't get it. What did you fix?
Here is m
Karl Heinz Marbaise created MASSEMBLY-915:
-
Summary: Remove integration-test-archetype cause it's used
Key: MASSEMBLY-915
URL: https://issues.apache.org/jira/browse/MASSEMBLY-915
Project: Maven
[
https://issues.apache.org/jira/browse/MASSEMBLY-915?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Karl Heinz Marbaise updated MASSEMBLY-915:
--
Summary: Remove integration-test-archetype (was: Remove
integration-test-ar
Tibor17 commented on issue #234: (doc) add static modifier to signatures
URL: https://github.com/apache/maven-surefire/pull/234#issuecomment-496030290
@pzygielo
Regarding L240 and 244, iterates over all public methods and discovers
certain methods.
After they discovery mechanism has
Tibor17 edited a comment on issue #234: (doc) add static modifier to signatures
URL: https://github.com/apache/maven-surefire/pull/234#issuecomment-496030290
@pzygielo
Regarding L240 and 244, iterates over all public methods and discovers
certain methods.
After discovery mechanism ha
Tibor17 edited a comment on issue #234: (doc) add static modifier to signatures
URL: https://github.com/apache/maven-surefire/pull/234#issuecomment-496030290
@pzygielo
Regarding L240 and 244, iterates over all public methods and discovers
certain methods.
After discovery mechanism ha
pzygielo commented on issue #234: (doc) add static modifier to signatures
URL: https://github.com/apache/maven-surefire/pull/234#issuecomment-496031141
> If it is bug,
> then it is because the developers did not write complete integration test
in 2006.
I see it differently. Test
Tibor17 commented on issue #234: (doc) add static modifier to signatures
URL: https://github.com/apache/maven-surefire/pull/234#issuecomment-496031397
The semantics of code, e.g. `isValidTestMethod` is good! But the programmer
did not think deeply and did not realize that the check `!Modifi
[
https://issues.apache.org/jira/browse/MNG-6556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16848533#comment-16848533
]
Michael Osipov commented on MNG-6556:
-
MNG-3372 is failing with MINSTALL 3.0.0-M1 becau
pzygielo commented on issue #234: (doc) add static modifier to signatures
URL: https://github.com/apache/maven-surefire/pull/234#issuecomment-496032687
> The semantics of code, e.g. `isValidTestMethod` is good!
Then the name is wrong, as it accepts/consumes `public void ()` as wel
[
https://issues.apache.org/jira/browse/MCOMPILER-272?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Stefan Ocke updated MCOMPILER-272:
--
Affects Version/s: 3.6.0
3.6.1
3.6.2
Tibor17 commented on issue #234: (doc) add static modifier to signatures
URL: https://github.com/apache/maven-surefire/pull/234#issuecomment-496033139
@pzygielo
You would not believe that we are still fixing old providers. We have fixed
hunderds bugs. We had releases several years ago w
Tibor17 edited a comment on issue #234: (doc) add static modifier to signatures
URL: https://github.com/apache/maven-surefire/pull/234#issuecomment-496033139
@pzygielo
You would not believe that we are still fixing old providers. We have fixed
hunderds of bugs. We had releases several y
Tibor17 commented on issue #234: (doc) add static modifier to signatures
URL: https://github.com/apache/maven-surefire/pull/234#issuecomment-496033887
@pzygielo
I have checked SUREFIRE-498 (years 2008 - 2011) but the method
`isValidTestMethod` was in Surefire in 2006. So it is obvious t
pzygielo commented on issue #234: (doc) add static modifier to signatures
URL: https://github.com/apache/maven-surefire/pull/234#issuecomment-496034031
So I'll close this PR, as published documentation with `static`s added to
signatures would make [even] more confusion.
---
pzygielo closed pull request #234: (doc) add static modifier to signatures
URL: https://github.com/apache/maven-surefire/pull/234
This is an automated message from the Apache Git Service.
To respond to the message, please log
[
https://issues.apache.org/jira/browse/MNG-6556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16848544#comment-16848544
]
Michael Osipov commented on MNG-6556:
-
MNG-3441 is failing with MDEPLOY 3.0.0-M1 becaus
pzygielo commented on issue #234: (doc) add static modifier to signatures
URL: https://github.com/apache/maven-surefire/pull/234#issuecomment-496034145
> I have checked SUREFIRE-498 (years 2008 - 2011) but the method
isValidTestMethod was in Surefire in 2006.
Yeah, it was trap! :gri
Tibor Digana created SUREFIRE-1669:
--
Summary: POJO tests do not call fixture methods setUp and tearDown
and test instance are not new between tests
Key: SUREFIRE-1669
URL: https://issues.apache.org/jira/browse/SU
83 matches
Mail list logo
