Github user Tibor17 commented on a diff in the pull request:
https://github.com/apache/maven-surefire/pull/150#discussion_r155940679
--- Diff:
surefire-integration-tests/src/test/resources/junit47-rerun-failing-tests-with-cucumber/pom.xml
---
@@ -0,0 +1,79 @@
+
+
+
[
https://issues.apache.org/jira/browse/SUREFIRE-1372?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16285130#comment-16285130
]
ASF GitHub Bot commented on SUREFIRE-1372:
--
Github user Tibor17 commented on a
Github user Tibor17 commented on the issue:
https://github.com/apache/maven-surefire/pull/150
@mpkorstanje
How is `Description` constructed now by Cucumber?
Does it contain the real method name or it is a scenario text?
---
[
https://issues.apache.org/jira/browse/SUREFIRE-1372?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16285132#comment-16285132
]
ASF GitHub Bot commented on SUREFIRE-1372:
--
Github user Tibor17 commented on t
Github user Tibor17 commented on the issue:
https://github.com/apache/maven-surefire/pull/150
@mpkorstanje
Additionally, can you write a separate documentation file `cucumber.apt.vm`
for Cucumber with your best practices to setup and use cucumber in terms of
`maven-surefire-plugi
[
https://issues.apache.org/jira/browse/SUREFIRE-1372?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16285135#comment-16285135
]
ASF GitHub Bot commented on SUREFIRE-1372:
--
Github user Tibor17 commented on t
[
https://issues.apache.org/jira/browse/MNG-6308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16285144#comment-16285144
]
Hervé Boutemy commented on MNG-6308:
re-reading once more
http://maven.apache.org/ref/3
[
https://issues.apache.org/jira/browse/MNG-6308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16285144#comment-16285144
]
Hervé Boutemy edited comment on MNG-6308 at 12/10/17 8:52 AM:
--
Hervé Boutemy created DOXIASITETOOLS-181:
Summary: add docRenderingContext to template Velocity context
Key: DOXIASITETOOLS-181
URL: https://issues.apache.org/jira/browse/DOXIASITETOOLS-181
Pro
Github user britter commented on the issue:
https://github.com/apache/maven-surefire/pull/165
@Tibor17
> What about if I squash your commits to one? And then it would go to a new
branch based on master current HEAD?
> This branch has old history.
Let's do it like
Hervé Boutemy created MSKINS-139:
Summary: add edit button to link to scm source
Key: MSKINS-139
URL: https://issues.apache.org/jira/browse/MSKINS-139
Project: Maven Skins
Issue Type: Improve
[
https://issues.apache.org/jira/browse/MNG-6308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16285183#comment-16285183
]
Robert Scholte commented on MNG-6308:
-
javadoc and sources are attachments, but in the e
Github user Tibor17 commented on the issue:
https://github.com/apache/maven-surefire/pull/150
@mpkorstanje
I want to ask you few question because I want to make minimum invasive
changes in the code.
Why you have chosen provider `surefire-junit47` and not also the
`surefire-ju
[
https://issues.apache.org/jira/browse/SUREFIRE-1372?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16285193#comment-16285193
]
ASF GitHub Bot commented on SUREFIRE-1372:
--
Github user Tibor17 commented on t
Github user Tibor17 commented on the issue:
https://github.com/apache/maven-surefire/pull/166
@krmahadevan
Do you have a spare time for Surefire?
This is good work but there is only a little to do: checkstyle and Jira
ticket.
---
[
https://issues.apache.org/jira/browse/SUREFIRE-1444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16285236#comment-16285236
]
Tibor Digana commented on SUREFIRE-1444:
[~rfsnjb]
I have several questions, so
Github user mpkorstanje commented on the issue:
https://github.com/apache/maven-surefire/pull/150
> How is Description constructed now by Cucumber?
Executing cucumber while using JUnit creates a tree of Descriptions like so:
```
Cucumber
|- Feature 1
|
[
https://issues.apache.org/jira/browse/SUREFIRE-1372?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16285278#comment-16285278
]
ASF GitHub Bot commented on SUREFIRE-1372:
--
Github user mpkorstanje commented
[
https://issues.apache.org/jira/browse/ARCHETYPE-537?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dong Xu updated ARCHETYPE-537:
--
Description:
I think this will be an useful feature:
maven archetype user can choose to include files
Github user mpkorstanje commented on the issue:
https://github.com/apache/maven-surefire/pull/150
> Why you have chosen provider surefire-junit47 and not also the
surefire-junit4?
While it would be possible to change surefire-junit4 to filter by
description there is no need t
[
https://issues.apache.org/jira/browse/SUREFIRE-1372?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16285308#comment-16285308
]
ASF GitHub Bot commented on SUREFIRE-1372:
--
Github user mpkorstanje commented
Github user mpkorstanje commented on the issue:
https://github.com/apache/maven-surefire/pull/150
> Additionally, can you write a separate documentation file cucumber.apt.vm
for Cucumber with your best practices to setup and use cucumber in terms of
maven-surefire-plugin and maven-fai
[
https://issues.apache.org/jira/browse/SUREFIRE-1372?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16285309#comment-16285309
]
ASF GitHub Bot commented on SUREFIRE-1372:
--
Github user mpkorstanje commented
[
https://issues.apache.org/jira/browse/MNG-6308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16285311#comment-16285311
]
Hervé Boutemy commented on MNG-6308:
sure, one can avoid defining ${project.packaging} t
[
https://issues.apache.org/jira/browse/MNG-6308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16285311#comment-16285311
]
Hervé Boutemy edited comment on MNG-6308 at 12/10/17 4:42 PM:
--
GitHub user Tcharl opened a pull request:
https://github.com/apache/maven-wagon/pull/38
wagon-scm documentation update
https://issues.apache.org/jira/browse/WAGON-493
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Tcharl/maven-wa
[
https://issues.apache.org/jira/browse/MNG-6308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16285311#comment-16285311
]
Hervé Boutemy edited comment on MNG-6308 at 12/10/17 4:44 PM:
--
[
https://issues.apache.org/jira/browse/WAGON-493?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16285312#comment-16285312
]
ASF GitHub Bot commented on WAGON-493:
--
GitHub user Tcharl opened a pull request:
Github user mpkorstanje commented on the issue:
https://github.com/apache/maven-surefire/pull/150
@Tibor17 please let me know if you have more questions.
---
Github user mpkorstanje commented on the issue:
https://github.com/apache/maven-surefire/pull/150
I haven't answered yet is why cucumber creates descriptions with a unique
Id and doesn't just use the method names.
The reason for that is that scenarios in cucumber don't need t
[
https://issues.apache.org/jira/browse/SUREFIRE-1372?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16285314#comment-16285314
]
ASF GitHub Bot commented on SUREFIRE-1372:
--
Github user mpkorstanje commented
[
https://issues.apache.org/jira/browse/SUREFIRE-1372?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16285313#comment-16285313
]
ASF GitHub Bot commented on SUREFIRE-1372:
--
Github user mpkorstanje commented
Github user Tibor17 commented on the issue:
https://github.com/apache/maven-surefire/pull/150
@mpkorstanje
I do not have questions yet. I am just reading your comments. I would think
of the code combining together with Cucumber internals and then I would have
maybe some notice.
[
https://issues.apache.org/jira/browse/SUREFIRE-1372?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16285321#comment-16285321
]
ASF GitHub Bot commented on SUREFIRE-1372:
--
Github user Tibor17 commented on t
chonton opened a new pull request #1: fix DeployAtEnd failures
URL: https://github.com/apache/maven-deploy-plugin/pull/1
MDEPLOY-226: DeployAtEnd fails when module has extension
MDEPLOY-225: DeployAtEnd fails when overriding skip
MDEPLOY-224: Overriding deployAtEnd fails
-
chonton commented on issue #1: fix DeployAtEnd failures
URL: https://github.com/apache/maven-deploy-plugin/pull/1#issuecomment-350582953
Same PR as https://github.com/apache/maven-plugins/pull/138.
This is an automated message
[
https://issues.apache.org/jira/browse/MNG-6308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16285408#comment-16285408
]
Michael Osipov commented on MNG-6308:
-
The packaging in the HR line looks pretty displac
37 matches
Mail list logo
