Re: [PR] test mimir with Jenkinsfile [maven]

2025-04-05 Thread via GitHub
cstamas commented on PR #2208: URL: https://github.com/apache/maven/pull/2208#issuecomment-2780850209 > but it is user wide and Jenkins is sharing nodes. is there any difference? If shared, then yes, this place is good. GH does not share and always re-creates runners... -- This is

Re: [PR] test mimir with Jenkinsfile [maven]

2025-04-03 Thread via GitHub
olamy commented on PR #2208: URL: https://github.com/apache/maven/pull/2208#issuecomment-2774681611 > Also, do not copy it to `.mvn` (project wide) but `~/.m2/` (user wide). but it is user wide and Jenkins is sharing nodes. is there any difference? -- This is an automated me

Re: [PR] test mimir with Jenkinsfile [maven]

2025-03-31 Thread via GitHub
cstamas commented on PR #2208: URL: https://github.com/apache/maven/pull/2208#issuecomment-2766915239 And another Mimir change for CI https://github.com/apache/maven/pull/2212 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub an

Re: [PR] test mimir with Jenkinsfile [maven]

2025-03-31 Thread via GitHub
cstamas commented on PR #2208: URL: https://github.com/apache/maven/pull/2208#issuecomment-2766029415 Oh, just spotted: with Mimir, the maven.repo.local/tail thing is not needed anymore, that was done ONLY to make sure GH cached local repo is not "polluted" with CI installed things (that ne

Re: [PR] test mimir with Jenkinsfile [maven]

2025-03-31 Thread via GitHub
cstamas commented on code in PR #2208: URL: https://github.com/apache/maven/pull/2208#discussion_r2020917460 ## Jenkinsfile: ## @@ -67,6 +67,7 @@ def mavenBuild(jdk, extraArgs) { withEnv(["JAVA_HOME=${tool "$jdk"}", "PATH+MAVEN=${ tool "$jdk" }/bin:${tool

Re: [PR] test mimir with Jenkinsfile [maven]

2025-03-31 Thread via GitHub
cstamas commented on PR #2208: URL: https://github.com/apache/maven/pull/2208#issuecomment-2765995621 Or just merge master, the mentioned PR is merged. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

Re: [PR] test mimir with Jenkinsfile [maven]

2025-03-31 Thread via GitHub
cstamas commented on PR #2208: URL: https://github.com/apache/maven/pull/2208#issuecomment-2765980743 Also, do not copy it to `.mvn` (project wide) but `~/.m2/` (user wide). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [PR] test mimir with Jenkinsfile [maven]

2025-03-31 Thread via GitHub
cstamas commented on PR #2208: URL: https://github.com/apache/maven/pull/2208#issuecomment-2765978094 @olamy try to merge this one https://github.com/apache/maven/pull/2207 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u