Re: [PR] Upgrade to Maven 4.0.0-rc-3 [maven-plugin-testing]

2025-04-05 Thread via GitHub
gnodet closed pull request #81: Upgrade to Maven 4.0.0-rc-3 URL: https://github.com/apache/maven-plugin-testing/pull/81 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsub

Re: [PR] Upgrade to Maven 4.0.0-rc-3 [maven-plugin-testing]

2025-03-21 Thread via GitHub
gnodet closed pull request #81: Upgrade to Maven 4.0.0-rc-3 URL: https://github.com/apache/maven-plugin-testing/pull/81 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsub

Re: [PR] Upgrade to Maven 4.0.0-rc-3. [maven-plugin-testing]

2025-03-21 Thread via GitHub
gnodet merged PR #84: URL: https://github.com/apache/maven-plugin-testing/pull/84 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@mav

Re: [PR] Upgrade to Maven 4.0.0-rc-3. [maven-plugin-testing]

2025-03-16 Thread via GitHub
slachiewicz commented on PR #84: URL: https://github.com/apache/maven-plugin-testing/pull/84#issuecomment-2727606183 It would be good to modify gha to run tests also with Maven 4. So far all compilation and tests where under Maven 3. -- This is an automated message from the Apache Git Se

Re: [PR] Upgrade to Maven 4.0.0-rc-3. [maven-plugin-testing]

2025-03-16 Thread via GitHub
desruisseaux commented on PR #84: URL: https://github.com/apache/maven-plugin-testing/pull/84#issuecomment-2727382598 Added setter methods for usability. Also added an empty stub for `Session.getService(Lookup.class)`. With the latter addition, the `NullPointerException` observed in the JU

Re: [PR] Upgrade to Maven 4.0.0-rc-3. [maven-plugin-testing]

2025-03-16 Thread via GitHub
desruisseaux commented on PR #84: URL: https://github.com/apache/maven-plugin-testing/pull/84#issuecomment-2727347071 Just realized that this is a duplicated of #81, #83 and #67. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

Re: [PR] Upgrade to Maven 4.0.0-rc-3. [maven-plugin-testing]

2025-03-15 Thread via GitHub
desruisseaux commented on PR #84: URL: https://github.com/apache/maven-plugin-testing/pull/84#issuecomment-2726573391 I can remove the JUnit tests of `maven-compiler-plugin` that depend on the session stub. It would remove 3 of the 14 tests (not necessarily a big lost, since I find the IT

Re: [PR] Upgrade to Maven 4.0.0-rc-3. [maven-plugin-testing]

2025-03-15 Thread via GitHub
gnodet commented on PR #84: URL: https://github.com/apache/maven-plugin-testing/pull/84#issuecomment-2726494282 I don't think it's really a good idea to use the session stub anyway. There's too much needed and a simple stub will almost never work. We can check, but I don't think any plug

Re: [PR] Upgrade to Maven 4.0.0-rc-3. [maven-plugin-testing]

2025-03-15 Thread via GitHub
desruisseaux commented on PR #84: URL: https://github.com/apache/maven-plugin-testing/pull/84#issuecomment-2726458358 Note: with Maven 4.0.0-rc-3, the tests of the Maven compiler plugin fail with the following stack trace: ``` java.lang.NullPointerException: Cannot invoke "org.ap