Re: [PR] Improve enforcer rule error messages [maven-enforcer]

2025-02-21 Thread via GitHub
Bukama commented on code in PR #343: URL: https://github.com/apache/maven-enforcer/pull/343#discussion_r1965501985 ## enforcer-rules/src/main/java/org/apache/maven/enforcer/rules/files/AbstractRequireFiles.java: ## @@ -93,21 +93,36 @@ private void fail(List failures) throws Enf

Re: [PR] Improve enforcer rule error messages [maven-enforcer]

2025-02-21 Thread via GitHub
Bukama commented on code in PR #343: URL: https://github.com/apache/maven-enforcer/pull/343#discussion_r1965501985 ## enforcer-rules/src/main/java/org/apache/maven/enforcer/rules/files/AbstractRequireFiles.java: ## @@ -93,21 +93,36 @@ private void fail(List failures) throws Enf

Re: [PR] Improve enforcer rule error messages [maven-enforcer]

2025-02-21 Thread via GitHub
elharo commented on code in PR #343: URL: https://github.com/apache/maven-enforcer/pull/343#discussion_r1965438858 ## enforcer-rules/src/test/java/org/apache/maven/enforcer/rules/files/TestRequireFilesDontExist.java: ## @@ -121,11 +124,11 @@ void testFileDoesNotExistSatisfyAny()

Re: [PR] Improve enforcer rule error messages [maven-enforcer]

2025-02-21 Thread via GitHub
elharo commented on code in PR #343: URL: https://github.com/apache/maven-enforcer/pull/343#discussion_r1965438858 ## enforcer-rules/src/test/java/org/apache/maven/enforcer/rules/files/TestRequireFilesDontExist.java: ## @@ -121,11 +124,11 @@ void testFileDoesNotExistSatisfyAny()

Re: [PR] Improve enforcer rule error messages [maven-enforcer]

2025-02-21 Thread via GitHub
Bukama commented on code in PR #343: URL: https://github.com/apache/maven-enforcer/pull/343#discussion_r1965419596 ## enforcer-rules/src/test/java/org/apache/maven/enforcer/rules/files/TestRequireFilesDontExist.java: ## @@ -121,11 +124,11 @@ void testFileDoesNotExistSatisfyAny()

Re: [PR] Improve enforcer rule error messages [maven-enforcer]

2025-02-20 Thread via GitHub
elharo commented on PR #343: URL: https://github.com/apache/maven-enforcer/pull/343#issuecomment-2671495633 Ping -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscr

Re: [PR] Improve enforcer rule error messages [maven-enforcer]

2025-02-01 Thread via GitHub
elharo commented on code in PR #343: URL: https://github.com/apache/maven-enforcer/pull/343#discussion_r1938278197 ## enforcer-rules/src/test/java/org/apache/maven/enforcer/rules/files/TestRequireFilesSize.java: ## @@ -116,7 +122,7 @@ void testEmptyFileList() throws EnforcerRule

Re: [PR] Improve enforcer rule error messages [maven-enforcer]

2025-02-01 Thread via GitHub
slawekjaranowski commented on code in PR #343: URL: https://github.com/apache/maven-enforcer/pull/343#discussion_r1938264952 ## enforcer-rules/src/test/java/org/apache/maven/enforcer/rules/files/TestRequireFilesSize.java: ## @@ -116,7 +122,7 @@ void testEmptyFileList() throws En

Re: [PR] Improve enforcer rule error messages [maven-enforcer]

2025-01-29 Thread via GitHub
elharo commented on code in PR #343: URL: https://github.com/apache/maven-enforcer/pull/343#discussion_r1913587604 ## enforcer-rules/src/test/java/org/apache/maven/enforcer/rules/files/TestRequireFilesDontExist.java: ## @@ -27,10 +27,7 @@ import org.junit.jupiter.api.Test; imp

Re: [PR] Improve enforcer rule error messages [maven-enforcer]

2025-01-13 Thread via GitHub
slawekjaranowski commented on code in PR #343: URL: https://github.com/apache/maven-enforcer/pull/343#discussion_r1913555851 ## enforcer-rules/src/test/java/org/apache/maven/enforcer/rules/files/TestRequireFilesDontExist.java: ## @@ -27,10 +27,7 @@ import org.junit.jupiter.api.

Re: [PR] Improve enforcer rule error messages [maven-enforcer]

2025-01-13 Thread via GitHub
slawekjaranowski commented on code in PR #343: URL: https://github.com/apache/maven-enforcer/pull/343#discussion_r1913517308 ## enforcer-rules/src/test/java/org/apache/maven/enforcer/rules/files/TestRequireFilesDontExist.java: ## @@ -27,10 +27,7 @@ import org.junit.jupiter.api.

Re: [PR] Improve enforcer rule error messages [maven-enforcer]

2025-01-13 Thread via GitHub
slawekjaranowski commented on PR #343: URL: https://github.com/apache/maven-enforcer/pull/343#issuecomment-2587667226 @Bukama site is broken for all maven-plugins and Maven 4.x https://issues.apache.org/jira/browse/MPLUGIN-502 -- This is an automated message from the Apache Git Service.

Re: [PR] Improve enforcer rule error messages [maven-enforcer]

2025-01-13 Thread via GitHub
Bukama commented on code in PR #343: URL: https://github.com/apache/maven-enforcer/pull/343#discussion_r1913500812 ## enforcer-rules/src/test/java/org/apache/maven/enforcer/rules/files/TestRequireFilesDontExist.java: ## @@ -27,10 +27,7 @@ import org.junit.jupiter.api.Test; imp

Re: [PR] Improve enforcer rule error messages [maven-enforcer]

2025-01-13 Thread via GitHub
Bukama commented on code in PR #343: URL: https://github.com/apache/maven-enforcer/pull/343#discussion_r1913500812 ## enforcer-rules/src/test/java/org/apache/maven/enforcer/rules/files/TestRequireFilesDontExist.java: ## @@ -27,10 +27,7 @@ import org.junit.jupiter.api.Test; imp

Re: [PR] Improve enforcer rule error messages [maven-enforcer]

2025-01-13 Thread via GitHub
Bukama commented on PR #343: URL: https://github.com/apache/maven-enforcer/pull/343#issuecomment-2587648476 Build (`mvn clean verify site`) of this branch breaks (on Windows 10): Please have a look. ``` [INFO] Reactor Summary for Apache Maven Enforcer 3.6.0-SNAPSHOT: [INFO] [

Re: [PR] Improve enforcer rule error messages [maven-enforcer]

2025-01-13 Thread via GitHub
michael-o commented on code in PR #343: URL: https://github.com/apache/maven-enforcer/pull/343#discussion_r1913353739 ## enforcer-rules/src/main/java/org/apache/maven/enforcer/rules/files/AbstractRequireFiles.java: ## @@ -93,21 +93,36 @@ private void fail(List failures) throws

Re: [PR] Improve enforcer rule error messages [maven-enforcer]

2025-01-13 Thread via GitHub
slawekjaranowski commented on code in PR #343: URL: https://github.com/apache/maven-enforcer/pull/343#discussion_r1913342896 ## enforcer-rules/src/main/java/org/apache/maven/enforcer/rules/files/AbstractRequireFiles.java: ## @@ -93,21 +93,36 @@ private void fail(List failures) t