Re: [PR] [MRESOLVER-587] Memory usage improvements [maven-resolver]

2024-08-02 Thread via GitHub
cstamas merged PR #536: URL: https://github.com/apache/maven-resolver/pull/536 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.

Re: [PR] [MRESOLVER-587] Memory usage improvements [maven-resolver]

2024-08-02 Thread via GitHub
cstamas merged PR #537: URL: https://github.com/apache/maven-resolver/pull/537 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.

Re: [PR] [MRESOLVER-587] Memory usage improvements [maven-resolver]

2024-08-02 Thread via GitHub
gsmet commented on code in PR #536: URL: https://github.com/apache/maven-resolver/pull/536#discussion_r1701742710 ## maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/collect/DataPool.java: ## @@ -257,7 +257,7 @@ public static final class DescriptorKey {

Re: [PR] [MRESOLVER-587] Memory usage improvements [maven-resolver]

2024-08-02 Thread via GitHub
gsmet commented on PR #536: URL: https://github.com/apache/maven-resolver/pull/536#issuecomment-2265105027 > Am tinkering, that maybe feasible default would be false/true (do not intern deps, do intern managedDeps)? It looks like a good compromise from my side. -- This is an automa

Re: [PR] [MRESOLVER-587] Memory usage improvements [maven-resolver]

2024-08-02 Thread via GitHub
cstamas commented on PR #536: URL: https://github.com/apache/maven-resolver/pull/536#issuecomment-2265085629 @gsmet this PR now has it all merged changes, plus, introduces config (defaults to "as before" -- false both) to intern or not intern the artifact descriptor deps list and managedDep

Re: [PR] [MRESOLVER-587] Memory usage improvements [maven-resolver]

2024-07-13 Thread via GitHub
cstamas commented on PR #536: URL: https://github.com/apache/maven-resolver/pull/536#issuecomment-2226999018 This PR causes noticeable slow down: building Quarkus (mvn clean install -Dquickly) went from 9:20 to 11:10. Ideas: * make interning of dependencies configurable, default NO