[ 
https://jira.codehaus.org/browse/SCM-541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=283877#comment-283877
 ] 
Petr Kozelka commented on SCM-541:
----------------------------------

Hello Kathryn,

I just tested your suggested option - see 
https://github.com/pkozelka/git-demo/commit/8bc7b72317b3e5d80fa8fdfa3a692ddc211a8620

It shows that it causes git to *create an empty commit* , but that is not a 
no-op and I believe it should not be used.

Instead, I think the output should be parsed for string "nothing to commit 
(working directory clean)" when git fails and used for the no-op case.


> GitExe commit should include --allow-empty option
> -------------------------------------------------
>
>                 Key: SCM-541
>                 URL: https://jira.codehaus.org/browse/SCM-541
>             Project: Maven SCM
>          Issue Type: Bug
>          Components: maven-scm-provider-git
>            Reporter: Kathryn Huxtable
>            Priority: Minor
>
> Without it, git returns a status of 1 when there is nothing to commit. This 
> makes the wagon-scm and other processes that depend on this being a no-op 
> fail.
> I think that git should not fail on an empty commit, and adding the 
> --allow-empty option on commits would achieve that.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to