[jira] [Commented] (MNG-8490) Combine XmlNode and XmlNodeImpl

[ https://issues.apache.org/jira/browse/MNG-8490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17932619#comment-17932619 ] Guillaume Nodet commented on MNG-8490: -- I think it would make sense to use the same me

[jira] [Commented] (MNG-8490) Combine XmlNode and XmlNodeImpl

[ https://issues.apache.org/jira/browse/MNG-8490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17916691#comment-17916691 ] Elliotte Rusty Harold commented on MNG-8490: On the mocking point specifically,

[jira] [Commented] (MNG-8490) Combine XmlNode and XmlNodeImpl

[ https://issues.apache.org/jira/browse/MNG-8490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17916628#comment-17916628 ] Guillaume Nodet commented on MNG-8490: -- So here are a few arguments: * decoupling is

[jira] [Commented] (MNG-8490) Combine XmlNode and XmlNodeImpl

[ https://issues.apache.org/jira/browse/MNG-8490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17911465#comment-17911465 ] Yu Yu commented on MNG-8490: Due to an accidental operation, I deleted the repository, which ca

[jira] [Commented] (MNG-8490) Combine XmlNode and XmlNodeImpl

[ https://issues.apache.org/jira/browse/MNG-8490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17910610#comment-17910610 ] Elliotte Rusty Harold commented on MNG-8490: Using interfaces does *not* enable

[jira] [Commented] (MNG-8490) Combine XmlNode and XmlNodeImpl

[ https://issues.apache.org/jira/browse/MNG-8490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17910465#comment-17910465 ] Guillaume Nodet commented on MNG-8490: -- Using interfaces allows decoupling (in additio

[jira] [Commented] (MNG-8490) Combine XmlNode and XmlNodeImpl

[ https://issues.apache.org/jira/browse/MNG-8490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17910157#comment-17910157 ] Guillaume Nodet commented on MNG-8490: -- I'm -1 on this. The role of an API is to decou

[jira] [Commented] (MNG-8490) Combine XmlNode and XmlNodeImpl

[ https://issues.apache.org/jira/browse/MNG-8490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17909991#comment-17909991 ] Yu Yu commented on MNG-8490: I understand, I'll submit a PR later.Thank you. > Combine XmlNode

[jira] [Commented] (MNG-8490) Combine XmlNode and XmlNodeImpl

[ https://issues.apache.org/jira/browse/MNG-8490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17909892#comment-17909892 ] Elliotte Rusty Harold commented on MNG-8490: I think you can just turn XmlNode

[jira] [Commented] (MNG-8490) Combine XmlNode and XmlNodeImpl

[ https://issues.apache.org/jira/browse/MNG-8490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17909813#comment-17909813 ] Yu Yu commented on MNG-8490: After attempting to combine the code, I realized that the API laye

[jira] [Commented] (MNG-8490) Combine XmlNode and XmlNodeImpl

[ https://issues.apache.org/jira/browse/MNG-8490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17909776#comment-17909776 ] Elliotte Rusty Harold commented on MNG-8490: Thanks for your interest. In the p

[jira] [Commented] (MNG-8490) Combine XmlNode and XmlNodeImpl

[ https://issues.apache.org/jira/browse/MNG-8490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17909775#comment-17909775 ] Yu Yu commented on MNG-8490: I will try to finish this task in the future, could you please ass