Re: [PR] fix DeployAtEnd failures [maven-deploy-plugin]

2023-10-24 Thread via GitHub
NersesAM commented on PR #1: URL: https://github.com/apache/maven-deploy-plugin/pull/1#issuecomment-1777295783 I thought GH uses latest maven! lessons learned I guess :) I agree controlling the version is the best. Thanks for your help -- This is an automated message from the Apache Git

Re: [PR] fix DeployAtEnd failures [maven-deploy-plugin]

2023-10-24 Thread via GitHub
cstamas commented on PR #1: URL: https://github.com/apache/maven-deploy-plugin/pull/1#issuecomment-1777280821 Well,... * 3.8.x should be left for oblivion, use 3.9.x * your best bet is wrapper, as you fully control Maven in use, and not rely on any 3rd party things like GH Action,

Re: [PR] fix DeployAtEnd failures [maven-deploy-plugin]

2023-10-24 Thread via GitHub
NersesAM commented on PR #1: URL: https://github.com/apache/maven-deploy-plugin/pull/1#issuecomment-1777268274 I tried to create small reproducible case but I am not able to. I started playing a bit more with my project and I noticed that github actions runner was using maven version 3.

Re: [PR] fix DeployAtEnd failures [maven-deploy-plugin]

2023-10-23 Thread via GitHub
cstamas commented on PR #1: URL: https://github.com/apache/maven-deploy-plugin/pull/1#issuecomment-1776252065 I see nothing in JIRA (all similar issues were reported against older versions, that yes, had known issues w/ skip). 3.1.1 should not have these issues (unless whole plugin is left

Re: [PR] fix DeployAtEnd failures [maven-deploy-plugin]

2023-10-23 Thread via GitHub
cstamas commented on PR #1: URL: https://github.com/apache/maven-deploy-plugin/pull/1#issuecomment-1776247653 Can you create a simple reproducer and post it on GitHub (or wherever)? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

Re: [PR] fix DeployAtEnd failures [maven-deploy-plugin]

2023-10-23 Thread via GitHub
cstamas commented on PR #1: URL: https://github.com/apache/maven-deploy-plugin/pull/1#issuecomment-1776246395 And how is the module skipped? Using the ``? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] fix DeployAtEnd failures [maven-deploy-plugin]

2023-10-23 Thread via GitHub
NersesAM commented on PR #1: URL: https://github.com/apache/maven-deploy-plugin/pull/1#issuecomment-1776241945 yes -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsub

Re: [PR] fix DeployAtEnd failures [maven-deploy-plugin]

2023-10-23 Thread via GitHub
cstamas commented on PR #1: URL: https://github.com/apache/maven-deploy-plugin/pull/1#issuecomment-1776240971 Does that happen with latest m-deploy-p as well? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

Re: [PR] fix DeployAtEnd failures [maven-deploy-plugin]

2023-10-23 Thread via GitHub
NersesAM commented on PR #1: URL: https://github.com/apache/maven-deploy-plugin/pull/1#issuecomment-1776237801 I wish this had been merged and was available in documentation. Spent hours only to figure out that having one of the modules skip deployments makes the whole deployAtEnd silently