Re: [PR] bug: pass these only if exists [maven-javadoc-plugin]

2024-08-27 Thread via GitHub
michael-o commented on PR #313: URL: https://github.com/apache/maven-javadoc-plugin/pull/313#issuecomment-2313240741 Let's wait for IT and will create JIRA issue and merge. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [PR] bug: pass these only if exists [maven-javadoc-plugin]

2024-08-27 Thread via GitHub
cstamas commented on PR #313: URL: https://github.com/apache/maven-javadoc-plugin/pull/313#issuecomment-2313237148 Lgtm -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] bug: pass these only if exists [maven-javadoc-plugin]

2024-08-27 Thread via GitHub
michael-o commented on PR #313: URL: https://github.com/apache/maven-javadoc-plugin/pull/313#issuecomment-2313235235 @cstamas I modified the code to respect the method contract and not to pass non-existing values. -- This is an automated message from the Apache Git Service. To respond to

Re: [PR] bug: pass these only if exists [maven-javadoc-plugin]

2024-08-27 Thread via GitHub
cstamas commented on code in PR #313: URL: https://github.com/apache/maven-javadoc-plugin/pull/313#discussion_r1733080306 ## src/main/java/org/apache/maven/plugins/javadoc/JavadocUtil.java: ## @@ -781,9 +781,13 @@ protected static void invokeMaven( request.setBaseDirec

[PR] bug: pass these only if exists [maven-javadoc-plugin]

2024-08-27 Thread via GitHub
cstamas opened a new pull request, #313: URL: https://github.com/apache/maven-javadoc-plugin/pull/313 As request carries the "effective" value (default or user overriden ones) but it does not mean they exist. And as invoker used, effect is same as user would use -s/-t CLI commands with non-