slawekjaranowski merged PR #1553:
URL: https://github.com/apache/maven/pull/1553
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@mave
slawekjaranowski commented on PR #1548:
URL: https://github.com/apache/maven/pull/1548#issuecomment-2145825719
Done in #1553
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
slawekjaranowski opened a new pull request, #1553:
URL: https://github.com/apache/maven/pull/1553
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscrib
slawekjaranowski commented on PR #1548:
URL: https://github.com/apache/maven/pull/1548#issuecomment-2145810928
I will create a new one for 3.x 😄
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
slawekjaranowski commented on PR #1548:
URL: https://github.com/apache/maven/pull/1548#issuecomment-2145809544
#1550 is for master ... this one was for 3.x branch
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
slawekjaranowski merged PR #1550:
URL: https://github.com/apache/maven/pull/1550
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@mave
cstamas commented on PR #1548:
URL: https://github.com/apache/maven/pull/1548#issuecomment-2145782407
Superseded by https://github.com/apache/maven/pull/1550
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abov
cstamas closed pull request #1548: Use Maven Wrapper to build
URL: https://github.com/apache/maven/pull/1548
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-m
slawekjaranowski commented on PR #1548:
URL: https://github.com/apache/maven/pull/1548#issuecomment-2145748141
I hope it is ready to merge @cstamas @gnodet what do you think
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
slawekjaranowski commented on PR #1550:
URL: https://github.com/apache/maven/pull/1550#issuecomment-2143604023
This one is needed
https://github.com/apache/maven-integration-testing/pull/345
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
slawekjaranowski opened a new pull request, #1550:
URL: https://github.com/apache/maven/pull/1550
We should control Maven version used for builds
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
slawekjaranowski commented on code in PR #1548:
URL: https://github.com/apache/maven/pull/1548#discussion_r1623245316
##
.github/workflows/maven.yml:
##
@@ -47,7 +47,7 @@ jobs:
cache: 'maven'
- name: Build with Maven
-run: mvn verify -e -B -V -Ddistri
gnodet commented on PR #1548:
URL: https://github.com/apache/maven/pull/1548#issuecomment-2143461937
Actually, we're not using it... I thought, but the matrix is used with
wrapper
https://github.com/apache/maven-gh-actions-shared/blob/v4/.github/workflows/maven-verify.yml#L196-L198
laeubi commented on PR #1548:
URL: https://github.com/apache/maven/pull/1548#issuecomment-2143449905
> You are mixing things. Again, we do NOT use setup-maven action, hence the
readme you point it is... off topic.
I mentioned [you need to use setup-maven
action](https://github.com/ap
cstamas commented on PR #1548:
URL: https://github.com/apache/maven/pull/1548#issuecomment-2143449297
IMHO we should not use any action to setup Maven but wrapper that's my 5
cents (we even have examples of "maven matrix" that is simply doable with
wrapper).
--
This is an automated m
cstamas commented on PR #1548:
URL: https://github.com/apache/maven/pull/1548#issuecomment-2143449034
> Well I would call it **strange** to use an action without specify a
version ... I mean even [the readme tells you to specify
one](https://github.com/stCarolas/setup-maven), i more suspect
laeubi commented on PR #1548:
URL: https://github.com/apache/maven/pull/1548#issuecomment-2143448479
setup-java has nothing to do with installing / "using" maven it just do the
following:
- generates `toolchain.xml` from installed jdks
- uses `pom.xml` files as cache keys
be
rmannibucau commented on PR #1548:
URL: https://github.com/apache/maven/pull/1548#issuecomment-2143424345
setup-java uses OS maven version which is likely not what we want.
Guess we should reuse our shared action enabling to support setup-maven to
have a build matrix (ideally).
--
This
laeubi commented on PR #1548:
URL: https://github.com/apache/maven/pull/1548#issuecomment-2143422824
> I can't see the use of this action for ITs. We do use actions/setup-java,
but not actions/setup-maven. I would think reusing this action in the context
of GH action makes more sense.
gnodet commented on PR #1548:
URL: https://github.com/apache/maven/pull/1548#issuecomment-2143420229
> > There is a setup-maven action:
https://github.com/marketplace/actions/setup-maven
> > I use it all the time without any issues and you can perfectly control
the maven version.
>
laeubi commented on PR #1548:
URL: https://github.com/apache/maven/pull/1548#issuecomment-2143352303
> and the last IT failures made us realize how strange it behaves: it set up
different Maven versions per
> True, we did not ask for specific maven version, but that is not the point.
cstamas commented on PR #1548:
URL: https://github.com/apache/maven/pull/1548#issuecomment-2143346085
> There is a setup-maven action:
https://github.com/marketplace/actions/setup-maven
>
> I use it all the time without any issues and you can perfectly control the
maven version.
laeubi commented on PR #1548:
URL: https://github.com/apache/maven/pull/1548#issuecomment-2143285471
There is a setup-maven action:
https://github.com/marketplace/actions/setup-maven-action
--
This is an automated message from the Apache Git Service.
To respond to the message, please lo
slawekjaranowski commented on PR #1548:
URL: https://github.com/apache/maven/pull/1548#issuecomment-2142844431
or we can add:
```
- name: Set up Maven
run:
mvn --errors --batch-mode --show-version
org.apache.maven.plugins:maven-wrapper-plugin:3.3.2:wra
24 matches
Mail list logo
