Re: [PR] Use @Component only [maven-dependency-plugin]

2023-12-29 Thread via GitHub
michael-o commented on PR #360: URL: https://github.com/apache/maven-dependency-plugin/pull/360#issuecomment-1872256364 @slawekjaranowski This is fantastic work, **thank you**. Your change must go with the upgrade of MPLUGIN with every modified plugin as well as this one. -- This is an a

Re: [PR] Use @Component only [maven-dependency-plugin]

2023-12-29 Thread via GitHub
slawekjaranowski commented on PR #360: URL: https://github.com/apache/maven-dependency-plugin/pull/360#issuecomment-1872079561 Unit test pass. Site build due to parameters list can be null 😄 -- This is an automated message from the Apache Git Service. To respond to the message, pl

Re: [PR] Use @Component only [maven-dependency-plugin]

2023-12-29 Thread via GitHub
slawekjaranowski commented on PR #360: URL: https://github.com/apache/maven-dependency-plugin/pull/360#issuecomment-1871964145 @michael-o @cstamas please look at my commit ... I fix one test by adding mock MavenProject and MavenSession as component in test -- This is an automated message

Re: [PR] Use @Component only [maven-dependency-plugin]

2023-12-29 Thread via GitHub
michael-o commented on PR #360: URL: https://github.com/apache/maven-dependency-plugin/pull/360#issuecomment-1871955789 > Unit tests still fail for me But executing ITs are ok ... Yes, that's the point. A misconfig or dep is missing. -- This is an automated message from the Ap

Re: [PR] Use @Component only [maven-dependency-plugin]

2023-12-29 Thread via GitHub
slawekjaranowski commented on PR #360: URL: https://github.com/apache/maven-dependency-plugin/pull/360#issuecomment-1871946562 Unit tests still fail for me But executing ITs are ok ... -- This is an automated message from the Apache Git Service. To respond to the message, please

[PR] Use @Component only [maven-dependency-plugin]

2023-12-29 Thread via GitHub
michael-o opened a new pull request, #360: URL: https://github.com/apache/maven-dependency-plugin/pull/360 This should depict the failing behavior. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to