Re: [PR] There are exceptions you want to deal with [maven]

2024-11-14 Thread via GitHub
gnodet commented on PR #1910: URL: https://github.com/apache/maven/pull/1910#issuecomment-2476773834 I really don't think that works. What if the ModelBuilder calls internally a service which throws an unchecked exception ? If the caller catches ModelBuilderException (which he would have t

Re: [PR] There are exceptions you want to deal with [maven]

2024-11-14 Thread via GitHub
cstamas commented on code in PR #1910: URL: https://github.com/apache/maven/pull/1910#discussion_r1842178580 ## impl/maven-impl/src/main/java/org/apache/maven/internal/impl/model/DefaultModelBuilder.java: ## @@ -1733,12 +1734,50 @@ ModelSource resolveReactorModel(String groupId,

Re: [PR] There are exceptions you want to deal with [maven]

2024-11-14 Thread via GitHub
cstamas commented on code in PR #1910: URL: https://github.com/apache/maven/pull/1910#discussion_r1842178580 ## impl/maven-impl/src/main/java/org/apache/maven/internal/impl/model/DefaultModelBuilder.java: ## @@ -1733,12 +1734,50 @@ ModelSource resolveReactorModel(String groupId,

Re: [PR] There are exceptions you want to deal with [maven]

2024-11-14 Thread via GitHub
cstamas commented on code in PR #1910: URL: https://github.com/apache/maven/pull/1910#discussion_r1842176036 ## impl/maven-impl/src/main/java/org/apache/maven/internal/impl/model/DefaultModelBuilder.java: ## @@ -1733,12 +1734,50 @@ ModelSource resolveReactorModel(String groupId,

Re: [PR] There are exceptions you want to deal with [maven]

2024-11-14 Thread via GitHub
gnodet commented on code in PR #1910: URL: https://github.com/apache/maven/pull/1910#discussion_r1842143877 ## impl/maven-impl/src/main/java/org/apache/maven/internal/impl/model/DefaultModelBuilder.java: ## @@ -1733,12 +1734,50 @@ ModelSource resolveReactorModel(String groupId,