Re: [PR] Switch to Guice constructor injection [maven-invoker-plugin]

2024-12-24 Thread via GitHub
elharo merged PR #266: URL: https://github.com/apache/maven-invoker-plugin/pull/266 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@m

Re: [PR] Switch to Guice constructor injection [maven-invoker-plugin]

2024-12-07 Thread via GitHub
elharo commented on code in PR #266: URL: https://github.com/apache/maven-invoker-plugin/pull/266#discussion_r1874543428 ## pom.xml: ## @@ -257,7 +257,12 @@ under the License. maven-shared-utils 3.4.2 - + + javax.inject Review Comment: fixed

Re: [PR] Switch to Guice constructor injection [maven-invoker-plugin]

2024-12-07 Thread via GitHub
gnodet commented on code in PR #266: URL: https://github.com/apache/maven-invoker-plugin/pull/266#discussion_r1874516331 ## pom.xml: ## @@ -257,7 +257,12 @@ under the License. maven-shared-utils 3.4.2 - + + javax.inject Review Comment: This is a