Re: [PR] Remove unused parameters, use CachingWriter, simplify a bit [maven-archiver]

2024-11-27 Thread via GitHub
gnodet merged PR #79: URL: https://github.com/apache/maven-archiver/pull/79 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apa

Re: [PR] Remove unused parameters, use CachingWriter, simplify a bit [maven-archiver]

2024-11-27 Thread via GitHub
elharo commented on code in PR #79: URL: https://github.com/apache/maven-archiver/pull/79#discussion_r1860515352 ## src/main/java/org/apache/maven/shared/archiver/PomPropertiesUtil.java: ## @@ -52,92 +48,54 @@ private Properties loadPropertiesFile(Path file) throws IOException

Re: [PR] Remove unused parameters, use CachingWriter, simplify a bit [maven-archiver]

2024-11-27 Thread via GitHub
gnodet commented on code in PR #79: URL: https://github.com/apache/maven-archiver/pull/79#discussion_r1860283250 ## src/main/java/org/apache/maven/shared/archiver/PomPropertiesUtil.java: ## @@ -52,92 +48,53 @@ private Properties loadPropertiesFile(Path file) throws IOException

Re: [PR] Remove unused parameters, use CachingWriter, simplify a bit [maven-archiver]

2024-11-27 Thread via GitHub
gnodet commented on code in PR #79: URL: https://github.com/apache/maven-archiver/pull/79#discussion_r1860283250 ## src/main/java/org/apache/maven/shared/archiver/PomPropertiesUtil.java: ## @@ -52,92 +48,53 @@ private Properties loadPropertiesFile(Path file) throws IOException

Re: [PR] Remove unused parameters, use CachingWriter, simplify a bit [maven-archiver]

2024-11-27 Thread via GitHub
elharo commented on code in PR #79: URL: https://github.com/apache/maven-archiver/pull/79#discussion_r1860223895 ## src/main/java/org/apache/maven/shared/archiver/PomPropertiesUtil.java: ## @@ -52,92 +48,53 @@ private Properties loadPropertiesFile(Path file) throws IOException