Re: [PR] Remove references to very old versions of surefire and TestNG [maven-surefire]

2024-03-05 Thread via GitHub
elharo merged PR #723: URL: https://github.com/apache/maven-surefire/pull/723 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.a

Re: [PR] Remove references to very old versions of surefire and TestNG [maven-surefire]

2024-03-04 Thread via GitHub
rmannibucau commented on PR #723: URL: https://github.com/apache/maven-surefire/pull/723#issuecomment-1977142555 @elharo currentTimeMillis (surefire1144.Test1#sleep), I think you should feel free to add some tolerance ~50ms in `assertThat( xmlTime, is(greaterThanOrEqualTo( 1.6f ) ) );` asse

Re: [PR] Remove references to very old versions of surefire and TestNG [maven-surefire]

2024-03-04 Thread via GitHub
elharo commented on PR #723: URL: https://github.com/apache/maven-surefire/pull/723#issuecomment-1977131173 Not sure what this is about. Probably flaky but I'll take a look: 2024-03-04T16:53:19.6293270Z [INFO] Results: 2024-03-04T16:53:19.6293780Z [INFO] 2024-03-04T16:53:19.

[PR] Remove references to very old versions of surefire and TestNG [maven-surefire]

2024-03-04 Thread via GitHub
elharo opened a new pull request, #723: URL: https://github.com/apache/maven-surefire/pull/723 TestNG 5 is circa 2010. Focus on what the current version does. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL