Re: [PR] Remove plexus components.xml [maven-war-plugin]

2024-12-28 Thread via GitHub
cstamas commented on PR #81: URL: https://github.com/apache/maven-war-plugin/pull/81#issuecomment-2564449229 > I made some updates to the Wiki. Seems it is asking folks to do things that can't yet be done. And this is wrong: this is NOT about dropping Plexus XML (it is doable), it is

Re: [PR] Remove plexus components.xml [maven-war-plugin]

2024-12-28 Thread via GitHub
cstamas commented on PR #81: URL: https://github.com/apache/maven-war-plugin/pull/81#issuecomment-2564447638 @elharo one obvious one: use this plugin in a project used in "ordinary" way (not as extension) and observe plugin versions used in the build, they come from Maven core (with Maven 3

Re: [PR] Remove plexus components.xml [maven-war-plugin]

2024-12-28 Thread via GitHub
elharo commented on PR #81: URL: https://github.com/apache/maven-war-plugin/pull/81#issuecomment-2564437444 Question for @cstamas what observable effect do you expect from merging this PR? As far as I can tell the only change is that the jar file is a little smaller. Behavior is the same. I

Re: [PR] Remove plexus components.xml [maven-war-plugin]

2024-12-27 Thread via GitHub
elharo commented on PR #81: URL: https://github.com/apache/maven-war-plugin/pull/81#issuecomment-2563959728 I made some updates to the Wiki. Seems it is asking folks to do things that can't yet be done. -- This is an automated message from the Apache Git Service. To respond to the messag

Re: [PR] Remove plexus components.xml [maven-war-plugin]

2024-12-27 Thread via GitHub
cstamas commented on PR #81: URL: https://github.com/apache/maven-war-plugin/pull/81#issuecomment-2563948207 We need to decide how to do this first... please see https://issues.apache.org/jira/browse/MNG-8472 for context (esp mentioned issues and list discussion). -- This is an automated

Re: [PR] Remove plexus components.xml [maven-war-plugin]

2024-12-27 Thread via GitHub
elharo commented on PR #81: URL: https://github.com/apache/maven-war-plugin/pull/81#issuecomment-2563947288 If you think we need to keep these bindings, there are two questions that need to be answered: 1. What test is missing? There are lot of integration tests in this project and t

Re: [PR] Remove plexus components.xml [maven-war-plugin]

2024-12-27 Thread via GitHub
cstamas commented on PR #81: URL: https://github.com/apache/maven-war-plugin/pull/81#issuecomment-2563781386 I hope this is a joke... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] Remove plexus components.xml [maven-war-plugin]

2024-12-24 Thread via GitHub
elharo closed pull request #80: Remove plexus components.xml URL: https://github.com/apache/maven-war-plugin/pull/80 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscr