hboutemy commented on PR #569:
URL: https://github.com/apache/maven-site/pull/569#issuecomment-2638265368
before changing project policy, let's document our reality: just "CTR" is
too crude as it was the pure reality when we were with svn = something from the
past
let's write what we
olamy commented on PR #569:
URL: https://github.com/apache/maven-site/pull/569#issuecomment-2637984038
Personally I wouldn't make reviews required but at least PR required.
Some changes are trivial and doesn't require reviews and by the way people
should have enough common sense to ask wh
elharo commented on PR #569:
URL: https://github.com/apache/maven-site/pull/569#issuecomment-2637684078
Yes, we should make it explicit that review comes before commit and enforce
that in the source repository. This hasn't happened yet, but we should discuss
and do that. This won't be the f
hboutemy commented on PR #569:
URL: https://github.com/apache/maven-site/pull/569#issuecomment-2637539414
> this change should be reverted.
yes, ignoring what existed before GitHub Pull Requests and deciding
unilaterally to change project practice is not an option (even with best inte
elharo commented on PR #569:
URL: https://github.com/apache/maven-site/pull/569#issuecomment-2636611893
I've seen too many questionable commits sneak in without review to be
comfortable with it. It's not commit then review. It never has been. It's
Commit Never Review. This is a massive secu
olamy commented on PR #569:
URL: https://github.com/apache/maven-site/pull/569#issuecomment-2636573145
Agree this change should be reverted.
By the way there is not even approval or discussion here...
--
This is an automated message from the Apache Git Service.
To respond to the message
hboutemy commented on PR #569:
URL: https://github.com/apache/maven-site/pull/569#issuecomment-2636255397
> This is not what we're usually doing
this is what we were always doing with svn
then with Git
with GitHub PR, habits changed for some people, on very active Maven projects
michael-o commented on PR #569:
URL: https://github.com/apache/maven-site/pull/569#issuecomment-2434516974
> So what commit policy now we have? I think that should be discussed on ML
and finish with formal vote.
>
> To be clear I'm no a fun of CRT, I like reviews and see benefit of it
slawekjaranowski commented on PR #569:
URL: https://github.com/apache/maven-site/pull/569#issuecomment-2434501117
So what commit policy now we have? I think that should be discussed on ML
and finish with formal vote.
To be clear I'm no a fun of CRT, I like reviews and see benefit of i
elharo merged PR #569:
URL: https://github.com/apache/maven-site/pull/569
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apach
ditbace commented on PR #569:
URL: https://github.com/apache/maven-site/pull/569#issuecomment-2432886342
ok
On Wed, Oct 23, 2024 at 1:02 PM Michael Osipov ***@***.***>
wrote:
> ***@***. approved this pull request.
>
> This does not imply the opposite, but simply tha
elharo opened a new pull request, #569:
URL: https://github.com/apache/maven-site/pull/569
This is not what we're usually doing and not what we should be doing.
I avoided making more affirmat\ive statements about what we should be doing.
I'm not sure this is the right page for that, b
12 matches
Mail list logo
