Re: [PR] Redirect the element to [maven]

2025-01-29 Thread via GitHub
desruisseaux commented on code in PR #2061: URL: https://github.com/apache/maven/pull/2061#discussion_r1933693763 ## api/maven-api-core/src/main/java/org/apache/maven/api/Project.java: ## @@ -234,4 +239,32 @@ default String getId() { */ @Nonnull Optional getParen

Re: [PR] Redirect the element to [maven]

2025-01-28 Thread via GitHub
gnodet commented on PR #2061: URL: https://github.com/apache/maven/pull/2061#issuecomment-2620123313 I think we also need to move the `Project#getSourceRoots()` and `Project#getEnabledSourceRoots(ProjectScope,Language)` to `ProjectManager` as they return values that are not meant to be immu

Re: [PR] Redirect the element to [maven]

2025-01-28 Thread via GitHub
gnodet commented on code in PR #2061: URL: https://github.com/apache/maven/pull/2061#discussion_r1932722679 ## api/maven-api-core/src/main/java/org/apache/maven/api/Project.java: ## @@ -234,4 +239,32 @@ default String getId() { */ @Nonnull Optional getParent(); +

Re: [PR] Redirect the element to [maven]

2025-01-28 Thread via GitHub
gnodet commented on code in PR #2061: URL: https://github.com/apache/maven/pull/2061#discussion_r1932720388 ## api/maven-api-core/src/main/java/org/apache/maven/api/Project.java: ## @@ -234,4 +239,32 @@ default String getId() { */ @Nonnull Optional getParent(); +

Re: [PR] Redirect the element to [maven]

2025-01-28 Thread via GitHub
desruisseaux commented on code in PR #2061: URL: https://github.com/apache/maven/pull/2061#discussion_r1932699313 ## api/maven-api-core/src/main/java/org/apache/maven/api/Project.java: ## @@ -234,4 +239,32 @@ default String getId() { */ @Nonnull Optional getParen

Re: [PR] Redirect the element to [maven]

2025-01-28 Thread via GitHub
gnodet commented on code in PR #2061: URL: https://github.com/apache/maven/pull/2061#discussion_r1932053003 ## api/maven-api-core/src/main/java/org/apache/maven/api/Project.java: ## @@ -234,4 +239,32 @@ default String getId() { */ @Nonnull Optional getParent(); +

Re: [PR] Redirect the element to [maven]

2025-01-28 Thread via GitHub
gnodet commented on code in PR #2061: URL: https://github.com/apache/maven/pull/2061#discussion_r1932053003 ## api/maven-api-core/src/main/java/org/apache/maven/api/Project.java: ## @@ -234,4 +239,32 @@ default String getId() { */ @Nonnull Optional getParent(); +

Re: [PR] Redirect the element to [maven]

2025-01-28 Thread via GitHub
desruisseaux commented on code in PR #2061: URL: https://github.com/apache/maven/pull/2061#discussion_r1932040453 ## api/maven-api-core/src/main/java/org/apache/maven/api/Project.java: ## @@ -234,4 +239,32 @@ default String getId() { */ @Nonnull Optional getParen

Re: [PR] Redirect the element to [maven]

2025-01-28 Thread via GitHub
gnodet commented on code in PR #2061: URL: https://github.com/apache/maven/pull/2061#discussion_r1932029325 ## api/maven-api-core/src/main/java/org/apache/maven/api/Project.java: ## @@ -234,4 +239,32 @@ default String getId() { */ @Nonnull Optional getParent(); +

Re: [PR] Redirect the element to [maven]

2025-01-28 Thread via GitHub
gnodet commented on code in PR #2061: URL: https://github.com/apache/maven/pull/2061#discussion_r1932029325 ## api/maven-api-core/src/main/java/org/apache/maven/api/Project.java: ## @@ -234,4 +239,32 @@ default String getId() { */ @Nonnull Optional getParent(); +

Re: [PR] Redirect the element to [maven]

2025-01-28 Thread via GitHub
gnodet commented on code in PR #2061: URL: https://github.com/apache/maven/pull/2061#discussion_r1931949298 ## impl/maven-core/src/main/java/org/apache/maven/project/MavenProject.java: ## @@ -420,17 +425,29 @@ public void addTestCompileSourceRoot(String path) { } /**

Re: [PR] Redirect the element to [maven]

2025-01-28 Thread via GitHub
desruisseaux commented on code in PR #2061: URL: https://github.com/apache/maven/pull/2061#discussion_r1931835330 ## impl/maven-core/src/main/java/org/apache/maven/project/MavenProject.java: ## @@ -420,17 +425,29 @@ public void addTestCompileSourceRoot(String path) { }

Re: [PR] Redirect the element to [maven]

2025-01-27 Thread via GitHub
gnodet commented on code in PR #2061: URL: https://github.com/apache/maven/pull/2061#discussion_r1930340516 ## impl/maven-core/src/main/java/org/apache/maven/project/MavenProject.java: ## @@ -420,17 +425,29 @@ public void addTestCompileSourceRoot(String path) { } /**

Re: [PR] Redirect the element to [maven]

2025-01-27 Thread via GitHub
gnodet commented on code in PR #2061: URL: https://github.com/apache/maven/pull/2061#discussion_r1930340516 ## impl/maven-core/src/main/java/org/apache/maven/project/MavenProject.java: ## @@ -420,17 +425,29 @@ public void addTestCompileSourceRoot(String path) { } /**

Re: [PR] Redirect the element to [maven]

2025-01-27 Thread via GitHub
gnodet commented on code in PR #2061: URL: https://github.com/apache/maven/pull/2061#discussion_r1930280096 ## api/maven-api-model/src/main/mdo/maven.mdo: ## @@ -775,28 +775,30 @@ String - resources 3.0.0+

Re: [PR] Redirect the element to [maven]

2025-01-27 Thread via GitHub
desruisseaux commented on code in PR #2061: URL: https://github.com/apache/maven/pull/2061#discussion_r1930222882 ## api/maven-api-model/src/main/mdo/maven.mdo: ## @@ -775,28 +775,30 @@ String - resources 3.0.0+

Re: [PR] Redirect the element to [maven]

2025-01-26 Thread via GitHub
gnodet commented on code in PR #2061: URL: https://github.com/apache/maven/pull/2061#discussion_r1930065449 ## api/maven-api-model/src/main/mdo/maven.mdo: ## @@ -775,28 +775,30 @@ String - resources 3.0.0+

Re: [PR] Redirect the element to [maven]

2025-01-26 Thread via GitHub
desruisseaux commented on code in PR #2061: URL: https://github.com/apache/maven/pull/2061#discussion_r1929880809 ## api/maven-api-model/src/main/mdo/maven.mdo: ## @@ -775,28 +775,30 @@ String - resources 3.0.0+

Re: [PR] Redirect the element to [maven]

2025-01-26 Thread via GitHub
desruisseaux commented on code in PR #2061: URL: https://github.com/apache/maven/pull/2061#discussion_r1929880442 ## api/maven-api-model/src/main/mdo/maven.mdo: ## @@ -775,28 +775,30 @@ String - resources 3.0.0+

Re: [PR] Redirect the element to [maven]

2025-01-26 Thread via GitHub
gnodet commented on code in PR #2061: URL: https://github.com/apache/maven/pull/2061#discussion_r1929864637 ## api/maven-api-model/src/main/mdo/maven.mdo: ## @@ -2161,6 +2165,8 @@ element with this value: {@code org/apache/maven/messages}. This is not r

Re: [PR] Redirect the element to [maven]

2025-01-26 Thread via GitHub
gnodet commented on code in PR #2061: URL: https://github.com/apache/maven/pull/2061#discussion_r1929864598 ## api/maven-api-model/src/main/mdo/maven.mdo: ## @@ -910,6 +913,8 @@ project. The generated build system will compile these directories when the project is

Re: [PR] Redirect the element to [maven]

2025-01-26 Thread via GitHub
gnodet commented on code in PR #2061: URL: https://github.com/apache/maven/pull/2061#discussion_r1929864561 ## api/maven-api-model/src/main/mdo/maven.mdo: ## @@ -897,11 +899,12 @@ contents will be copied to the output directory in most cases (since scripts are

Re: [PR] Redirect the element to [maven]

2025-01-26 Thread via GitHub
gnodet commented on code in PR #2061: URL: https://github.com/apache/maven/pull/2061#discussion_r1929864525 ## api/maven-api-model/src/main/mdo/maven.mdo: ## @@ -883,11 +884,12 @@ generated build system will compile the sources from this directory when the project

Re: [PR] Redirect the element to [maven]

2025-01-26 Thread via GitHub
gnodet commented on code in PR #2061: URL: https://github.com/apache/maven/pull/2061#discussion_r1929864479 ## api/maven-api-model/src/main/mdo/maven.mdo: ## @@ -775,28 +775,30 @@ String - resources 3.0.0+

Re: [PR] Redirect the element to [maven]

2025-01-26 Thread via GitHub
gnodet commented on code in PR #2061: URL: https://github.com/apache/maven/pull/2061#discussion_r1929864413 ## api/maven-api-model/src/main/mdo/maven.mdo: ## @@ -775,28 +775,30 @@ String - resources 3.0.0+

[PR] Redirect the element to [maven]

2025-01-26 Thread via GitHub
desruisseaux opened a new pull request, #2061: URL: https://github.com/apache/maven/pull/2061 Notable changes: * Add a `SourceRoot` interface for the properties declared in the POM's `` element. * In the POM, deprecate the `sourceDirectory`, `testSourceDirectory`, `scriptSourceDir